[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123120308 --- Diff: libminifi/include/core/repository/AtomicRepoEntries.h --- @@ -0,0 +1,501 @@ +/** + * + * Licensed to the Apache Software

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread benqiu2016
Github user benqiu2016 commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123119696 --- Diff: libminifi/include/core/repository/AtomicRepoEntries.h --- @@ -0,0 +1,501 @@ +/** + * + * Licensed to the Apache Software

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123119025 --- Diff: libminifi/include/core/repository/VolatileRepository.h --- @@ -331,22 +132,240 @@ class VolatileRepository : public core::Repository,

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread benqiu2016
Github user benqiu2016 commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123118428 --- Diff: libminifi/include/core/repository/VolatileRepository.h --- @@ -331,22 +132,240 @@ class VolatileRepository : public core::Repository,

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123113442 --- Diff: libminifi/include/core/FlowFile.h --- @@ -224,6 +224,10 @@ class FlowFile { void setStoredToRepository(bool

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-20 Thread benqiu2016
Github user benqiu2016 commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123110689 --- Diff: libminifi/include/core/FlowFile.h --- @@ -224,6 +224,10 @@ class FlowFile { void setStoredToRepository(bool

[GitHub] nifi-minifi-cpp pull request #110: MINIFI-249: Update prov repo to better ab...

2017-06-01 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/110 MINIFI-249: Update prov repo to better abstract deser. Deserialization and serialization are better abstracted into SerializableComponent allowing us to use all repos with the same