Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/459
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r241191018
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK_END_FLAGS
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r240994771
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK_END_FLAGS
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r240863016
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK_END_FLAGS
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r240643845
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK_END_FLAGS
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459
MINIFICPP-695 - NanoFi Examples appear to be broken
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we