Github user jdye64 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
I think if the EventType is null, which I'm like you I don't know if it
ever could be?? Then the whitelisting logic should be ignored and the Event
Handlers should all be invoked. That makes th
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/133
A couple of other things I thought of:
- The default
[providers.xml](https://github.com/apache/nifi-registry/blob/7e4e9713406f3bb3ac1544b6ad69fbdd437f794c/nifi-registry-resources/src/
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Thanks @jdye64! That sounds good, I'll give it another look when those
changes are ready.
---
Github user jdye64 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Ok. After reading through all of these I'm thinking the best way to handle
this and have it operate the way I had envisioned is to take the approach of
adding the handleEvent() method in the Ev
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/133
If we are allowing each implementation to decide the logic in the handle
method, I don't see the value in the "share property" concept as documented:
> There are certain properties th
Github user jdye64 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
I had contemplated placing the logic that checked if the hook provider
should be invoked for an event or not right above
https://github.com/apache/nifi-registry/blob/7e4e9713406f3bb3ac1544b6ad6
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Will review...
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Had a quick look through the code and it LGTM, will try to give it a try
today or tomorrow if no else has the cycles to do so.
---
Github user jdye64 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Looks like the Travis CI build is failing trying to extract the npm binary
for building the web ui section. This doesn't have anything to do with the PR
so don't believe the build is truly fail
