[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-28 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1064 +1 Visually verified code and did a contrib check build. In a standalone instance configured tried all combinations of configured CS (configured, not, invalid ID and no CS) moving up and

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1064 Good call. Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1064 Thanks @JPercivall, I've updated the logic to verify the move is allowed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1064 @mcgilman this properly prevents the processor from being moved up to a parent group but it also prevents moving the processor to a child process group. Also when I tried moving a processor up a

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1064 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if