[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Thank you for merging! closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-17 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak merged. However I forgot to add reference to the PR in the commit message. Would you mind closing it manually ? I thank you in advance --- If your project is set up for it,

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Since the failing test has more Thread.sleep calls than before, the meaning of variables such as `age1` or `age2` became fragile at the later part of the test. I added another commit to

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Thanks for reviewing and catching the unit test failure. Yes, I'd like to look at it closer. I will update the PR accordingly. --- If your project is set up for it, you can reply to

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak my bad. I was just running a extra set of compilations and I noticed that under certain conditions there seems to be a race condition affecting ``` Tests run: 12,

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 LGTM merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak reviewing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and