[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 I think the issue was that I had left nifi.remote.input.host blank on both instances. So in the push model it was getting the ip address of the incoming connection which was my laptop's internal IP tha

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 @ijokarumawak yes they were both running on my laptop which is why I was wondering how the pull model ends up with the hostname, and the push model ends up with the ip address. I'll keep digging. ---

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1342 I used InetAddress.getHostName() to convert ip address to hostname, but if it can't resolve hostname, it just returns ip address. It depends on network environment. If `$ host ` command can't res

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1342 @bbende Are those nifi-1 and nifi-2 running on your laptop with different port configurations? Then I'd expect s2s.hostname will be the laptop hostname. Thanks! --- If your project is set up fo

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 Thanks @ijokarumawak ! I was testing this and I noticed that whenever I do a push model from nifi-1 to nifi-2, the value of s2s.hostname on the flow file in nifi-2 ends up being the IP addres

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1342 Hi @bbende I've updated unit tests. Please review the tests and merge it if it looks good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1342 @bbende Thanks for the comment. I reconsidered about s2s.address property, and by focusing only on the downstream flow, I think it probably doesn't matter whether the flow file came into the flow

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 @ijokarumawak thanks for digging in to this! I closed the other PR. Everything you described makes sense... I'm on the fence about the attribute names... lets say we have MiNiFi -> s2s -> NiFi

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-19 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1342 @bbende @randerzander Sorry for taking long, it took time to confirm results and consider how the result should be.. Please take a look on the table in previous comment, and let me k