[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-04-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1496 +1 LGTM, ran with the latest, full build and a number of use cases. All looks great, thanks very much! Merging to master --- If your project is set up for it, you can reply to this email and have y

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-04-09 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 @mattyb149 I've incorporated your comments. Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-04-07 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 @mattyb149 Glad to hear that EnforceOrderProcessor works for your use-cases. I'll fix the typos and apply suggested changes. Thanks! --- If your project is set up for it, you can reply to this e

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-04-07 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1496 I added a [gist](https://gist.github.com/mattyb149/bc601d0d00409922e788c0d4e5f8b0e2) with a couple of use cases as well (branching w random delay, and multiple Split processors). I left a

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 Hey @pvillard31 thanks for trying out this PR. I've update it to use both `.name()` and `.displayName`. Please let me know if you find anything suspicious during your test. --- If your project

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-02-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1496 Hey @ijokarumawak, I did few tests with your processor following your Gist explanations and using your template. It worked as expected. I'll try to test other scenarios. In the meantime, could you

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-02-10 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 I've written a Gist with a flow template to describe how this is intended to work, hope this helps for reviewing PR. Thanks! https://gist.github.com/ijokarumawak/88fc30a2300845b3c27a79113fc72d