Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
Reviewed, verified contrib-check and all tests, and ran tool. Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
@pvillard31 I reviewed this again. I like it; my only concern is that if
you run with `-SAN` it will still process, it won't show any error and a user
might expect it to generate a SAN in the keysto
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1530
Sorry for the misunderstanding @alopresto, agreed that it could be
confusing. Updated the PR as per your comments. Should be good now.
---
If your project is set up for it, you can reply to this e
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
@pvillard31 I think I was a little unclear -- I didn't expect both `-SAN`
and `--subjectAlternativeNames`, but just the long flag
`--subjectAlternativeNames`. Some commands stack their short flags (
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
Thanks @pvillard31 . For the record, I know some people prefer the Java 8
lambdas, and I come from a Ruby/Groovy background where I use closures and
chained collection operations for everything, but
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1530
Hey guys, hopefully I've addressed all your comments, thanks for the review!
- changed the option to SAN
- refactored code as suggested by @olegz
---
If your project is set up for it, you
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
I verified the contrib-check, all tests pass, smoke tests on flows work,
and the tool now generates SANs in standalone mode.
```
#5: ObjectId: 2.5.29.17 Criticality=false
SubjectAlt
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
That's a good point; not every flag needs a short code. SANs, while useful,
are definitely less common than some of the other features of the toolkit.
---
If your project is set up for it, you can
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1530
I agree that changing flags is likely to cause confusion although since we
haven't had a release yet, I would hope it would be minimal impact. Consistency
across modes of operation will help reduce
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
In general I would push to keep the flags consistent across client/server
and standalone mode. On the other hand, I am hesitant to change a flag that
already exists in the wild (although, it was jus
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1530
Thanks @alopresto, really appreciated. In particular I'd like your opinion
regarding the option letter: I used ``N`` because both ``s`` and ``S`` are
already used in standalone mode. Should I chang
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1530
@pvillard31 I have limited connectivity for the next couple days but I am
happy to review this as I reviewed your similar changes for client/server mode.
---
If your project is set up for it, you
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1530
Test example:
./tls-toolkit.sh standalone -s "nifi.vip.org,localhost,nifi-01" -n nifi-01
$ keytool -list -keystore keystore.jks -v
Keystore type: JKS
13 matches
Mail list logo
