[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2018-05-16 Thread joetrite
Github user joetrite commented on the issue: https://github.com/apache/nifi/pull/1589 i drove this one off a cliff :). New pull request raised. ---

[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1589 For furture reference, rather than merging master into your branch, I find it helpful to checkout master, pull the latest from upstream, then checkout your branch and rebase against master. There

[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2018-04-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1589 Another thing to consider here (although it would be a fair amount of refactor) is to repurpose this processor as AttributesToRecord. It doesn't add efficiency as a "record-aware" processor as

[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2017-03-27 Thread joetrite
Github user joetrite commented on the issue: https://github.com/apache/nifi/pull/1589 @mattyb149 thanks for reviewing, let me have a think on these things. i like the idea of allowing the attribute list to be dynamic. --- If your project is set up for it, you can reply to this