[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-06-02 Thread jfrazee
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1794 @trixpan LGTM +1 and I tested on SuSE and not SuSE. You can go ahead and merge it or I can in my afternoon/your evening. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-06-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @apiri @jfrazee - should I go ahead and merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee I intentionally used ID as I noticed ID_LIKE seemed like a mix bag... https://gist.github.com/djcp/6132025 --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread jfrazee
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1794 @trixpan Yep, it's working. Is there any use in using the ID_LIKE variable instead of ID? If so we could change that up quick, else I think this is good to go. --- If your project is set up for it,

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee sorry. I misread your comment. It works on leap?! Great. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee thanks. I haven't tested on leap. as not working you mean the file is not being linked or the service isn't being started? Cheers --- If your project is set up for it,

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-24 Thread jfrazee
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1794 @trixpan Fair enough. Seems clear the lsb_release suggestion was bad. BTW, I tested your changes on opensuse:latest (leap) and it's working as expected. --- If your project is set up for it, you can

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-22 Thread jfrazee
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1794 @trixpan @apiri Few things. It seems like we should be using lsb_release to grab the OS as well as chkconfig to handle creating run level symlinks instead of on on our own, at least for most of the

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @apiri may I ask you to have a look on this? Idea here is to use `/etc/os-release` to identify the Linux distribution and use that to flag some particular distro specific issues such as use