[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-08-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1921 @markap14 done and updated a bit to match the recent refactoring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-08-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1921 @pvillard31 looks like this PR has some conflicts. Do you mind rebasing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1921 Hey @trixpan, consistency is always a good thing and thanks for spotting that. I changed the name to ``_raw``. Let me know if something else is needed. --- If your project is set up for it, you

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-07-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1921 @pvillard31 I accept it is a bit of bit picking but is there any chance we call it _raw? IIRC this is the name we used on ParseCEF. Naming conventions make user experience smoother 😀 --- If your

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-06-26 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1921 Thanks @bbende, I updated my PR with latest master code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not