Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1976
@mattyb149 I confirmed that changes are merged, closing. Thanks for
reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1976
@ijokarumawak For some reason my rebase/squash didn't work so it also
didn't close this PR. But it has been merged, can you close this PR? Please and
thanks!
---
If your project is set up for it,
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1976
+1 LGTM, tested with MySQL, Oracle, and Postgres (and ran unit tests which
use Derby). Thanks for the fix/improvement @ijokarumawak and @ToivoAdams!
Merging to master
---
If your project is set
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1976
@mattyb149 Thanks for your feedback. I added a conversion for numeric
columns if the input JSON field is a boolean (true -> 0, false -> 1). Now
boolean JSON value can be mapped to Oracle
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1976
The code changes look good; I have a question in general about expected
behavior when the database doesn't explicitly support boolean types (such as
Oracle SQL). Let's say I have a JSON object
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1976
This PR contains commits from #293 which has been closed due to being
inactive, but the change was reasonable. I've cherry picked commits from the
PR, the 1st commit in this PR is a squashed
