Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2251
Ran `contrib-check` and all tests pass. Fired up an instance of the
application and it performed normally. +1, merging.
---
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2251
@peter-gergely-horvath I will merge this today.
---
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2251
@patricker, @joewitt Would it be possible for you to perform the merge?
Based on my understanding, the changes have been approved by @alopresto.
I have some additional pull
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2251
I don't see any breaking changes.
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2251
This looks fine to me (have a full clean build w/contrib check running but
i expect it will be fine). Travis-CI would probably work fine now too given
all the improvements that have been made.
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2251
Hi @patricker, please let me know if there is anything that requires
clarification or if there is any way I could help the review. I would love to
see this pull request being merged.
