[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-04-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2575 +1 LGTM, ran full build with unit tests and tried Ambari Format as well as Record Format with an AvroRecordSetWriter. Verified the records are in the prescribed format and the standard S2S

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-04-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2575 Done, thanks @mattyb149 ! ---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-04-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2575 Mind doing another rebase? I will review shortly thereafter, thanks! ---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-03-31 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2575 Both issues seem to be resolved on master, I have rebased against master. ---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-03-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2575 I saw the "unable to find schema" issue in the last PR too, it seems to be related to the onPropertyModified() method of AvroSchemaRegistry, that's where the actual schemas get populated, but while