[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-07-10 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2629 The database error only propagates if `isClosed` returns false; I was thinking that it might be possible to have a connection close before all results are read. The documentation isn't clear on this

[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-07-10 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2629 Hi @patricker, Regarding: "Also, this seems to specifically be for Phoenix. With the fix as is, I don't know if it's possible to tell the difference between a database going off

[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-07-10 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2629 I like the unit tests, but what about moving your check? If you created a `catch` block at the end of the existing `try` block in `convertToAvroStream` it would probably simplify the flow a lot.

[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-04-12 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2629 @zenfenan fixed checkstyle violations. Thanks ---