Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2711
+1 LGTM, thanks all for the reviews and @joetrite for the new feature! I
ran unit tests and tried various combinations of options on a live NiFi,
everything looks good, merging to master.
---
Github user bdesert commented on the issue:
https://github.com/apache/nifi/pull/2711
@joetrite , no more comments from my side, thanks for addressing code
review comments!
@MikeThomsen , LGTM. Could you please give a second look on it now? I
believe it's ready, but there are
Github user joetrite commented on the issue:
https://github.com/apache/nifi/pull/2711
@bdesert good catch, we should add the option to push the header to
attribute or content based on the selection. The header should also be csv
format so that when the header and data are in the
Github user bdesert commented on the issue:
https://github.com/apache/nifi/pull/2711
@joetrite , @MikeThomsen ,
So, I tested the processor. It works OK.
But I've got a question.
In JSON it's easy - json structure will include both attribute name and
attribute value. in CSV
Github user joetrite commented on the issue:
https://github.com/apache/nifi/pull/2711
@bdesert it looks like the regex support was added to AttributesToJSON
after copied the code. I'll add regex support to this processor and check if
anything else has changed.
---
Github user bdesert commented on the issue:
https://github.com/apache/nifi/pull/2711
@joetrite , while AttributesToJSON has regex support for attributes, new
AttributesToCSV doesn't have it - is there a reason for not keeping consistency?
---
Github user bdesert commented on the issue:
https://github.com/apache/nifi/pull/2711
@joetrite , I would like to mention it under the current PR - there was a
discussion about having ["record-aware"
output](https://github.com/apache/nifi/pull/1589#issuecomment-383639761). This
will
