[GitHub] nifi issue #2874: NIFI-4279 PutDatabaseRecord and ConvertJSONToSQL stream ha...

2018-07-10 Thread lfrancke
Github user lfrancke commented on the issue: https://github.com/apache/nifi/pull/2874 @mattyb149 I'd still argue that adding a hint to the JIRA would be a good thing. Now there's no context at all. What is the bug you're referring to? Sure, I can dig in the history but all it

[GitHub] nifi issue #2874: NIFI-4279 PutDatabaseRecord and ConvertJSONToSQL stream ha...

2018-07-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2874 +1 LGTM, reproduced the issue before this fix, and verified the correct behavior is implemented. Sorry you had to do this lol, but very thankful for the fix! Merging to master ---

[GitHub] nifi issue #2874: NIFI-4279 PutDatabaseRecord and ConvertJSONToSQL stream ha...

2018-07-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2874 Reviewing... (I think since the link is in the Jira already that should be fine) ---

[GitHub] nifi issue #2874: NIFI-4279 PutDatabaseRecord and ConvertJSONToSQL stream ha...

2018-07-10 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2874 @lfrancke I considered adding a link to the article or ticket, but it's not something that I see done frequently in NiFi; if you feel it makes sense to do so in this scenario I gladly will.

[GitHub] nifi issue #2874: NIFI-4279 PutDatabaseRecord and ConvertJSONToSQL stream ha...

2018-07-10 Thread lfrancke
Github user lfrancke commented on the issue: https://github.com/apache/nifi/pull/2874 I did read the JIRA and referenced article. I also found https://jira.apache.org/jira/browse/DDLUTILS-29 which fixes the same issue in another project. The only comment I have about the