[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 +1 thanks! Merged to master... ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/3043 Fixed that and also a checkstyle error that broke the build, hopefully will pass this time, thanks! ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 Thansk @pepov. I had one minor comment regarding logging, but aside from that these changes look good to me ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/3043 @kevdoran changes are in ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-02 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 Thanks @pepov! I'll re-review the PR when your changes are in. ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-02 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/3043 I didn't think about considering an empty group as not set, but now I can see that initial admin is treated the same, so will update the PR to work like that. I used custom because I was