Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/319
+1 LGTM, thanks for this awesome feature! I ran the tests and tried with
various incrementing strategies, all looks good, merging to master
---
If your project is set up for it, you can reply to
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/319
@mattyb149 pushed out a new commit adding documentation on the init value
requirements and clarification on the "empty" value.
Thanks for reviewing documentation too! I totally forgot it.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/319
@mattyb149 removed the default value, added a validation check so that it
is invalid if it is configured for state but has no initial value, and added a
check in the unit tests.
---
If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/319
Hey @trixpan, if you have free cycles I'd appreciate finalizing this
review. I've rebased on the latest master
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/319
@trixpan, Ah sorry for not commenting but it is ready for review. It is
rebased and I added an EL function to access state in a consistent
user-friendly way.
---
If your project is set up for it,
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/319
@JPercivall no issue. let us know when ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/319
Thanks @trixpan! Rgr, I'm working on rebasing this and making the state
variable accessing a bit more user-friendly
---
If your project is set up for it, you can reply to this email and have your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/319
@JPercivall welcome back!
Could you rebase this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
