Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/496
@pvillard31 addressed both the trailing whitespace (sigh...) and the name
fiasco. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/496
@trixpan
You've given the same .name() to multiple properties, this has to be
unique. The consequence is that properties are not longer displayed in the UI.
Besides, there is a checkstyle viola
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/496
@pvillard31 let me know if you have any other comments as I am waiting for
this to be merged to submit a PR covering NIFI-1971 as well
Cheers
---
If your project is set up for it, you can re
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/496
@pvillard31
Hopefully issues have been addressed now.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/496
@pvillard31 rebase complete and hopefully all issues were addressed.
Let me know if I missed something
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/496
Hey @trixpan, thanks for your work! I've made some comments. Also, could
you rebase against master? At the moment, I've not been able to test it because
of the NPE I mentioned in comments. Once comm
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/496
@pvillard31
Thanks for the feedback. I did rework the tests so that compilation no
longer requires Internet access. I also removed references to 3rd party
trademarks and other terms that coul
