Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
+1 LGTM, ran tests and verified comments were incorporated, merging to
master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
@mattyb149 your comments are addressed in the last commit. Thanks for
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
@mattyb149 all the suggested changes have been addressed in the last
commit. I've also included in the additional documentation sample configuration
for GMail, so you can use it to play around/test.
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
@mattyb149 I was just trying to reproduce the issue with the hanging thread
you described above in relation to ConsumePop3, but I can't. Are you sure that
what you saw is related to this processor or
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
I ran ConsumePop3 against GMail but hadn't seen your comment on all the
dynamic properties that need to be set. I started and stopped the processor,
but there is a thread continuing to run. Stopped
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
+1 to the "Additional Details" file for all the dynamic properties, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/710
@olegz, seems like an option. How about adding an additional help file
withbthe basics of what you already found?
---
If your project is set up for it, you can reply to this email and have your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/710
@olegz what about using the same strategy as PutEmail where the user can
configure the socket on runtime?
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
One advise though is that there are additional JavaMail properties that one
may need to provide to accomodate specific servers. For example in Gmail you
need to specify
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
Digging into the source code for it looks like something is out of
compliance with POP3 protocol
```java
if (line.startsWith("+OK"))
r.ok = true;
else if
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/710
@olegz agreed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/710
@trixpan Well, I am not sure what that is (will be looking) and how
reliable mailtrap.io is for such testing giving it's description "Fake smtp
testing server. Dummy smtp email testing". I've tested it
12 matches
Mail list logo