Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/913
@jskora closed it.
Whenever this happens you can simply push an empty commit to git with the
fixed reference to the PR
---
If your project is set up for it, you can reply to this email and
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/913
@kirkalicious Please close this, I committed it, but I transposed the PR
number in the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kirkalicious commented on the issue:
https://github.com/apache/nifi/pull/913
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/913
@joewitt Thanks, from what I can tell looking at JDK source the format spec
drives the output more than the Locale, so I agree that the comments should
cover it.
@kirkalicious can you add the
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/913
Should it go into the 0.x branch:
It does not meet the criteria for backporting so doing so would require a
specific need and willing merger.
The use of ListFile statics seems ok to me
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/913
@kirkalicious, thanks! The changes look good and tests check out fine.
I'd prefer to move the constants to a parent common to ListFileTransfer and
ListFile, but the only common parent is
