[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-09-29 Thread a-aravindan
Github user a-aravindan commented on the issue: https://github.com/apache/nifi/pull/914 Hi All, This nifi-**-nar-0.6.1.nar created for this request is not working with HDP 2.3.4. It is throwing the ERROR "failed to process due to java.lang.NoSuchMethodError:

[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/914 Tested and all looks good, will merge to master, thanks Andrew! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-08-23 Thread apsaltis
Github user apsaltis commented on the issue: https://github.com/apache/nifi/pull/914 Bryan, Thanks for the review. This is certainly new development and thus I agree that this should be put into master --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/914 Thanks for making the updates, looks good, testing it now... I noticed this PR is against 0.x, since most new development is going into 1.x, should we put this into master? I think the changes

[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/914 Overall this looks good, thanks Andrew! One overall comment is that we now have several places where we create a new string from a byte[] like `new String(byte[])` and I think we want to