[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/999 I confirmed that this builds fine on the 0.x branch with Java 7. Thanks @pvillard31 and @alopresto --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/999 Yes @alopresto, I noticed it, hopefully I've done all the required modifications. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/999 Thanks @pvillard31 . Be careful with `StandardProcessorTestRunner` -- I think my IDE cleaned up the `` typing on line 392 which will cause an issue with Java 7 compatibility. ---

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/999 Thanks @alopresto, everything is OK! I merged it to master. I also followed recommendations from @mosermw to cherry-pick into 0.x with Java 7 compatibility. --- If your project is set up for it,

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/999 @pvillard31 I really appreciate your persistence with this one. Not sure why I missed that the last time. I added a method to clear the flowfile queue in the test runner, because it seems

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/999 @alopresto your last changes are fine to me but it's still not working on my side. If I run the unit test individually it works fine, but when running maven build or the whole tests suite of the

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/999 And, of course, as soon as I comment, it hits me -- `GetHTTP`, unlike `PostHTTP`, does not require a flowfile input in order to execute. So when I copied the tests I had written for `PostHTTP`, I

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/999 @pvillard31 and @mosermw , thanks for noting that. When I re-ran locally, I encountered the same issue. I have resolved it, but not to my complete satisfaction. The test now accepts that _n_

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/999 I had the same unit test failure as @pvillard31. Once I resolved that locally, I confirmed that this change works against the URL listed in NIFI-2373. contrib-check passes. This also

[GitHub] nifi issue #999: NIFI-2266 Enabled TLSv1.1 and TLSv1.2 protocols for GetHTTP...

Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/999 Hey @alopresto, I have this unit test failing: Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.999 sec <<< FAILURE! - in