GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/2229
NIFI-4534 Force CSV Record Read/Write streams to UTF-8
I've been trying to read UTF-8 BOM CSV files with occasional Chinese in
them. I've been running into a lot of trouble with the strings being read as
junk characters.
The strange thing is, though I added two unit tests, these tests pass
without this code change in place in my environment (I know... not great
tests). But with this code change in place CSV now works great on my actual
server.
According to the docs, if you don't explicitly specify UTF-8 then the
read/write streams will use the environments default encoding. It feels likely
that my default environment for my unit tests is UTF-8, but is something
different when I run NiFi. Not exactly sure.
With this change in place, the code now matches the example code from
Apache Commons CSV documentation on how to handle files with a BOM. The BOM was
being handled already through the use of a BOMInputStream, but no encoding was
being explicitly set.
https://commons.apache.org/proper/commons-csv/user-guide.html#Handling_Byte_Order_Marks
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-4534
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2229
----
commit 55d85ffd5c60c2dee2ba01cd66f5647064b6c4d7
Author: patricker <patric...@gmail.com>
Date: 2017-10-27T05:42:28Z
NIFI-4534 Force CSV Record Read/Write streams to UTF-8
----
---
