szaszm closed pull request #1702: MINIFICPP-2244 Update MiNiFi C2 and tests to
support NiFi 2.0
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lordgamez commented on code in PR #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702#discussion_r1425132359
##
docker/test/integration/minifi/flow_serialization/Nifi_flow_json_serializer.py:
##
@@ -0,0 +1,226 @@
+# Licensed to the Apache Software Foundation (ASF)
martinzink commented on code in PR #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702#discussion_r1415530574
##
docker/test/integration/minifi/flow_serialization/Nifi_flow_json_serializer.py:
##
@@ -0,0 +1,226 @@
+# Licensed to the Apache Software Foundation (ASF)
lordgamez commented on code in PR #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702#discussion_r1411758760
##
docker/test/integration/minifi/flow_serialization/Nifi_flow_json_serializer.py:
##
@@ -0,0 +1,226 @@
+# Licensed to the Apache Software Foundation (ASF)
lordgamez commented on code in PR #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702#discussion_r1411749563
##
docker/test/integration/features/http.feature:
##
Review Comment:
I was only testing the NiFi specific changes in this featureset, I didn't
push the
szaszm commented on code in PR #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702#discussion_r1410973507
##
docker/test/integration/features/http.feature:
##
Review Comment:
Why are these commented out?
##
lordgamez opened a new pull request, #1702:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1702
Also tested with the NiFi 1.24 release and the updates changes to work with
that version as well.
https://issues.apache.org/jira/browse/MINIFICPP-2244
