exceptionfactory closed pull request #7884: NIFI-12233 - Parameter context
provider for 1Password
URL: https://github.com/apache/nifi/pull/7884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter commented on PR #7884:
URL: https://github.com/apache/nifi/pull/7884#issuecomment-1806086984
##
[Codecov](https://app.codecov.io/gh/apache/nifi/pull/7884?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> :exclamation: No
pvillard31 commented on PR #7884:
URL: https://github.com/apache/nifi/pull/7884#issuecomment-1805957690
Additional commit to address your comments @exceptionfactory, thanks for the
review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
exceptionfactory commented on code in PR #7884:
URL: https://github.com/apache/nifi/pull/7884#discussion_r1386864555
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java:
##
@@ -0,0
pvillard31 commented on PR #7884:
URL: https://github.com/apache/nifi/pull/7884#issuecomment-1799536578
Thanks for the review @exceptionfactory. I believe I've addressed all of
your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
exceptionfactory commented on code in PR #7884:
URL: https://github.com/apache/nifi/pull/7884#discussion_r1385246902
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java:
##
@@ -0,0
pvillard31 commented on code in PR #7884:
URL: https://github.com/apache/nifi/pull/7884#discussion_r1383609909
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java:
##
@@ -0,0 +1,216
pvillard31 commented on code in PR #7884:
URL: https://github.com/apache/nifi/pull/7884#discussion_r1383609346
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java:
##
@@ -0,0 +1,216
mattyb149 commented on code in PR #7884:
URL: https://github.com/apache/nifi/pull/7884#discussion_r1382694003
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java:
##
@@ -0,0 +1,216
pvillard31 commented on PR #7884:
URL: https://github.com/apache/nifi/pull/7884#issuecomment-1764253118
Some screenshots
![Screenshot 2023-10-14 at 16 38
29](https://github.com/apache/nifi/assets/11541012/fdec55a4-12f8-415b-8337-23a76e7e52b5)
![Screenshot 2023-10-14 at 16 39
pvillard31 opened a new pull request, #7884:
URL: https://github.com/apache/nifi/pull/7884
# Summary
[NIFI-12233](https://issues.apache.org/jira/browse/NIFI-12233) - Parameter
context provider for 1Password
# Tracking
Please complete the following tracking steps prior
11 matches
Mail list logo