tpalfy commented on PR #8250:
URL: https://github.com/apache/nifi/pull/8250#issuecomment-2048073797
LGTM
Thank your for work @mark-bathori and for the review @dan-s1 !
Merged into main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
asfgit closed pull request #8250: NIFI-12614: Create record reader service for
Protobuf messages
URL: https://github.com/apache/nifi/pull/8250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mark-bathori commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1501870173
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/converter/ProtobufDataConverter.java:
##
@@ -0,0
mark-bathori commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1501869967
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/ProtobufReader.java:
##
@@ -0,0 +1,136 @@
+/*
+ *
tpalfy commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1495827976
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/converter/ProtobufDataConverter.java:
##
@@ -0,0 +1,380 @@
tpalfy commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1491461479
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/converter/ProtobufDataConverter.java:
##
@@ -0,0 +1,380 @@
tpalfy commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1491426957
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/test/java/org/apache/nifi/services/protobuf/TestProtobufRecordReader.java:
##
@@ -0,0 +1,151 @@
+/*
+ *
tpalfy commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1487902665
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/ProtobufReader.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed
mark-bathori commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1478221782
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/resources/docs/org.apache.nifi.services.protobuf.ProtobufReader/additionalDetails.html:
##
dan-s1 commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1476509298
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/resources/docs/org.apache.nifi.services.protobuf.ProtobufReader/additionalDetails.html:
##
@@ -0,0
dan-s1 commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1476509298
##
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/resources/docs/org.apache.nifi.services.protobuf.ProtobufReader/additionalDetails.html:
##
@@ -0,0
dan-s1 commented on PR #8250:
URL: https://github.com/apache/nifi/pull/8250#issuecomment-1919646204
@exceptionfactory Can you please restart the `dependency-check`? The
exception does not seem to relate to the changes. Thanks!
--
This is an automated message from the Apache Git Service.
mark-bathori commented on PR #8250:
URL: https://github.com/apache/nifi/pull/8250#issuecomment-1899211820
Thanks @dan-s1 for the comment. I've added additionDeatils page to the
Reader in my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the
dan-s1 commented on PR #8250:
URL: https://github.com/apache/nifi/pull/8250#issuecomment-1896558818
@mark-bathori With a big addition such as this, I would recommend some more
documentation for end users so they are clear on how this works. This would go
in your case under
mark-bathori opened a new pull request, #8250:
URL: https://github.com/apache/nifi/pull/8250
# Summary
The implementation does not generate message specific code with builders,
instead it reads the schema from the provided proto
15 matches
Mail list logo
