Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-06 Thread via GitHub
scottyaslan merged PR #8464: URL: https://github.com/apache/nifi/pull/8464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-06 Thread via GitHub
james-elliott commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1515071307 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss: ## @@ -317,7 +317,7 @@ $appFontPath:

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-06 Thread via GitHub
james-elliott commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1515070864 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss: ## @@ -393,7 +393,7 @@

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1513589282 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss: ## @@ -393,7 +393,7 @@

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1513589096 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss: ## @@ -317,7 +317,7 @@ $appFontPath:

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on PR #8464: URL: https://github.com/apache/nifi/pull/8464#issuecomment-1979364266 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] NIFI-12721 Button UX [nifi]

2024-03-01 Thread via GitHub
james-elliott opened a new pull request, #8464: URL: https://github.com/apache/nifi/pull/8464 Updated all the dialog buttons to change them from stroked and raised to basic. This better aligns with Angular Material guidelines and should address the confusion between disabled and cancelled.