exceptionfactory closed pull request #8493: NIFI-12887 Additional ways for
handling Strings as binary in PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/8493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
exceptionfactory commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1997607252
> > The last item to address it the `required()` status for the new
property. As mentioned in the comment, it can be set to `true` since the
default value provided maintains
tpalfy commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1997388520
> The last item to address it the `required()` status for the new property.
As mentioned in the comment, it can be set to `true` since the default value
provided maintains compatibility with
pvillard31 commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1994840950
Yeah the option of opening another PR for 1.x is also OK :) As a FYI, from
the Github UI, on the PR, you can change the branch against which the PR is
submitted, that is why I suggested
exceptionfactory commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1994733725
> > @tpalfy - I think the easiest is to keep this PR for support/1.x, and
open another PR targeted at main that does not use Google library. I think it's
safer compared to letting
tpalfy commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1994675042
> @tpalfy - I think the easiest is to keep this PR for support/1.x, and open
another PR targeted at main that does not use Google library. I think it's
safer compared to letting the merger
pvillard31 commented on PR #8493:
URL: https://github.com/apache/nifi/pull/8493#issuecomment-1994603126
@tpalfy - I think the easiest is to keep this PR for support/1.x, and open
another PR targeted at main that does not use Google library. I think it's
safer compared to letting the merger
tpalfy commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1523369229
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -764,7 +796,15 @@ private
tpalfy commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1523369229
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -764,7 +796,15 @@ private
exceptionfactory commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1521755668
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -238,6 +239,34
exceptionfactory commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1521652062
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -764,7 +796,15
tpalfy commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1521646045
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -764,7 +796,15 @@ private
exceptionfactory commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1521441171
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -764,7 +796,15
tpalfy opened a new pull request, #8493:
URL: https://github.com/apache/nifi/pull/8493
Add option to treat Strings as hexadecimal character sequences or
base64-encoded binary data when inserting into a binary type column.
# Summary
14 matches
Mail list logo
