exceptionfactory commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-2150411573
Thanks for your work on this improvement @Freedom9339. With recent changes
the `nifi-web-ui` module has been removed in favor of the restructured
`nifi-web-frontend` module. Given t
exceptionfactory closed pull request #7734: NIFI-3785 Added feature to move a
controller service to it's parent o…
URL: https://github.com/apache/nifi/pull/7734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Freedom9339 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-2056834188
@markap14 Good Morning, Have you had a chance to look at the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513383264
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java:
##
@@ -680,6 +681,
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513382206
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java:
##
@@ -680,6 +681,
Freedom9339 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1979482152
@markap14 Thank you for the feedback. I've addressed all the changes and
concerns provided. The process will now fail if there is a referencing
component scope conflict and an error prom
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513378795
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##
@@ -2624,6 +2788,26 @@
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513377994
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java:
##
@@ -680,6 +681,
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513377110
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513376790
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513375471
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374784
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374477
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374037
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513373146
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513373492
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513372649
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1513372161
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,11
markap14 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1506333554
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -2939,6 +2939,115 @
Freedom9339 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1957639012
@markap14 I've rebased against main and pushed. Thank You!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
markap14 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1955220883
@Freedom9339 you mind rebasing against `main` and pushing again? That should
kick off the tests against the latest & greatest. I misread the github comments
initially, thinking you pushed a
markap14 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1955213676
Oh nice, thanks @Freedom9339 ! This is something that I've wanted for a
while. I would definitely want to get a reviewer who knows the UI as well such
as @mcgilman or @scottyaslan. I should
Freedom9339 commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1946480058
@markap14 Would mind taking a look at this PR? I do see you were the one who
created the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1383685612
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java:
##
@@ -688,6 +689,
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1383685393
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -3022,6 +3022,11
Freedom9339 commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1381998714
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -3022,6 +3022,11
markobean commented on code in PR #7734:
URL: https://github.com/apache/nifi/pull/7734#discussion_r1381940007
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##
@@ -3022,6 +3022,119
markobean commented on PR #7734:
URL: https://github.com/apache/nifi/pull/7734#issuecomment-1792769374
I had trouble building, but once I rebased to `main` the issues resolved.
Please rebase.
I installed NiFi and played with this feature. It worked as expected moving
to parent, to a
28 matches
Mail list logo
