Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]

2024-04-25 Thread via GitHub
lordgamez commented on PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#issuecomment-2077025996 > It would be nice to be able to differentiate between this and future versions, like 1.0 proper, but I didn't find any way to convince CMake to add something other than a

Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]

2024-04-25 Thread via GitHub
szaszm commented on PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#issuecomment-2077004610 It would be nice to be able to differentiate between this and future versions, like 1.0 proper, but I didn't find any way to convince CMake to add something other than a number at

Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]

2024-04-25 Thread via GitHub
lordgamez commented on code in PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#discussion_r1579318823 ## CMakeLists.txt: ## @@ -22,7 +22,7 @@ cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_ cmake_policy(SET CMP0065 OLD) #

Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]

2024-04-25 Thread via GitHub
martinzink commented on code in PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#discussion_r1579314596 ## CMakeLists.txt: ## @@ -22,7 +22,7 @@ cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_ cmake_policy(SET CMP0065 OLD) #