Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-04-16 Thread via GitHub
mcgilman merged PR #8273: URL: https://github.com/apache/nifi/pull/8273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-04-16 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1567741800 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-04-16 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1567607846 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-04-15 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1565769286 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-04-12 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1563327796 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/flow-analysis-drawer.jsp: ## @@ -0,0 +1,84 @@ +<%--

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-19 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1531038999 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-19 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1530355434 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-15 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1526743150 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-15 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1526709847 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-14 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1525292949 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-07 Thread via GitHub
sardell commented on PR #8273: URL: https://github.com/apache/nifi/pull/8273#issuecomment-1984539412 @mcgilman I believe I addressed all your comments. Thanks for the quick assist, @tpalfy! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-07 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1516859726 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-07 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1516856485 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-07 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1516140292 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/flow-analysis-drawer.jsp: ## @@ -0,0 +1,85 @@ +<%-- +

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-05 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1513231844 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-04 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1511380014 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-01 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1509031907 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1508148578 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1508139735 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1508127197 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/flow-status.jsp: ## @@ -71,6 +71,7 @@

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1507857234 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1507846158 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-29 Thread via GitHub
tpalfy commented on PR #8273: URL: https://github.com/apache/nifi/pull/8273#issuecomment-1971265091 LGTM Tested with built-in and some custom rules. All issues raised by me seem to be addressed. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-02 Thread via GitHub
sardell commented on PR #8273: URL: https://github.com/apache/nifi/pull/8273#issuecomment-1924612023 @tpalfy I believe I addressed all of the issues you pointed out. When you have time, could you please take another look? -- This is an automated message from the Apache Git Service. To res

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-02 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1476649837 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-02 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1476628525 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-02 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1476627180 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-02 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1476626561 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-01 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1474564178 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-02-01 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1474542558 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-26 Thread via GitHub
mcgilman commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1468196770 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-25 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r142453 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-25 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1463631993 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-23 Thread via GitHub
sardell commented on PR #8273: URL: https://github.com/apache/nifi/pull/8273#issuecomment-1907023978 > Hey @sardell 👋 Thanks for the PR! Would love to have you help contribute this into the new UI work. That work is still in progress and is being tracked here [1]. Please add a line item the

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-23 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1463925689 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-23 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1463913231 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-23 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1463913231 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-23 Thread via GitHub
mcgilman commented on PR #8273: URL: https://github.com/apache/nifi/pull/8273#issuecomment-1906159835 > I'm not sure how this will translate over to the new UI work that's currently in-progress, but I'll gladly take responsibility for adding it there as well. Hey @sardell 👋 Thanks fo

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-22 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1462197492 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-01-19 Thread via GitHub
sardell commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1459356177 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6