[GitHub] nifi-minifi pull request #33: Minifi 108
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79510580 --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConfigSchema.java --- @@ -198,4 +305,31 @@ public ComponentStatusRepositorySchema getComponentStatusRepositoryProperties() public ProvenanceRepositorySchema getProvenanceRepositorySchema() { return provenanceRepositorySchema; } + +public int getVersion() { +return CONFIG_VERSION; +} + +/** + * Will replace all characters not in [A-Za-z0-9_] with _ + * + * This has potential for collisions so it will also append numbers as necessary to prevent that + * + * @param ids id map of already incremented numbers + * @param name the name + * @return a unique filesystem-friendly id + */ +protected static String getUniqueId(Mapids, String name) { +String baseId = StringUtil.isNullOrEmpty(name) ? EMPTY_NAME : ID_REPLACE_PATTERN.matcher(name).replaceAll("_"); +String id = baseId; +Integer idNum = ids.get(baseId); +while (ids.containsKey(id)) { +id = baseId + "_" + idNum++; +} +if (id != baseId) { --- End diff -- Both "id" and "baseId" are Strings, are you comparing using "!=" instead of "!id.equals(..." on purpose? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi pull request #33: Minifi 108
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79514742 --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConfigSchema.java --- @@ -96,51 +100,154 @@ public ConfigSchema(Map map) { addIssuesIfNotNull(provenanceReportingProperties); addIssuesIfNotNull(provenanceRepositorySchema); +Set processorIds = new HashSet<>(); if (processors != null) { - checkForDuplicateNames(FOUND_THE_FOLLOWING_DUPLICATE_PROCESSOR_NAMES, processors.stream().map(ProcessorSchema::getName).collect(Collectors.toList())); +List processorIdList = processors.stream().map(ProcessorSchema::getId).collect(Collectors.toList()); +checkForDuplicates(this::addValidationIssue, FOUND_THE_FOLLOWING_DUPLICATE_PROCESSOR_IDS, processorIdList); for (ProcessorSchema processorSchema : processors) { addIssuesIfNotNull(processorSchema); } +processorIds.addAll(processorIdList); } if (connections != null) { - checkForDuplicateNames(FOUND_THE_FOLLOWING_DUPLICATE_CONNECTION_NAMES, connections.stream().map(ConnectionSchema::getName).collect(Collectors.toList())); +List idList = connections.stream().map(ConnectionSchema::getId).filter(s -> !StringUtil.isNullOrEmpty(s)).collect(Collectors.toList()); +checkForDuplicates(this::addValidationIssue, FOUND_THE_FOLLOWING_DUPLICATE_CONNECTION_IDS, idList); for (ConnectionSchema connectionSchema : connections) { addIssuesIfNotNull(connectionSchema); } } +Set remoteInputPortIds = new HashSet<>(); if (remoteProcessingGroups != null) { - checkForDuplicateNames(FOUND_THE_FOLLOWING_DUPLICATE_REMOTE_PROCESSING_GROUP_NAMES, remoteProcessingGroups.stream().map(RemoteProcessingGroupSchema::getName).collect(Collectors.toList())); +checkForDuplicates(this::addValidationIssue, FOUND_THE_FOLLOWING_DUPLICATE_REMOTE_PROCESSING_GROUP_NAMES, + remoteProcessingGroups.stream().map(RemoteProcessingGroupSchema::getName).collect(Collectors.toList())); for (RemoteProcessingGroupSchema remoteProcessingGroupSchema : remoteProcessingGroups) { addIssuesIfNotNull(remoteProcessingGroupSchema); } +List remoteProcessingGroups = getRemoteProcessingGroups(); +if (remoteProcessingGroups != null) { +List remoteInputPortIdList = remoteProcessingGroups.stream().filter(r -> r.getInputPorts() != null) +.flatMap(r -> r.getInputPorts().stream()).map(RemoteInputPortSchema::getId).collect(Collectors.toList()); +checkForDuplicates(this::addValidationIssue, FOUND_THE_FOLLOWING_DUPLICATE_REMOTE_INPUT_PORT_IDS, remoteInputPortIdList); +remoteInputPortIds.addAll(remoteInputPortIdList); +} +} + +Set duplicateIds = new HashSet<>(processorIds); +duplicateIds.retainAll(remoteInputPortIds); +if (duplicateIds.size() > 0) { +addValidationIssue(FOUND_THE_FOLLOWING_DUPLICATE_IDS + duplicateIds.stream().sorted().collect(Collectors.joining(", "))); +} +} + +protected List getProcessorSchemas(List processorMaps) { +if (processorMaps == null) { +return null; } +List processors = convertListToType(processorMaps, "processor", ProcessorSchema.class, PROCESSORS_KEY); + +MapidMap = processors.stream().map(ProcessorSchema::getId).filter( +s -> !StringUtil.isNullOrEmpty(s)).collect(Collectors.toMap(Function.identity(), s -> 2, Integer::compareTo)); + +// Set unset ids +processors.stream().filter(connection -> StringUtil.isNullOrEmpty(connection.getId())).forEachOrdered(processor -> processor.setId(getUniqueId(idMap, processor.getName(; + +return processors; } -private void checkForDuplicateNames(String errorMessagePrefix, List names) { -if (names != null) { -Set seenNames = new HashSet<>(); -Set duplicateNames = new TreeSet<>(); -for (String name : names) { -if (!seenNames.add(name)) { -duplicateNames.add(name); +protected List getConnectionSchemas(List connectionMaps) { +if (connectionMaps == null) { +return null; +} +List connections = convertListToType(connectionMaps, "connection",
[jira] [Created] (NIFI-2795) Enhance Cluster UI with System Diagnostics
James Wing created NIFI-2795: Summary: Enhance Cluster UI with System Diagnostics Key: NIFI-2795 URL: https://issues.apache.org/jira/browse/NIFI-2795 Project: Apache NiFi Issue Type: New Feature Components: Core UI Affects Versions: 1.0.0 Reporter: James Wing Priority: Minor The Cluster UI currently provides some basic information on each node in the cluster and options for connecting and disconnecting nodes. I propose to add system diagnostics information in tables, contained in multiple tabs. Roughly, the tabs should cover the same content as the System Diagnostics dialog already in the System UI, but in a tabular format for comparing across nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1032: NIFI-2794 - Expose a getOneFromEachConnection metho...
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1032 NIFI-2794 - Expose a getOneFromEachConnection method in ProcessSession You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi getonefromeach Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1032.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1032 commit ee813f5844bdbd0576f1653be34e41817625eb0b Author: Pierre VillardDate: 2016-09-19T22:00:32Z NIFI-2794 - Expose a getOneFromEachConnection method in ProcessSession --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination
[ https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504784#comment-15504784 ] ASF GitHub Bot commented on NIFI-2790: -- Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1027 Reviewing. . . > Set JMS destination name on send/receive instead of using the default > destination > - > > Key: NIFI-2790 > URL: https://issues.apache.org/jira/browse/NIFI-2790 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS and PublishJMS currently pull their destination name from the > default JMS destination (setDefaultDestinationName() on the JmsTemplate). The > effect this has is that attribute expressions are evaluated with respect to > the context only and not the FlowFile, so expression language support really > only extends to EL functions and variables from the variable registry. > This doesn't have a big impact on ConsumeJMS since it doesn't take input, but > it means that destinations can be set at runtime in PublishJMS. > The JmsTemplate send() and receive() can take the destination name as an > argument though, so these method variants should be used so EL support is > fully enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #1027: NIFI-2790 Set JMS destination name on send/receive instead...
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1027 Reviewing. . . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-2792) Removal of a Template does not save the flow.
[ https://issues.apache.org/jira/browse/NIFI-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2792: -- Status: Patch Available (was: In Progress) > Removal of a Template does not save the flow. > - > > Key: NIFI-2792 > URL: https://issues.apache.org/jira/browse/NIFI-2792 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > When removing a template, the flow is not saved. Consequently, if no other > actions are taken prior to shutting down the template will be reloaded upon > the next restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2792) Removal of a Template does not save the flow.
[ https://issues.apache.org/jira/browse/NIFI-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504411#comment-15504411 ] ASF GitHub Bot commented on NIFI-2792: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1031 Saving flow after Template removal NIFI-2792: - Ensuring the flow is saved when a template is deleted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-2792 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1031 commit 5bc2fb50b3ccdc2f9e302ecfc3a2ba8fc55dfe6e Author: Matt GilmanDate: 2016-09-19T19:28:55Z NIFI-2792: - Ensuring the flow is saved when a template is deleted. > Removal of a Template does not save the flow. > - > > Key: NIFI-2792 > URL: https://issues.apache.org/jira/browse/NIFI-2792 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > When removing a template, the flow is not saved. Consequently, if no other > actions are taken prior to shutting down the template will be reloaded upon > the next restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1031: Saving flow after Template removal
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1031 Saving flow after Template removal NIFI-2792: - Ensuring the flow is saved when a template is deleted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-2792 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1031 commit 5bc2fb50b3ccdc2f9e302ecfc3a2ba8fc55dfe6e Author: Matt GilmanDate: 2016-09-19T19:28:55Z NIFI-2792: - Ensuring the flow is saved when a template is deleted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2774) ConsumeJMS processor losses messages on NiFi restart
[ https://issues.apache.org/jira/browse/NIFI-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504406#comment-15504406 ] ASF GitHub Bot commented on NIFI-2774: -- Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1022 @ckmcd PR comments addressed with few minor improvements. > ConsumeJMS processor losses messages on NiFi restart > > > Key: NIFI-2774 > URL: https://issues.apache.org/jira/browse/NIFI-2774 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0, 0.7.0 >Reporter: Christopher McDermott >Assignee: Oleg Zhurakousky >Priority: Critical > Fix For: 1.1.0, 0.8.0 > > Attachments: 2774.patch > > > ConsumeJMS processor uses auto-acknowledge mode. Unlike the deprecated > GetJMSQueue processor it does not provide a way to specify a different ACK > mode (i.e. client-acknowledge.) Using auto-acknowledge, acknowledges message > receipt from JMS *before* the messages are actually added to the flow. This > leads to data-loss on NiFi stop (or crash.) > I believe the fix for this is to allow the user to specify the ACK mode in > the processor configuration like is allowed by the GetJMSQueue processor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #1022: NIFI-2774 changed the default ACK mode to CLIENT
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1022 @ckmcd PR comments addressed with few minor improvements. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi pull request #33: Minifi 108
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79467029 --- Diff: minifi-commons/minifi-commons-schema/src/test/java/org/apache/nifi/minifi/commons/schema/serialization/SchemaLoaderTest.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.minifi.commons.schema.serialization; + +import org.apache.nifi.minifi.commons.schema.ConfigSchema; +import org.apache.nifi.minifi.commons.schema.ConnectionSchema; +import org.apache.nifi.minifi.commons.schema.ProcessorSchema; +import org.apache.nifi.minifi.commons.schema.common.BaseSchema; +import org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys; +import org.apache.nifi.minifi.commons.schema.exception.SchemaLoaderException; +import org.apache.nifi.minifi.commons.schema.v1.ConfigSchemaV1; +import org.junit.Test; + +import java.io.IOException; +import java.util.List; +import java.util.Map; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +public class SchemaLoaderTest { --- End diff -- Since making the ids optional, we don't have 2 distinct versions anymore. Leaving versioning part of SchemaLoader in place though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (NIFI-2792) Removal of a Template does not save the flow.
[ https://issues.apache.org/jira/browse/NIFI-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-2792: - Assignee: Matt Gilman > Removal of a Template does not save the flow. > - > > Key: NIFI-2792 > URL: https://issues.apache.org/jira/browse/NIFI-2792 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > When removing a template, the flow is not saved. Consequently, if no other > actions are taken prior to shutting down the template will be reloaded upon > the next restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi-minifi pull request #33: Minifi 108
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79464399 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/resources/CsvToJson.yml --- @@ -13,6 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. +MiNiFi Config Version: 2 --- End diff -- We could move them all to a test/resources folder and use it as a dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi pull request #33: Minifi 108
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79457033 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/resources/StressTestFramework.yml --- @@ -13,6 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. +MiNiFi Config Version: 2 --- End diff -- Will do, ended up using version 1 for this one though so that ids are optional as long as names are unique. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi pull request #33: Minifi 108
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/33#discussion_r79456962 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/resources/InvokeHttpMiNiFiTemplateTest.yml --- @@ -255,8 +273,8 @@ Remote Processing Groups: timeout: 30 sec --- End diff -- The input ports already have ids, which is what should matter. I think we can add some validation though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-2793) Add documentation for primary node only scheduling strategy
Arpit Gupta created NIFI-2793: - Summary: Add documentation for primary node only scheduling strategy Key: NIFI-2793 URL: https://issues.apache.org/jira/browse/NIFI-2793 Project: Apache NiFi Issue Type: Bug Components: Documentation & Website Reporter: Arpit Gupta Fix For: 1.1.0 https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#scheduling-tab does not cover the primary node only option. This option is only available when user is running in clustered mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2793) Add documentation for primary node only scheduling strategy
[ https://issues.apache.org/jira/browse/NIFI-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Gupta updated NIFI-2793: -- Priority: Minor (was: Major) > Add documentation for primary node only scheduling strategy > --- > > Key: NIFI-2793 > URL: https://issues.apache.org/jira/browse/NIFI-2793 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Reporter: Arpit Gupta >Priority: Minor > Fix For: 1.1.0 > > > https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#scheduling-tab > does not cover the primary node only option. This option is only available > when user is running in clustered mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (NIFI-2774) ConsumeJMS processor losses messages on NiFi restart
[ https://issues.apache.org/jira/browse/NIFI-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky updated NIFI-2774: --- Comment: was deleted (was: Looking further into this the use of we can't really rely on session QoS attributes since they are meaningless across sessions. This means hat un-acknowledged message on the crashing NiFi is already lost upon the restart of NiFi since at that point the interaction with JMS will be done using new Session. The only true and reliable way of handling it is thru local transaction (as was suggested in the original comment). Basically create an instance of the TX manager as part of the ConsumetJMS processor and commit/rollback transaction after FF is disposed. ) > ConsumeJMS processor losses messages on NiFi restart > > > Key: NIFI-2774 > URL: https://issues.apache.org/jira/browse/NIFI-2774 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0, 0.7.0 >Reporter: Christopher McDermott >Assignee: Oleg Zhurakousky >Priority: Critical > Fix For: 1.1.0, 0.8.0 > > Attachments: 2774.patch > > > ConsumeJMS processor uses auto-acknowledge mode. Unlike the deprecated > GetJMSQueue processor it does not provide a way to specify a different ACK > mode (i.e. client-acknowledge.) Using auto-acknowledge, acknowledges message > receipt from JMS *before* the messages are actually added to the flow. This > leads to data-loss on NiFi stop (or crash.) > I believe the fix for this is to allow the user to specify the ACK mode in > the processor configuration like is allowed by the GetJMSQueue processor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2781) Broken bower install
[ https://issues.apache.org/jira/browse/NIFI-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504078#comment-15504078 ] ASF GitHub Bot commented on NIFI-2781: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1030 [NIFI-2781] use npm to install bower …ources in nifi-web-ui and nifi-jolt-transform-json-ui You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi devBranch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1030.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1030 commit 19395789548f8b1d6088f23d7226dbee125d3503 Author: Scott AslanDate: 2016-09-19T17:16:07Z [NIFI-2781] removing bower and allowing npm to manage client side resources in nifi-web-ui and nifi-jolt-transform-json-ui > Broken bower install > > > Key: NIFI-2781 > URL: https://issues.apache.org/jira/browse/NIFI-2781 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.0.0 >Reporter: Andrew Psaltis >Assignee: Scott Aslan > > Often times when building the NiFi source, the installation of bower fails > and thus the whole build fails. > Looking at a mvn debug log, appears to show this: > [INFO] Running 'npm install bower' in > /Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/frontend-working-directory > [WARNING] npm WARN package.json mqlight@1.0.2016051011 No repository field. > [ERROR] npm http GET https://registry.npmjs.org/bower > [ERROR] npm http 200 https://registry.npmjs.org/bower > [INFO] bower@1.7.9 ../../../../../../../../../node_modules/bower > [INFO] > [INFO] --- frontend-maven-plugin:1.0:bower (bower-install) @ nifi-web-ui --- > [DEBUG] Configuring mojo com.github.eirslett:frontend-maven-plugin:1.0:bower > from plugin realm > ClassRealm[plugin>com.github.eirslett:frontend-maven-plugin:1.0, parent: > sun.misc.Launcher$AppClassLoader@55f96302] > [DEBUG] Configuring mojo > 'com.github.eirslett:frontend-maven-plugin:1.0:bower' with basic configurator > --> > [DEBUG] (f) arguments = install > --config.directory=/Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/nifi-web-ui-1.0.0-SNAPSHOT/assets > [DEBUG] (f) installDirectory = > /Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/frontend-working-directory > [DEBUG] (f) project = MavenProject: > org.apache.nifi:nifi-web-ui:1.0.0-SNAPSHOT @ > /Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml > [DEBUG] (f) repositorySystemSession = > org.eclipse.aether.DefaultRepositorySystemSession@315edc50 > [DEBUG] (f) session = org.apache.maven.execution.MavenSession@4052c8c2 > [DEBUG] (f) skip = false > [DEBUG] (f) skipTests = false > [DEBUG] (f) workingDirectory = > /Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/frontend-working-directory > [DEBUG] (f) execution = com.github.eirslett:frontend-maven-plugin:1.0:bower > {execution: bower-install} > [DEBUG] -- end configuration -- > [INFO] Running 'bower install > --config.directory=/Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/nifi-web-ui-1.0.0-SNAPSHOT/assets' > in > /Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/frontend-working-directory > [ERROR] > [ERROR] module.js:340 > [ERROR] throw err; > [ERROR] ^ > [ERROR] Error: Cannot find module > '/Users/apsaltis/development/forked-nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/frontend-working-directory/node_modules/bower/bin/bower' > [ERROR] at Function.Module._resolveFilename (module.js:338:15) > [ERROR] at Function.Module._load (module.js:280:25) > [ERROR] at Function.Module.runMain (module.js:497:10) > [ERROR] at startup (node.js:119:16) > [ERROR] at node.js:901:3 > [INFO] > > In essence bower is not installed. This is reproducible in my environment, > which looks like this: > $ printenv > TERM_PROGRAM=iTerm.app > TERM=xterm > SHELL=/bin/bash > TMPDIR=/var/folders/5l/xlzh00b10_lf16cd06dqwvs4gn/T/ >
[GitHub] nifi pull request #1030: [NIFI-2781] use npm to install bower
GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1030 [NIFI-2781] use npm to install bower â¦ources in nifi-web-ui and nifi-jolt-transform-json-ui You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi devBranch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1030.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1030 commit 19395789548f8b1d6088f23d7226dbee125d3503 Author: Scott AslanDate: 2016-09-19T17:16:07Z [NIFI-2781] removing bower and allowing npm to manage client side resources in nifi-web-ui and nifi-jolt-transform-json-ui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-2785) Template Upload - Unable to upload to descendant group
[ https://issues.apache.org/jira/browse/NIFI-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2785: -- Status: Patch Available (was: Open) > Template Upload - Unable to upload to descendant group > -- > > Key: NIFI-2785 > URL: https://issues.apache.org/jira/browse/NIFI-2785 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > Templates can be uploaded to any Process Group. This is driven by the URL > used during the upload request. Currently, the URL in the UI for the upload > request is initialized with the root group id and never updated. As a result, > through the UI templates can only be uploaded to the root group. > > As a work-around, templates could still be uploaded to descendant groups via > a request directly to the REST API. This can be done using the following > command: > {noformat}curl -X POST -v -F template=@"/path/to/template.xml" > http://{host}:{port}/nifi-api/process-groups/{process-group-id}/templates/upload{noformat} > Additionally, templates uploaded to the root group could have explicit > policies set to share with other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (NIFI-2785) Template Upload - Unable to upload to descendant group
[ https://issues.apache.org/jira/browse/NIFI-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-2785: - Assignee: Matt Gilman > Template Upload - Unable to upload to descendant group > -- > > Key: NIFI-2785 > URL: https://issues.apache.org/jira/browse/NIFI-2785 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > Templates can be uploaded to any Process Group. This is driven by the URL > used during the upload request. Currently, the URL in the UI for the upload > request is initialized with the root group id and never updated. As a result, > through the UI templates can only be uploaded to the root group. > > As a work-around, templates could still be uploaded to descendant groups via > a request directly to the REST API. This can be done using the following > command: > {noformat}curl -X POST -v -F template=@"/path/to/template.xml" > http://{host}:{port}/nifi-api/process-groups/{process-group-id}/templates/upload{noformat} > Additionally, templates uploaded to the root group could have explicit > policies set to share with other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2785) Template Upload - Unable to upload to descendant group
[ https://issues.apache.org/jira/browse/NIFI-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504066#comment-15504066 ] ASF GitHub Bot commented on NIFI-2785: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1029 Fixed issue uploading templates into descendant Process Groups NIFI-2785: - Ensure the URL is updated when uploading a template to ensure it's going to the appropriate Process Group. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-2785 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1029.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1029 commit c64a9059f8b68cd803caebd0ec61f5cfbe3c1a44 Author: Matt GilmanDate: 2016-09-19T17:23:00Z NIFI-2785: - Ensure the URL is updated when uploading a template to ensure it's going to the appropriate Process Group. > Template Upload - Unable to upload to descendant group > -- > > Key: NIFI-2785 > URL: https://issues.apache.org/jira/browse/NIFI-2785 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Priority: Critical > Fix For: 1.1.0 > > > Templates can be uploaded to any Process Group. This is driven by the URL > used during the upload request. Currently, the URL in the UI for the upload > request is initialized with the root group id and never updated. As a result, > through the UI templates can only be uploaded to the root group. > > As a work-around, templates could still be uploaded to descendant groups via > a request directly to the REST API. This can be done using the following > command: > {noformat}curl -X POST -v -F template=@"/path/to/template.xml" > http://{host}:{port}/nifi-api/process-groups/{process-group-id}/templates/upload{noformat} > Additionally, templates uploaded to the root group could have explicit > policies set to share with other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1029: Fixed issue uploading templates into descendant Pro...
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1029 Fixed issue uploading templates into descendant Process Groups NIFI-2785: - Ensure the URL is updated when uploading a template to ensure it's going to the appropriate Process Group. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-2785 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1029.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1029 commit c64a9059f8b68cd803caebd0ec61f5cfbe3c1a44 Author: Matt GilmanDate: 2016-09-19T17:23:00Z NIFI-2785: - Ensure the URL is updated when uploading a template to ensure it's going to the appropriate Process Group. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-2792) Removal of a Template does not save the flow.
Matt Gilman created NIFI-2792: - Summary: Removal of a Template does not save the flow. Key: NIFI-2792 URL: https://issues.apache.org/jira/browse/NIFI-2792 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Matt Gilman Priority: Critical Fix For: 1.1.0 When removing a template, the flow is not saved. Consequently, if no other actions are taken prior to shutting down the template will be reloaded upon the next restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-1768) Add SSL Support for Solr Processors
[ https://issues.apache.org/jira/browse/NIFI-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504051#comment-15504051 ] ASF GitHub Bot commented on NIFI-1768: -- Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1005 @bbende I'll take a look > Add SSL Support for Solr Processors > --- > > Key: NIFI-1768 > URL: https://issues.apache.org/jira/browse/NIFI-1768 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.1.0 > > > Currently the Solr processors do not support communicating with a Solr > instance that is secured with SSL. > We should be able to add the SSLContextService to the processor and pass an > SSLContext to the underlying HttpClient used by the SolrClient in the > SolrProcessor base class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #1005: NIFI-1768 Adding TLS/SSL support to Solr processors
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1005 @bbende I'll take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-2757) Site-to-Site Auth Breaks when using DN Identity Mapping Patterns
[ https://issues.apache.org/jira/browse/NIFI-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-2757: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Site-to-Site Auth Breaks when using DN Identity Mapping Patterns > > > Key: NIFI-2757 > URL: https://issues.apache.org/jira/browse/NIFI-2757 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Koji Kawamura > Fix For: 1.1.0 > > > If you setup a nifi.security.identity.mapping for DN's Site-to-Site won't be > able to authenticate against the server with identity mappings unless you > create two user accounts, one for the identity mapped one and another with > the full DN from the certificate. > Maybe look at StandardRootGroupPort.java, > final CommunicationsSession commsSession = peer.getCommunicationsSession(); > final String sourceDn = commsSession.getUserDn(); > .. > final PortAuthorizationResult authorizationResult = > checkUserAuthorization(sourceDn); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2757) Site-to-Site Auth Breaks when using DN Identity Mapping Patterns
[ https://issues.apache.org/jira/browse/NIFI-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503998#comment-15503998 ] ASF GitHub Bot commented on NIFI-2757: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1010 > Site-to-Site Auth Breaks when using DN Identity Mapping Patterns > > > Key: NIFI-2757 > URL: https://issues.apache.org/jira/browse/NIFI-2757 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Koji Kawamura > Fix For: 1.1.0 > > > If you setup a nifi.security.identity.mapping for DN's Site-to-Site won't be > able to authenticate against the server with identity mappings unless you > create two user accounts, one for the identity mapped one and another with > the full DN from the certificate. > Maybe look at StandardRootGroupPort.java, > final CommunicationsSession commsSession = peer.getCommunicationsSession(); > final String sourceDn = commsSession.getUserDn(); > .. > final PortAuthorizationResult authorizationResult = > checkUserAuthorization(sourceDn); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2757) Site-to-Site Auth Breaks when using DN Identity Mapping Patterns
[ https://issues.apache.org/jira/browse/NIFI-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503995#comment-15503995 ] ASF subversion and git services commented on NIFI-2757: --- Commit feaa4c9db82f6d29777d82df45beb43879be87cf in nifi's branch refs/heads/master from [~ijokarumawak] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=feaa4c9 ] NIFI-2757: Site-to-Site with DN mapping Added DN identity mapping pattern support to Site-to-Site client authorization. This closes #1010. Signed-off-by: Bryan Bende> Site-to-Site Auth Breaks when using DN Identity Mapping Patterns > > > Key: NIFI-2757 > URL: https://issues.apache.org/jira/browse/NIFI-2757 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Koji Kawamura > Fix For: 1.1.0 > > > If you setup a nifi.security.identity.mapping for DN's Site-to-Site won't be > able to authenticate against the server with identity mappings unless you > create two user accounts, one for the identity mapped one and another with > the full DN from the certificate. > Maybe look at StandardRootGroupPort.java, > final CommunicationsSession commsSession = peer.getCommunicationsSession(); > final String sourceDn = commsSession.getUserDn(); > .. > final PortAuthorizationResult authorizationResult = > checkUserAuthorization(sourceDn); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1010: NIFI-2757: Site-to-Site with DN mapping
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1010: NIFI-2757: Site-to-Site with DN mapping
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 +1 looks good, verified this fixes the problem when using identity mapping with RAW site-to-site, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2757) Site-to-Site Auth Breaks when using DN Identity Mapping Patterns
[ https://issues.apache.org/jira/browse/NIFI-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503992#comment-15503992 ] ASF GitHub Bot commented on NIFI-2757: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 +1 looks good, verified this fixes the problem when using identity mapping with RAW site-to-site, thanks! > Site-to-Site Auth Breaks when using DN Identity Mapping Patterns > > > Key: NIFI-2757 > URL: https://issues.apache.org/jira/browse/NIFI-2757 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Koji Kawamura > Fix For: 1.1.0 > > > If you setup a nifi.security.identity.mapping for DN's Site-to-Site won't be > able to authenticate against the server with identity mappings unless you > create two user accounts, one for the identity mapped one and another with > the full DN from the certificate. > Maybe look at StandardRootGroupPort.java, > final CommunicationsSession commsSession = peer.getCommunicationsSession(); > final String sourceDn = commsSession.getUserDn(); > .. > final PortAuthorizationResult authorizationResult = > checkUserAuthorization(sourceDn); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2757) Site-to-Site Auth Breaks when using DN Identity Mapping Patterns
[ https://issues.apache.org/jira/browse/NIFI-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503915#comment-15503915 ] ASF GitHub Bot commented on NIFI-2757: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 Reviewing... > Site-to-Site Auth Breaks when using DN Identity Mapping Patterns > > > Key: NIFI-2757 > URL: https://issues.apache.org/jira/browse/NIFI-2757 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Koji Kawamura > Fix For: 1.1.0 > > > If you setup a nifi.security.identity.mapping for DN's Site-to-Site won't be > able to authenticate against the server with identity mappings unless you > create two user accounts, one for the identity mapped one and another with > the full DN from the certificate. > Maybe look at StandardRootGroupPort.java, > final CommunicationsSession commsSession = peer.getCommunicationsSession(); > final String sourceDn = commsSession.getUserDn(); > .. > final PortAuthorizationResult authorizationResult = > checkUserAuthorization(sourceDn); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #1010: NIFI-2757: Site-to-Site with DN mapping
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-1870) Restore go to source/destination capability
[ https://issues.apache.org/jira/browse/NIFI-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503874#comment-15503874 ] ASF GitHub Bot commented on NIFI-1870: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1028 Restore upstream/downstream connections dialog NIFI-1870: - Restoring the upstream/downstream connections dialog. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-1870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1028.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1028 commit ca5cf0226cb1f386b16db4a89a6b6df1466b7af6 Author: Matt GilmanDate: 2016-09-19T16:08:23Z NIFI-1870: - Restoring the upstream/downstream connections dialog. > Restore go to source/destination capability > --- > > Key: NIFI-1870 > URL: https://issues.apache.org/jira/browse/NIFI-1870 > Project: Apache NiFi > Issue Type: Task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Minor > Fix For: 1.1.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1028: Restore upstream/downstream connections dialog
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1028 Restore upstream/downstream connections dialog NIFI-1870: - Restoring the upstream/downstream connections dialog. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-1870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1028.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1028 commit ca5cf0226cb1f386b16db4a89a6b6df1466b7af6 Author: Matt GilmanDate: 2016-09-19T16:08:23Z NIFI-1870: - Restoring the upstream/downstream connections dialog. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #12: Minifi 109
GitHub user benqiu2016 opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/12 Minifi 109 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-109 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 34cc473f478c3ffe3e5dc236ed4b233779a09139 Author: Bin QiuDate: 2016-08-20T18:11:43Z MINFI-85: Add ListenSyslog processor commit 29e6793821b49d355ff5b43ebe5080f86df746d3 Author: Bin Qiu Date: 2016-08-24T15:33:47Z add MiNiFi start/stop script commit edb827c682eb8becf05710d4f69ddf9bbfc619f5 Author: Bin Qiu Date: 2016-08-25T00:12:43Z Revert "MINIFI-68 Adding yaml-cpp source and updating LICENSE to reflect its inclusion." This reverts commit 63d2358d3a37dcd44415ae764c028f72f64355e3. commit 3c8ccb9eeafe2938cae5779ce8db316a8a0442ce Author: Bin Qiu Date: 2016-08-25T00:13:50Z Revert "Revert "MINIFI-68 Adding yaml-cpp source and updating LICENSE to reflect its inclusion."" This reverts commit edb827c682eb8becf05710d4f69ddf9bbfc619f5. commit 042fe1e0a661d5c7942b03e6809a3c1cc141f90e Author: Bin Qiu Date: 2016-08-25T00:14:39Z Revert "add MiNiFi start/stop script" This reverts commit 29e6793821b49d355ff5b43ebe5080f86df746d3. commit edeccc4031d2520f183ce7c2bfc0eacee1d04c8c Author: Bin Qiu Date: 2016-09-19T16:02:29Z MINIFI-109: Add ExecuteProcess --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination
[ https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503839#comment-15503839 ] ASF GitHub Bot commented on NIFI-2790: -- GitHub user jfrazee opened a pull request: https://github.com/apache/nifi/pull/1027 NIFI-2790 Set JMS destination name on send/receive instead of using the default destination Note: This was branched off of NIFI-2789 / #1026. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jfrazee/nifi NIFI-2790 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1027.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1027 commit d59b4338a838dff88c66ff86ea377071cf981765 Author: Joey FrazeeDate: 2016-09-19T13:18:30Z Read JMS properties and add to FlowFile attributes in ConsumeJMS commit 621fec64bd6ffbe7aefffcfd005421a6515c8ff2 Author: Joey Frazee Date: 2016-09-19T14:49:07Z Remove unused assertEquals import commit 1c76e22b06bd999496e19cd05d08db50660c1652 Author: Joey Frazee Date: 2016-09-19T15:50:59Z Move destination from default to send/receive to support EL better > Set JMS destination name on send/receive instead of using the default > destination > - > > Key: NIFI-2790 > URL: https://issues.apache.org/jira/browse/NIFI-2790 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS and PublishJMS currently pull their destination name from the > default JMS destination (setDefaultDestinationName() on the JmsTemplate). The > effect this has is that attribute expressions are evaluated with respect to > the context only and not the FlowFile, so expression language support really > only extends to EL functions and variables from the variable registry. > This doesn't have a big impact on ConsumeJMS since it doesn't take input, but > it means that destinations can be set at runtime in PublishJMS. > The JmsTemplate send() and receive() can take the destination name as an > argument though, so these method variants should be used so EL support is > fully enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi pull request #1027: NIFI-2790 Set JMS destination name on send/receive ...
GitHub user jfrazee opened a pull request: https://github.com/apache/nifi/pull/1027 NIFI-2790 Set JMS destination name on send/receive instead of using the default destination Note: This was branched off of NIFI-2789 / #1026. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jfrazee/nifi NIFI-2790 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1027.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1027 commit d59b4338a838dff88c66ff86ea377071cf981765 Author: Joey FrazeeDate: 2016-09-19T13:18:30Z Read JMS properties and add to FlowFile attributes in ConsumeJMS commit 621fec64bd6ffbe7aefffcfd005421a6515c8ff2 Author: Joey Frazee Date: 2016-09-19T14:49:07Z Remove unused assertEquals import commit 1c76e22b06bd999496e19cd05d08db50660c1652 Author: Joey Frazee Date: 2016-09-19T15:50:59Z Move destination from default to send/receive to support EL better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2774) ConsumeJMS processor losses messages on NiFi restart
[ https://issues.apache.org/jira/browse/NIFI-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503780#comment-15503780 ] Oleg Zhurakousky commented on NIFI-2774: Looking further into this the use of we can't really rely on session QoS attributes since they are meaningless across sessions. This means hat un-acknowledged message on the crashing NiFi is already lost upon the restart of NiFi since at that point the interaction with JMS will be done using new Session. The only true and reliable way of handling it is thru local transaction (as was suggested in the original comment). Basically create an instance of the TX manager as part of the ConsumetJMS processor and commit/rollback transaction after FF is disposed. > ConsumeJMS processor losses messages on NiFi restart > > > Key: NIFI-2774 > URL: https://issues.apache.org/jira/browse/NIFI-2774 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0, 0.7.0 >Reporter: Christopher McDermott >Assignee: Oleg Zhurakousky >Priority: Critical > Fix For: 1.1.0, 0.8.0 > > Attachments: 2774.patch > > > ConsumeJMS processor uses auto-acknowledge mode. Unlike the deprecated > GetJMSQueue processor it does not provide a way to specify a different ACK > mode (i.e. client-acknowledge.) Using auto-acknowledge, acknowledges message > receipt from JMS *before* the messages are actually added to the flow. This > leads to data-loss on NiFi stop (or crash.) > I believe the fix for this is to allow the user to specify the ACK mode in > the processor configuration like is allowed by the GetJMSQueue processor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination
[ https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky reassigned NIFI-2790: -- Assignee: Oleg Zhurakousky > Set JMS destination name on send/receive instead of using the default > destination > - > > Key: NIFI-2790 > URL: https://issues.apache.org/jira/browse/NIFI-2790 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS and PublishJMS currently pull their destination name from the > default JMS destination (setDefaultDestinationName() on the JmsTemplate). The > effect this has is that attribute expressions are evaluated with respect to > the context only and not the FlowFile, so expression language support really > only extends to EL functions and variables from the variable registry. > This doesn't have a big impact on ConsumeJMS since it doesn't take input, but > it means that destinations can be set at runtime in PublishJMS. > The JmsTemplate send() and receive() can take the destination name as an > argument though, so these method variants should be used so EL support is > fully enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination
[ https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky updated NIFI-2790: --- Fix Version/s: 1.1.0 > Set JMS destination name on send/receive instead of using the default > destination > - > > Key: NIFI-2790 > URL: https://issues.apache.org/jira/browse/NIFI-2790 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS and PublishJMS currently pull their destination name from the > default JMS destination (setDefaultDestinationName() on the JmsTemplate). The > effect this has is that attribute expressions are evaluated with respect to > the context only and not the FlowFile, so expression language support really > only extends to EL functions and variables from the variable registry. > This doesn't have a big impact on ConsumeJMS since it doesn't take input, but > it means that destinations can be set at runtime in PublishJMS. > The JmsTemplate send() and receive() can take the destination name as an > argument though, so these method variants should be used so EL support is > fully enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (NIFI-2789) Add JMS properties to FlowFile attributes on receive in ConsumeJMS
[ https://issues.apache.org/jira/browse/NIFI-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky reassigned NIFI-2789: -- Assignee: Oleg Zhurakousky > Add JMS properties to FlowFile attributes on receive in ConsumeJMS > -- > > Key: NIFI-2789 > URL: https://issues.apache.org/jira/browse/NIFI-2789 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS currently adds JMS headers to the FlowFile attributes when it > receives a message but ignores any JMS properties coming through. It should > be reading both the headers and properties and merging them into the FlowFile > attributes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2789) Add JMS properties to FlowFile attributes on receive in ConsumeJMS
[ https://issues.apache.org/jira/browse/NIFI-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky updated NIFI-2789: --- Fix Version/s: 1.1.0 > Add JMS properties to FlowFile attributes on receive in ConsumeJMS > -- > > Key: NIFI-2789 > URL: https://issues.apache.org/jira/browse/NIFI-2789 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Assignee: Oleg Zhurakousky >Priority: Minor > Fix For: 1.1.0 > > > ConsumeJMS currently adds JMS headers to the FlowFile attributes when it > receives a message but ignores any JMS properties coming through. It should > be reading both the headers and properties and merging them into the FlowFile > attributes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (NIFI-2791) Create a new Expression Language Function to support Java.lang.Math operations
Joseph Percivall created NIFI-2791: -- Summary: Create a new Expression Language Function to support Java.lang.Math operations Key: NIFI-2791 URL: https://issues.apache.org/jira/browse/NIFI-2791 Project: Apache NiFi Issue Type: Improvement Reporter: Joseph Percivall Assignee: Joseph Percivall Fix For: 1.1.0 Once EL is improved to support decimals (NIFI-1662) it will be desired to support higher level math functions than are currently implemented. The easiest way to do this is to provide access to the Math class[1]. This should provide all the building blocks necessary to do any desired operations on decimals. [1] https://docs.oracle.com/javase/7/docs/api/java/lang/Math.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination
Joey Frazee created NIFI-2790: - Summary: Set JMS destination name on send/receive instead of using the default destination Key: NIFI-2790 URL: https://issues.apache.org/jira/browse/NIFI-2790 Project: Apache NiFi Issue Type: Improvement Reporter: Joey Frazee Priority: Minor ConsumeJMS and PublishJMS currently pull their destination name from the default JMS destination (setDefaultDestinationName() on the JmsTemplate). The effect this has is that attribute expressions are evaluated with respect to the context only and not the FlowFile, so expression language support really only extends to EL functions and variables from the variable registry. This doesn't have a big impact on ConsumeJMS since it doesn't take input, but it means that destinations can be set at runtime in PublishJMS. The JmsTemplate send() and receive() can take the destination name as an argument though, so these method variants should be used so EL support is fully enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-1662) Improve Expression Language to Enable Working with Decimals
[ https://issues.apache.org/jira/browse/NIFI-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Percivall updated NIFI-1662: --- Description: Currently the math operations in Expression Language use Longs to evaluate numbers. This leads to any decimal places getting truncated when performing operations like divide. NiFi should support working with decimals was: Currently the math operations in Expression Language use Longs to evaluate numbers. This leads to any decimal places getting truncated when performing operations like divide. EL should be improved to enable the user to evaluate math expressions using doubles. Another desired portion of this would be to open up the static Math class [1] methods (using reflection) to further enable working with Decimals. [1] https://docs.oracle.com/javase/7/docs/api/java/lang/Math.html > Improve Expression Language to Enable Working with Decimals > --- > > Key: NIFI-1662 > URL: https://issues.apache.org/jira/browse/NIFI-1662 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Percivall > > Currently the math operations in Expression Language use Longs to evaluate > numbers. This leads to any decimal places getting truncated when performing > operations like divide. > NiFi should support working with decimals -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2789) Add JMS properties to FlowFile attributes on receive in ConsumeJMS
[ https://issues.apache.org/jira/browse/NIFI-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503473#comment-15503473 ] ASF GitHub Bot commented on NIFI-2789: -- GitHub user jfrazee opened a pull request: https://github.com/apache/nifi/pull/1026 NIFI-2789 Add JMS properties to FlowFile attributes on receive in ConsumeJMS You can merge this pull request into a Git repository by running: $ git pull https://github.com/jfrazee/nifi NIFI-2789 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1026.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1026 commit d59b4338a838dff88c66ff86ea377071cf981765 Author: Joey FrazeeDate: 2016-09-19T13:18:30Z Read JMS properties and add to FlowFile attributes in ConsumeJMS > Add JMS properties to FlowFile attributes on receive in ConsumeJMS > -- > > Key: NIFI-2789 > URL: https://issues.apache.org/jira/browse/NIFI-2789 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Priority: Minor > > ConsumeJMS currently adds JMS headers to the FlowFile attributes when it > receives a message but ignores any JMS properties coming through. It should > be reading both the headers and properties and merging them into the FlowFile > attributes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (NIFI-2789) Add JMS properties to FlowFile attributes on receive in ConsumeJMS
Joey Frazee created NIFI-2789: - Summary: Add JMS properties to FlowFile attributes on receive in ConsumeJMS Key: NIFI-2789 URL: https://issues.apache.org/jira/browse/NIFI-2789 Project: Apache NiFi Issue Type: Improvement Reporter: Joey Frazee Priority: Minor ConsumeJMS currently adds JMS headers to the FlowFile attributes when it receives a message but ignores any JMS properties coming through. It should be reading both the headers and properties and merging them into the FlowFile attributes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2788) Cluster icon in the menu doesn't have a consistent size
[ https://issues.apache.org/jira/browse/NIFI-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grande updated NIFI-2788: Attachment: (was: screenshot-1.png) > Cluster icon in the menu doesn't have a consistent size > --- > > Key: NIFI-2788 > URL: https://issues.apache.org/jira/browse/NIFI-2788 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: OSX, Chrome >Reporter: Andrew Grande >Priority: Trivial > Attachments: screenshot.png > > > The global menu cluster icon has incorrect size, the Cluster menu item is > shifted to the right as a result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2788) Cluster icon in the menu doesn't have a consistent size
[ https://issues.apache.org/jira/browse/NIFI-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grande updated NIFI-2788: Attachment: screenshot-1.png > Cluster icon in the menu doesn't have a consistent size > --- > > Key: NIFI-2788 > URL: https://issues.apache.org/jira/browse/NIFI-2788 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: OSX, Chrome >Reporter: Andrew Grande >Priority: Trivial > Attachments: screenshot.png > > > The global menu cluster icon has incorrect size, the Cluster menu item is > shifted to the right as a result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (NIFI-2788) Cluster icon in the menu doesn't have a consistent size
Andrew Grande created NIFI-2788: --- Summary: Cluster icon in the menu doesn't have a consistent size Key: NIFI-2788 URL: https://issues.apache.org/jira/browse/NIFI-2788 Project: Apache NiFi Issue Type: Bug Components: Core UI Affects Versions: 1.0.0 Environment: OSX, Chrome Reporter: Andrew Grande Priority: Trivial Attachments: screenshot.png The global menu cluster icon has incorrect size, the Cluster menu item is shifted to the right as a result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (NIFI-2788) Cluster icon in the menu doesn't have a consistent size
[ https://issues.apache.org/jira/browse/NIFI-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grande updated NIFI-2788: Attachment: screenshot.png > Cluster icon in the menu doesn't have a consistent size > --- > > Key: NIFI-2788 > URL: https://issues.apache.org/jira/browse/NIFI-2788 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: OSX, Chrome >Reporter: Andrew Grande >Priority: Trivial > Attachments: screenshot.png > > > The global menu cluster icon has incorrect size, the Cluster menu item is > shifted to the right as a result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)