[jira] [Commented] (NIFI-5372) Update Docker clustering to allow compose based scaling
[ https://issues.apache.org/jira/browse/NIFI-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533091#comment-16533091 ] ASF subversion and git services commented on NIFI-5372: --- Commit 3764b77b7ccf6e8edb5eb4ed153adaa285dd5657 in nifi's branch refs/heads/master from [~aldrin] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3764b77 ] NIFI-5372 Making adjustments to the docker-compose file to allow utilization of docker-compose up --scale. Providing a README as to how to use the docker-compose.yml NIFI-5372 Fixed a typo. This closes #2839 Signed-off-by: Mike Thomsen > Update Docker clustering to allow compose based scaling > --- > > Key: NIFI-5372 > URL: https://issues.apache.org/jira/browse/NIFI-5372 > Project: Apache NiFi > Issue Type: Task > Components: Docker >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > Fix For: 1.8.0 > > > NIFI-5195 provided clustering in Docker containers and provided a sample > config file. This currently is done via each node being defined as an > independent service. Extending the container to allow for some specification > of properties in an automated manner could allow a cluster to be established > with a single node service definition and then more fully utilize the > docker-compose commands -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5372) Update Docker clustering to allow compose based scaling
[ https://issues.apache.org/jira/browse/NIFI-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-5372: --- Resolution: Fixed Fix Version/s: 1.8.0 Status: Resolved (was: Patch Available) > Update Docker clustering to allow compose based scaling > --- > > Key: NIFI-5372 > URL: https://issues.apache.org/jira/browse/NIFI-5372 > Project: Apache NiFi > Issue Type: Task > Components: Docker >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > Fix For: 1.8.0 > > > NIFI-5195 provided clustering in Docker containers and provided a sample > config file. This currently is done via each node being defined as an > independent service. Extending the container to allow for some specification > of properties in an automated manner could allow a cluster to be established > with a single node service definition and then more fully utilize the > docker-compose commands -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5372) Update Docker clustering to allow compose based scaling
[ https://issues.apache.org/jira/browse/NIFI-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533092#comment-16533092 ] ASF subversion and git services commented on NIFI-5372: --- Commit 3764b77b7ccf6e8edb5eb4ed153adaa285dd5657 in nifi's branch refs/heads/master from [~aldrin] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3764b77 ] NIFI-5372 Making adjustments to the docker-compose file to allow utilization of docker-compose up --scale. Providing a README as to how to use the docker-compose.yml NIFI-5372 Fixed a typo. This closes #2839 Signed-off-by: Mike Thomsen > Update Docker clustering to allow compose based scaling > --- > > Key: NIFI-5372 > URL: https://issues.apache.org/jira/browse/NIFI-5372 > Project: Apache NiFi > Issue Type: Task > Components: Docker >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > Fix For: 1.8.0 > > > NIFI-5195 provided clustering in Docker containers and provided a sample > config file. This currently is done via each node being defined as an > independent service. Extending the container to allow for some specification > of properties in an automated manner could allow a cluster to be established > with a single node service definition and then more fully utilize the > docker-compose commands -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5372) Update Docker clustering to allow compose based scaling
[ https://issues.apache.org/jira/browse/NIFI-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533093#comment-16533093 ] ASF GitHub Bot commented on NIFI-5372: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2839 > Update Docker clustering to allow compose based scaling > --- > > Key: NIFI-5372 > URL: https://issues.apache.org/jira/browse/NIFI-5372 > Project: Apache NiFi > Issue Type: Task > Components: Docker >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > Fix For: 1.8.0 > > > NIFI-5195 provided clustering in Docker containers and provided a sample > config file. This currently is done via each node being defined as an > independent service. Extending the container to allow for some specification > of properties in an automated manner could allow a cluster to be established > with a single node service definition and then more fully utilize the > docker-compose commands -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2839 ---
[GitHub] nifi issue #2843: NIFI-5318 Implement NiFi test harness: initial commit of n...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2843 @peter-gergely-horvath @joewitt I can start reviewing this, but would like verification from both of you that the IP issues y'all talked about on dev are sufficiently squared away before I begin. ---
[jira] [Commented] (NIFIREG-166) Provide feature to show incoming flow changes before accepting import
[ https://issues.apache.org/jira/browse/NIFIREG-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533045#comment-16533045 ] Fredrik Skolmli commented on NIFIREG-166: - It looks like this would be solved when the work in NIFIREG-77 is completed. > Provide feature to show incoming flow changes before accepting import > - > > Key: NIFIREG-166 > URL: https://issues.apache.org/jira/browse/NIFIREG-166 > Project: NiFi Registry > Issue Type: New Feature >Affects Versions: 0.1.0 >Reporter: Andy LoPresto >Priority: Major > Labels: preview, ui, ux, version > > Similar to the way NiFi UI can show the local changes to a flow before > persisting it to the registry, a new flow version should be "previewable" in > the NiFi UI before being "accepted" and written to the canvas/flow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533012#comment-16533012
]
ASF GitHub Bot commented on NIFI-5376:
--
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2841
Some were simply suppressed with an annotation if they were in a test class
that specifically covered a deprecated class. The `NiFiLegacyCipherProvider` is
an example. Some deprecated methods were switched to their follow-on methods,
like `IOUtils.toString(Object)` to `IOUtils.toString(Object, Charset)`. The
`StringEncryptor.createEncryptor()` switch is the only one that stands out to
me as having logic changed, so that may be a good place to examine.
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
> [deprecation]
[GitHub] nifi issue #2841: NIFI-5376 Removed deprecation warnings
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2841 Some were simply suppressed with an annotation if they were in a test class that specifically covered a deprecated class. The `NiFiLegacyCipherProvider` is an example. Some deprecated methods were switched to their follow-on methods, like `IOUtils.toString(Object)` to `IOUtils.toString(Object, Charset)`. The `StringEncryptor.createEncryptor()` switch is the only one that stands out to me as having logic changed, so that may be a good place to examine. ---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533008#comment-16533008
]
ASF GitHub Bot commented on NIFI-5318:
--
GitHub user peter-gergely-horvath opened a pull request:
https://github.com/apache/nifi/pull/2843
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ x Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
At the moment, the build fails with unit test failures unrelated to this
commit:
```
[INFO] Running org.apache.nifi.csv.TestCSVValidators
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.018 s - in org.apache.nifi.csv.TestCSVValidators
[INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.033 s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[黃凱揚]> but was:<[???]>
at
org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
[INFO] Running org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Running org.apache.nifi.csv.TestCSVRecordReader
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.015 s - in org.apache.nifi.csv.TestCSVRecordReader
[INFO] Running org.apache.nifi.csv.TestWriteCSVResult
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestWriteCSVResult
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJacksonCSVRecordReader.testUTF8:81 expected:<[黃凱揚]> but
was:<[???]>
[ERROR] TestXMLReader.testAttributePrefix:133 expected:<... ATTR_ID=P3,
NAME=Am[é]lie Bonfils, AGE=74}...> but was:<... ATTR_ID=P3, NAME=Am[?]lie
Bonfils, AGE=74}...>
[ERROR] TestXMLReader.testContentField:156
expected:<...apRecord[{CONTENT=Am[é]lie Bonfils, ATTR=at...> but
was:<...apRecord[{CONTENT=Am[?]lie Bonfils, ATTR=at...>
[INFO]
[ERROR] Tests run: 221, Failures: 3, Errors: 0, Skipped: 2
[INFO]
[INFO]
```
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-gergely-horvath/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2843
commit 02e338e3b2c53c6a0af8f83f44378b4a242e0ec1
Author: Peter G. Horvath
Date: 2018-07-04T18:44:06Z
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL:
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
GitHub user peter-gergely-horvath opened a pull request:
https://github.com/apache/nifi/pull/2843
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ x Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
At the moment, the build fails with unit test failures unrelated to this
commit:
```
[INFO] Running org.apache.nifi.csv.TestCSVValidators
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.018 s - in org.apache.nifi.csv.TestCSVValidators
[INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.033 s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[é»å±æ]> but was:<[???]>
at
org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
[INFO] Running org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Running org.apache.nifi.csv.TestCSVRecordReader
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.015 s - in org.apache.nifi.csv.TestCSVRecordReader
[INFO] Running org.apache.nifi.csv.TestWriteCSVResult
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestWriteCSVResult
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJacksonCSVRecordReader.testUTF8:81 expected:<[é»å±æ]> but
was:<[???]>
[ERROR] TestXMLReader.testAttributePrefix:133 expected:<... ATTR_ID=P3,
NAME=Am[é]lie Bonfils, AGE=74}...> but was:<... ATTR_ID=P3, NAME=Am[?]lie
Bonfils, AGE=74}...>
[ERROR] TestXMLReader.testContentField:156
expected:<...apRecord[{CONTENT=Am[é]lie Bonfils, ATTR=at...> but
was:<...apRecord[{CONTENT=Am[?]lie Bonfils, ATTR=at...>
[INFO]
[ERROR] Tests run: 221, Failures: 3, Errors: 0, Skipped: 2
[INFO]
[INFO]
```
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-gergely-horvath/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2843
commit 02e338e3b2c53c6a0af8f83f44378b4a242e0ec1
Author: Peter G. Horvath
Date: 2018-07-04T18:44:06Z
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533005#comment-16533005 ] ASF GitHub Bot commented on NIFI-5318: -- Github user peter-gergely-horvath closed the pull request at: https://github.com/apache/nifi/pull/2842 > Implement NiFi test harness > --- > > Key: NIFI-5318 > URL: https://issues.apache.org/jira/browse/NIFI-5318 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Peter Horvath >Priority: Major > > Currently, it is not really possible to automatically test the behaviour of a > specific NiFi flow and make unit test type asserts if it works as expected. > For example, if the expected behaviour of a NiFi flow is that a file placed > to a specific directory will trigger some operation after which some output > file will appear at another directory, once currently can only do one thing: > test the NiFi flow manually. > Manual testing is especially hard to manage if a NiFi flow is being actively > developed: any change to a complex, existing NiFi flow might require a lot of > manual testing just to ensure there are no regressions introduced. > Some kind of Java API that allows managing a NiFi instance and manipulating > flow deployments like for example, [Codehaus > Cargo|]https://codehaus-cargo.github.io/] would be of great help. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2842: NIFI-5318 Implement NiFi test harness: initial comm...
Github user peter-gergely-horvath closed the pull request at: https://github.com/apache/nifi/pull/2842 ---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533001#comment-16533001
]
ASF GitHub Bot commented on NIFI-5318:
--
GitHub user peter-gergely-horvath opened a pull request:
https://github.com/apache/nifi/pull/2842
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
At the moment, the build fails with unit **test failures unrelated to this
commit**:
```
[INFO] Running org.apache.nifi.csv.TestCSVValidators
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.018 s - in org.apache.nifi.csv.TestCSVValidators
[INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.033 s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[黃凱揚]> but was:<[???]>
at
org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
[INFO] Running org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Running org.apache.nifi.csv.TestCSVRecordReader
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.015 s - in org.apache.nifi.csv.TestCSVRecordReader
[INFO] Running org.apache.nifi.csv.TestWriteCSVResult
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestWriteCSVResult
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJacksonCSVRecordReader.testUTF8:81 expected:<[黃凱揚]> but
was:<[???]>
[ERROR] TestXMLReader.testAttributePrefix:133 expected:<... ATTR_ID=P3,
NAME=Am[é]lie Bonfils, AGE=74}...> but was:<... ATTR_ID=P3, NAME=Am[?]lie
Bonfils, AGE=74}...>
[ERROR] TestXMLReader.testContentField:156
expected:<...apRecord[{CONTENT=Am[é]lie Bonfils, ATTR=at...> but
was:<...apRecord[{CONTENT=Am[?]lie Bonfils, ATTR=at...>
[INFO]
[ERROR] Tests run: 221, Failures: 3, Errors: 0, Skipped: 2
[INFO]
[INFO]
```
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-gergely-horvath/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2842
commit 7af1eebc61d764790fb108db0bed8eb63f050b96
Author: Peter G. Horvath
Date: 2018-07-04T16:33:24Z
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL:
[GitHub] nifi pull request #2842: NIFI-5318 Implement NiFi test harness: initial comm...
GitHub user peter-gergely-horvath opened a pull request:
https://github.com/apache/nifi/pull/2842
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
At the moment, the build fails with unit **test failures unrelated to this
commit**:
```
[INFO] Running org.apache.nifi.csv.TestCSVValidators
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.018 s - in org.apache.nifi.csv.TestCSVValidators
[INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.033 s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[é»å±æ]> but was:<[???]>
at
org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
[INFO] Running org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Running org.apache.nifi.csv.TestCSVRecordReader
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.015 s - in org.apache.nifi.csv.TestCSVRecordReader
[INFO] Running org.apache.nifi.csv.TestWriteCSVResult
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.004 s - in org.apache.nifi.csv.TestWriteCSVResult
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJacksonCSVRecordReader.testUTF8:81 expected:<[é»å±æ]> but
was:<[???]>
[ERROR] TestXMLReader.testAttributePrefix:133 expected:<... ATTR_ID=P3,
NAME=Am[é]lie Bonfils, AGE=74}...> but was:<... ATTR_ID=P3, NAME=Am[?]lie
Bonfils, AGE=74}...>
[ERROR] TestXMLReader.testContentField:156
expected:<...apRecord[{CONTENT=Am[é]lie Bonfils, ATTR=at...> but
was:<...apRecord[{CONTENT=Am[?]lie Bonfils, ATTR=at...>
[INFO]
[ERROR] Tests run: 221, Failures: 3, Errors: 0, Skipped: 2
[INFO]
[INFO]
```
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-gergely-horvath/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2842
commit 7af1eebc61d764790fb108db0bed8eb63f050b96
Author: Peter G. Horvath
Date: 2018-07-04T16:33:24Z
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
---
[jira] [Commented] (NIFI-5310) Not able to read record as string type ending with \ (backslash)
[
https://issues.apache.org/jira/browse/NIFI-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532916#comment-16532916
]
Otto Fowler commented on NIFI-5310:
---
[~nishant.gupta] this is marked as critical, have you been able to review my
comments? Can we resolve this issue?
> Not able to read record as string type ending with \ (backslash)
>
>
> Key: NIFI-5310
> URL: https://issues.apache.org/jira/browse/NIFI-5310
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.6.0
> Environment: Windows/Linux Both
>Reporter: Nishant Gupta
>Assignee: Otto Fowler
>Priority: Critical
> Labels: BackSlash, CSV, Nifi, QueryRecord,
> Attachments: IssueWithBackSlash.PNG
>
>
> *Processor* - QueryRecord
> *RecordReader* - CSVReader
> *RecordWriter* - CSVRecordSetWriter
> *Data* Type- String
> {
> "name": "Name",
> "type": ["string","null"]
> }
> *Data - John\ (Failing), John\M(passing)*
> *Query* - select Name, ID from FLOWFILE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5337) Add Syslog 5424 Record Reader and create nifi-syslog-utils
[ https://issues.apache.org/jira/browse/NIFI-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler updated NIFI-5337: -- Status: In Progress (was: Patch Available) > Add Syslog 5424 Record Reader and create nifi-syslog-utils > -- > > Key: NIFI-5337 > URL: https://issues.apache.org/jira/browse/NIFI-5337 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Otto Fowler >Assignee: Otto Fowler >Priority: Major > > Create Record Reader for Syslog 5424 messages ( including structured data ) > built on the ParseSyslog5424 processor infrastructure. > > Create nifi-syslog-utils to centralize syslog support to be shared better the > standard processors and the serialization library > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532846#comment-16532846
]
ASF GitHub Bot commented on NIFI-5376:
--
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2841
build with contrib check is fine as well
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
>
[GitHub] nifi issue #2841: NIFI-5376 Removed deprecation warnings
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2841 build with contrib check is fine as well ---
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532829#comment-16532829
]
ASF GitHub Bot commented on NIFI-5376:
--
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2841
Before :
``` bash
grep -o 'deprecation' ../build.log | wc -l
795
```
After:
```bash
grep -o 'deprecation' build.log | wc -l
260
```
There seems to be a mix of deprecation fixes and formatting changes, are
there any specific changes that warrant attention that you can point out?
Is there some other way to measure or test this that you would recommend?
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
> [deprecation] ByteArrayOutputStream in
[GitHub] nifi issue #2841: NIFI-5376 Removed deprecation warnings
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2841 Before : ``` bash grep -o 'deprecation' ../build.log | wc -l 795 ``` After: ```bash grep -o 'deprecation' build.log | wc -l 260 ``` There seems to be a mix of deprecation fixes and formatting changes, are there any specific changes that warrant attention that you can point out? Is there some other way to measure or test this that you would recommend? ---
[jira] [Resolved] (NIFI-5369) ReplaceText not replacing all references to capture groups
[
https://issues.apache.org/jira/browse/NIFI-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otto Fowler resolved NIFI-5369.
---
Resolution: Information Provided
> ReplaceText not replacing all references to capture groups
> --
>
> Key: NIFI-5369
> URL: https://issues.apache.org/jira/browse/NIFI-5369
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.7.0
>Reporter: Sebastian Schlitte
>Assignee: Otto Fowler
>Priority: Minor
>
> ||Property||Value||
> |Search
> Value|(^.*\"type\"\:\"([0-9A-Za-z\-]*).*})\,\"timestamp\"\:[\s]*([0-9]*).*\"~event_uuid\"\:[\s]*\"([0-9A-Za-z\-\.]*).*$|
> |Replacement
> Value|{"index":\{"_index":"${'$2'}-${'$3':format('.MM.dd')}","_type":"${'$2'}","_id":"${'$4'}"}}
> $1|
> |Character Set|UTF-8|
> |Maximum Buffer Size|10MB|
> |Replacement Strategy|Regex Replacement|
> |Evaluation Mode|Line-by-Line|
> *Input data:*
> {"type":"Windows","id":12345},"timestamp":1530539722000,"~event_uuid":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"
> *result in 1.5.0:*
> {"index":{"_index":"windows-2017.07.02","_type":"windows","_id":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"}}
> {"type":"Windows","id":12345}
>
> *result in 1.7.0:*
> {"index":{"_index":"windows-","_type":"","_id":""}}
> {"type":"Windows","id":12345}
>
> In 1.7.0, replacement is not working as expected. Only one reference to
> capture group 2 is repalce with the correct content. The other reference to
> the same Group and the references to other groups are replaced with empty
> strings. The replacement with group 1 in line 2, which does not use
> expression language, is working ok.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5372) Update Docker clustering to allow compose based scaling
[ https://issues.apache.org/jira/browse/NIFI-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532636#comment-16532636 ] ASF GitHub Bot commented on NIFI-5372: -- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2839#discussion_r200042921 --- Diff: nifi-docker/docker-compose/README.md --- @@ -0,0 +1,56 @@ + + +# Apache NiFi Docker Compose + +# Usage + +## Overview +The colocated docker-compose.yml is a [Docker Compose](https://docs.docker.com/compose/overview/) definition providing an easy way to start up an Apache NiFi Cluster. + +## NiFi version configuration +There are two primary ways in which the cluster can be configured: + + 1. By default, the Compose file (docker-compose.yml) is configured to make use of the latest image that would be created by a NiFi Maven build with the Docker profile activated through an invocation similar to `mvn clean install -Pdocker`. + 2. Optionally, a user can update the docker-compose.yml file to use a released convenience image provided in the [Apache NiFi Docker Hub repository](https://hub.docker.com/r/apache/nifi/tags/). This is accomplished by chainging the `image` property of the `nifi` service definition to be an available Docker Hub tag such as `apache/nifi:1.7.0`. **NOTE** Changes to the image can affect the expected conventions of the docker-compose.yml configuration. All released images 1.7.0 or later should work with the file as provided. If there are any issues, please file a [JIRA](https://issues.apache.org/jira/browse/NIFI). --- End diff -- typo ``changing`` > Update Docker clustering to allow compose based scaling > --- > > Key: NIFI-5372 > URL: https://issues.apache.org/jira/browse/NIFI-5372 > Project: Apache NiFi > Issue Type: Task > Components: Docker >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > > NIFI-5195 provided clustering in Docker containers and provided a sample > config file. This currently is done via each node being defined as an > independent service. Extending the container to allow for some specification > of properties in an automated manner could allow a cluster to be established > with a single node service definition and then more fully utilize the > docker-compose commands -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2839#discussion_r200042921 --- Diff: nifi-docker/docker-compose/README.md --- @@ -0,0 +1,56 @@ + + +# Apache NiFi Docker Compose + +# Usage + +## Overview +The colocated docker-compose.yml is a [Docker Compose](https://docs.docker.com/compose/overview/) definition providing an easy way to start up an Apache NiFi Cluster. + +## NiFi version configuration +There are two primary ways in which the cluster can be configured: + + 1. By default, the Compose file (docker-compose.yml) is configured to make use of the latest image that would be created by a NiFi Maven build with the Docker profile activated through an invocation similar to `mvn clean install -Pdocker`. + 2. Optionally, a user can update the docker-compose.yml file to use a released convenience image provided in the [Apache NiFi Docker Hub repository](https://hub.docker.com/r/apache/nifi/tags/). This is accomplished by chainging the `image` property of the `nifi` service definition to be an available Docker Hub tag such as `apache/nifi:1.7.0`. **NOTE** Changes to the image can affect the expected conventions of the docker-compose.yml configuration. All released images 1.7.0 or later should work with the file as provided. If there are any issues, please file a [JIRA](https://issues.apache.org/jira/browse/NIFI). --- End diff -- typo ``changing`` ---
[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2841 NIFI-5376 Removed deprecation warnings Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-5376 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2841.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2841 commit bdee6889ee7ed9212cf5d25c7c1c356184f18e60 Author: Andy LoPresto Date: 2018-07-04T07:30:32Z NIFI-5376 Removed deprecation warnings. ---
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532389#comment-16532389
]
ASF GitHub Bot commented on NIFI-5376:
--
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/2841
NIFI-5376 Removed deprecation warnings
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-5376
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2841
commit bdee6889ee7ed9212cf5d25c7c1c356184f18e60
Author: Andy LoPresto
Date: 2018-07-04T07:30:32Z
NIFI-5376 Removed deprecation warnings.
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation]
[jira] [Updated] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-5376:
Status: Patch Available (was: In Progress)
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,22]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
>
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532383#comment-16532383
]
Andy LoPresto commented on NIFI-5376:
-
There were quite a few other deprecation warnings I was able to remove. I've
included a list of the outstanding warnings that require either:
1. more in-depth analysis
1. updates to dependencies/libraries
1. analysis of legacy components
{code}
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[27,31]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[61,38]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFilePackagerV1.java:[62,40]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[21,31]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[22,46]
[deprecation] CharSequenceTranslator in
org.apache.commons.lang3.text.translate has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[30,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[34,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[38,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[42,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[46,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[50,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[54,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[58,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[62,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[66,58]
[deprecation] StringEscapeUtils in org.apache.commons.lang3 has been deprecated
[WARNING]
/Users/alopresto/Workspace/nifi/nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/CharSequenceTranslatorEvaluator.java:[70,18]
[deprecation] CharSequenceTranslator in
org.apache.commons.lang3.text.translate has been deprecated
[WARNING]
[jira] [Updated] (NIFI-5369) ReplaceText not replacing all references to capture groups
[
https://issues.apache.org/jira/browse/NIFI-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Schlitte updated NIFI-5369:
-
Priority: Minor (was: Major)
> ReplaceText not replacing all references to capture groups
> --
>
> Key: NIFI-5369
> URL: https://issues.apache.org/jira/browse/NIFI-5369
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.7.0
>Reporter: Sebastian Schlitte
>Assignee: Otto Fowler
>Priority: Minor
>
> ||Property||Value||
> |Search
> Value|(^.*\"type\"\:\"([0-9A-Za-z\-]*).*})\,\"timestamp\"\:[\s]*([0-9]*).*\"~event_uuid\"\:[\s]*\"([0-9A-Za-z\-\.]*).*$|
> |Replacement
> Value|{"index":\{"_index":"${'$2'}-${'$3':format('.MM.dd')}","_type":"${'$2'}","_id":"${'$4'}"}}
> $1|
> |Character Set|UTF-8|
> |Maximum Buffer Size|10MB|
> |Replacement Strategy|Regex Replacement|
> |Evaluation Mode|Line-by-Line|
> *Input data:*
> {"type":"Windows","id":12345},"timestamp":1530539722000,"~event_uuid":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"
> *result in 1.5.0:*
> {"index":{"_index":"windows-2017.07.02","_type":"windows","_id":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"}}
> {"type":"Windows","id":12345}
>
> *result in 1.7.0:*
> {"index":{"_index":"windows-","_type":"","_id":""}}
> {"type":"Windows","id":12345}
>
> In 1.7.0, replacement is not working as expected. Only one reference to
> capture group 2 is repalce with the correct content. The other reference to
> the same Group and the references to other groups are replaced with empty
> strings. The replacement with group 1 in line 2, which does not use
> expression language, is working ok.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5369) ReplaceText not replacing all references to capture groups
[
https://issues.apache.org/jira/browse/NIFI-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532300#comment-16532300
]
Sebastian Schlitte commented on NIFI-5369:
--
Hi Otto,
thank you very much for looking into this. The regex you state in your last
post is exactly what we want to match. If it was not displayed like that, it
must have been the formatting.
I can confirm that what you suggested as "Replace Value" works fine!
Apparently, my original statement uses expression language where it is not
required. We will now use that simplified version.
> ReplaceText not replacing all references to capture groups
> --
>
> Key: NIFI-5369
> URL: https://issues.apache.org/jira/browse/NIFI-5369
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.7.0
>Reporter: Sebastian Schlitte
>Assignee: Otto Fowler
>Priority: Major
>
> ||Property||Value||
> |Search
> Value|(^.*\"type\"\:\"([0-9A-Za-z\-]*).*})\,\"timestamp\"\:[\s]*([0-9]*).*\"~event_uuid\"\:[\s]*\"([0-9A-Za-z\-\.]*).*$|
> |Replacement
> Value|{"index":\{"_index":"${'$2'}-${'$3':format('.MM.dd')}","_type":"${'$2'}","_id":"${'$4'}"}}
> $1|
> |Character Set|UTF-8|
> |Maximum Buffer Size|10MB|
> |Replacement Strategy|Regex Replacement|
> |Evaluation Mode|Line-by-Line|
> *Input data:*
> {"type":"Windows","id":12345},"timestamp":1530539722000,"~event_uuid":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"
> *result in 1.5.0:*
> {"index":{"_index":"windows-2017.07.02","_type":"windows","_id":"8b4cfd28-5ac6-4ea9-86fc-2c682b76bbc3"}}
> {"type":"Windows","id":12345}
>
> *result in 1.7.0:*
> {"index":{"_index":"windows-","_type":"","_id":""}}
> {"type":"Windows","id":12345}
>
> In 1.7.0, replacement is not working as expected. Only one reference to
> capture group 2 is repalce with the correct content. The other reference to
> the same Group and the references to other groups are replaced with empty
> strings. The replacement with group 1 in line 2, which does not use
> expression language, is working ok.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
