[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-09-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608209#comment-16608209 ] ASF GitHub Bot commented on NIFI-5318: -- Github user MikeThomsen commented on the issue:

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-09-08 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2872 @peter-gergely-horvath the consensus seems to be just keep pushing new commits and let us do a squashed commit for you because that helps GitHub maintain the context of feedback in a review.

[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-09-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608193#comment-16608193 ] ASF GitHub Bot commented on NIFI-5318: -- Github user peter-gergely-horvath commented on the issue:

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-09-08 Thread peter-gergely-horvath
Github user peter-gergely-horvath commented on the issue: https://github.com/apache/nifi/pull/2872 @MikeThomsen The pull request contains the latest changes; after @lfrancke had made his comments, I corrected the issues mentioned, nuked my whole fork and force-pushed my new version.