[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697873#comment-16697873
 ] 

ASF GitHub Bot commented on NIFI-5318:
--

Github user peter-gergely-horvath commented on the issue:

https://github.com/apache/nifi/pull/3165
  
Hi Guys, thank you for pointing this out. I've replaced it with some 
synthetic content.


> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a 
> specific NiFi flow and make unit test type asserts if it works as expected. 
> For example, if the expected behaviour of a NiFi flow is that a file placed 
> to a specific directory will trigger some operation after which some output 
> file will appear at another directory, once currently can only do one thing: 
> test the NiFi flow manually. 
> Manual testing is especially hard to manage if a NiFi flow is being actively 
> developed: any change to a complex, existing NiFi flow might require a lot of 
> manual testing just to ensure there are no regressions introduced. 
> Some kind of Java API that allows managing a NiFi instance and manipulating 
> flow deployments like for example, [Codehaus 
> Cargo|]https://codehaus-cargo.github.io/] would be of great help. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread peter-gergely-horvath
Github user peter-gergely-horvath commented on the issue:

https://github.com/apache/nifi/pull/3165
  
Hi Guys, thank you for pointing this out. I've replaced it with some 
synthetic content.


---


[jira] [Commented] (NIFI-5646) Alpine-based Docker image

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697863#comment-16697863
 ] 

ASF GitHub Bot commented on NIFI-5646:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/3038
  
@MikeThomsen We (certain folks on the PMC) have some good flexibility with 
performing releases to Docker Hub.  I think the Alpine addition is certainly 
fine and the tagging makes sense.  Likely don't need the full breadth of 
offerings that JDK has (https://hub.docker.com/r/library/openjdk/tags/) but 
establishing a similar taxonomy would be my preference.  That, in conjunction 
with helper scripts, would allow us to a bit more seamlessly automate this 
process for those that have push access to the repositories.


> Alpine-based Docker image
> -
>
> Key: NIFI-5646
> URL: https://issues.apache.org/jira/browse/NIFI-5646
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.7.1
>Reporter: Jon Davies
>Priority: Minor
>
> Provide an Alpine Linux based Docker image



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #3038: [NIFI-5646] Dockerfile.alpine: Added.

2018-11-24 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/3038
  
@MikeThomsen We (certain folks on the PMC) have some good flexibility with 
performing releases to Docker Hub.  I think the Alpine addition is certainly 
fine and the tagging makes sense.  Likely don't need the full breadth of 
offerings that JDK has (https://hub.docker.com/r/library/openjdk/tags/) but 
establishing a similar taxonomy would be my preference.  That, in conjunction 
with helper scripts, would allow us to a bit more seamlessly automate this 
process for those that have push access to the repositories.


---


[GitHub] nifi pull request #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3165#discussion_r236045789
  
--- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml ---
@@ -0,0 +1,28 @@
+
+
--- End diff --

Yes, it absolutely must be changed because the BBC is asserting its IP 
rights here:

```

```


---


[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697858#comment-16697858
 ] 

ASF GitHub Bot commented on NIFI-5318:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3165#discussion_r236045789
  
--- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml ---
@@ -0,0 +1,28 @@
+
+
--- End diff --

Yes, it absolutely must be changed because the BBC is asserting its IP 
rights here:

```

```


> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a 
> specific NiFi flow and make unit test type asserts if it works as expected. 
> For example, if the expected behaviour of a NiFi flow is that a file placed 
> to a specific directory will trigger some operation after which some output 
> file will appear at another directory, once currently can only do one thing: 
> test the NiFi flow manually. 
> Manual testing is especially hard to manage if a NiFi flow is being actively 
> developed: any change to a complex, existing NiFi flow might require a lot of 
> manual testing just to ensure there are no regressions introduced. 
> Some kind of Java API that allows managing a NiFi instance and manipulating 
> flow deployments like for example, [Codehaus 
> Cargo|]https://codehaus-cargo.github.io/] would be of great help. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread joewitt
Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3165#discussion_r236045703
  
--- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml ---
@@ -0,0 +1,28 @@
+
+
--- End diff --

this xml document looks like a real http response.  We cannot use it as 
test material unless we can assert its license and it is ALv2 compatible.  Its 
better to use entirely synthetic test data.


---


[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697856#comment-16697856
 ] 

ASF GitHub Bot commented on NIFI-5318:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3165#discussion_r236045703
  
--- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml ---
@@ -0,0 +1,28 @@
+
+
--- End diff --

this xml document looks like a real http response.  We cannot use it as 
test material unless we can assert its license and it is ALv2 compatible.  Its 
better to use entirely synthetic test data.


> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a 
> specific NiFi flow and make unit test type asserts if it works as expected. 
> For example, if the expected behaviour of a NiFi flow is that a file placed 
> to a specific directory will trigger some operation after which some output 
> file will appear at another directory, once currently can only do one thing: 
> test the NiFi flow manually. 
> Manual testing is especially hard to manage if a NiFi flow is being actively 
> developed: any change to a complex, existing NiFi flow might require a lot of 
> manual testing just to ensure there are no regressions introduced. 
> Some kind of Java API that allows managing a NiFi instance and manipulating 
> flow deployments like for example, [Codehaus 
> Cargo|]https://codehaus-cargo.github.io/] would be of great help. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3165
  
Will try to get back into it soon. BTW, thanks for putting it all back onto 
a branch.


---


[jira] [Commented] (NIFI-5318) Implement NiFi test harness

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697854#comment-16697854
 ] 

ASF GitHub Bot commented on NIFI-5318:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3165
  
Will try to get back into it soon. BTW, thanks for putting it all back onto 
a branch.


> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a 
> specific NiFi flow and make unit test type asserts if it works as expected. 
> For example, if the expected behaviour of a NiFi flow is that a file placed 
> to a specific directory will trigger some operation after which some output 
> file will appear at another directory, once currently can only do one thing: 
> test the NiFi flow manually. 
> Manual testing is especially hard to manage if a NiFi flow is being actively 
> developed: any change to a complex, existing NiFi flow might require a lot of 
> manual testing just to ensure there are no regressions introduced. 
> Some kind of Java API that allows managing a NiFi instance and manipulating 
> flow deployments like for example, [Codehaus 
> Cargo|]https://codehaus-cargo.github.io/] would be of great help. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #3038: [NIFI-5646] Dockerfile.alpine: Added.

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3038
  
@apiri What do you think?

> An alternative would be to put the Dockerfiles into subdirectories if the 
above is a limitation in the plugin.

I think an alpine build would be a nice thing to have.


---


[jira] [Commented] (NIFI-5646) Alpine-based Docker image

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697853#comment-16697853
 ] 

ASF GitHub Bot commented on NIFI-5646:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3038
  
@apiri What do you think?

> An alternative would be to put the Dockerfiles into subdirectories if the 
above is a limitation in the plugin.

I think an alpine build would be a nice thing to have.


> Alpine-based Docker image
> -
>
> Key: NIFI-5646
> URL: https://issues.apache.org/jira/browse/NIFI-5646
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.7.1
>Reporter: Jon Davies
>Priority: Minor
>
> Provide an Alpine Linux based Docker image



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697791#comment-16697791
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041568
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for `de.svenkubiak:jBCrypt`


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697798#comment-16697798
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3105
  
You also need to verify the LICENSE as well.


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041500
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing logback dependency reference


---


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697790#comment-16697790
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041495
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
+Copyright 2016 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+**
+Apache Software License v2
+**
+
+The following binary components are provided under the Apache Software 
License v2
+
+  (ASLv2) DataStax Java Driver for Apache Cassandra - Core
+  The following NOTICE information applies:
+DataStax Java Driver for Apache Cassandra - Core
+Copyright (C) 2012-2017 DataStax Inc.
+
+  (ASLv2) Apache Avro
--- End diff --

It can be removed.


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041495
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
+Copyright 2016 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+**
+Apache Software License v2
+**
+
+The following binary components are provided under the Apache Software 
License v2
+
+  (ASLv2) DataStax Java Driver for Apache Cassandra - Core
+  The following NOTICE information applies:
+DataStax Java Driver for Apache Cassandra - Core
+Copyright (C) 2012-2017 DataStax Inc.
+
+  (ASLv2) Apache Avro
--- End diff --

It can be removed.


---


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041589
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notices for this entire branch:

```
[INFO] | |  +- org.antlr:antlr-runtime:jar:3.5.2:compile
[INFO] | |  +- com.jayway.jsonpath:json-path:jar:2.4.0:compile
[INFO] | |  |  \- net.minidev:json-smart:jar:2.3:compile
[INFO] | |  | \- net.minidev:accessors-smart:jar:1.2:compile
```


---


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697792#comment-16697792
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041500
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing logback dependency reference


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697797#comment-16697797
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041602
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
+Copyright 2016 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+**
+Apache Software License v2
+**
+
+The following binary components are provided under the Apache Software 
License v2
+
+  (ASLv2) DataStax Java Driver for Apache Cassandra - Core
+  The following NOTICE information applies:
+DataStax Java Driver for Apache Cassandra - Core
+Copyright (C) 2012-2017 DataStax Inc.
+
+  (ASLv2) Apache Avro
+  The following NOTICE information applies:
+Apache Avro
+Copyright 2009-2017 The Apache Software Foundation
+
+  (ASLv2) Jackson JSON processor
--- End diff --

It is referenced in `mvn dependency:tree` on your services NAR.


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697793#comment-16697793
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041589
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notices for this entire branch:

```
[INFO] | |  +- org.antlr:antlr-runtime:jar:3.5.2:compile
[INFO] | |  +- com.jayway.jsonpath:json-path:jar:2.4.0:compile
[INFO] | |  |  \- net.minidev:json-smart:jar:2.3:compile
[INFO] | |  | \- net.minidev:accessors-smart:jar:1.2:compile
```


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041556
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for Netty


---


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041536
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for groupId `org.ow2.asm`


---


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697796#comment-16697796
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041517
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for `io.dropwizard.metrics:metrics-core:jar:3.2.2:compile`


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697795#comment-16697795
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041556
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for Netty


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041568
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for `de.svenkubiak:jBCrypt`


---


[jira] [Commented] (NIFI-5621) Create a Connection Pooling service implementation to be used in Cassandra processors

2018-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697794#comment-16697794
 ] 

ASF GitHub Bot commented on NIFI-5621:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041536
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for groupId `org.ow2.asm`


> Create a Connection Pooling service implementation to be used in Cassandra 
> processors
> -
>
> Key: NIFI-5621
> URL: https://issues.apache.org/jira/browse/NIFI-5621
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> Like how the Relational Database processors leverage 'DBCPConnectionPool' 
> controller service, there should be one that could be used by the processors 
> from Cassandra bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041602
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
+Copyright 2016 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+**
+Apache Software License v2
+**
+
+The following binary components are provided under the Apache Software 
License v2
+
+  (ASLv2) DataStax Java Driver for Apache Cassandra - Core
+  The following NOTICE information applies:
+DataStax Java Driver for Apache Cassandra - Core
+Copyright (C) 2012-2017 DataStax Inc.
+
+  (ASLv2) Apache Avro
+  The following NOTICE information applies:
+Apache Avro
+Copyright 2009-2017 The Apache Software Foundation
+
+  (ASLv2) Jackson JSON processor
--- End diff --

It is referenced in `mvn dependency:tree` on your services NAR.


---


[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/3105
  
You also need to verify the LICENSE as well.


---


[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3105#discussion_r236041517
  
--- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE
 ---
@@ -0,0 +1,327 @@
+nifi-cassandra-services-nar
--- End diff --

Missing notice for `io.dropwizard.metrics:metrics-core:jar:3.2.2:compile`


---