[GitHub] [nifi] patricker commented on pull request #2231: NIFI-4521 MS SQL CDC Processor

2020-08-26 Thread GitBox


patricker commented on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-681301223


   @readl1 I can add those, sure.  How about `INFO` level for the timestamps, 
and `DEBUG` level for SQL Statements?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] jfrazee commented on pull request #4482: NIFI-7745: Add SampleRecord processor

2020-08-26 Thread GitBox


jfrazee commented on pull request #4482:
URL: https://github.com/apache/nifi/pull/4482#issuecomment-681178575


   @mattyb149 I went through this pretty closely and I think it looks good. The 
Probabilistic and Reservoir sampling produces the right distributions over 100k 
files. Two things I wanted to verify: (1) since the reservoir sampling is 
in-memory (for good reasons), setting it too high will be problematic? and (2) 
you've opted to not do these as controller services because that's potentially 
more complicated than most users would need/want?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #877: MINIFICPP-1339 - Reopen rocksdb database when space becomes available on the disk

2020-08-26 Thread GitBox


arpadboda closed pull request #877:
URL: https://github.com/apache/nifi-minifi-cpp/pull/877


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (NIFI-7767) SAN not being added to certificates using tls-toolkit

2020-08-26 Thread Joey Frazee (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185504#comment-17185504
 ] 

Joey Frazee commented on NIFI-7767:
---

[~thenatog] There was a slack comment that it might be related to the 
bouncycastle version. I did a build on main with it downgraded to 1.61 and it 
works as expected.

> SAN not being added to certificates using tls-toolkit 
> --
>
> Key: NIFI-7767
> URL: https://issues.apache.org/jira/browse/NIFI-7767
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Security
>Affects Versions: 1.12.0
>Reporter: Nathan Gough
>Assignee: Nathan Gough
>Priority: Major
>  Labels: tls-toolkit
>
> There appears to be an issue with certificates generated using the 
> tls-toolkit. A few people have reported that the tls-toolkit server/client 
> mode does not include the SAN in the generated certificates. This results in 
> TLS errors when using these certificates in NiFi.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Moved] (MINIFICPP-1341) no matching conversion for static_cast from 'const org::apache::nifi::minifi::core::PropertyValue' to 'std::__1::chrono::duration >'

2020-08-26 Thread Aldrin Piri (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldrin Piri moved MINIFI-535 to MINIFICPP-1341:
---

  Component/s: (was: Build)
  Key: MINIFICPP-1341  (was: MINIFI-535)
Affects Version/s: (was: 1.0.0)
   1.0.0
  Project: Apache NiFi MiNiFi C++  (was: Apache NiFi MiNiFi)

> no matching conversion for static_cast from 'const 
> org::apache::nifi::minifi::core::PropertyValue' to 
> 'std::__1::chrono::duration >'
> 
>
> Key: MINIFICPP-1341
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1341
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: 1.0.0
> Environment: $ cmake --version
> cmake version 3.16.3
> $ clang --version
> clang version 10.0.0-4ubuntu1 
> Target: x86_64-pc-linux-gnu
> Thread model: posix
>Reporter: Ivan Serdyuk
>Priority: Critical
>  Labels: clang
> Attachments: TailFile_build_error.log
>
>
> I was compiling MiNiFi using Clang 10.0.0-4ubuntu1 release.
> I did like this:
> $ cmake -DENABLE_COAP=ON -DASAN_BUILD=ON -DSKIP_TESTS=ON -DUSE_SHARED_LIBS=ON 
> -DPORTABLE=ON -DBUILD_ROCKSDB=ON -DBUILD_IDENTIFIER= 
> -DCMAKE_BUILD_TYPE=MinSizeRel -DFAIL_ON_WARNINGS= -DCMAKE_C_COMPILER=clang 
> -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-stdlib=libc++" ..
> And (eventually) got this:
> [ 47%] Building CXX object 
> extensions/standard-processors/CMakeFiles/minifi-standard-processors.dir/processors/TailFile.cpp.o
> In file included from 
> /home/ubuntu/minifi_cpp/extensions/standard-processors/processors/TailFile.cpp:40:
> In file included from 
> /home/ubuntu/minifi_cpp/extensions/standard-processors/processors/TailFile.h:30:
> In file included from 
> /home/ubuntu/minifi_cpp/extensions/standard-processors/../../libminifi/include/core/Processor.h:39:
> /home/ubuntu/minifi_cpp/extensions/standard-processors/../../libminifi/include/core/ConfigurableComponent.h:230:13:
>  error: no matching conversion for static_cast from 'const 
> org::apache::nifi::minifi::core::PropertyValue' to 
> 'std::__1::chrono::duration >'
>  value = static_cast(item.getValue());
>  ^~~
> /home/ubuntu/minifi_cpp/extensions/standard-processors/../../libminifi/include/core/ProcessorNode.h:71:30:
>  note: in instantiation of function template specialization 
> 'org::apache::nifi::minifi::core::ConfigurableComponent::getProperty  long, std::__1::ratio<1, 1000> > >' requested here
>  return processor_cast->getProperty(name, value);
>  ^
> /home/ubuntu/minifi_cpp/extensions/standard-processors/../../libminifi/include/core/ProcessContext.h:329:29:
>  note: in instantiation of function template specialization 
> 'org::apache::nifi::minifi::core::ProcessorNode::getProperty  long, std::__1::ratio<1, 1000> > >' requested here
>  return processor_node_->getProperty std::common_type::type>(name, value);
>  ^
> /home/ubuntu/minifi_cpp/extensions/standard-processors/../../libminifi/include/core/ProcessContext.h:102:12:
>  note: in instantiation of function template specialization 
> 'org::apache::nifi::minifi::core::ProcessContext::getPropertyImp  long, std::__1::ratio<1, 1000> > >' requested here
>  return getPropertyImp::type>(name, value);
>  ^
> /home/ubuntu/minifi_cpp/extensions/standard-processors/processors/TailFile.cpp:367:14:
>  note: in instantiation of function template specialization 
> 'org::apache::nifi::minifi::core::ProcessContext::getProperty  long, std::__1::ratio<1, 1000> > >' requested here
>  context->getProperty(LookupFrequency.getName(), lookup_frequency_);
>  ^
> /usr/lib/llvm-10/bin/../include/c++/v1/chrono:1021:28: note: candidate 
> constructor (the implicit copy constructor) not viable: no known conversion 
> from 'const org::apache::nifi::minifi::core::PropertyValue' to 'const 
> std::__1::chrono::duration >' for 1st 
> argument
> class _LIBCPP_TEMPLATE_VIS duration
>  ^
> /usr/lib/llvm-10/bin/../include/c++/v1/chrono:1021:28: note: candidate 
> constructor (the implicit move constructor) not viable: no known conversion 
> from 'const org::apache::nifi::minifi::core::PropertyValue' to 
> 'std::__1::chrono::duration >' for 1st 
> argument
> /usr/lib/llvm-10/bin/../include/c++/v1/chrono:1073:18: note: candidate 
> template ignored: requirement 
> 'is_convertible long>::value' was not satisfied [with _Rep2 = 
> org::apache::nifi::minifi::core::PropertyValue]
>  explicit duration(const _Rep2& __r,
>  ^
> /usr/lib/llvm-10/bin/../include/c++/v1/chrono:1085:9: note: candidate 
> template ignored: could not match 'duration type-parameter-0-1>' against 'const 
> 

[jira] [Assigned] (NIFI-7768) enhance the MongoDB processor URL acceptance protocol to accept mongodb+srv://

2020-08-26 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-7768:
--

Assignee: Mike Thomsen

> enhance the MongoDB processor URL acceptance protocol to accept mongodb+srv://
> --
>
> Key: NIFI-7768
> URL: https://issues.apache.org/jira/browse/NIFI-7768
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
> Environment: Any machine or platform would have similar pattern
>Reporter: Ravi Teja
>Assignee: Mike Thomsen
>Priority: Critical
>
> when trying to connect to a MongoDB atlas instance, we see a message that 
> says `mongo db URL should start with mobgodb://`. But our atlas connection 
> string starts with `mongodb+srv`. Please enhance the processor/controller 
> service to accept `mongodb+srv://` also.
>  
> More info here: https://docs.mongodb.com/manual/reference/connection-string/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] alopresto commented on pull request #4471: NIFI-7730: Jetty server does not start up when a keystore with multiple certificates is used

2020-08-26 Thread GitBox


alopresto commented on pull request #4471:
URL: https://github.com/apache/nifi/pull/4471#issuecomment-681132073


   I am currently reviewing this. While the introduction of 
`SslContextFactory.Server` does help, other changes here need to be considered, 
and additional regression tests need to be introduced. I am working to bring 
this to a stable state. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] sushilkm commented on pull request #4471: NIFI-7730: Jetty server does not start up when a keystore with multiple certificates is used

2020-08-26 Thread GitBox


sushilkm commented on pull request #4471:
URL: https://github.com/apache/nifi/pull/4471#issuecomment-681131557


   Thanks @kotarot for the work. Tested this PR with nifi-toolkit version 
1.11.4, it works!!!
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] sushilkm removed a comment on pull request #4471: NIFI-7730: Jetty server does not start up when a keystore with multiple certificates is used

2020-08-26 Thread GitBox


sushilkm removed a comment on pull request #4471:
URL: https://github.com/apache/nifi/pull/4471#issuecomment-681131104


   Thanks @kotarot for the work. Tested this PR with nifi-toolkit version 
1.11.4, it works!!!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] sushilkm edited a comment on pull request #4471: NIFI-7730: Jetty server does not start up when a keystore with multiple certificates is used

2020-08-26 Thread GitBox


sushilkm edited a comment on pull request #4471:
URL: https://github.com/apache/nifi/pull/4471#issuecomment-681131104


   Thanks @kotarot for the work. Tested this PR with nifi-toolkit version 
1.11.4, it works!!!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] sushilkm commented on pull request #4471: NIFI-7730: Jetty server does not start up when a keystore with multiple certificates is used

2020-08-26 Thread GitBox


sushilkm commented on pull request #4471:
URL: https://github.com/apache/nifi/pull/4471#issuecomment-681131104


   Tested this PR with nifi-toolkit version 1.11.4, it works!!!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (NIFI-7767) SAN not being added to certificates using tls-toolkit

2020-08-26 Thread Joey Frazee (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185471#comment-17185471
 ] 

Joey Frazee commented on NIFI-7767:
---

I've been able to replicate this. Here's what I'm seeing (Y = SANs populated, N 
= SANs +not+ populated):

 
| |*1.12 server*|*1.11 server*|
|*1.12 client*|N|Y|
|*1.11 client*|proto error|Y|

 

 

> SAN not being added to certificates using tls-toolkit 
> --
>
> Key: NIFI-7767
> URL: https://issues.apache.org/jira/browse/NIFI-7767
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Security
>Affects Versions: 1.12.0
>Reporter: Nathan Gough
>Assignee: Nathan Gough
>Priority: Major
>  Labels: tls-toolkit
>
> There appears to be an issue with certificates generated using the 
> tls-toolkit. A few people have reported that the tls-toolkit server/client 
> mode does not include the SAN in the generated certificates. This results in 
> TLS errors when using these certificates in NiFi.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] readl1 commented on pull request #2231: NIFI-4521 MS SQL CDC Processor

2020-08-26 Thread GitBox


readl1 commented on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-681025535


   @patricker @mattyb149 Can we add some optional logging that will output the 
sql statement text so it will be easier to troubleshoot. Also log the 
timestamps. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (NIFI-7765) Toolket CLI OpenID Connect Support

2020-08-26 Thread Pierre Villard (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185313#comment-17185313
 ] 

Pierre Villard commented on NIFI-7765:
--

This is clearly not a bug, and this is not a critical improvement as they're 
many ways to interact with NiFi and NiFi Registry as of today even when OIDC is 
configured (you can use client certificates). Pull requests are welcome if you 
want to contribute this improvement.

> Toolket CLI OpenID Connect Support
> --
>
> Key: NIFI-7765
> URL: https://issues.apache.org/jira/browse/NIFI-7765
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.11.4
> Environment: CentOS Linux 7
>Reporter: W Chang
>Priority: Major
>  Labels: Authentication, CLI, Connect, OIDC, OpenID
>
> When a NiFi or a Registry instance is configured for OpenID Connect 
> authentication, a user cannot authenticate to the secure NiFi or the secure 
> Registry using Toolkit CLI to use CLI commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (NIFI-7765) Toolket CLI OpenID Connect Support

2020-08-26 Thread Pierre Villard (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-7765:
-
Priority: Major  (was: Critical)

> Toolket CLI OpenID Connect Support
> --
>
> Key: NIFI-7765
> URL: https://issues.apache.org/jira/browse/NIFI-7765
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.11.4
> Environment: CentOS Linux 7
>Reporter: W Chang
>Priority: Major
>  Labels: Authentication, CLI, Connect, OIDC, OpenID
>
> When a NiFi or a Registry instance is configured for OpenID Connect 
> authentication, a user cannot authenticate to the secure NiFi or the secure 
> Registry using Toolkit CLI to use CLI commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (NIFI-7765) Toolket CLI OpenID Connect Support

2020-08-26 Thread Pierre Villard (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-7765:
-
Issue Type: Improvement  (was: Bug)

> Toolket CLI OpenID Connect Support
> --
>
> Key: NIFI-7765
> URL: https://issues.apache.org/jira/browse/NIFI-7765
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.11.4
> Environment: CentOS Linux 7
>Reporter: W Chang
>Priority: Critical
>  Labels: Authentication, CLI, Connect, OIDC, OpenID
>
> When a NiFi or a Registry instance is configured for OpenID Connect 
> authentication, a user cannot authenticate to the secure NiFi or the secure 
> Registry using Toolkit CLI to use CLI commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (NIFI-7768) enhance the MongoDB processor URL acceptance protocol to accept mongodb+srv://

2020-08-26 Thread Joey Frazee (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185306#comment-17185306
 ] 

Joey Frazee commented on NIFI-7768:
---

Pretty sure this is just a matter of what version of the Mongo driver is being 
used and the error is being thrown there:

java.lang.IllegalArgumentException: The connection string is invalid. 
Connection strings must start with 'mongodb://'
 at com.mongodb.ConnectionString.(ConnectionString.java:203)
 at com.mongodb.MongoClientURI.(MongoClientURI.java:176)
 at com.mongodb.MongoClientURI.(MongoClientURI.java:158)

The default driver version in NiFi is still 3.2.2, which is 4 years old and 
pre-dates the SRV record support [1]. There are build profiles for using 3.6.x 
(-P3.6) or 3.8.x (-P3.8) and using those the processor initialization gets past 
this point. I don't have access to a setup using this though so I can't do a 
real test.

Bumping the driver version we're using should probably resolve the issue.

1. 
https://www.mongodb.com/blog/post/mongodb-3-6-here-to-SRV-you-with-easier-replica-set-connections?jmp=fcb_source=4244_medium=FBPAGE_term=4=50841309

> enhance the MongoDB processor URL acceptance protocol to accept mongodb+srv://
> --
>
> Key: NIFI-7768
> URL: https://issues.apache.org/jira/browse/NIFI-7768
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
> Environment: Any machine or platform would have similar pattern
>Reporter: Ravi Teja
>Priority: Critical
>
> when trying to connect to a MongoDB atlas instance, we see a message that 
> says `mongo db URL should start with mobgodb://`. But our atlas connection 
> string starts with `mongodb+srv`. Please enhance the processor/controller 
> service to accept `mongodb+srv://` also.
>  
> More info here: https://docs.mongodb.com/manual/reference/connection-string/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (NIFI-7766) Getting initialize class org.apache.nifi.util.text.RegexDateTimeMatcher error in jsontreereader

2020-08-26 Thread Mark Payne (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-7766:
-
Fix Version/s: 1.13.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Getting initialize class org.apache.nifi.util.text.RegexDateTimeMatcher error 
> in jsontreereader
> ---
>
> Key: NIFI-7766
> URL: https://issues.apache.org/jira/browse/NIFI-7766
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.12.0
>Reporter: Lucas Read
>Assignee: Otto Fowler
>Priority: Minor
> Fix For: 1.13.0
>
> Attachments: nifi-app.log
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Setting the date formats in the jsontreereader causes an error. Server time 
> was set for UTC and has since been changed to ETC but the issue still 
> persists. 
> {code:java}
> Could not initialize class 
> org.apache.nifi.util.text.RegexDateTimeMatcher$Compiler
> {code}
> {code:java}
> 0174-1000-e2c7-552f72fd9f08], versionedComponentId=null, 
> processGroup=StandardProcessGroup[identifier=20fdafa4-0174-1000-7885-3f4547c81e71,name=test],
>  active=true]   Failed to invoke @OnEnabled method due to 
> java.lang.ExceptionInInitializerError: {}
>  1098 java.lang.ExceptionInInitializerError: null
>  1099   at 
> org.apache.nifi.util.text.DateTimeMatcherCompiler.compile(DateTimeMatcherCompiler.java:25)
>  1100   at 
> org.apache.nifi.util.text.DateTimeMatcher.compile(DateTimeMatcher.java:66)
>  1101   at 
> org.apache.nifi.schema.inference.TimeValueInference.(TimeValueInference.java:39)
>  1102   at 
> org.apache.nifi.json.JsonTreeReader.lambda$getSchemaAccessStrategy$1(JsonTreeReader.java:96)
>  1103   at 
> org.apache.nifi.schema.inference.SchemaInferenceUtil.getSchemaAccessStrategy(SchemaInferenceUtil.java:47)
>  1104   at 
> org.apache.nifi.json.JsonTreeReader.getSchemaAccessStrategy(JsonTreeReader.java:98)
>  1105   at 
> org.apache.nifi.serialization.SchemaRegistryService.storeSchemaAccessStrategy(SchemaRegistryService.java:108)
>  1106   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  1107   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  1108   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  1109   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>  1110   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:142)
>     at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:130)
>  1112   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:75)
>  1113   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:52)
>  1114   at 
> org.apache.nifi.controller.service.StandardControllerServiceNode$2.run(StandardControllerServiceNode.java:432)
>  1115   at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
>  1116   at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>  1117   at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>  1118   at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>  1119   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>  1120   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>  1121   at java.base/java.lang.Thread.run(Thread.java:834)
>  1122 Caused by: java.lang.NullPointerException: null
>  1123   at java.base/java.util.regex.Pattern.quote(Pattern.java:1352)
>  1124   at 
> org.apache.nifi.util.text.RegexDateTimeMatcher$Compiler.(RegexDateTimeMatcher.java:134)
>  1125   ... 23 common frames omitted
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (NIFI-7766) Getting initialize class org.apache.nifi.util.text.RegexDateTimeMatcher error in jsontreereader

2020-08-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185240#comment-17185240
 ] 

ASF subversion and git services commented on NIFI-7766:
---

Commit bdfe1f23705a3df86eafed12ac8839ee76662730 in nifi's branch 
refs/heads/main from Otto Fowler
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=bdfe1f2 ]

NIFI-7766 Getting initialize class 
org.apache.nifi.util.text.RegexDateTimeMatcher error in jsontreereader

check for null values returned by getZoneStrings()


> Getting initialize class org.apache.nifi.util.text.RegexDateTimeMatcher error 
> in jsontreereader
> ---
>
> Key: NIFI-7766
> URL: https://issues.apache.org/jira/browse/NIFI-7766
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.12.0
>Reporter: Lucas Read
>Assignee: Otto Fowler
>Priority: Minor
> Fix For: 1.13.0
>
> Attachments: nifi-app.log
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Setting the date formats in the jsontreereader causes an error. Server time 
> was set for UTC and has since been changed to ETC but the issue still 
> persists. 
> {code:java}
> Could not initialize class 
> org.apache.nifi.util.text.RegexDateTimeMatcher$Compiler
> {code}
> {code:java}
> 0174-1000-e2c7-552f72fd9f08], versionedComponentId=null, 
> processGroup=StandardProcessGroup[identifier=20fdafa4-0174-1000-7885-3f4547c81e71,name=test],
>  active=true]   Failed to invoke @OnEnabled method due to 
> java.lang.ExceptionInInitializerError: {}
>  1098 java.lang.ExceptionInInitializerError: null
>  1099   at 
> org.apache.nifi.util.text.DateTimeMatcherCompiler.compile(DateTimeMatcherCompiler.java:25)
>  1100   at 
> org.apache.nifi.util.text.DateTimeMatcher.compile(DateTimeMatcher.java:66)
>  1101   at 
> org.apache.nifi.schema.inference.TimeValueInference.(TimeValueInference.java:39)
>  1102   at 
> org.apache.nifi.json.JsonTreeReader.lambda$getSchemaAccessStrategy$1(JsonTreeReader.java:96)
>  1103   at 
> org.apache.nifi.schema.inference.SchemaInferenceUtil.getSchemaAccessStrategy(SchemaInferenceUtil.java:47)
>  1104   at 
> org.apache.nifi.json.JsonTreeReader.getSchemaAccessStrategy(JsonTreeReader.java:98)
>  1105   at 
> org.apache.nifi.serialization.SchemaRegistryService.storeSchemaAccessStrategy(SchemaRegistryService.java:108)
>  1106   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  1107   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  1108   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  1109   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>  1110   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:142)
>     at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:130)
>  1112   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:75)
>  1113   at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:52)
>  1114   at 
> org.apache.nifi.controller.service.StandardControllerServiceNode$2.run(StandardControllerServiceNode.java:432)
>  1115   at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
>  1116   at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>  1117   at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>  1118   at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>  1119   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>  1120   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>  1121   at java.base/java.lang.Thread.run(Thread.java:834)
>  1122 Caused by: java.lang.NullPointerException: null
>  1123   at java.base/java.util.regex.Pattern.quote(Pattern.java:1352)
>  1124   at 
> org.apache.nifi.util.text.RegexDateTimeMatcher$Compiler.(RegexDateTimeMatcher.java:134)
>  1125   ... 23 common frames omitted
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] markap14 commented on pull request #4493: NIFI-7766 Getting initialize class org.apache.nifi.util.text.RegexDat…

2020-08-26 Thread GitBox


markap14 commented on pull request #4493:
URL: https://github.com/apache/nifi/pull/4493#issuecomment-680929055


   Thanks @ottobackwards ! All looks good to me. +1 merging to main



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] markap14 merged pull request #4493: NIFI-7766 Getting initialize class org.apache.nifi.util.text.RegexDat…

2020-08-26 Thread GitBox


markap14 merged pull request #4493:
URL: https://github.com/apache/nifi/pull/4493


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (NIFI-7765) Toolket CLI OpenID Connect Support

2020-08-26 Thread W Chang (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

W Chang updated NIFI-7765:
--
Issue Type: Bug  (was: Improvement)
  Priority: Critical  (was: Major)

> Toolket CLI OpenID Connect Support
> --
>
> Key: NIFI-7765
> URL: https://issues.apache.org/jira/browse/NIFI-7765
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.11.4
> Environment: CentOS Linux 7
>Reporter: W Chang
>Priority: Critical
>  Labels: Authentication, CLI, Connect, OIDC, OpenID
>
> When a NiFi or a Registry instance is configured for OpenID Connect 
> authentication, a user cannot authenticate to the secure NiFi or the secure 
> Registry using Toolkit CLI to use CLI commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] adenes commented on a change in pull request #4463: NIFI-7714: QueryCassandra loses precision when converting timestamps to JSON

2020-08-26 Thread GitBox


adenes commented on a change in pull request #4463:
URL: https://github.com/apache/nifi/pull/4463#discussion_r477255009



##
File path: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java
##
@@ -379,7 +406,7 @@ public static long convertToAvroStream(final ResultSet rs, 
final OutputStream ou
  * @throws TimeoutException If a result set fetch has taken longer 
than the specified timeout
  * @throws ExecutionException   If any error occurs during the result set 
fetch
  */
-public static long convertToJsonStream(final ResultSet rs, final 
OutputStream outStream,
+public static long convertToJsonStream(final Optional 
context, final ResultSet rs, final OutputStream outStream,

Review comment:
   Thanks @turcsanyip , I've updated the code according to your comment.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi-minifi-cpp] szaszm closed pull request #880: MINIFICPP-1321 Add documentation to MergeContent's attribute strategy

2020-08-26 Thread GitBox


szaszm closed pull request #880:
URL: https://github.com/apache/nifi-minifi-cpp/pull/880


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (NIFI-7769) Wait/Notify processors should default to keeping state in ZK

2020-08-26 Thread Malthe Borch (Jira)
Malthe Borch created NIFI-7769:
--

 Summary: Wait/Notify processors should default to keeping state in 
ZK
 Key: NIFI-7769
 URL: https://issues.apache.org/jira/browse/NIFI-7769
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Malthe Borch


Most processors that keep state can now use ZooKeeper as a default in addition 
to a distributed cache service. This should also apply to Wait/Notify.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] turcsanyip commented on a change in pull request #4463: NIFI-7714: QueryCassandra loses precision when converting timestamps to JSON

2020-08-26 Thread GitBox


turcsanyip commented on a change in pull request #4463:
URL: https://github.com/apache/nifi/pull/4463#discussion_r477208816



##
File path: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java
##
@@ -379,7 +406,7 @@ public static long convertToAvroStream(final ResultSet rs, 
final OutputStream ou
  * @throws TimeoutException If a result set fetch has taken longer 
than the specified timeout
  * @throws ExecutionException   If any error occurs during the result set 
fetch
  */
-public static long convertToJsonStream(final ResultSet rs, final 
OutputStream outStream,
+public static long convertToJsonStream(final Optional 
context, final ResultSet rs, final OutputStream outStream,

Review comment:
   In my opinion we should not expose this method as `public`. It is 
unnecessary in general and I believe the signature will change when the 
SimpleDateFormat code is migrated to `java.time`.
   The javadoc should be moved to the original method (otherwise the new 
parameter should be added here).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (MINIFICPP-1327) Add timezone information as attribute to flowfiles crated by CWEL

2020-08-26 Thread Arpad Boda (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpad Boda resolved MINIFICPP-1327.
---
Resolution: Fixed

> Add timezone information as attribute to flowfiles crated by CWEL
> -
>
> Key: MINIFICPP-1327
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1327
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Affects Versions: 0.7.0
>Reporter: Arpad Boda
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.8.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> All flowfiles contain UTC times without specifying the actual timezone of the 
> source computer. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (MINIFICPP-1326) Improve PublishKafka logging

2020-08-26 Thread Marton Szasz (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz resolved MINIFICPP-1326.
-
Resolution: Fixed

> Improve PublishKafka logging
> 
>
> Key: MINIFICPP-1326
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1326
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Marton Szasz
>Assignee: Marton Szasz
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> PublishKafka seems to produce a strange behavior on some deployments where 
> messages are delivered but the agents waits until they would time out before 
> continuing to send more. This issue is about adding logs to ease debugging on 
> the affected deployments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MINIFICPP-1334) libgps raised "a different language linkage", while compiling using Clang 11.0.0

2020-08-26 Thread Marton Szasz (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated MINIFICPP-1334:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> libgps raised "a different language linkage", while compiling using Clang 
> 11.0.0
> 
>
> Key: MINIFICPP-1334
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1334
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: master
> Environment: $ clang --version
> clang version 11.0.0
> Target: x86_64-unknown-linux-gnu
> $cmake --version
> cmake version 3.16.3
> $ cat /proc/cpuinfo
> processor : 0
> vendor_id : GenuineIntel
> cpu family: 6
> model : 23
> model name: Intel(R) Core(TM)2 Quad CPUQ9400  @ 2.66GHz
>Reporter: Ivan Serdyuk
>Assignee: Marton Szasz
>Priority: Blocker
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> I was compiling on x86_64 Ubuntu 20.
> I used to define CC=clang and CXX=clang++, to build MiNiFi, using Clang.
>  
>  
> [ 52%] Building CXX object 
> extensions/rocksdb-repos/CMakeFiles/minifi-rocksdb-repos.dir/RocksDBLoader.cpp.o
>  [ 52%] Building CXX object 
> extensions/rocksdb-repos/CMakeFiles/minifi-rocksdb-repos.dir/RocksDbStream.cpp.o
>  [ 52%] Building CXX object 
> extensions/rocksdb-repos/CMakeFiles/minifi-rocksdb-repos.dir/controllers/RocksDbPersistableKeyValueStoreService.cpp.o
>  [ 52%] Building CXX object 
> extensions/gps/CMakeFiles/minifi-gps.dir/GetGPS.cpp.o
>  In file included from 
> /media/ubuntu/5d3d053e-8b78-4052-8725-674eb332a753/nifi-minifi-cpp-main/extensions/gps/GetGPS.cpp:44:
>  In file included from /usr/include/libgpsmm.h:12:
>  /usr/include/gps.h:2335:15: error: declaration of 'mkgmtime' has a different 
> language linkage
>  extern time_t mkgmtime(struct tm *);
>  ^
>  
> /media/ubuntu/5d3d053e-8b78-4052-8725-674eb332a753/nifi-minifi-cpp-main/extensions/gps/../../libminifi/include/utils/TimeUtil.h:69:15:
>  note: previous definition is here
>  inline time_t mkgmtime(struct tm *date_time) {
>  ^
>  1 error generated.
>  make[2]: *** [extensions/gps/CMakeFiles/minifi-gps.dir/build.make:63: 
> extensions/gps/CMakeFiles/minifi-gps.dir/GetGPS.cpp.o] Error 1
>  make[1]: *** [CMakeFiles/Makefile2:4246: 
> extensions/gps/CMakeFiles/minifi-gps.dir/all] Error 2
>  make[1]: *** Waiting for unfinished jobs
>  [ 52%] Linking CXX static library libminifi-rocksdb-repos.a
>  [ 52%] Linking CXX static library libcatch_main.a
>  [ 52%] Built target minifi-rocksdb-repos
>  [ 52%] Built target catch_main
>  
> I am using this dev. package:
>  $ apt info libgps-dev
>  Package: libgps-dev
>  Version: 3.20-8ubuntu0.2
>  Priority: optional
>  Section: libdevel
>  Source: gpsd
>  Origin: Ubuntu
>  
> From the corresponding sub-folder:
>  $ pwd
>  .../nifi-minifi-cpp-main/build/extensions/gps
>  $ make
>  [ 6%] Built target zlib-external
>  [ 13%] Built target ossp-uuid-external
>  [ 20%] Built target yaml-cpp-external
>  [ 26%] Built target libressl-portable
>  [100%] Built target core-minifi
>  [100%] Building CXX object 
> extensions/gps/CMakeFiles/minifi-gps.dir/GetGPS.cpp.o
>  In file included from 
> /media/ubuntu/5d3d053e-8b78-4052-8725-674eb332a753/nifi-minifi-cpp-main/extensions/gps/GetGPS.cpp:44:
>  In file included from /usr/include/libgpsmm.h:12:
>  /usr/include/gps.h:2335:15: error: declaration of 'mkgmtime' has a different 
> language linkage
>  extern time_t mkgmtime(struct tm *);
>  ^
>  
> /media/ubuntu/5d3d053e-8b78-4052-8725-674eb332a753/nifi-minifi-cpp-main/extensions/gps/../../libminifi/include/utils/TimeUtil.h:69:15:
>  note: previous definition is here
>  inline time_t mkgmtime(struct tm *date_time) {
>  ^
>  1 error generated.
>  make[2]: *** [extensions/gps/CMakeFiles/minifi-gps.dir/build.make:63: 
> extensions/gps/CMakeFiles/minifi-gps.dir/GetGPS.cpp.o] Error 1
>  make[1]: *** [CMakeFiles/Makefile2:4246: 
> extensions/gps/CMakeFiles/minifi-gps.dir/all] Error 2
>  make: *** [Makefile:163: all] Error 2
>  
> And btw:
> $ ls /usr/include/gps.h
> ls: cannot access '/usr/include/gps.h': No such file or directory



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi-minifi-cpp] szaszm closed pull request #867: MINIFICPP-1327 - Add timezone information as attribute to flowfiles c…

2020-08-26 Thread GitBox


szaszm closed pull request #867:
URL: https://github.com/apache/nifi-minifi-cpp/pull/867


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #880: MINIFICPP-1321 Add documentation to MergeContent's attribute strategy

2020-08-26 Thread GitBox


fgerlits commented on a change in pull request #880:
URL: https://github.com/apache/nifi-minifi-cpp/pull/880#discussion_r477095472



##
File path: PROCESSORS.md
##
@@ -757,7 +757,8 @@ Merges a Group of FlowFiles together based on a 
user-defined strategy and packag
 In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
 
 | Name | Default Value | Allowable Values | Description | 
-| - | - | - | - | 
+| - | - | - | - |
+|Attribute Strategy|Keep Only Common Attributes|Keep Only Common 
AttributesKeep All Unique Attributes|Determines which FlowFile 
attributes should be added to the bundle. If 'Keep All Unique Attributes' is 
selected, any attribute on any FlowFile that gets bundled will be kept unless 
its value conflicts with the value from another FlowFile. If 'Keep Only Common 
Attributes' is selected, only the attributes that exist on all FlowFiles in the 
bundle, with the same value, will be preserved.| 

Review comment:
   I would, unless there is a length limit in the C2 GUI.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #880: MINIFICPP-1321 Add documentation to MergeContent's attribute strategy

2020-08-26 Thread GitBox


lordgamez commented on a change in pull request #880:
URL: https://github.com/apache/nifi-minifi-cpp/pull/880#discussion_r477083525



##
File path: PROCESSORS.md
##
@@ -757,7 +757,8 @@ Merges a Group of FlowFiles together based on a 
user-defined strategy and packag
 In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
 
 | Name | Default Value | Allowable Values | Description | 
-| - | - | - | - | 
+| - | - | - | - |
+|Attribute Strategy|Keep Only Common Attributes|Keep Only Common 
AttributesKeep All Unique Attributes|Determines which FlowFile 
attributes should be added to the bundle. If 'Keep All Unique Attributes' is 
selected, any attribute on any FlowFile that gets bundled will be kept unless 
its value conflicts with the value from another FlowFile. If 'Keep Only Common 
Attributes' is selected, only the attributes that exist on all FlowFiles in the 
bundle, with the same value, will be preserved.| 

Review comment:
   Shall I also update the property in MergeContent.cpp as currently it has 
the same description?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #877: MINIFICPP-1339 - Reopen rocksdb database when space becomes available on the disk

2020-08-26 Thread GitBox


adamdebreceni commented on a change in pull request #877:
URL: https://github.com/apache/nifi-minifi-cpp/pull/877#discussion_r477068493



##
File path: extensions/rocksdb-repos/FlowFileRepository.cpp
##
@@ -91,14 +95,18 @@ void FlowFileRepository::flush() {
 }
 
 void FlowFileRepository::printStats() {
+  auto opendb = db_->open();
+  if (!opendb) {
+return;

Review comment:
   logging error on failed `open`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org