[jira] [Commented] (NIFI-8401) o.apache.nifi.controller.FlowController Failed to capture component stats for Stats History on Windows Systems

2021-04-07 Thread Nadeem (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316685#comment-17316685 ] Nadeem commented on NIFI-8401: --   [~ERD] The issue is related to what [~mattyb149] has reported already 

[jira] [Updated] (NIFI-8394) Fix NPE error when NiFi connects to external zookeeper insecurely

2021-04-07 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-8394: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Fix NPE error when NiFi connects

[jira] [Updated] (NIFI-8394) Fix NPE error when NiFi connects to external zookeeper insecurely

2021-04-07 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-8394: -- Priority: Minor (was: Major) > Fix NPE error when NiFi connects to external zookeeper insecurely >

[jira] [Updated] (NIFI-8394) Fix NPE error when NiFi connects to external zookeeper insecurely

2021-04-07 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-8394: -- Fix Version/s: 1.14.0 > Fix NPE error when NiFi connects to external zookeeper insecurely >

[jira] [Commented] (NIFI-8394) Fix NPE error when NiFi connects to external zookeeper insecurely

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316595#comment-17316595 ] ASF subversion and git services commented on NIFI-8394: --- Commit

[GitHub] [nifi] jfrazee closed pull request #4974: NIFI-8394: Fix NPE error when NiFi connects to external zookeeper insecurely

2021-04-07 Thread GitBox
jfrazee closed pull request #4974: URL: https://github.com/apache/nifi/pull/4974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (NIFI-8401) o.apache.nifi.controller.FlowController Failed to capture component stats for Stats History on Windows Systems

2021-04-07 Thread Eric Detwiler (Jira)
Eric Detwiler created NIFI-8401: --- Summary: o.apache.nifi.controller.FlowController Failed to capture component stats for Stats History on Windows Systems Key: NIFI-8401 URL:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4981: NIFI-7198: Adding optional SSL Context Service to RedisConnectionPool…

2021-04-07 Thread GitBox
exceptionfactory commented on a change in pull request #4981: URL: https://github.com/apache/nifi/pull/4981#discussion_r608949849 ## File path: nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/test/java/org/apache/nifi/redis/service/TestRedisConnectionPoolService.java

[jira] [Updated] (NIFI-7198) Support TLS in RedisConnectionPoolService

2021-04-07 Thread Joseph Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock updated NIFI-7198: - Fix Version/s: 1.14.0 Status: Patch Available (was: In Progress) > Support TLS in

[GitHub] [nifi] gresockj opened a new pull request #4981: NIFI-7198: Adding optional SSL Context Service to RedisConnectionPool…

2021-04-07 Thread GitBox
gresockj opened a new pull request #4981: URL: https://github.com/apache/nifi/pull/4981 …Service Description of PR This adds an optional property "SSL Context Service" to the RedisConnectionPoolService, which allows users to connect to a TLS-secured Redis port.

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1031: MINIFICPP-1476 Improve parallel S3 request handling in S3 processors

2021-04-07 Thread GitBox
fgerlits commented on a change in pull request #1031: URL: https://github.com/apache/nifi-minifi-cpp/pull/1031#discussion_r608776773 ## File path: extensions/aws/processors/DeleteS3Object.h ## @@ -65,6 +65,11 @@ class DeleteS3Object : public S3Processor { explicit

[GitHub] [nifi] mattyb149 commented on pull request #4901: NIFI-8326: Send records as individual messages in Kafka RecordSinks

2021-04-07 Thread GitBox
mattyb149 commented on pull request #4901: URL: https://github.com/apache/nifi/pull/4901#issuecomment-815099839 It's not ready yet, I need to change the producer.send() to not call get() directly after, or else each message will be ack'ed one at a time, which impacts performance. --

[jira] [Updated] (NIFI-8400) SystemDiagnostics throws NPE on Windows

2021-04-07 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8400: --- Fix Version/s: 1.14.0 Status: Patch Available (was: In Progress) > SystemDiagnostics

[GitHub] [nifi] mattyb149 opened a new pull request #4980: NIFI-8400: Use longs in SystemDiagnostics, add null checks

2021-04-07 Thread GitBox
mattyb149 opened a new pull request #4980: URL: https://github.com/apache/nifi/pull/4980 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Changes Long variables to long in

[jira] [Assigned] (NIFI-8400) SystemDiagnostics throws NPE on Windows

2021-04-07 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-8400: -- Assignee: Matt Burgess > SystemDiagnostics throws NPE on Windows >

[jira] [Commented] (NIFI-8400) SystemDiagnostics throws NPE on Windows

2021-04-07 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316461#comment-17316461 ] Otto Fowler commented on NIFI-8400: --- If you read this description, and initially thought "That variable

[jira] [Created] (NIFI-8400) SystemDiagnostics throws NPE on Windows

2021-04-07 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-8400: -- Summary: SystemDiagnostics throws NPE on Windows Key: NIFI-8400 URL: https://issues.apache.org/jira/browse/NIFI-8400 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi] pvillard31 commented on pull request #4939: NIFI-8341 Support Multi Hosts in AMQP Processors

2021-04-07 Thread GitBox
pvillard31 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-815002530 Yeah fair enough. Not in a position to merge right now but will do later today if no one else does before me. -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1043: MINIFICPP-1359 Implement FollowRedirects property in InvokeHTTP

2021-04-07 Thread GitBox
lordgamez commented on a change in pull request #1043: URL: https://github.com/apache/nifi-minifi-cpp/pull/1043#discussion_r608752782 ## File path: extensions/http-curl/tests/VerifyInvokeHTTPTest.cpp ## @@ -120,6 +126,31 @@ class VerifyInvokeHTTPOKResponse : public

[GitHub] [nifi] timeabarna commented on pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors

2021-04-07 Thread GitBox
timeabarna commented on pull request #4973: URL: https://github.com/apache/nifi/pull/4973#issuecomment-814974273 @joshelser @bbende Josh and Bryan thank you very much for your help, PR has been updated -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] nabmoh123 commented on pull request #4939: NIFI-8341 Support Multi Hosts in AMQP Processors

2021-04-07 Thread GitBox
nabmoh123 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-814967533 > I still think that a custom validate method makes sense. Especially to make the processor invalid if brokers, host, and port are all set. Because in that case it could confuse

[jira] [Assigned] (NIFI-8148) Selecting field from array with QueryRecord routes to failure

2021-04-07 Thread Jon Kessler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Kessler reassigned NIFI-8148: - Assignee: (was: Jon Kessler) > Selecting field from array with QueryRecord routes to failure

[GitHub] [nifi] JonathanKessler commented on pull request #4780: NIFI-8126 Include Total Queued Duration in ConnectionStatus metrics

2021-04-07 Thread GitBox
JonathanKessler commented on pull request #4780: URL: https://github.com/apache/nifi/pull/4780#issuecomment-814925343 @markap14, just wanted to ping you to please take a second look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608642381 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -71,7 +71,7 @@ enum class Mode { SINGLE, MULTIPLE, UNDEFINED

[jira] [Resolved] (NIFI-7912) Site-to-Site over HTTP fails for FlowFiles over 100MB

2021-04-07 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-7912. Fix Version/s: 1.14.0 Resolution: Fixed > Site-to-Site over HTTP fails for FlowFiles

[jira] [Commented] (NIFI-7912) Site-to-Site over HTTP fails for FlowFiles over 100MB

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316292#comment-17316292 ] ASF subversion and git services commented on NIFI-7912: --- Commit

[GitHub] [nifi] asfgit closed pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-07 Thread GitBox
asfgit closed pull request #4972: URL: https://github.com/apache/nifi/pull/4972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] exceptionfactory commented on pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-07 Thread GitBox
exceptionfactory commented on pull request #4972: URL: https://github.com/apache/nifi/pull/4972#issuecomment-814876578 > @thenatog Thanks for the review changes! > @exceptionfactory I have no more comments, +1 from my side too. Thanks for the confirmation @turcsanyip! Merging.

[GitHub] [nifi] markap14 commented on pull request #4950: NIFI-8380: Allow for an extensions.directory property to specify wher…

2021-04-07 Thread GitBox
markap14 commented on pull request #4950: URL: https://github.com/apache/nifi/pull/4950#issuecomment-814871049 Awesome! Thanks @akatona84 and @urbandan for such thorough testing & review! And thanks @pvillard31 for reviewing & merging! -- This is an automated message from the Apache

[GitHub] [nifi] gresockj commented on a change in pull request #4976: NIFI-3862: Added Issuer DN support to ListenHTTP

2021-04-07 Thread GitBox
gresockj commented on a change in pull request #4976: URL: https://github.com/apache/nifi/pull/4976#discussion_r608586852 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java ## @@

[GitHub] [nifi] gresockj commented on a change in pull request #4976: NIFI-3862: Added Issuer DN support to ListenHTTP

2021-04-07 Thread GitBox
gresockj commented on a change in pull request #4976: URL: https://github.com/apache/nifi/pull/4976#discussion_r608586502 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java ## @@

[GitHub] [nifi] gresockj commented on a change in pull request #4976: NIFI-3862: Added Issuer DN support to ListenHTTP

2021-04-07 Thread GitBox
gresockj commented on a change in pull request #4976: URL: https://github.com/apache/nifi/pull/4976#discussion_r608584778 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java

[jira] [Resolved] (NIFI-8380) Stateless NiFi Kafka connector should allow separate directories for extensions and base nars

2021-04-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8380. -- Fix Version/s: 1.14.0 Resolution: Fixed > Stateless NiFi Kafka connector should allow

[jira] [Commented] (NIFI-8380) Stateless NiFi Kafka connector should allow separate directories for extensions and base nars

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316246#comment-17316246 ] ASF subversion and git services commented on NIFI-8380: --- Commit

[jira] [Commented] (NIFI-8380) Stateless NiFi Kafka connector should allow separate directories for extensions and base nars

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316244#comment-17316244 ] ASF subversion and git services commented on NIFI-8380: --- Commit

[jira] [Commented] (NIFI-8380) Stateless NiFi Kafka connector should allow separate directories for extensions and base nars

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316245#comment-17316245 ] ASF subversion and git services commented on NIFI-8380: --- Commit

[GitHub] [nifi] pvillard31 commented on pull request #4950: NIFI-8380: Allow for an extensions.directory property to specify wher…

2021-04-07 Thread GitBox
pvillard31 commented on pull request #4950: URL: https://github.com/apache/nifi/pull/4950#issuecomment-814836289 Merged to main, thanks @markap14 @akatona84 @urbandan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nifi] asfgit closed pull request #4950: NIFI-8380: Allow for an extensions.directory property to specify wher…

2021-04-07 Thread GitBox
asfgit closed pull request #4950: URL: https://github.com/apache/nifi/pull/4950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] turcsanyip commented on pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-07 Thread GitBox
turcsanyip commented on pull request #4972: URL: https://github.com/apache/nifi/pull/4972#issuecomment-814786327 @thenatog Thanks for the review changes! @exceptionfactory I have no more comments, +1 from my side too. -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #1046: MINIFICPP-1032 Refactor parse_url

2021-04-07 Thread GitBox
fgerlits opened a new pull request #1046: URL: https://github.com/apache/nifi-minifi-cpp/pull/1046 https://issues.apache.org/jira/browse/MINIFICPP-1032 Modernize the parse_url() function and add error checking. --- Thank you for submitting a contribution to Apache NiFi

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608475655 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,77 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1043: MINIFICPP-1359 Implement FollowRedirects property in InvokeHTTP

2021-04-07 Thread GitBox
adamdebreceni commented on a change in pull request #1043: URL: https://github.com/apache/nifi-minifi-cpp/pull/1043#discussion_r608472239 ## File path: extensions/http-curl/tests/VerifyInvokeHTTPTest.cpp ## @@ -120,6 +126,31 @@ class VerifyInvokeHTTPOKResponse : public

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608471765 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,77 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608449176 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -71,7 +71,7 @@ enum class Mode { SINGLE, MULTIPLE, UNDEFINED

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608447451 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,77 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (NIFI-8389) Grok Reader - raw data strategy when no match

2021-04-07 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8389: -- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-8389) Grok Reader - raw data strategy when no match

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316062#comment-17316062 ] ASF subversion and git services commented on NIFI-8389: --- Commit

[GitHub] [nifi] asfgit closed pull request #4966: NIFI-8389 - Grok Reader - raw data strategy when no match

2021-04-07 Thread GitBox
asfgit closed pull request #4966: URL: https://github.com/apache/nifi/pull/4966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] turcsanyip commented on pull request #4966: NIFI-8389 - Grok Reader - raw data strategy when no match

2021-04-07 Thread GitBox
turcsanyip commented on pull request #4966: URL: https://github.com/apache/nifi/pull/4966#issuecomment-814669723 @pvillard31 Thanks for the improvement! @ottobackwards Thanks for the review! Merging to main. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (NIFI-8390) Handle HBase namespaces in Atlas reporting task

2021-04-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8390: - Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [nifi] pvillard31 commented on pull request #4977: NIFI-8390: Handle HBase namespaces in Atlas reporting task

2021-04-07 Thread GitBox
pvillard31 commented on pull request #4977: URL: https://github.com/apache/nifi/pull/4977#issuecomment-814656430 Thanks @turcsanyip - merged to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (NIFI-8390) Handle HBase namespaces in Atlas reporting task

2021-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316046#comment-17316046 ] ASF subversion and git services commented on NIFI-8390: --- Commit

[GitHub] [nifi] asfgit closed pull request #4977: NIFI-8390: Handle HBase namespaces in Atlas reporting task

2021-04-07 Thread GitBox
asfgit closed pull request #4977: URL: https://github.com/apache/nifi/pull/4977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] pvillard31 commented on pull request #4901: NIFI-8326: Send records as individual messages in Kafka RecordSinks

2021-04-07 Thread GitBox
pvillard31 commented on pull request #4901: URL: https://github.com/apache/nifi/pull/4901#issuecomment-814655520 Hey @mattyb149 - is this ready for final review? (also, while playing more with this, I realized some authN methods are missing

[jira] [Created] (NIFI-8399) Kerberos username/password for KafkaRecordSink

2021-04-07 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-8399: Summary: Kerberos username/password for KafkaRecordSink Key: NIFI-8399 URL: https://issues.apache.org/jira/browse/NIFI-8399 Project: Apache NiFi Issue Type:

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-07 Thread GitBox
adamdebreceni opened a new pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-04-07 Thread GitBox
aminadinari19 commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r608373420 ## File path: extensions/standard-processors/processors/HashContent.cpp ## @@ -84,6 +82,7 @@ void

[GitHub] [nifi] timeabarna commented on a change in pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors

2021-04-07 Thread GitBox
timeabarna commented on a change in pull request #4973: URL: https://github.com/apache/nifi/pull/4973#discussion_r608365626 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java

[GitHub] [nifi] timeabarna commented on a change in pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors

2021-04-07 Thread GitBox
timeabarna commented on a change in pull request #4973: URL: https://github.com/apache/nifi/pull/4973#discussion_r608365626 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-04-07 Thread GitBox
aminadinari19 commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r608365026 ## File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp ## @@ -146,7 +148,7 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-04-07 Thread GitBox
aminadinari19 commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r608365026 ## File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp ## @@ -146,7 +148,7 @@ void AbstractMQTTProcessor::onSchedule(const