[jira] [Updated] (NIFI-8763) Hide some properties in CSVReader when built-in CSV Format is selected

2021-07-29 Thread Timea Barna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timea Barna updated NIFI-8763: -- Status: Patch Available (was: In Progress) > Hide some properties in CSVReader when built-in CSV

[GitHub] [nifi] timeabarna opened a new pull request #5263: NIFI-8763 Hide some properties in CSVReader when built-in CSV Format …

2021-07-29 Thread GitBox
timeabarna opened a new pull request #5263: URL: https://github.com/apache/nifi/pull/5263 …is selected https://issues.apache.org/jira/browse/NIFI-8763 Description of PR Hide properties on CSVReader and CSVRecordSetWriter which can not be modified when pre-defined CSV

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1121: MINIFICPP-1596 Refactor docker tests by removing unnecessary clusters

2021-07-29 Thread GitBox
aminadinari19 commented on a change in pull request #1121: URL: https://github.com/apache/nifi-minifi-cpp/pull/1121#discussion_r679652800 ## File path: docker/test/integration/features/s3.feature ## @@ -36,14 +36,14 @@ Feature: Sending data from MiNiFi-C++ to an AWS server

[jira] [Closed] (NIFI-8127) Https work with jdk certificate

2021-07-29 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen closed NIFI-8127. -- > Https work with jdk certificate > --- > > Key: NIFI-8127 >

[jira] [Commented] (NIFI-8961) Postgresql duplicate key exception

2021-07-29 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390266#comment-17390266 ] chen commented on NIFI-8961: Hi there,I have a problem with ExecuteSQL by primary key.If I write SQL myself,

[jira] [Created] (NIFI-8961) Postgresql duplicate key exception

2021-07-29 Thread chen (Jira)
chen created NIFI-8961: -- Summary: Postgresql duplicate key exception Key: NIFI-8961 URL: https://issues.apache.org/jira/browse/NIFI-8961 Project: Apache NiFi Issue Type: Bug Components: Tools

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679592512 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679592382 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679591863 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi] github-actions[bot] closed pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image

2021-07-29 Thread GitBox
github-actions[bot] closed pull request #4856: URL: https://github.com/apache/nifi/pull/4856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nifi] github-actions[bot] commented on pull request #4956: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4956: URL: https://github.com/apache/nifi/pull/4956#issuecomment-889536174 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4959: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-framework-bundle

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4959: URL: https://github.com/apache/nifi/pull/4959#issuecomment-889536148 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4957: Bump guava from 28.0-jre to 29.0-jre in /nifi-toolkit/nifi-toolkit-admin

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4957: URL: https://github.com/apache/nifi/pull/4957#issuecomment-889536158 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4958: Bump guava from 28.0-jre to 29.0-jre in /nifi-toolkit/nifi-toolkit-zookeeper-migrator

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4958: URL: https://github.com/apache/nifi/pull/4958#issuecomment-889536153 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4962: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4962: URL: https://github.com/apache/nifi/pull/4962#issuecomment-889536116 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4963: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4963: URL: https://github.com/apache/nifi/pull/4963#issuecomment-889536102 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4964: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4964: URL: https://github.com/apache/nifi/pull/4964#issuecomment-889536086 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4961: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4961: URL: https://github.com/apache/nifi/pull/4961#issuecomment-889536126 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4960: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-standard-bundle

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4960: URL: https://github.com/apache/nifi/pull/4960#issuecomment-889536140 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] github-actions[bot] commented on pull request #4965: Bump guava from 28.0-jre to 29.0-jre in /nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #4965: URL: https://github.com/apache/nifi/pull/4965#issuecomment-889536069 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5259: NIFI-8955 Add Max Connection Lifetime property to Hive(_1_1)ConnectionPool CS

2021-07-29 Thread GitBox
exceptionfactory commented on a change in pull request #5259: URL: https://github.com/apache/nifi/pull/5259#discussion_r679493124 ## File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/pom.xml ## @@ -121,6 +121,11 @@ commons-text 1.8

[GitHub] [nifi] adenes commented on a change in pull request #5259: NIFI-8955 Add Max Connection Lifetime property to Hive(_1_1)ConnectionPool CS

2021-07-29 Thread GitBox
adenes commented on a change in pull request #5259: URL: https://github.com/apache/nifi/pull/5259#discussion_r679471640 ## File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/pom.xml ## @@ -121,6 +121,11 @@ commons-text 1.8 +

[jira] [Updated] (NIFI-8766) Improve JWT Authentication Handling

2021-07-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8766: --- Affects Version/s: 1.14.0 Status: Patch Available (was: In Progress) >

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5261: NIFI-7588: Handling dynamic properties on termination

2021-07-29 Thread GitBox
exceptionfactory commented on a change in pull request #5261: URL: https://github.com/apache/nifi/pull/5261#discussion_r679440032 ## File path:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5261: NIFI-7588: Handling dynamic properties on termination

2021-07-29 Thread GitBox
exceptionfactory commented on a change in pull request #5261: URL: https://github.com/apache/nifi/pull/5261#discussion_r679440032 ## File path:

[GitHub] [nifi] exceptionfactory opened a new pull request #5262: NIFI-8766 Implemented RS512 Algorithm for JWT Signing

2021-07-29 Thread GitBox
exceptionfactory opened a new pull request #5262: URL: https://github.com/apache/nifi/pull/5262 Description of PR NIFI-8766 Implements asymmetric-key processing for internal JSON Web Token signing and verification. The changes replace the current approach based on per-user

[GitHub] [nifi] gresockj commented on a change in pull request #5261: NIFI-7588: Handling dynamic properties on termination

2021-07-29 Thread GitBox
gresockj commented on a change in pull request #5261: URL: https://github.com/apache/nifi/pull/5261#discussion_r679432526 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardReloadComponent.java

[jira] [Updated] (NIFI-8959) Add a DPAPI implementation of SensitivePropertyProvider

2021-07-29 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated NIFI-8959: - Description: Add a {{SensitivePropertyProvider}} which works with the Windows DPAPI (See details

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5261: NIFI-7588: Handling dynamic properties on termination

2021-07-29 Thread GitBox
exceptionfactory commented on a change in pull request #5261: URL: https://github.com/apache/nifi/pull/5261#discussion_r679427486 ## File path:

[GitHub] [nifi] gresockj opened a new pull request #5261: NIFI-7588: Handling dynamic properties on termination

2021-07-29 Thread GitBox
gresockj opened a new pull request #5261: URL: https://github.com/apache/nifi/pull/5261 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Sets the new properties of a processor from the

[jira] [Commented] (NIFI-7588) InvokeHTTP ignoring custom parameters when stop+finalize+start

2021-07-29 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390080#comment-17390080 ] Joe Witt commented on NIFI-7588: Thanks for the bump. This seems important to sort out > InvokeHTTP

[jira] [Assigned] (NIFI-7588) InvokeHTTP ignoring custom parameters when stop+finalize+start

2021-07-29 Thread Joseph Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock reassigned NIFI-7588: Assignee: Joseph Gresock > InvokeHTTP ignoring custom parameters when stop+finalize+start

[GitHub] [nifi] tpalfy closed pull request #5118: NIFI-8650 Flow Analysis

2021-07-29 Thread GitBox
tpalfy closed pull request #5118: URL: https://github.com/apache/nifi/pull/5118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (NIFI-8960) Create ability for EvaluateJsonPath processor to match any or all defined json paths.

2021-07-29 Thread Tim Smith (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith reassigned NIFI-8960: --- Assignee: Tim Smith > Create ability for EvaluateJsonPath processor to match any or all defined >

[jira] [Created] (NIFI-8960) Create ability for EvaluateJsonPath processor to match any or all defined json paths.

2021-07-29 Thread Tim Smith (Jira)
Tim Smith created NIFI-8960: --- Summary: Create ability for EvaluateJsonPath processor to match any or all defined json paths. Key: NIFI-8960 URL: https://issues.apache.org/jira/browse/NIFI-8960 Project:

[jira] [Commented] (NIFI-4315) Upgrade to newer version of logback

2021-07-29 Thread Wiktor Kubicki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390031#comment-17390031 ] Wiktor Kubicki commented on NIFI-4315: -- I checked my issue (fle rolling) and it is fixed only in

[jira] [Commented] (NIFI-4315) Upgrade to newer version of logback

2021-07-29 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390027#comment-17390027 ] Joe Witt commented on NIFI-4315: NiFi appears to still use 1.2.3 as of now. The latest stable appears to

[jira] [Comment Edited] (NIFI-4315) Upgrade to newer version of logback

2021-07-29 Thread Wiktor Kubicki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137840#comment-17137840 ] Wiktor Kubicki edited comment on NIFI-4315 at 7/29/21, 4:50 PM: Version of

[jira] [Commented] (NIFI-7588) InvokeHTTP ignoring custom parameters when stop+finalize+start

2021-07-29 Thread George Knaggs (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389966#comment-17389966 ] George Knaggs commented on NIFI-7588: - This bug happened to me, and we are on 1.13.2, and what a pain

[jira] [Created] (NIFI-8959) Add a DPAPI implementation of SensitivePropertyProvider

2021-07-29 Thread Jon Zeolla (Jira)
Jon Zeolla created NIFI-8959: Summary: Add a DPAPI implementation of SensitivePropertyProvider Key: NIFI-8959 URL: https://issues.apache.org/jira/browse/NIFI-8959 Project: Apache NiFi Issue

[jira] [Updated] (MINIFICPP-1289) Add range-v3

2021-07-29 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1289: Status: Patch Available (was: In Progress)

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1147: MINIFICPP-1289 add range-v3 and examples

2021-07-29 Thread GitBox
szaszm opened a new pull request #1147: URL: https://github.com/apache/nifi-minifi-cpp/pull/1147 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679208828 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
lordgamez commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679201307 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[jira] [Assigned] (MINIFICPP-1289) Add range-v3

2021-07-29 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz reassigned MINIFICPP-1289: --- Assignee: Marton Szasz > Add range-v3 > > > Key:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679198370 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679198370 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r679191844 ## File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp ## @@ -119,7 +118,7 @@ class SimplePythonFlowFileTransferTest :

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
lordgamez commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679167560 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1141: MINIFICPP-1479-Rework integration tests for HashContent

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1141: URL: https://github.com/apache/nifi-minifi-cpp/pull/1141#discussion_r679166402 ## File path: extensions/standard-processors/tests/unit/HashContentTest.cpp ## @@ -149,17 +149,31 @@ TEST_CASE("TestingFailOnEmptyProperty",

[jira] [Updated] (NIFI-8958) support for ISO-8601 dates

2021-07-29 Thread Yannick Majoros (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yannick Majoros updated NIFI-8958: -- Description: Following up on NIFI-5081, we have a similar use case:  we have a service that

[jira] [Created] (NIFI-8958) support for ISO-8601 dates

2021-07-29 Thread Yannick Majoros (Jira)
Yannick Majoros created NIFI-8958: - Summary: support for ISO-8601 dates Key: NIFI-8958 URL: https://issues.apache.org/jira/browse/NIFI-8958 Project: Apache NiFi Issue Type: Improvement

[jira] [Created] (NIFI-8957) NiFi Registry - Possibility to set a description when creating a bucket

2021-07-29 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-8957: Summary: NiFi Registry - Possibility to set a description when creating a bucket Key: NIFI-8957 URL: https://issues.apache.org/jira/browse/NIFI-8957 Project: Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
fgerlits commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679071529 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
fgerlits commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679067097 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679056562 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679054962 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679052318 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
fgerlits commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679026918 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
fgerlits commented on a change in pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146#discussion_r679024480 ## File path: CONTRIB.md ## @@ -15,24 +15,59 @@ # Apache NiFi - MiNiFi - C++ Contribution Guide - -We welcome all contributions to Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

2021-07-29 Thread GitBox
fgerlits commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r679004197 ## File path: libminifi/test/unit/FileMatcherTests.cpp ## @@ -0,0 +1,208 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (MINIFICPP-1617) Update CONTRIB.md where it differs from practice

2021-07-29 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1617: Status: Patch Available (was: Open)

[jira] [Assigned] (MINIFICPP-1617) Update CONTRIB.md where it differs from practice

2021-07-29 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz reassigned MINIFICPP-1617: --- Assignee: Marton Szasz > Update CONTRIB.md where it differs from practice >

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1146: MINIFICPP-1617 Update CONTRIB.md with current practice

2021-07-29 Thread GitBox
szaszm opened a new pull request #1146: URL: https://github.com/apache/nifi-minifi-cpp/pull/1146 - divergence from the Google Style Guide - recommendation to follow the C++ Core Guidelines This is largely based on my observation of existing practice to help new contributors. If

[jira] [Updated] (MINIFICPP-1617) Update CONTRIB.md where it differs from practice

2021-07-29 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1617: Description: CONTRIB.md refers to the google style guide, but the codebase and

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-07-29 Thread GitBox
lordgamez commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r678935221 ## File path: libminifi/test/sql-tests/mocks/MockConnectors.cpp ## @@ -0,0 +1,386 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r678913235 ## File path: libminifi/test/sql-tests/mocks/MockConnectors.cpp ## @@ -0,0 +1,386 @@ +/** + * + * Licensed to the Apache Software

[GitHub] [nifi] pvillard31 commented on pull request #5260: NIFI-8956 Changed TestListenHTTP to expect IOException

2021-07-29 Thread GitBox
pvillard31 commented on pull request #5260: URL: https://github.com/apache/nifi/pull/5260#issuecomment-80783 Thanks @exceptionfactory, merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (NIFI-8956) TestListenHTTP Failures on Azul Zulu 11.0.12

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389719#comment-17389719 ] ASF subversion and git services commented on NIFI-8956: --- Commit

[GitHub] [nifi] asfgit closed pull request #5260: NIFI-8956 Changed TestListenHTTP to expect IOException

2021-07-29 Thread GitBox
asfgit closed pull request #5260: URL: https://github.com/apache/nifi/pull/5260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (NIFI-8956) TestListenHTTP Failures on Azul Zulu 11.0.12

2021-07-29 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8956: - Fix Version/s: 1.15.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r678899881 ## File path: libminifi/src/FlowController.cpp ## @@ -60,7 +60,7 @@ namespace minifi { FlowController::FlowController(std::shared_ptr

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r678901043 ## File path: win_build_vs.bat ## @@ -65,7 +65,7 @@ for %%x in (%*) do ( mkdir %builddir% pushd %builddir%\ -cmake -G %generator% -A

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-07-29 Thread GitBox
lordgamez commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r678899606 ## File path: win_build_vs.bat ## @@ -65,7 +65,7 @@ for %%x in (%*) do ( mkdir %builddir% pushd %builddir%\ -cmake -G %generator% -A

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r678898892 ## File path: libminifi/include/core/ObjectFactory.h ## @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r678898651 ## File path: libminifi/src/utils/file/FileMatcher.cpp ## @@ -0,0 +1,273 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-07-29 Thread GitBox
adamdebreceni commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r678893397 ## File path: win_build_vs.bat ## @@ -65,7 +65,7 @@ for %%x in (%*) do ( mkdir %builddir% pushd %builddir%\ -cmake -G %generator% -A