[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1166271912 ## libminifi/include/core/PropertyValidation.h: ## @@ -87,22 +83,23 @@ class ValidationResult { class PropertyValidator { public: -

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7173: NIFI-11439 - correct provenance reporting parameter

2023-04-13 Thread via GitHub
exceptionfactory commented on code in PR #7173: URL: https://github.com/apache/nifi/pull/7173#discussion_r1166213682 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/FetchGCSObject.java: ## @@ -273,7 +275,15 @@ public

[GitHub] [nifi] greyp9 opened a new pull request, #7173: NIFI-11439 - correct provenance reporting parameter

2023-04-13 Thread via GitHub
greyp9 opened a new pull request, #7173: URL: https://github.com/apache/nifi/pull/7173 In previous PR, missed adjustment of URL supplied to provenance reporting subsystem. # Summary [NIFI-11439](https://issues.apache.org/jira/browse/NIFI-11439) # Tracking Please

[jira] [Updated] (NIFI-11449) add autocommit property to PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdelrahim Ahmad updated NIFI-11449: Summary: add autocommit property to PutDatabaseRecord processor (was: add autocommit

[jira] [Updated] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdelrahim Ahmad updated NIFI-11449: Description: The issue is with the {{PutDatabaseRecord}} processor in Apache NiFi. When

[jira] [Updated] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdelrahim Ahmad updated NIFI-11449: Description: The issue is with the {{PutDatabaseRecord}} processor in Apache NiFi. When

[jira] [Updated] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdelrahim Ahmad updated NIFI-11449: Description: The issue is with the {{PutDatabaseRecord}} processor in Apache NiFi. When

[jira] [Commented] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712091#comment-17712091 ] Abdelrahim Ahmad commented on NIFI-11449: - Improving this process will allow Nifi to be the main

[jira] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11449 ] Abdelrahim Ahmad deleted comment on NIFI-11449: - was (Author: abdelrahimk): Improving this process will allow Nifi to be the main tool to ingest data into these new Technologies. So we

[jira] [Created] (NIFI-11449) add autocommit property to control commit in PutDatabaseRecord processor

2023-04-13 Thread Abdelrahim Ahmad (Jira)
Abdelrahim Ahmad created NIFI-11449: --- Summary: add autocommit property to control commit in PutDatabaseRecord processor Key: NIFI-11449 URL: https://issues.apache.org/jira/browse/NIFI-11449

[GitHub] [nifi] exceptionfactory commented on pull request #7170: NIFI-11440: Speed up Hive Metastore based unit tests

2023-04-13 Thread via GitHub
exceptionfactory commented on PR #7170: URL: https://github.com/apache/nifi/pull/7170#issuecomment-1507581057 > I would advise not to waste any time bothering with these tests on Windows. I'd just detect running on windows and ignore them. I concur, the tests are already disabled on

[GitHub] [nifi] joewitt commented on pull request #7170: NIFI-11440: Speed up Hive Metastore based unit tests

2023-04-13 Thread via GitHub
joewitt commented on PR #7170: URL: https://github.com/apache/nifi/pull/7170#issuecomment-1507577479 I would advise not to waste any time bothering with these tests on Windows. I'd just detect running on windows and ignore them. -- This is an automated message from the Apache Git

[GitHub] [nifi] abdelrahim-ahmad commented on pull request #5554: NIFI-8605 Adding a new property to enable/disable auto committing

2023-04-13 Thread via GitHub
abdelrahim-ahmad commented on PR #5554: URL: https://github.com/apache/nifi/pull/5554#issuecomment-1507537242 Hi All, I would appreciate your kind help if anyone knows how to enable autocommit in the PutDatabaseRecord process in Nifi. I have tried to do this many ways but still not

[GitHub] [nifi] Lehel44 commented on a diff in pull request #7019: NIFI-11224: Refactor and FF attribute support in WHERE in QuerySalesf…

2023-04-13 Thread via GitHub
Lehel44 commented on code in PR #7019: URL: https://github.com/apache/nifi/pull/7019#discussion_r1165964062 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java: ## @@ -560,6 +566,27

[GitHub] [nifi] Lehel44 commented on a diff in pull request #7019: NIFI-11224: Refactor and FF attribute support in WHERE in QuerySalesf…

2023-04-13 Thread via GitHub
Lehel44 commented on code in PR #7019: URL: https://github.com/apache/nifi/pull/7019#discussion_r1165955781 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java: ## @@ -102,11

[jira] [Commented] (NIFI-11439) Add Storage API URL to GCS Processors

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712040#comment-17712040 ] ASF subversion and git services commented on NIFI-11439: Commit

[jira] [Commented] (NIFI-11439) Add Storage API URL to GCS Processors

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712041#comment-17712041 ] ASF subversion and git services commented on NIFI-11439: Commit

[jira] [Updated] (NIFI-11439) GCS processors: add ability to configure custom GCS client endpoint

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11439: Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed Status:

[jira] [Updated] (NIFI-11439) Add Storage API URL to GCS Processors

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11439: Summary: Add Storage API URL to GCS Processors (was: GCS processors: add ability to

[jira] [Commented] (NIFI-11439) GCS processors: add ability to configure custom GCS client endpoint

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712031#comment-17712031 ] ASF subversion and git services commented on NIFI-11439: Commit

[jira] [Commented] (NIFI-11439) GCS processors: add ability to configure custom GCS client endpoint

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712028#comment-17712028 ] ASF subversion and git services commented on NIFI-11439: Commit

[GitHub] [nifi] exceptionfactory closed pull request #7172: NIFI-11439 - GCS processors; expose config of custom client endpoint

2023-04-13 Thread via GitHub
exceptionfactory closed pull request #7172: NIFI-11439 - GCS processors; expose config of custom client endpoint URL: https://github.com/apache/nifi/pull/7172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] Lehel44 commented on pull request #7082: NIFI-11067: Clear property history when set sensitive

2023-04-13 Thread via GitHub
Lehel44 commented on PR #7082: URL: https://github.com/apache/nifi/pull/7082#issuecomment-1507456370 Thanks for the review @exceptionfactory. I added the change to ReportingTasks and ControllerServices and did some runtime testing. -- This is an automated message from the Apache Git

[GitHub] [nifi] markap14 commented on a diff in pull request #7003: NIFI-11241: Initial implementation of Python-based Processor API with…

2023-04-13 Thread via GitHub
markap14 commented on code in PR #7003: URL: https://github.com/apache/nifi/pull/7003#discussion_r1165569083 ## nifi-nar-bundles/nifi-py4j-bundle/nifi-python-framework/src/main/python/framework/ExtensionManager.py: ## @@ -0,0 +1,531 @@ +# Licensed to the Apache Software

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7124: NIFI-11385 Expose JMX metrics from NiFi JVM

2023-04-13 Thread via GitHub
exceptionfactory commented on code in PR #7124: URL: https://github.com/apache/nifi/pull/7124#discussion_r1165799800 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/JmxMetricsResource.java: ## @@ -0,0 +1,129

[jira] [Resolved] (NIFI-11233) adjust Github runner configuration to use HTTP connection pooling

2023-04-13 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey resolved NIFI-11233. -- Resolution: Duplicate > adjust Github runner configuration to use HTTP connection pooling >

[jira] [Updated] (NIFI-11437) Improve EncryptContentPGP Content Type Detection

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11437: Fix Version/s: 2.0.0 1.22.0 (was: 1.latest)

[jira] [Commented] (NIFI-11437) Improve EncryptContentPGP Content Type Detection

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711973#comment-17711973 ] ASF subversion and git services commented on NIFI-11437: Commit

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1557: MINIFICPP-2099 Only run tests requiring test processors if they are available

2023-04-13 Thread via GitHub
lordgamez opened a new pull request, #1557: URL: https://github.com/apache/nifi-minifi-cpp/pull/1557 https://issues.apache.org/jira/browse/MINIFICPP-2099 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7172: NIFI-11439 - GCS processors; expose config of custom client endpoint

2023-04-13 Thread via GitHub
exceptionfactory commented on code in PR #7172: URL: https://github.com/apache/nifi/pull/7172#discussion_r1165758118 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/DeleteGCSObject.java: ## @@ -81,6 +81,7 @@ public

[jira] [Created] (MINIFICPP-2099) Only run docker tests requiring test processors if they are available

2023-04-13 Thread Jira
Gábor Gyimesi created MINIFICPP-2099: Summary: Only run docker tests requiring test processors if they are available Key: MINIFICPP-2099 URL: https://issues.apache.org/jira/browse/MINIFICPP-2099

[jira] [Commented] (NIFI-11437) Improve EncryptContentPGP Content Type Detection

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711969#comment-17711969 ] ASF subversion and git services commented on NIFI-11437: Commit

[GitHub] [nifi] greyp9 closed pull request #7166: NIFI-11437 Improve EncryptContentPGP Content Type Detection

2023-04-13 Thread via GitHub
greyp9 closed pull request #7166: NIFI-11437 Improve EncryptContentPGP Content Type Detection URL: https://github.com/apache/nifi/pull/7166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711965#comment-17711965 ] macdoor615 commented on NIFI-11409: --- [~exceptionfactory] Thank you for your suggestion. Translating a

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165733292 ## libminifi/include/core/PropertyValidation.h: ## @@ -87,22 +83,23 @@ class ValidationResult { class PropertyValidator { public: -

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711949#comment-17711949 ] David Handermann commented on NIFI-11409: - Thanks for the diagram [~macdoor615], that is very

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711948#comment-17711948 ] macdoor615 commented on NIFI-11409: --- [~exceptionfactory] Unfortunately, my problem has not been solved

[jira] [Updated] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] macdoor615 updated NIFI-11409: -- Attachment: macdoor network topology.png > OIDC Token Revocation Error on Logout >

[GitHub] [nifi] exceptionfactory commented on pull request #7171: NIFI-11441 Removed OpenCypher client service because the core depende…

2023-04-13 Thread via GitHub
exceptionfactory commented on PR #7171: URL: https://github.com/apache/nifi/pull/7171#issuecomment-1507145124 Thanks for getting this started @MikeThomsen. It looks like there are still tests that need to be deleted as part of this PR. -- This is an automated message from the Apache Git

[jira] [Updated] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] macdoor615 updated NIFI-11409: -- Attachment: (was: macdoor network topology.png) > OIDC Token Revocation Error on Logout >

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1552: MINIFICPP-2089 prefix EventData in flat JSON output so it doesnt need t…

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1552: URL: https://github.com/apache/nifi-minifi-cpp/pull/1552#discussion_r1165654617 ## extensions/windows-event-log/wel/JSONUtils.cpp: ## @@ -135,28 +157,37 @@ rapidjson::Document toJSONImpl(const pugi::xml_node& root, bool flatten) {

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1552: MINIFICPP-2089 prefix EventData in flat JSON output so it doesnt need t…

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1552: URL: https://github.com/apache/nifi-minifi-cpp/pull/1552#discussion_r1165654617 ## extensions/windows-event-log/wel/JSONUtils.cpp: ## @@ -135,28 +157,37 @@ rapidjson::Document toJSONImpl(const pugi::xml_node& root, bool flatten) {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
adamdebreceni commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165631311 ## libminifi/include/core/PropertyValidation.h: ## @@ -87,22 +83,23 @@ class ValidationResult { class PropertyValidator { public: -

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
adamdebreceni commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165627512 ## libminifi/include/core/PropertyValidation.h: ## @@ -87,22 +83,23 @@ class ValidationResult { class PropertyValidator { public: -

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165621722 ## .github/workflows/ci.yml: ## @@ -302,13 +306,132 @@ jobs: if [ -d ~/.ccache ]; then mv ~/.ccache .; fi mkdir build cd

[jira] [Updated] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] macdoor615 updated NIFI-11409: -- Attachment: macdoor network topology.png > OIDC Token Revocation Error on Logout >

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1551: URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1165618648 ## docker/test/integration/resources/kafka_broker/conf/server.properties: ## @@ -28,15 +28,15 @@ broker.id=0 # listeners =

[jira] [Updated] (NIFI-11439) GCS processors: add ability to configure custom GCS client endpoint

2023-04-13 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-11439: - Status: Patch Available (was: In Progress) > GCS processors: add ability to configure custom GCS client

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711919#comment-17711919 ] David Handermann commented on NIFI-11409: - Thanks for the reply [~macdoor615]. Changing the NiFi

[GitHub] [nifi] greyp9 opened a new pull request, #7172: NIFI-11439 - GCS processors; expose config of custom client endpoint

2023-04-13 Thread via GitHub
greyp9 opened a new pull request, #7172: URL: https://github.com/apache/nifi/pull/7172 # Summary [NIFI-11439](https://issues.apache.org/jira/browse/NIFI-11439) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
adamdebreceni commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165598645 ## .github/workflows/ci.yml: ## @@ -302,13 +306,132 @@ jobs: if [ -d ~/.ccache ]; then mv ~/.ccache .; fi mkdir build cd

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165592135 ## extensions/aws/CMakeLists.txt: ## @@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES}) target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI}

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165592135 ## extensions/aws/CMakeLists.txt: ## @@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES}) target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI}

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711905#comment-17711905 ] macdoor615 commented on NIFI-11409: --- [~exceptionfactory] You are right. The current implementation of

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1551: URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1165563766 ## docker/test/integration/resources/kafka_broker/conf/server.properties: ## @@ -28,15 +28,15 @@ broker.id=0 # listeners = listener_name://host_name:port

[GitHub] [nifi] markap14 commented on a diff in pull request #7003: NIFI-11241: Initial implementation of Python-based Processor API with…

2023-04-13 Thread via GitHub
markap14 commented on code in PR #7003: URL: https://github.com/apache/nifi/pull/7003#discussion_r1165569083 ## nifi-nar-bundles/nifi-py4j-bundle/nifi-python-framework/src/main/python/framework/ExtensionManager.py: ## @@ -0,0 +1,531 @@ +# Licensed to the Apache Software

[GitHub] [nifi] markap14 commented on pull request #7003: NIFI-11241: Initial implementation of Python-based Processor API with…

2023-04-13 Thread via GitHub
markap14 commented on PR #7003: URL: https://github.com/apache/nifi/pull/7003#issuecomment-1507012164 Thanks for the thorough review @exceptionfactory . I've pushed a couple new commits that should address the concerns raised (except for the few that I responded to directly). Or I created

[GitHub] [nifi] markap14 commented on a diff in pull request #7003: NIFI-11241: Initial implementation of Python-based Processor API with…

2023-04-13 Thread via GitHub
markap14 commented on code in PR #7003: URL: https://github.com/apache/nifi/pull/7003#discussion_r1165547987 ## nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/main/java/org/apache/nifi/py4j/PythonProcess.java: ## @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (NIFI-11448) Speed up process of adding a Python Processor

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11448: - Summary: Speed up process of adding a Python Processor Key: NIFI-11448 URL: https://issues.apache.org/jira/browse/NIFI-11448 Project: Apache NiFi Issue Type:

[jira] [Created] (NIFI-11447) Improve performance for TransformRecord implementations

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11447: - Summary: Improve performance for TransformRecord implementations Key: NIFI-11447 URL: https://issues.apache.org/jira/browse/NIFI-11447 Project: Apache NiFi Issue

[jira] [Created] (NIFI-11446) Better handling for cases where Python process dies

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11446: - Summary: Better handling for cases where Python process dies Key: NIFI-11446 URL: https://issues.apache.org/jira/browse/NIFI-11446 Project: Apache NiFi Issue

[jira] [Created] (NIFI-11445) Support packaging of Python processors

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11445: - Summary: Support packaging of Python processors Key: NIFI-11445 URL: https://issues.apache.org/jira/browse/NIFI-11445 Project: Apache NiFi Issue Type: Sub-task

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711887#comment-17711887 ] David Handermann commented on NIFI-11409: - [~macdoor615]  Although it is possible to think of

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165532281 ## extensions/aws/CMakeLists.txt: ## @@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES}) target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI}

[jira] [Created] (NIFI-11444) Improve FlowFileTransform to allow returning a String for the content instead of byte[]

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11444: - Summary: Improve FlowFileTransform to allow returning a String for the content instead of byte[] Key: NIFI-11444 URL: https://issues.apache.org/jira/browse/NIFI-11444

[jira] [Created] (NIFI-11443) Setup proper logging for Python framework

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11443: - Summary: Setup proper logging for Python framework Key: NIFI-11443 URL: https://issues.apache.org/jira/browse/NIFI-11443 Project: Apache NiFi Issue Type: Sub-task

[jira] [Created] (NIFI-11442) Add docs to explain how to use Controller Services from Python Processors

2023-04-13 Thread Mark Payne (Jira)
Mark Payne created NIFI-11442: - Summary: Add docs to explain how to use Controller Services from Python Processors Key: NIFI-11442 URL: https://issues.apache.org/jira/browse/NIFI-11442 Project: Apache

[GitHub] [nifi] MikeThomsen opened a new pull request, #7171: NIFI-11441 Removed OpenCypher client service because the core depende…

2023-04-13 Thread via GitHub
MikeThomsen opened a new pull request, #7171: URL: https://github.com/apache/nifi/pull/7171 …ncy appears to be unsupported for quite some time. # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) #

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165506164 ## .github/workflows/ci.yml: ## Review Comment: @martinzink all right, I'm okay with that @szaszm unfortunately that will not work due to the

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165478090 ## .github/workflows/ci.yml: ## Review Comment: In the meantime, maybe we could do something like this: ``` make docker-verify-q1 & make

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #761: MINIFICPP-1008 - Chunkio integration into nanofi

2023-04-13 Thread via GitHub
martinzink commented on PR #761: URL: https://github.com/apache/nifi-minifi-cpp/pull/761#issuecomment-1506901910 I'm closing this due to inactivity and nanofi is already kinda deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #761: MINIFICPP-1008 - Chunkio integration into nanofi

2023-04-13 Thread via GitHub
martinzink closed pull request #761: MINIFICPP-1008 - Chunkio integration into nanofi URL: https://github.com/apache/nifi-minifi-cpp/pull/761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (NIFI-11441) Remove OpenCypher client service from the graph bundle

2023-04-13 Thread Mike Thomsen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-11441: Description: The core dependency from the OpenCypher project has not been updated since 2019 and

[jira] [Created] (NIFI-11441) Remove OpenCypher client service from the graph bundle

2023-04-13 Thread Mike Thomsen (Jira)
Mike Thomsen created NIFI-11441: --- Summary: Remove OpenCypher client service from the graph bundle Key: NIFI-11441 URL: https://issues.apache.org/jira/browse/NIFI-11441 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165458301 ## .github/workflows/ci.yml: ## Review Comment: Besides the reruns, since the download/upload artifact overhead is minimal separating them vs keeping

[jira] [Updated] (NIFI-11429) Upgrade Gremlin to 3.6.2

2023-04-13 Thread Mike Thomsen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-11429: Fix Version/s: 1.latest 2.latest Resolution: Fixed Status:

[jira] [Commented] (NIFI-11429) Upgrade Gremlin to 3.6.2

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711870#comment-17711870 ] ASF subversion and git services commented on NIFI-11429: Commit

[jira] [Commented] (NIFI-11429) Upgrade Gremlin to 3.6.2

2023-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711869#comment-17711869 ] ASF subversion and git services commented on NIFI-11429: Commit

[GitHub] [nifi] asfgit closed pull request #7160: NIFI-11429 - Upgrade Gremlin to 3.6.2

2023-04-13 Thread via GitHub
asfgit closed pull request #7160: NIFI-11429 - Upgrade Gremlin to 3.6.2 URL: https://github.com/apache/nifi/pull/7160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1165408681 ## controller/MiNiFiController.cpp: ## @@ -75,33 +80,60 @@ int main(int argc, char **argv) { secure_context =

[GitHub] [nifi] MikeThomsen commented on pull request #7160: NIFI-11429 - Upgrade Gremlin to 3.6.2

2023-04-13 Thread via GitHub
MikeThomsen commented on PR #7160: URL: https://github.com/apache/nifi/pull/7160#issuecomment-1506779850 @exceptionfactory the other graph services module needs to be reexamined because its main selling point was OpenCypher support, and I'm not sure what level of support that has today.

[GitHub] [nifi] mark-bathori opened a new pull request, #7170: NIFI-11440: Speed up Hive Metastore based unit tests

2023-04-13 Thread via GitHub
mark-bathori opened a new pull request, #7170: URL: https://github.com/apache/nifi/pull/7170 # Summary [NIFI-11440](https://issues.apache.org/jira/browse/NIFI-11440) # Tracking Please complete the following tracking

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1508: MINIFICPP-2040 - Avoid deserializing flow files just to be deleted

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1508: URL: https://github.com/apache/nifi-minifi-cpp/pull/1508#discussion_r1165298009 ## extensions/rocksdb-repos/FlowFileRepository.cpp: ## @@ -41,52 +41,70 @@ void FlowFileRepository::flush() { return; } auto batch =

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1165289303 ## controller/tests/ControllerTests.cpp: ## @@ -0,0 +1,545 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Created] (NIFI-11440) Speed up Hive Metastore based unit tests

2023-04-13 Thread Mark Bathori (Jira)
Mark Bathori created NIFI-11440: --- Summary: Speed up Hive Metastore based unit tests Key: NIFI-11440 URL: https://issues.apache.org/jira/browse/NIFI-11440 Project: Apache NiFi Issue Type:

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165231758 ## .github/workflows/ci.yml: ## Review Comment: I think it's good to separate the test jobs and the build jobs and it would be cool to have that for

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165217460 ## .github/workflows/ci.yml: ## Review Comment: There is already a ticket for running tests in parallel, but as Martin mentioned it requires larger

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165209315 ## extensions/aws/CMakeLists.txt: ## Review Comment: Restricted linkage and removed test workaround in 3ad1d51a4b678eed4550251c33f5a0a62d19d524 --

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165182366 ## extensions/aws/CMakeLists.txt: ## Review Comment: I think something like ``` if (CMAKE_SYSTEM_PROCESSOR MATCHES "(aarch64)|(arm64)")

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165139414 ## extensions/aws/CMakeLists.txt: ## Review Comment: Can we restrict the "wholearchive" linkage to ARM64? -- This is an automated message from the

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165135660 ## extensions/aws/CMakeLists.txt: ## Review Comment: Now with this fix, it seems we can remove the workarounds I've included in MINIFICPP-2048 that

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1555: URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1165117425 ## extensions/script/CMakeLists.txt: ## Review Comment: I have created Jira https://issues.apache.org/jira/browse/MINIFICPP-2098 as a follow-up. --

[jira] [Created] (MINIFICPP-2098) ENABLE_ALL should enable (almost) all extensions

2023-04-13 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-2098: - Summary: ENABLE_ALL should enable (almost) all extensions Key: MINIFICPP-2098 URL: https://issues.apache.org/jira/browse/MINIFICPP-2098 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165098428 ## libminifi/include/core/Property.h: ## @@ -96,7 +96,7 @@ class Property { std::string getDisplayName() const; std::vector getAllowedTypes() const;

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1553: URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1165098248 ## libminifi/include/core/CachedValueValidator.h: ## @@ -67,29 +67,21 @@ class CachedValueValidator { return *this; } - explicit

[GitHub] [nifi] arkadius opened a new pull request, #7169: NIFI-8161 NiFi EL: migration from SimpleDateFormat to DateTimeFormatter: rebased to 2.0

2023-04-13 Thread via GitHub
arkadius opened a new pull request, #7169: URL: https://github.com/apache/nifi/pull/7169 # Summary Optimization improvement: Migrates NiFi Expression Language from SimpleDateFormat to DateTimeFormatter

[jira] [Commented] (NIFI-11409) OIDC Token Revocation Error on Logout

2023-04-13 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711715#comment-17711715 ] macdoor615 commented on NIFI-11409: --- [~exceptionfactory]  You said "As the client, NiFi needs to call

[jira] [Assigned] (MINIFICPP-2081) CWEL saved logs support

2023-04-13 Thread Adam Debreceni (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni reassigned MINIFICPP-2081: - Assignee: Adam Debreceni > CWEL saved logs support >

[jira] [Resolved] (NIFI-10353) ConsumeAzureEventHub does not stop even though output queue is backpressured

2023-04-13 Thread Peter Schmitzer (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Schmitzer resolved NIFI-10353. Resolution: Workaround remove eventhub processor and use standard kafka consumer instead

[jira] [Commented] (NIFI-10353) ConsumeAzureEventHub does not stop even though output queue is backpressured

2023-04-13 Thread Peter Schmitzer (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711708#comment-17711708 ] Peter Schmitzer commented on NIFI-10353: Update from our side: Azure eventhub supports connecting

  1   2   >