[jira] [Updated] (NIFI-8932) Add feature to CSVReader to skip N lines at top of the file
[
https://issues.apache.org/jira/browse/NIFI-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8932:
---
Summary: Add feature to CSVReader to skip N lines at top of the file (was:
Add feature to CSVReader to skip N lines at top/bottom of the file)
> Add feature to CSVReader to skip N lines at top of the file
> ---
>
> Key: NIFI-8932
> URL: https://issues.apache.org/jira/browse/NIFI-8932
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Philipp Korniets
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
>
> We have a lot of CSV files where provider add custom header/footer to valid
> CSV content.
> CSV header is actually second row.
> To remove unnecessary data we can use
> * ReplaceText
> * splitText->RouteOnAttribute -> MergeContent
> It would be great to have an option in CSVReader controller to skip N rows
> from top/bottom in order to get5 clean data.
> * skip N from the top
> * skip M from the bottom
> Similar request was developed in FLINK
> https://issues.apache.org/jira/browse/FLINK-1002
>
> Data Example:
> {code}
> 7/20/21 2:48:47 AM GMT-04:00 ABB: Blended Rate Calc (X),,,
> distribution_id,Distribution
> Id,settle_date,group_code,company_name,currency_code,common_account_name,business_date,prod_code,security,class,asset_type
> -1,all,20210719,Repo 21025226,qwerty
> ,EUR,TPSL_21025226 ,19-Jul-21,BRM96ST7 ,ABC
> 14/09/24,NR,BOND
> -1,all,20210719,Repo 21025226,qwerty
> ,GBP,RPSS_21025226 ,19-Jul-21,,Total @ -0.11,,
> {code}
> |7/20/21 2:48:47 AM GMT-04:00 ABB: Blended Rate Calc (X)| | | | | | |
> | | | | |
> |distribution_id|Distribution
> Id|settle_date|group_code|company_name|currency_code|common_account_name|business_date|prod_code|security|class|asset_type|
> |-1|all|20210719|Repo 21025226|qwerty
> |EUR|TPSL_21025226 |19-Jul-21|BRM96ST7 |ABC
> 14/09/24|NR|BOND |
> |-1|all|20210719|Repo 21025226|qwerty
> |GBP|RPSS_21025226 |19-Jul-21| |Total @ -0.11| | |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12290) Move from Quartz to Spring Cron Expression
[
https://issues.apache.org/jira/browse/NIFI-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12290:
Status: Patch Available (was: Open)
> Move from Quartz to Spring Cron Expression
> --
>
> Key: NIFI-12290
> URL: https://issues.apache.org/jira/browse/NIFI-12290
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Quartz library supports [cron|https://en.wikipedia.org/wiki/Cron]
> expression parsing to enable framework component scheduling using the Cron
> strategy.
> The Quartz library includes several legacy dependencies on HikariCP and C3P0
> which are not necessary for framework operations. The Quartz library also
> relies on {{java.util.Date}} for calculation, as opposed to {{java.time}}
> components.
> Spring Framework 5.3 introduced new [Cron Expression
> capabilities|https://spring.io/blog/2020/11/10/new-in-spring-5-3-improved-cron-expressions]
> that provide standard compatibility with [Cron scheduling
> expressions|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html].
> The Spring CronExpression supports standard {{java.time}} classes.
> The Spring
> [CronExpression|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html]
> has two differences from the Quartz implementation:
> 1. The Year field is not supported
> 2. The numeric day of the week representation begins with 0 instead of 1
> These differences follow the capabilities of the standard Unix crontab, and
> are not commonly used. However, these differences could invalidate custom
> scheduling configurations that used numeric day of the week or year values.
> Based on existing NiFI framework use of Spring, Quartz should be replaced
> with Spring Cron Expression parsing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12290 Migrate from Quartz to Spring for Cron Expressions [nifi]
exceptionfactory opened a new pull request, #7951: URL: https://github.com/apache/nifi/pull/7951 # Summary [NIFI-12290](https://issues.apache.org/jira/browse/NIFI-12290) Migrates from Quartz to Spring Framework [CronExpression](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html) for Cron scheduling of components. The Quartz library relies on `java.util.Date` and has several legacy dependencies including HikariCP and C3P0 which are not necessary for project operations. The Spring Framework 5.3 [introduced new Cron Expression](https://spring.io/blog/2020/11/10/new-in-spring-5-3-improved-cron-expressions) capabilities based on `java.time` classes that follow standard Unix crontab conventions. The differences from Quartz are minimal, but include the removal of the optional Year field, and the change from 1-7 to 0-7 for numeric Day of Week references. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9458) Refactor NiFi to use Java 8 Time classes
[ https://issues.apache.org/jira/browse/NIFI-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9458: --- Epic Name: Refactor Date and Time Handling (was: Date/Time handling in NiFi) > Refactor NiFi to use Java 8 Time classes > > > Key: NIFI-9458 > URL: https://issues.apache.org/jira/browse/NIFI-9458 > Project: Apache NiFi > Issue Type: Epic > Components: Core Framework, Extensions >Reporter: Pierre Villard >Priority: Major > > In order to support microseconds or even nanoseconds in NiFi, we should > consider refactoring NiFi code to leverage Java 8 Time classes. This is going > to be a significant amount of work so creating this epic to breakdown the > work into smaller pieces. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12290) Move from Quartz to Spring Cron Expression
David Handermann created NIFI-12290:
---
Summary: Move from Quartz to Spring Cron Expression
Key: NIFI-12290
URL: https://issues.apache.org/jira/browse/NIFI-12290
Project: Apache NiFi
Issue Type: Improvement
Components: Core Framework
Reporter: David Handermann
Assignee: David Handermann
Fix For: 2.latest
The Quartz library supports [cron|https://en.wikipedia.org/wiki/Cron]
expression parsing to enable framework component scheduling using the Cron
strategy.
The Quartz library includes several legacy dependencies on HikariCP and C3P0
which are not necessary for framework operations. The Quartz library also
relies on {{java.util.Date}} for calculation, as opposed to {{java.time}}
components.
Spring Framework 5.3 introduced new [Cron Expression
capabilities|https://spring.io/blog/2020/11/10/new-in-spring-5-3-improved-cron-expressions]
that provide standard compatibility with [Cron scheduling
expressions|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html].
The Spring CronExpression supports standard {{java.time}} classes.
The Spring
[CronExpression|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html]
has two differences from the Quartz implementation:
1. The Year field is not supported
2. The numeric day of the week representation begins with 0 instead of 1
These differences follow the capabilities of the standard Unix crontab, and are
not commonly used. However, these differences could invalidate custom
scheduling configurations that used numeric day of the week or year values.
Based on existing NiFI framework use of Spring, Quartz should be replaced with
Spring Cron Expression parsing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12265) EncryptContentPGP cannot search subkey with keyID start with zero
[ https://issues.apache.org/jira/browse/NIFI-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12265: Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed Status: Resolved (was: Patch Available) > EncryptContentPGP cannot search subkey with keyID start with zero > - > > Key: NIFI-12265 > URL: https://issues.apache.org/jira/browse/NIFI-12265 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Tan Luu >Assignee: Tan Luu >Priority: Major > Labels: pull-request-available > Fix For: 2.0.0, 1.24.0 > > Attachments: testpublic.key > > Time Spent: 0.5h > Remaining Estimate: 0h > > If the PGP public key has subkey with keyID starting with zero e.g. > 0DD090CBF6ED38B7, EncryptContentPGP key search returns "not found" for that > subkey if it is specified in the "Public Key Search" field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12265) EncryptContentPGP cannot search subkey with keyID start with zero
[ https://issues.apache.org/jira/browse/NIFI-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780655#comment-17780655 ] ASF subversion and git services commented on NIFI-12265: Commit ead1c235ad0e2d662624dd84fd4a69eb5a0e76b8 in nifi's branch refs/heads/support/nifi-1.x from nathluu [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ead1c235ad ] NIFI-12265 Fixed OpenPGP Hexadecimal Key Formatting with leading 0 - Replaced Long.toHexString() with String.format() using pattern with leading 0 This closes #7926 Signed-off-by: David Handermann (cherry picked from commit 8e301cfdef37004a9cf3c7a8c47f4932dc090375) > EncryptContentPGP cannot search subkey with keyID start with zero > - > > Key: NIFI-12265 > URL: https://issues.apache.org/jira/browse/NIFI-12265 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Tan Luu >Assignee: Tan Luu >Priority: Major > Labels: pull-request-available > Attachments: testpublic.key > > Time Spent: 0.5h > Remaining Estimate: 0h > > If the PGP public key has subkey with keyID starting with zero e.g. > 0DD090CBF6ED38B7, EncryptContentPGP key search returns "not found" for that > subkey if it is specified in the "Public Key Search" field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12265) EncryptContentPGP cannot search subkey with keyID start with zero
[ https://issues.apache.org/jira/browse/NIFI-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780654#comment-17780654 ] ASF subversion and git services commented on NIFI-12265: Commit 8e301cfdef37004a9cf3c7a8c47f4932dc090375 in nifi's branch refs/heads/main from nathluu [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8e301cfdef ] NIFI-12265 Fixed OpenPGP Hexadecimal Key Formatting with leading 0 - Replaced Long.toHexString() with String.format() using pattern with leading 0 This closes #7926 Signed-off-by: David Handermann > EncryptContentPGP cannot search subkey with keyID start with zero > - > > Key: NIFI-12265 > URL: https://issues.apache.org/jira/browse/NIFI-12265 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Tan Luu >Assignee: Tan Luu >Priority: Major > Labels: pull-request-available > Attachments: testpublic.key > > Time Spent: 20m > Remaining Estimate: 0h > > If the PGP public key has subkey with keyID starting with zero e.g. > 0DD090CBF6ED38B7, EncryptContentPGP key search returns "not found" for that > subkey if it is specified in the "Public Key Search" field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12265 Fix StandardPGPPublicKeyService key search issue with subkey starts with 0 [nifi]
exceptionfactory closed pull request #7926: NIFI-12265 Fix StandardPGPPublicKeyService key search issue with subkey starts with 0 URL: https://github.com/apache/nifi/pull/7926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12249) FetchSFTP needs failure attributes
[ https://issues.apache.org/jira/browse/NIFI-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12249: Affects Version/s: (was: 2.0.0) > FetchSFTP needs failure attributes > -- > > Key: NIFI-12249 > URL: https://issues.apache.org/jira/browse/NIFI-12249 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Anna Nys >Assignee: Anna Nys >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > The FetchSFTP processor has several failure relationships: > comms.failure > not.found > permission.denied > While these relationships can help route files that fail for different > reasons, it would be helpful to have the failure reason written to a flowfile > attribute, so that the reason can be automatically included in an automated > notification message. > The value of the flowfile attribute could be used in an UpdateAttribute > advanced rules to generate error-specific email notifications to the > customer. Otherwise, we need separate processors for each failure > relationship. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12249) FetchSFTP needs failure attributes
[ https://issues.apache.org/jira/browse/NIFI-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780640#comment-17780640 ] ASF subversion and git services commented on NIFI-12249: Commit 0bdc392462a37c99028fe302d5566bfb2691f39c in nifi's branch refs/heads/support/nifi-1.x from annanys23 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0bdc392462 ] NIFI-12249 FetchFTP and FetchSFTP set fetch.failure.reason on failures - Set fetch.failure.reason to relationship name when routing to failure relationships This closes #7929 Signed-off-by: David Handermann (cherry picked from commit 90498a352d059376b96630c1c3f1136313999d17) > FetchSFTP needs failure attributes > -- > > Key: NIFI-12249 > URL: https://issues.apache.org/jira/browse/NIFI-12249 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Anna Nys >Assignee: Anna Nys >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > The FetchSFTP processor has several failure relationships: > comms.failure > not.found > permission.denied > While these relationships can help route files that fail for different > reasons, it would be helpful to have the failure reason written to a flowfile > attribute, so that the reason can be automatically included in an automated > notification message. > The value of the flowfile attribute could be used in an UpdateAttribute > advanced rules to generate error-specific email notifications to the > customer. Otherwise, we need separate processors for each failure > relationship. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12249) FetchSFTP and FetchFTP should set failure reason attribute
[ https://issues.apache.org/jira/browse/NIFI-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12249: Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed Status: Resolved (was: Patch Available) > FetchSFTP and FetchFTP should set failure reason attribute > -- > > Key: NIFI-12249 > URL: https://issues.apache.org/jira/browse/NIFI-12249 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Anna Nys >Assignee: Anna Nys >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The FetchSFTP processor has several failure relationships: > comms.failure > not.found > permission.denied > While these relationships can help route files that fail for different > reasons, it would be helpful to have the failure reason written to a flowfile > attribute, so that the reason can be automatically included in an automated > notification message. > The value of the flowfile attribute could be used in an UpdateAttribute > advanced rules to generate error-specific email notifications to the > customer. Otherwise, we need separate processors for each failure > relationship. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12249) FetchSFTP and FetchFTP should set failure reason attribute
[ https://issues.apache.org/jira/browse/NIFI-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12249: Summary: FetchSFTP and FetchFTP should set failure reason attribute (was: FetchSFTP needs failure attributes) > FetchSFTP and FetchFTP should set failure reason attribute > -- > > Key: NIFI-12249 > URL: https://issues.apache.org/jira/browse/NIFI-12249 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Anna Nys >Assignee: Anna Nys >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > The FetchSFTP processor has several failure relationships: > comms.failure > not.found > permission.denied > While these relationships can help route files that fail for different > reasons, it would be helpful to have the failure reason written to a flowfile > attribute, so that the reason can be automatically included in an automated > notification message. > The value of the flowfile attribute could be used in an UpdateAttribute > advanced rules to generate error-specific email notifications to the > customer. Otherwise, we need separate processors for each failure > relationship. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12249) FetchSFTP needs failure attributes
[ https://issues.apache.org/jira/browse/NIFI-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780639#comment-17780639 ] ASF subversion and git services commented on NIFI-12249: Commit 90498a352d059376b96630c1c3f1136313999d17 in nifi's branch refs/heads/main from annanys23 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=90498a352d ] NIFI-12249 FetchFTP and FetchSFTP set fetch.failure.reason on failures - Set fetch.failure.reason to relationship name when routing to failure relationships This closes #7929 Signed-off-by: David Handermann > FetchSFTP needs failure attributes > -- > > Key: NIFI-12249 > URL: https://issues.apache.org/jira/browse/NIFI-12249 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 2.0.0 >Reporter: Anna Nys >Assignee: Anna Nys >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > The FetchSFTP processor has several failure relationships: > comms.failure > not.found > permission.denied > While these relationships can help route files that fail for different > reasons, it would be helpful to have the failure reason written to a flowfile > attribute, so that the reason can be automatically included in an automated > notification message. > The value of the flowfile attribute could be used in an UpdateAttribute > advanced rules to generate error-specific email notifications to the > customer. Otherwise, we need separate processors for each failure > relationship. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12249 FetchFTP and FetchSFTP processors now write failure reason to 'failure' attribute [nifi]
exceptionfactory closed pull request #7929: NIFI-12249 FetchFTP and FetchSFTP processors now write failure reason to 'failure' attribute URL: https://github.com/apache/nifi/pull/7929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12288: Fix Version/s: 1.24.0 > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780637#comment-17780637 ] David Handermann commented on NIFI-12288: - Thanks [~joewitt], backported the changes to the support branch for 1.24.0, only minor generic typing adjustments required. > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780636#comment-17780636 ] ASF subversion and git services commented on NIFI-12288: Commit fa068945560df94676e57edc0a5210fb561963bc in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fa06894556 ] NIFI-12288 This closes #7950. Improved Long and Integer handling in Utilities - Added explicit round in FormatUtils.makeWholeNumberTime() - Removed unnecessary boxing in component descriptors - Maintained long number tracking for releasable counts in Wait and Notify Processors Signed-off-by: Joseph Witt (cherry picked from commit ae14738dead33ca20dc2e779f5157118ee2b228f) > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12288: Resolution: Fixed Status: Resolved (was: Patch Available) > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780634#comment-17780634 ] Joe Witt commented on NIFI-12288: - [~exceptionfactory]thanks! if this should also go on the 1.x line as implied can you please confirm that build works and self-merge off this +1. THanks > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12288: Fix Version/s: 2.0.0 (was: 1.latest) (was: 2.latest) > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12288 Improve Long and Integer handling in Utilities [nifi]
asfgit closed pull request #7950: NIFI-12288 Improve Long and Integer handling in Utilities URL: https://github.com/apache/nifi/pull/7950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12288) Improve Number Handling in Utilities
[ https://issues.apache.org/jira/browse/NIFI-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780633#comment-17780633 ] ASF subversion and git services commented on NIFI-12288: Commit ae14738dead33ca20dc2e779f5157118ee2b228f in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ae14738dea ] NIFI-12288 This closes #7950. Improved Long and Integer handling in Utilities - Added explicit round in FormatUtils.makeWholeNumberTime() - Removed unnecessary boxing in component descriptors - Maintained long number tracking for releasable counts in Wait and Notify Processors Signed-off-by: Joseph Witt > Improve Number Handling in Utilities > > > Key: NIFI-12288 > URL: https://issues.apache.org/jira/browse/NIFI-12288 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Several utilities and components, such as FormatUtils, as well as the Wait > and Notify Processors, include imprecise conversion between long and integer > numbers. These references should be updated to maintain the original typing > and use explicit methods when converting to integers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2260 Fix OpenCV extension build failure on macOS [nifi-minifi-cpp]
szaszm commented on code in PR #1694:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1694#discussion_r1375270870
##
extensions/opencv/CMakeLists.txt:
##
@@ -32,6 +32,10 @@ add_library(minifi-opencv SHARED ${SOURCES})
target_link_libraries(minifi-opencv ${LIBMINIFI})
target_link_libraries(minifi-opencv OPENCV::libopencv)
+if (APPLE)
+target_link_libraries(minifi-opencv "-framework AVFoundation" "-framework
CoreFoundation" "-framework CoreGraphics" "-framework CoreMedia" "-framework
CoreVideo" "-framework Foundation" "-framework OpenCL")
+target_link_libraries(minifi-opencv -llapack -lblas)
Review Comment:
Are these the dependencies of OpenCV itself? If so, it should be handled on
the OpenCV lib target. Ideally the OpenCV project itself would link these to
itself, or advertise them as required.
Also, why are two linear algebra libraries needed? As far as I understand,
they are similar and serve the same purpose, like yacc and bison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2260 Fix OpenCV extension build failure on macOS [nifi-minifi-cpp]
szaszm commented on code in PR #1694:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1694#discussion_r1375270870
##
extensions/opencv/CMakeLists.txt:
##
@@ -32,6 +32,10 @@ add_library(minifi-opencv SHARED ${SOURCES})
target_link_libraries(minifi-opencv ${LIBMINIFI})
target_link_libraries(minifi-opencv OPENCV::libopencv)
+if (APPLE)
+target_link_libraries(minifi-opencv "-framework AVFoundation" "-framework
CoreFoundation" "-framework CoreGraphics" "-framework CoreMedia" "-framework
CoreVideo" "-framework Foundation" "-framework OpenCL")
+target_link_libraries(minifi-opencv -llapack -lblas)
Review Comment:
Are these the dependencies of OpenCV itself? If so, it should be handled on
the OpenCV lib target. Ideally the OpenCV project itself would link these to
itself, or advertise them as required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12279) Add Standard Shared NAR to System Test Modules
[
https://issues.apache.org/jira/browse/NIFI-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780623#comment-17780623
]
ASF subversion and git services commented on NIFI-12279:
Commit 211a3aa7c4176a16c6dea3bfc1d5e0b2926ceb58 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=211a3aa7c4 ]
NIFI-12279 Added nifi-standard-shared-nar to Kafka Connector Tests
- Corrected integration-tests workflow failures
Signed-off-by: David Handermann
> Add Standard Shared NAR to System Test Modules
> --
>
> Key: NIFI-12279
> URL: https://issues.apache.org/jira/browse/NIFI-12279
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Blocker
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Recent changes introducing the {{nifi-standard-shared-nar}} did not include
> updating several system test modules, resulting in failures when running the
> PythonProcessorIT and Stateless CreateFlowFileIT. The Shared NAR needs to be
> added to the list of scoped dependencies for system tests to correct these
> test failures.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINIFICPP-2259) ProcessContext::getProperty should operate on raw pointers
[ https://issues.apache.org/jira/browse/MINIFICPP-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780613#comment-17780613 ] Marton Szasz commented on MINIFICPP-2259: - how about references instead? I don't think we need nullability > ProcessContext::getProperty should operate on raw pointers > -- > > Key: MINIFICPP-2259 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2259 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
