[jira] [Commented] (NIFI-11197) Add YAML Record Reader
[
https://issues.apache.org/jira/browse/NIFI-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788640#comment-17788640
]
macdoor615 commented on NIFI-11197:
---
[~gbc] Here is my groovy script
{code:java}
import org.apache.commons.io.IOUtils;
import java.nio.charset.StandardCharsets;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
def flowFile = session.get()
if (!flowFile) return
//def attributes = flowFile.getAttributes()
flowFile = session.write(flowFile, {inputStream, outputStream ->
//text = IOUtils.toString(inputStream, StandardCharsets.UTF_8)
try {
String contentYaml = IOUtils.toString(inputStream,
String.valueOf(StandardCharsets.UTF_8))
ObjectMapper yamlReader = new ObjectMapper(new YAMLFactory());
Object obj = yamlReader.readValue(contentYaml, Object.class);
ObjectMapper jsonWriter = new ObjectMapper();
String
contentJson=jsonWriter.writerWithDefaultPrettyPrinter().writeValueAsString(obj);
outputStream.write(contentJson.getBytes(StandardCharsets.UTF_8));
} catch(JsonProcessingException e){
flowFile = session.putAttribute(flowFile, 'yaml-error', "yaml format error")
session.transfer(flowFile, REL_FAILURE)
return;
}catch (Exception e){
flowFile = session.putAttribute(flowFile, 'yaml-error', "convert error")
session.transfer(flowFile, REL_FAILURE)
return;
}
} as StreamCallback)
session.transfer(flowFile, REL_SUCCESS)
{code}
> Add YAML Record Reader
> --
>
> Key: NIFI-11197
> URL: https://issues.apache.org/jira/browse/NIFI-11197
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.20.0
>Reporter: macdoor615
>Assignee: Daniel Stieglitz
>Priority: Major
> Fix For: 2.0.0-M1, 1.24.0
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> The yaml format is basically equivalent to json. When used as a configuration
> file, it is much more convenient than json. It can have comments and the file
> is shorter.
> More and more systems adopt yaml format. Now we developed a conversion tool
> from yaml to json with the ExecuteGroovyScript processor.
> It is recommended to add a processor that can convert between yaml and json
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11197) Add YAML Record Reader
[ https://issues.apache.org/jira/browse/NIFI-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788639#comment-17788639 ] Grant Cotton commented on NIFI-11197: - [~macdoor615] Any chance you can share your ExecuteGroovyScript version of the yaml to json converter while we wait for the feature described above? > Add YAML Record Reader > -- > > Key: NIFI-11197 > URL: https://issues.apache.org/jira/browse/NIFI-11197 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.20.0 >Reporter: macdoor615 >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 2.0.0-M1, 1.24.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > The yaml format is basically equivalent to json. When used as a configuration > file, it is much more convenient than json. It can have comments and the file > is shorter. > More and more systems adopt yaml format. Now we developed a conversion tool > from yaml to json with the ExecuteGroovyScript processor. > It is recommended to add a processor that can convert between yaml and json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-4243) OAuth 2 Authorization support - Authorization Code Grant
[
https://issues.apache.org/jira/browse/NIFI-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-4243.
Resolution: Won't Fix
The Authorization Code Grant Type is designed for interactive authentication
with a user, not for automated communication. The Standard OAuth2 Service
provides support for the Client Credentials Grant Type, which is the standard
approach for programmatic access. Although it might be possible to
implementation Authorization Code Grant Type handling with a custom UI, the
token expiration would not support persistent programmatic access.
> OAuth 2 Authorization support - Authorization Code Grant
> -
>
> Key: NIFI-4243
> URL: https://issues.apache.org/jira/browse/NIFI-4243
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Jeremy Dyer
>Priority: Major
>
> If your interacting with REST endpoints on the web chances are you are going
> to run into an OAuth2 secured webservice. The IETF (Internet Engineering Task
> Force) defines 4 methods in which OAuth2 authorization can occur. This JIRA
> is focused solely on the Authorization Code Grant method defined at
> https://tools.ietf.org/html/rfc6749#section-4.1
> This implementation should provide a ControllerService in which the enduser
> can configure the credentials for obtaining the authorization grant (access
> token) from the resource owner. In turn a new property will be added to the
> InvokeHTTP processor where the processor can reference this controller
> service to obtain the access token and insert the appropriate HTTP header
> (Authorization: Bearer {access_token}) so that the InvokeHTTP processor can
> interact with the OAuth protected resources without having to worry about
> setting up the credentials for each InvokeHTTP processor saving time and
> complexity.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-9985) Improve grant type client_credentials in StandardOauth2AccessTokenProvider
[
https://issues.apache.org/jira/browse/NIFI-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-9985.
Fix Version/s: 1.20.0
Resolution: Fixed
> Improve grant type client_credentials in StandardOauth2AccessTokenProvider
> --
>
> Key: NIFI-9985
> URL: https://issues.apache.org/jira/browse/NIFI-9985
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Anders
>Priority: Minor
> Labels: StandardOauth2AccessTokenProvider
> Fix For: 1.20.0
>
>
> StandardOauth2AccessTokenProvider supports grant type client_credentials,
> however it only supports it by forcing client_id and client_secret
> ([code|https://github.com/apache/nifi/blob/5aa71570ff1781f83f9fb8bf16ed3ab386d06b85/nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/StandardOauth2AccessTokenProvider.java#L260]).
> According to the
> [RFC|https://datatracker.ietf.org/doc/html/rfc6749#section-4.4.2] the actual
> example uses Basic auth, which is a common way to authenticate against oauth:
> {code}
> POST /token HTTP/1.1
> Host: server.example.com
> Authorization: Basic czZCaGRSa3F0MzpnWDFmQmF0M2JW
> Content-Type: application/x-www-form-urlencoded
> grant_type=client_credentials
> {code}
> Further according to the RFC:
> {code}
> The client MUST authenticate with the authorization server as described in
> Section 3.2.1.
> {code}
> which against says
> {code}
> A client MAY use the "client_id" request parameter to identify itself when
> sending requests to the token endpoint.
> {code}
> In other words, using client_id should be optional.
> One example of using grant type client_credentials with Basic auth:
> https://api.intelligence.fireeye.com/docs#authentication
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401334134
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/canvas/ui/connection/destination/destination-process-group/destination-process-group.component.ts:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, forwardRef, Input } from '@angular/core';
+import { ControlValueAccessor, FormsModule, NG_VALUE_ACCESSOR } from
'@angular/forms';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { NgForOf, NgIf } from '@angular/common';
+import { TextTip } from
'../../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { MatFormFieldModule } from '@angular/material/form-field';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { NifiTooltipDirective } from
'../../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { SelectOption, TextTipInput } from '../../../../../../state/shared';
+
+@Component({
+selector: 'destination-process-group',
+standalone: true,
+templateUrl: './destination-process-group.component.html',
+styleUrls: ['./destination-process-group.component.scss'],
+imports: [
+MatCheckboxModule,
+NgForOf,
+NgIf,
+FormsModule,
+MatFormFieldModule,
+MatOptionModule,
+MatSelectModule,
+NifiTooltipDirective
+],
+providers: [
+{
+provide: NG_VALUE_ACCESSOR,
+useExisting: forwardRef(() => DestinationProcessGroup),
+multi: true
+}
+]
+})
+export class DestinationProcessGroup implements ControlValueAccessor {
+@Input() set processGroup(processGroup: any) {
+if (processGroup.permissions.canRead) {
+this.groupName = processGroup.component.name;
+} else {
+this.groupName = processGroup.id;
+}
+}
+@Input() set inputPorts(inputPorts: any[]) {
+if (inputPorts) {
+this.noPorts = inputPorts.length == 0;
+this.hasUnauthorizedPorts = false;
+
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401333976
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/canvas/ui/connection/source/source-process-group/source-process-group.component.ts:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, forwardRef, Input } from '@angular/core';
+import { ControlValueAccessor, FormsModule, NG_VALUE_ACCESSOR } from
'@angular/forms';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { NgForOf, NgIf } from '@angular/common';
+import { TextTip } from
'../../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { MatFormFieldModule } from '@angular/material/form-field';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { NifiTooltipDirective } from
'../../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { SelectOption, TextTipInput } from '../../../../../../state/shared';
+
+@Component({
+selector: 'source-process-group',
+standalone: true,
+templateUrl: './source-process-group.component.html',
+styleUrls: ['./source-process-group.component.scss'],
+imports: [
+MatCheckboxModule,
+NgForOf,
+NgIf,
+FormsModule,
+MatFormFieldModule,
+MatOptionModule,
+MatSelectModule,
+NifiTooltipDirective
+],
+providers: [
+{
+provide: NG_VALUE_ACCESSOR,
+useExisting: forwardRef(() => SourceProcessGroup),
+multi: true
+}
+]
+})
+export class SourceProcessGroup implements ControlValueAccessor {
+@Input() set processGroup(processGroup: any) {
+if (processGroup) {
+if (processGroup.permissions.canRead) {
+this.groupName = processGroup.component.name;
+} else {
+this.groupName = processGroup.id;
+}
+}
+}
+
+@Input() set outputPorts(outputPorts: any[]) {
+if (outputPorts) {
+this.noPorts = outputPorts.length == 0;
+this.hasUnauthorizedPorts = false;
+
Review Comment:
I had to solve this slightly differently because the `Input` setter ran
before the `ControlValueAccessor` lifecycle hook which set `onTouched`. Please
have a look at my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12361) Conduct Apache NiFi 2.0.0-M1 Release
[ https://issues.apache.org/jira/browse/NIFI-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788566#comment-17788566 ] ASF subversion and git services commented on NIFI-12361: Commit 6f573c4a64b0d4b25315d36d8a4ae37a0150c32e in nifi's branch refs/heads/NIFI-12361-RC5 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6f573c4a64 ] NIFI-12361-RC5 prepare for next development iteration > Conduct Apache NiFi 2.0.0-M1 Release > > > Key: NIFI-12361 > URL: https://issues.apache.org/jira/browse/NIFI-12361 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12361) Conduct Apache NiFi 2.0.0-M1 Release
[ https://issues.apache.org/jira/browse/NIFI-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788565#comment-17788565 ] ASF subversion and git services commented on NIFI-12361: Commit f81a3597d40f3fe6df93d55347a11474ee6af2c8 in nifi's branch refs/heads/NIFI-12361-RC5 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f81a3597d4 ] NIFI-12361-RC5 prepare release nifi-2.0.0-M1-RC5 > Conduct Apache NiFi 2.0.0-M1 Release > > > Key: NIFI-12361 > URL: https://issues.apache.org/jira/browse/NIFI-12361 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
rfellows commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401063300
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/canvas/ui/connection/source/source-process-group/source-process-group.component.ts:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, forwardRef, Input } from '@angular/core';
+import { ControlValueAccessor, FormsModule, NG_VALUE_ACCESSOR } from
'@angular/forms';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { NgForOf, NgIf } from '@angular/common';
+import { TextTip } from
'../../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { MatFormFieldModule } from '@angular/material/form-field';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { NifiTooltipDirective } from
'../../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { SelectOption, TextTipInput } from '../../../../../../state/shared';
+
+@Component({
+selector: 'source-process-group',
+standalone: true,
+templateUrl: './source-process-group.component.html',
+styleUrls: ['./source-process-group.component.scss'],
+imports: [
+MatCheckboxModule,
+NgForOf,
+NgIf,
+FormsModule,
+MatFormFieldModule,
+MatOptionModule,
+MatSelectModule,
+NifiTooltipDirective
+],
+providers: [
+{
+provide: NG_VALUE_ACCESSOR,
+useExisting: forwardRef(() => SourceProcessGroup),
+multi: true
+}
+]
+})
+export class SourceProcessGroup implements ControlValueAccessor {
+@Input() set processGroup(processGroup: any) {
+if (processGroup) {
+if (processGroup.permissions.canRead) {
+this.groupName = processGroup.component.name;
+} else {
+this.groupName = processGroup.id;
+}
+}
+}
+
+@Input() set outputPorts(outputPorts: any[]) {
+if (outputPorts) {
+this.noPorts = outputPorts.length == 0;
+this.hasUnauthorizedPorts = false;
+
Review Comment:
we should auto-select the first option if there is only 1.
```suggestion
if (outputPorts.length === 1) {
this.selectedOutputPort = outputPorts[0].id;
this.handleChanged();
}
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/canvas/ui/connection/destination/destination-process-group/destination-process-group.component.ts:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, forwardRef, Input } from '@angular/core';
+import { ControlValueAccessor, FormsModule, NG_VALUE_ACCESSOR } from
'@angular/forms';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { NgForOf, NgIf } from '@angular/common';
+import { TextTip } from
'../../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { MatFormFieldModule } from '@angular/material/form-field';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { NifiTooltipDirective } from
Re: [PR] NIFI-12386 Adds processor FilterAttributes [nifi]
mosermw commented on code in PR #8049:
URL: https://github.com/apache/nifi/pull/8049#discussion_r1401253256
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttributes.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.DefaultRunDuration;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.documentation.UseCase;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyValue;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
+@SideEffectFree
+@SupportsBatching(defaultDuration = DefaultRunDuration.TWENTY_FIVE_MILLIS)
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@Tags({"attributes", "modification", "filter", "retain", "delete", "Attribute
Expression Language"})
+@CapabilityDescription("Filters the Attributes for a FlowFile against a set of
attribute names to retain or remove")
+@UseCase(
+description = "Retain only a specified set of FlowFile attributes",
+configuration = """
+Define a "Delimiter" that does not occur in the names of any of the
attributes to retain.
+Specify the set of "Attributes to filter" using the delimiter defined
before.
+Set "Filter mode" to "Retain".
+"""
+)
+public class FilterAttributes extends AbstractProcessor {
+
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.description("All successful FlowFiles are routed to this
relationship").name("success").build();
+
+private final static Set relationships =
Collections.singleton(REL_SUCCESS);
+
+public static final PropertyDescriptor ATTRIBUTE_SET = new
PropertyDescriptor.Builder()
+.name("ATTRIBUTE_SET")
+.displayName("Attributes to filter")
+.description("A set of attribute names to filter from FlowFiles.
Each attribute name is separated by the delimiter.")
+.required(true)
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+
+public static final PropertyDescriptor DELIMITER = new
PropertyDescriptor.Builder()
+.name("DELIMITER")
+.displayName("Delimiter")
+.description("One or multiple characters that separates one
attribute name value from another.")
+.required(true)
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.defaultValue(",")
+.build();
+
+public static final AllowableValue FILTER_MODE_VALUE_RETAIN = new
AllowableValue(
+"RETAIN",
+"Retain",
+"Retains only the attributes matching the filter, all other
attributes are removed."
+);
+
+public static final AllowableValue FILTER_MODE_VALUE_REMOVE = new
AllowableValue(
+"REMOVE",
+"Remove",
+"Removes the attributes matching the filter, all other
Re: [PR] NIFI-12386 Adds processor FilterAttributes [nifi]
EndzeitBegins commented on PR #8049: URL: https://github.com/apache/nifi/pull/8049#issuecomment-1821772238 Thank you for your useful inputs @mosermw. That sounds like a reasonable middle-ground. I'll have another go at the tests & implementation in the upcoming days, when I've time to spare. I'll mark the PR as draft again and get back to you, as soon as I incorporated the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401258474
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/state/reporting-tasks/reporting-tasks.reducer.ts:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { createReducer, on } from '@ngrx/store';
+import { ReportingTasksState } from './index';
+import {
+createReportingTask,
+createReportingTaskSuccess,
+deleteReportingTaskSuccess,
+loadReportingTasks,
+loadReportingTasksSuccess,
+reportingTasksApiError,
+startReportingTaskSuccess,
+stopReportingTaskSuccess
+} from './reporting-tasks.actions';
+import { produce } from 'immer';
+
+export const initialState: ReportingTasksState = {
+reportingTasks: [],
+saving: false,
+loadedTimestamp: '',
+error: null,
+status: 'pending'
+};
Review Comment:
The source of truth for selection is the `router-state`. If there is a case
where we need a Reporting Task selected, we need to dispatch a
`selectReportingTask` action. It's very possible that we're missing this in a
few spots as the Reporting Task listing isn't completed just yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401254497
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/edit-controller-service/edit-controller-service.component.ts:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Inject, Input, Output } from '@angular/core';
+import { MAT_DIALOG_DATA, MatDialogModule } from '@angular/material/dialog';
+import { AbstractControl, FormBuilder, FormControl, FormGroup,
ReactiveFormsModule, Validators } from '@angular/forms';
+import { Client } from '../../../../service/client.service';
+import {
+ControllerServiceEntity,
+EditControllerServiceDialogRequest,
+InlineServiceCreationRequest,
+InlineServiceCreationResponse,
+Parameter,
+Property
+} from '../../../../state/shared';
+import { MatInputModule } from '@angular/material/input';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { MatButtonModule } from '@angular/material/button';
+import { AsyncPipe, NgForOf, NgIf } from '@angular/common';
+import { MatTabsModule } from '@angular/material/tabs';
+import { NiFiCommon } from '../../../../service/nifi-common.service';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { PropertyTable } from '../../property-table/property-table.component';
+import { ControllerServiceApi } from
'../controller-service-api/controller-service-api.component';
+import { Observable } from 'rxjs';
+import { ControllerServiceReferences } from
'../controller-service-references/controller-service-references.component';
+import { NifiSpinnerDirective } from '../../spinner/nifi-spinner.directive';
+
+@Component({
+selector: 'edit-controller-service',
+standalone: true,
+templateUrl: './edit-controller-service.component.html',
+imports: [
+ReactiveFormsModule,
+MatDialogModule,
+MatInputModule,
+MatCheckboxModule,
+MatButtonModule,
+NgIf,
+MatTabsModule,
+MatOptionModule,
+MatSelectModule,
+NgForOf,
+PropertyTable,
+ControllerServiceApi,
+ControllerServiceReferences,
+AsyncPipe,
+NifiSpinnerDirective
+],
+styleUrls: ['./edit-controller-service.component.scss']
+})
+export class EditControllerService {
+@Input() createNewProperty!: (existingProperties: string[],
allowsSensitive: boolean) => Observable;
+@Input() createNewService!: (request: InlineServiceCreationRequest) =>
Observable;
+@Input() getParameters!: (sensitive: boolean) => Observable;
+@Input() getServiceLink!: (serviceId: string) => Observable;
+@Input() saving$!: Observable;
+@Output() editControllerService: EventEmitter = new
EventEmitter();
+
+editControllerServiceForm: FormGroup;
+
+bulletinLevels = [
+{
+text: 'DEBUG',
+value: 'DEBUG'
+},
+{
+text: 'INFO',
+value: 'INFO'
+},
+{
+text: 'WARN',
+value: 'WARN'
+},
+{
+text: 'ERROR',
+value: 'ERROR'
+},
+{
+text: 'NONE',
+value: 'NONE'
+}
+];
+
+constructor(
+@Inject(MAT_DIALOG_DATA) public request:
EditControllerServiceDialogRequest,
+private formBuilder: FormBuilder,
+private client: Client,
+private nifiCommon: NiFiCommon
+) {
+const serviceProperties: any =
request.controllerService.component.properties;
+const properties: Property[] =
Object.entries(serviceProperties).map((entry: any) => {
+const [property, value] = entry;
+return {
+property,
+value,
+descriptor:
request.controllerService.component.descriptors[property]
+};
+});
+
+// build the form
+this.editControllerServiceForm = this.formBuilder.group({
+name: new
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401251628
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/edit-parameter-context/edit-parameter-context.component.html:
##
@@ -0,0 +1,125 @@
+
+
+{{ this.isNew ? 'Add' : 'Edit' }} Parameter Context
+
+
+
+
+Steps To Update Parameters
+
+
+{{ updateStep.description }}
+
+
+
+
+
+
+
+
+
+Parameter
+{{ getUpdatedParameters() }}
+
+
+Referencing Components
+
+
Review Comment:
I created the component that renders the referencing components. I just
forgot to use it here. I'll add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12386 Adds processor FilterAttributes [nifi]
mosermw commented on PR #8049:
URL: https://github.com/apache/nifi/pull/8049#issuecomment-1821747070
@EndzeitBegins I spent some time thinking about this. I feel like using
explicit enumeration of attributes would not be needed if operators could be
trained to design a simple regex. We could do this in the PropertyDescriptor
description, even giving an example regex that acts like an enumeration of
attributes.
However, regexes are hard for many people. And I see you want to support
Expression Language in the `Attributes to filter` filter . I fully support
doing this. I can see use cases where using ExpLang to create a regex would
not be ideal. Possible, but not ideal. So I would support an `Attribute
Matching Strategy` PropertyDescriptor that lets you choose regex or enumeration
to match attributes.
I'm not a fan, however, of a `Delimiter` PropertyDescriptor. We aren't
dealing with data that we can't control, the delimiter will only exist inside
NiFi itself. So, I feel like we can require a comma-separated enumeration
here. If operators have a pipe-separated enumeration already in an attribute,
then ExpLang `replaceAll('|', ',')` can change the delimiter to a comma.
I do like the `Filter Mode` to make the processor remove or retain the
matching attributes. I would rename `Attributes to filter` to something like
`Matching Attributes` or just `Attributes`. If you do this, `Attributes`
becomes the subject and `Filter Mode` becomes the action to take on that
subject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
mcgilman commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1401227807
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/storage.service.ts:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+
+@Injectable({
+providedIn: 'root'
+})
+export class Storage {
+private static readonly MILLIS_PER_DAY: number = 8640;
+private static readonly TWO_DAYS: number = Storage.MILLIS_PER_DAY * 2;
+
+constructor() {}
+
+/**
+ * Checks the expiration for the specified entry.
+ *
+ * @param {object} entry
+ * @returns {boolean}
+ */
+private checkExpiration(entry: any): boolean {
+if (entry.expires == null) {
+// get the expiration
+const expires: Date = new Date(entry.expires);
+const now: Date = new Date();
+
+// return whether the expiration date has passed
+return expires.valueOf() < now.valueOf();
+} else {
+return false;
+}
+}
Review Comment:
Yep. The condition is backward. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary * Counters * Bulletin Board * Provenance ** Replay from context menu * Flow Analysis Rules * Registry Clients * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG * Configure Processor ** Service Link ** Create inline Service ** Parameter Link ** Convert to Parameter * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary * Counters * Bulletin Board * Provenance * Replay from context menu * Flow Analysis Rules * Registry Clients * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version * Start * Commit * Force Commit * Show changes * Revert changes * Change Flow version * Stop * Configure PG * Configure Processor * Service Link * Create inline Service * Parameter Link * Convert to Parameter * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to migrate UI to currently supported/active framework > - > > Key: NIFI-12400 > URL: https://issues.apache.org/jira/browse/NIFI-12400 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > The purpose of this Jira is to track all remaining items following the > initial commit [1] for NIFI-11481. The description will be kept up to date > with remaining features, tasks, and improvements. As each items is worked, a > new sub task Jira will be created and referenced in this description. > * Support Parameters in Properties with Allowable Values (NIFI-12401) > * Summary > * Counters > * Bulletin Board > * Provenance > ** Replay from context menu > * Flow Analysis Rules > * Registry Clients > * Parameter Providers > * Cluster > * Flow Configuration History > * Node Status History > * Users > * Policies > * Help > * About > * Show Upstream/Downstream > * Align > * List Queue > * Empty [all] Queue > * View Content > * View State > * Change Version > * PG Version > ** Start > ** Commit > ** Force Commit > ** Show changes > ** Revert changes > ** Change Flow version > ** Stop > * Configure PG > * Configure Processor > ** Service Link > ** Create inline Service > ** Parameter Link > ** Convert to Parameter > * Download Flow > * Create RPG > * Configure RPG > * RPG Remote Ports > * RPG Go To > * Color > * Move to Front > * Copy/Paste > [1] [https://github.com/apache/nifi/pull/8053] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11481) Migrate the Nifi UI to a currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788554#comment-17788554 ] Matt Gilman commented on NIFI-11481: All follow on work is being tracked here [1]. [1] https://issues.apache.org/jira/browse/NIFI-12400 > Migrate the Nifi UI to a currently supported/active framework > - > > Key: NIFI-11481 > URL: https://issues.apache.org/jira/browse/NIFI-11481 > Project: Apache NiFi > Issue Type: Wish > Components: Core UI >Reporter: Dondi Imperial >Assignee: Matt Gilman >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > AngularJS support [officially ended as of January > 2020|https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429]. > This can be problematic in environments with strict compliance requirements. > Perhaps the Nifi UI should be refactored or upgraded to Angular (non-JS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary * Counters * Bulletin Board * Provenance * Replay from context menu * Flow Analysis Rules * Registry Clients * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version * Start * Commit * Force Commit * Show changes * Revert changes * Change Flow version * Stop * Configure PG * Configure Processor * Service Link * Create inline Service * Parameter Link * Convert to Parameter * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values * Summary * Counters * Bulletin Board * Provenance * Replay from context menu * Flow Analysis Rules * Registry Clients * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version * Start * Commit * Force Commit * Show changes * Revert changes * Change Flow version * Stop * Configure PG * Configure Processor * Service Link * Create inline Service * Parameter Link * Convert to Parameter * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to migrate UI to currently supported/active framework > - > > Key: NIFI-12400 > URL: https://issues.apache.org/jira/browse/NIFI-12400 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > The purpose of this Jira is to track all remaining items following the > initial commit [1] for NIFI-11481. The description will be kept up to date > with remaining features, tasks, and improvements. As each items is worked, a > new sub task Jira will be created and referenced in this description. > * Support Parameters in Properties with Allowable Values (NIFI-12401) > * Summary > * Counters > * Bulletin Board > * Provenance > * Replay from context menu > * Flow Analysis Rules > * Registry Clients > * Parameter Providers > * Cluster > * Flow Configuration History > * Node Status History > * Users > * Policies > * Help > * About > * Show Upstream/Downstream > * Align > * List Queue > * Empty [all] Queue > * View Content > * View State > * Change Version > * PG Version > * Start > * Commit > * Force Commit > * Show changes > * Revert changes > * Change Flow version > * Stop > * Configure PG > * Configure Processor > * Service Link > * Create inline Service > * Parameter Link > * Convert to Parameter > * Download Flow > * Create RPG > * Configure RPG > * RPG Remote Ports > * RPG Go To > * Color > * Move to Front > * Copy/Paste > [1] [https://github.com/apache/nifi/pull/8053] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12401) Support Parameters in Properties with Allowable Values
Matt Gilman created NIFI-12401: -- Summary: Support Parameters in Properties with Allowable Values Key: NIFI-12401 URL: https://issues.apache.org/jira/browse/NIFI-12401 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Update the combo editor to support referencing existing parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
Matt Gilman created NIFI-12400: -- Summary: Remaining items to migrate UI to currently supported/active framework Key: NIFI-12400 URL: https://issues.apache.org/jira/browse/NIFI-12400 Project: Apache NiFi Issue Type: Improvement Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values * Summary * Counters * Bulletin Board * Provenance * Replay from context menu * Flow Analysis Rules * Registry Clients * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version * Start * Commit * Force Commit * Show changes * Revert changes * Change Flow version * Stop * Configure PG * Configure Processor * Service Link * Create inline Service * Parameter Link * Convert to Parameter * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste [1] [https://github.com/apache/nifi/pull/8053] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-11671:
--
Status: Patch Available (was: Open)
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.23.0, 1.20.0, 1.18.0
>Reporter: Philipp Korniets
>Assignee: Mark Payne
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Attachments: screenshot-1.png, screenshot-2.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[PR] NIFI-11671: Allow FlowFile attributes to be referenced in SQL for Joi… [nifi]
markap14 opened a new pull request, #8059: URL: https://github.com/apache/nifi/pull/8059 …nEnrichment # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne reassigned NIFI-11671:
-
Assignee: Mark Payne
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0, 1.20.0, 1.23.0
>Reporter: Philipp Korniets
>Assignee: Mark Payne
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[jira] [Updated] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-11671:
--
Fix Version/s: 1.latest
2.latest
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0, 1.20.0, 1.23.0
>Reporter: Philipp Korniets
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[jira] [Updated] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-11671:
--
Priority: Minor (was: Critical)
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.18.0, 1.20.0, 1.23.0
>Reporter: Philipp Korniets
>Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[jira] [Updated] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-11671:
--
Component/s: Extensions
(was: Core Framework)
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0, 1.20.0, 1.23.0
>Reporter: Philipp Korniets
>Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[jira] [Updated] (NIFI-12398) Upgrade Apache Derby to 10.17.1.0
[ https://issues.apache.org/jira/browse/NIFI-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12398: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Upgrade Apache Derby to 10.17.1.0 > - > > Key: NIFI-12398 > URL: https://issues.apache.org/jira/browse/NIFI-12398 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M1 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Derby > [10.17.1.0|https://db.apache.org/derby/releases/release-10_17_1_0.cgi] > includes several bug fixes and requires Java 21. Most of the dependencies on > Derby within the project are specific to tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12397) Upgrade Commons Compress to 1.25.0
[ https://issues.apache.org/jira/browse/NIFI-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12397: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Upgrade Commons Compress to 1.25.0 > -- > > Key: NIFI-12397 > URL: https://issues.apache.org/jira/browse/NIFI-12397 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M1, 1.25.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Commons Compress > [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] > includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12393) Upgrade OWASP Dependency Check to 8.4.3 and Address Findings
[ https://issues.apache.org/jira/browse/NIFI-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12393: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Upgrade OWASP Dependency Check to 8.4.3 and Address Findings > > > Key: NIFI-12393 > URL: https://issues.apache.org/jira/browse/NIFI-12393 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M1 > > Time Spent: 20m > Remaining Estimate: 0h > > The OWASP Dependency Check Plugin should be upgraded to 8.4.3 and recent > findings in the report should be resolved. > Several findings are false positives due to misidentified dependencies, and > other findings are related to version settings that are not carried through > to the nifi-code-coverage module, which is specific to JaCoCo coverage > aggregation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12367) Upgrade Netty to 4.1.101
[ https://issues.apache.org/jira/browse/NIFI-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12367: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Upgrade Netty to 4.1.101 > > > Key: NIFI-12367 > URL: https://issues.apache.org/jira/browse/NIFI-12367 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0-M1 > > Time Spent: 20m > Remaining Estimate: 0h > > Update netty.4.version to 4.101.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12370) DistributedMapCacheClientService leaks threads
[
https://issues.apache.org/jira/browse/NIFI-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12370:
Fix Version/s: 2.0.0-M1
(was: 2.0.0)
> DistributedMapCacheClientService leaks threads
> --
>
> Key: NIFI-12370
> URL: https://issues.apache.org/jira/browse/NIFI-12370
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.21.0, 1.22.0, 1.23.2
>Reporter: Eric Secules
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M1, 1.24.0
>
> Attachments: Test_NIFI-12370.xml
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> # Using the attached flow template first enable and run the flow. This should
> exercise the cache.
> # run `nifi.sh diagnostics --verbose` and save the file
> # Disable and delete the controller services
> # run `nifi.sh diagnostics --verbose` and save the file with a different name
> # compare the thread dumps. The second file should not have any threads
> related to the DistributedMapCacheClientService but it will.
> # create and enable new controller services and link them to the Wait and
> Notify processors
> # run `nifi.sh diagnostics --verbose` and save the file with a different name
> # There should be threads from two separate DistributedMapCacheClientServices
> like this:
> {code:java}
> "NettyDistributedMapCacheClient[d06c8ea0-018b-1000-2904-26aa7612632a]-3-1"
> "NettyDistributedMapCacheClient[d06c8ea0-018b-1000-2904-26aa7612632a]-3-2"
> "NettyDistributedMapCacheClient[d06c8ea0-018b-1000-2904-26aa7612632a]-3-3"
> "NettyDistributedMapCacheClient[d06c8ea0-018b-1000-2904-26aa7612632a]-3-4"
> "NettyDistributedMapCacheClient[d0774323-018b-1000-5e78-07a7455a2bd2]-5-1"
> "NettyDistributedMapCacheClient[d0774323-018b-1000-5e78-07a7455a2bd2]-5-2"
> {code}
> Slack Thread:
> https://apachenifi.slack.com/archives/C0L9VCD47/p179443394479
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12364) Upgrade snowflake-ingest-sdk to 2.0.4 and snowflake-jdbc to 3.14.3
[ https://issues.apache.org/jira/browse/NIFI-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12364: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Upgrade snowflake-ingest-sdk to 2.0.4 and snowflake-jdbc to 3.14.3 > -- > > Key: NIFI-12364 > URL: https://issues.apache.org/jira/browse/NIFI-12364 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Fix For: 2.0.0-M1, 1.24.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Upgrade snowflake-ingest-sdk to 2.0.4 and snowflake-jdbc to 3.14.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12363) Update jline.version to 3.24.1
[ https://issues.apache.org/jira/browse/NIFI-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12363: Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Update jline.version to 3.24.1 > -- > > Key: NIFI-12363 > URL: https://issues.apache.org/jira/browse/NIFI-12363 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0-M1, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update jline.version to 3.24.1. The current version is affected by > [CVE-2023-35887|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-35887] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-1874) Improve IdentifyMimeType to detect character encoding in text data
[ https://issues.apache.org/jira/browse/NIFI-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-1874: --- Fix Version/s: 2.0.0-M1 (was: 2.0.0) > Improve IdentifyMimeType to detect character encoding in text data > -- > > Key: NIFI-1874 > URL: https://issues.apache.org/jira/browse/NIFI-1874 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: endzeit >Priority: Minor > Fix For: 2.0.0-M1, 1.24.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Leverage Apache Tika > [EncodingDetector|https://tika.apache.org/1.12/api/org/apache/tika/detect/EncodingDetector.html] > to additionally detect the character encoding of text data. > See > [AutoDetectReader|https://tika.apache.org/1.12/api/org/apache/tika/detect/AutoDetectReader.html] > too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12398) Upgrade Apache Derby to 10.17.1.0
[ https://issues.apache.org/jira/browse/NIFI-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12398. --- Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed > Upgrade Apache Derby to 10.17.1.0 > - > > Key: NIFI-12398 > URL: https://issues.apache.org/jira/browse/NIFI-12398 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Derby > [10.17.1.0|https://db.apache.org/derby/releases/release-10_17_1_0.cgi] > includes several bug fixes and requires Java 21. Most of the dependencies on > Derby within the project are specific to tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12398) Upgrade Apache Derby to 10.17.1.0
[ https://issues.apache.org/jira/browse/NIFI-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788491#comment-17788491 ] ASF subversion and git services commented on NIFI-12398: Commit e68c384c1293e0e7402effc8163e779d37f3b352 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e68c384c12 ] NIFI-12398 Upgraded Derby from 10.16.1.1 to 10.17.1.0 Signed-off-by: Pierre Villard This closes #8058. > Upgrade Apache Derby to 10.17.1.0 > - > > Key: NIFI-12398 > URL: https://issues.apache.org/jira/browse/NIFI-12398 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Derby > [10.17.1.0|https://db.apache.org/derby/releases/release-10_17_1_0.cgi] > includes several bug fixes and requires Java 21. Most of the dependencies on > Derby within the project are specific to tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12398 Upgrade Derby from 10.16.1.1 to 10.17.1.0 [nifi]
asfgit closed pull request #8058: NIFI-12398 Upgrade Derby from 10.16.1.1 to 10.17.1.0 URL: https://github.com/apache/nifi/pull/8058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12399) how to add parameter decimal_target_types on process PutBigQueryBatch
SYAZ created NIFI-12399:
---
Summary: how to add parameter decimal_target_types on process
PutBigQueryBatch
Key: NIFI-12399
URL: https://issues.apache.org/jira/browse/NIFI-12399
Project: Apache NiFi
Issue Type: Bug
Components: Configuration
Reporter: SYAZ
Hi,
i do an extract from hive with select3Hive3Ql in avro mode and then i use
PutBigQueryBatch with the file generated par Hive3QL.
for my hive table a type decimal become string in bigquery
i want to change this. it's possible to user the option decimal_target_types to
change decimal to NUMERIC or BIGNUMERIC
how to add this parameter to PutBigQueryBatch on nifi processor ?
https://cloud.google.com/bigquery/docs/reference/bq-cli-reference?hl=en#--decimal_target_types
*{{--decimal_target_types=DECIMAL_TYPE}}*
Determines how to convert a {{Decimal}} logical type. Equivalent to
[{{JobConfigurationLoad.decimalTargetTypes}}|https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobConfigurationLoad.FIELDS.decimal_target_types].
Repeat this flag to specify multiple target types.
thanks
Best regards
Sylvain AZNAR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) from PostgreSQL tables via Logical Replication API [nifi]
neha-120 commented on PR #6053: URL: https://github.com/apache/nifi/pull/6053#issuecomment-1821309426 Hi There, I am using the NAR that @janis-ax . But I have a requirement to use ssl authenticated postgres DB. Is there a way to configure ssl in this cdc postgres nar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11671) JoinEnrichment SQL strategy doesn't allow attributes in join statement
[
https://issues.apache.org/jira/browse/NIFI-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Korniets updated NIFI-11671:
Priority: Critical (was: Major)
> JoinEnrichment SQL strategy doesn't allow attributes in join statement
> --
>
> Key: NIFI-11671
> URL: https://issues.apache.org/jira/browse/NIFI-11671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.18.0, 1.20.0, 1.23.0
>Reporter: Philipp Korniets
>Priority: Critical
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> We use ForkEnrichement - JoinEnrichment pattern and want to include filtering
> in join SQL. Filter value is coming from FlowFile attribute
> {code:sql}
> ${test} = 'NewValue'
> SELECT original.*, enrichment.*,'${test}'
> FROM original
> LEFT OUTER JOIN enrichment
> ON original.Underlying = enrichment.Underlying
> WHERE enrichment.MyField = '${test}'
> {code}
> However this doesnt work because JoinEnrichment doesnt use
> evaluateAttributeExpressions
> Additionally in version 1.18,1.23 - doesnt allow whole query to be passed as
> attribute.
> !screenshot-1.png|width=692,height=431!
>
> {code:java}
> 2023-06-28 11:07:16,611 ERROR [Timer-Driven Process Thread-7]
> o.a.n.processors.standard.JoinEnrichment
> JoinEnrichment[id=dbe156ac-0187-1000-4477-0183899e0432] Failed to join
> 'original' FlowFile
> StandardFlowFileRecord[uuid=2ab9f6ad-73a5-4763-b25e-fd26c44835e1,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687948831976-629,
> container=default, section=629], offset=8334082,
> length=600557],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=600557]
> and 'enrichment' FlowFile
> StandardFlowFileRecord[uuid=e4bb7769-fdce-4dfe-af18-443676103035,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1687949723375-631,
> container=default, section=631], offset=5362822,
> length=1999502],offset=0,name=lmr_SY08C41-1_S_514682_20230627.csv,size=1999502];
> routing to failure
> java.sql.SQLException: Error while preparing statement [${instrumentJoinSQL}]
> at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement_(CalciteConnectionImpl.java:224)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:203)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.prepareStatement(CalciteConnectionImpl.java:99)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:178)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.createCalciteParameters(SqlJoinCache.java:91)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinCache.getCalciteParameters(SqlJoinCache.java:65)
> at
> org.apache.nifi.processors.standard.enrichment.SqlJoinStrategy.join(SqlJoinStrategy.java:49)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBin(JoinEnrichment.java:387)
> at
> org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:233)
> at
> org.apache.nifi.processors.standard.JoinEnrichment.processBins(JoinEnrichment.java:503)
> at
> org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:193)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.RuntimeException: parse failed: Encountered "$" at line
> 1, column 1.
> Was expecting one of:
> "ABS" ...
> {code}
> As I understand issue is in following line of code
>
[jira] [Updated] (NIFI-12396) Add python3-venv to Docker Hub Build
[
https://issues.apache.org/jira/browse/NIFI-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12396:
Fix Version/s: 2.0.0-M1
(was: 2.latest)
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add python3-venv to Docker Hub Build
>
>
> Key: NIFI-12396
> URL: https://issues.apache.org/jira/browse/NIFI-12396
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Dockerfile for the {{nifi-docker/dockerhub}} module is missing the
> {{python3-venv}} module, resulting in startup failures using the default
> configuration, which enables Python extensions. Adding the library mirrors
> the configuration in the dockermaven module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12386 Adds processor FilterAttributes [nifi]
EndzeitBegins commented on PR #8049: URL: https://github.com/apache/nifi/pull/8049#issuecomment-1821238367 @mosermw Thank for the review once more. I can see advantages to both approaches, explicit enumeration and pattern matching. While the first approach is more explicit and strict but more verbose, the later is more flexible and adaptive but less explicit and somewhat more complex. What do you think about supporting both approaches? That is, introducing something like a `Attribute matching style` with allowed values `Enumeration`, `Regular Expression` (and possibly others such as glob pattern). When `Enumeration` is selected, the properties `Attributes to filter` and `Delimiter` are present. When `Regular expression` is selected on the other hand, these properties are not available but a property `Attribute filter regex` is present. This way, both styles are supported, while keeping the properties available to the user at a time to a minimum. What are your thoughts about this? If that's something we can agree on, I'm more than happy about suggestions for the property names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12384) Upgrade Spring Framework to 6.0.13 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12384: Fix Version/s: 2.0.0-M1 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Spring Framework to 6.0.13 for Registry > --- > > Key: NIFI-12384 > URL: https://issues.apache.org/jira/browse/NIFI-12384 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M1 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Spring Framework 6 represents a major upgrade from version 5 and requires a > number of supporting libraries to be upgraded. These supporting libraries > include the following: > - Spring Security 6 > - Spring Boot 3 > - Jakarta Servlet API 5 > - Jetty 11 > - JAX RS 3 > - Jersey 3 > NiFi Registry should be upgraded independently of NiFi itself to provide an > incremental path forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12398 Upgrade Derby from 10.16.1.1 to 10.17.1.0 [nifi]
exceptionfactory opened a new pull request, #8058: URL: https://github.com/apache/nifi/pull/8058 # Summary [NIFI-12398](https://issues.apache.org/jira/browse/NIFI-12398) Upgrades Apache Derby dependencies from 10.16.1.1 to [10.17.1.0](https://db.apache.org/derby/releases/release-10_17_1_0.cgi). Derby 10.17.1.0 requires Java 21, so this upgrade applies only to the main branch. Most of the dependencies on Apache Derby are related to tests. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12384) Upgrade Spring Framework to 6.0.13 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788470#comment-17788470 ] ASF subversion and git services commented on NIFI-12384: Commit 6617fe8fe22192b74531cc2384ce310bfcafa862 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6617fe8fe2 ] NIFI-12384 This closes #8044. Upgraded Registry to Spring Framework 6 - Upgraded Spring from 5.3.30 to 6.0.13 - Upgraded Spring Boot from 2.7.16 to 3.1.5 - Upgraded Spring Security from 5.8.7 to 6.1.5 - Upgraded Jetty from 10.0.18 to 11.0.18 - Upgraded Servlet API from 3.1.0 to 5.0.0 - Upgraded JAX-RS from 2.1.1 to 3.1.0 - Upgraded Jersey from 2.41 to 3.1.3 - Upgraded JAXB from 2.3.2 to 4.0.4 - Upgraded Java Validation from 2.0.1 to 3.0.2 - Upgraded Flyway from 8.5.13 to 9.22.3 - Upgraded ASM from 9.3 to 9.6 for Java 21 - Upgraded NiFi Toolkit CLI to JAX RS 3 and Jersey 3 - Set Jersey 3 and JAX RS 3 dependency versions in nifi-flow-registry-client-bundle to align with updates to nifi-registry-client classes Signed-off-by: Joseph Witt > Upgrade Spring Framework to 6.0.13 for Registry > --- > > Key: NIFI-12384 > URL: https://issues.apache.org/jira/browse/NIFI-12384 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > Spring Framework 6 represents a major upgrade from version 5 and requires a > number of supporting libraries to be upgraded. These supporting libraries > include the following: > - Spring Security 6 > - Spring Boot 3 > - Jakarta Servlet API 5 > - Jetty 11 > - JAX RS 3 > - Jersey 3 > NiFi Registry should be upgraded independently of NiFi itself to provide an > incremental path forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12384 Upgrade Registry to Spring Framework 6 [nifi]
asfgit closed pull request #8044: NIFI-12384 Upgrade Registry to Spring Framework 6 URL: https://github.com/apache/nifi/pull/8044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12384 Upgrade Registry to Spring Framework 6 [nifi]
joewitt commented on PR #8044: URL: https://github.com/apache/nifi/pull/8044#issuecomment-1821213901 @pvillard31 No worries I'm good with your +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12396) Add python3-venv to Docker Hub Build
[
https://issues.apache.org/jira/browse/NIFI-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788469#comment-17788469
]
ASF subversion and git services commented on NIFI-12396:
Commit c4b3f20972424b93cb0bfd10045fb1dc9cc95065 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c4b3f20972 ]
NIFI-12396 Added python3-venv to Dockerfile for dockerhub
Signed-off-by: Gabor Gyimesi
This closes #8056
> Add python3-venv to Docker Hub Build
>
>
> Key: NIFI-12396
> URL: https://issues.apache.org/jira/browse/NIFI-12396
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Dockerfile for the {{nifi-docker/dockerhub}} module is missing the
> {{python3-venv}} module, resulting in startup failures using the default
> configuration, which enables Python extensions. Adding the library mirrors
> the configuration in the dockermaven module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12384 Upgrade Registry to Spring Framework 6 [nifi]
pvillard31 commented on PR #8044: URL: https://github.com/apache/nifi/pull/8044#issuecomment-1821211444 Full build, running NiFi and NiFi Registry secured, I was able to interact with the NiFi Registry instance to version flows, checkout versions, etc. I'm a +1. @joewitt - do you want to give it another try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12396 Add python3-venv to Dockerfile for dockerhub [nifi]
lordgamez closed pull request #8056: NIFI-12396 Add python3-venv to Dockerfile for dockerhub URL: https://github.com/apache/nifi/pull/8056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12398) Upgrade Apache Derby to 10.17.1.0
David Handermann created NIFI-12398: --- Summary: Upgrade Apache Derby to 10.17.1.0 Key: NIFI-12398 URL: https://issues.apache.org/jira/browse/NIFI-12398 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 2.latest Apache Derby [10.17.1.0|https://db.apache.org/derby/releases/release-10_17_1_0.cgi] includes several bug fixes and requires Java 21. Most of the dependencies on Derby within the project are specific to tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12386 Adds processor FilterAttributes [nifi]
mosermw commented on PR #8049: URL: https://github.com/apache/nifi/pull/8049#issuecomment-1821208121 Adding a new processor to the `nifi-standard-nar` with a clearly defined use case is certainly not going to be a bad thing. I feel strongly that the attribute filter needs to be a regular expression, though. If I want to retain 50 attributes out of 100 in a FlowFile, then I don't want to specify each one exactly. A regex pattern, though a little more complex, is much more powerful and useful. A regex can be written to be future-proof, to new attributes that get created, without having to update this processor's configuration every time I create new attributes in my flow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12397) Upgrade Commons Compress to 1.25.0
[ https://issues.apache.org/jira/browse/NIFI-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788465#comment-17788465 ] ASF subversion and git services commented on NIFI-12397: Commit 5cf8f7d31ee59026c1fe31d4c931a0a46f2428a3 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5cf8f7d31e ] NIFI-12397 Upgraded Commons Compress from 1.24.0 to 1.25.0 Signed-off-by: Pierre Villard This closes #8057. > Upgrade Commons Compress to 1.25.0 > -- > > Key: NIFI-12397 > URL: https://issues.apache.org/jira/browse/NIFI-12397 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Commons Compress > [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] > includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12397) Upgrade Commons Compress to 1.25.0
[ https://issues.apache.org/jira/browse/NIFI-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12397: -- Fix Version/s: 1.25.0 2.0.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Commons Compress to 1.25.0 > -- > > Key: NIFI-12397 > URL: https://issues.apache.org/jira/browse/NIFI-12397 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Commons Compress > [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] > includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12397) Upgrade Commons Compress to 1.25.0
[ https://issues.apache.org/jira/browse/NIFI-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788466#comment-17788466 ] ASF subversion and git services commented on NIFI-12397: Commit 353e3beb0e8d72b17fce14b7d0bd48f4a317ca44 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=353e3beb0e ] NIFI-12397 Upgraded Commons Compress from 1.24.0 to 1.25.0 Signed-off-by: Pierre Villard This closes #8057. > Upgrade Commons Compress to 1.25.0 > -- > > Key: NIFI-12397 > URL: https://issues.apache.org/jira/browse/NIFI-12397 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Commons Compress > [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] > includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12397 Upgrade Commons Compress from 1.24.0 to 1.25.0 [nifi]
asfgit closed pull request #8057: NIFI-12397 Upgrade Commons Compress from 1.24.0 to 1.25.0 URL: https://github.com/apache/nifi/pull/8057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12395 Update Jackson.bom.version to 2.16.0 [nifi]
mr1716 commented on PR #8055: URL: https://github.com/apache/nifi/pull/8055#issuecomment-1821178450 @exceptionfactory thanks. I'll close this for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12395 Update Jackson.bom.version to 2.16.0 [nifi]
mr1716 closed pull request #8055: NIFI-12395 Update Jackson.bom.version to 2.16.0 URL: https://github.com/apache/nifi/pull/8055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12397 Upgrade Commons Compress from 1.24.0 to 1.25.0 [nifi]
exceptionfactory opened a new pull request, #8057: URL: https://github.com/apache/nifi/pull/8057 # Summary [NIFI-12397](https://issues.apache.org/jira/browse/NIFI-12397) Upgrades Apache Commons Compress from 1.24.0 to [1.25.0](https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0), which includes a number of minor bug fixes and improvements. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12397) Upgrade Commons Compress to 1.25.0
[ https://issues.apache.org/jira/browse/NIFI-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12397: Status: Patch Available (was: Open) > Upgrade Commons Compress to 1.25.0 > -- > > Key: NIFI-12397 > URL: https://issues.apache.org/jira/browse/NIFI-12397 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Commons Compress > [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] > includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12397) Upgrade Commons Compress to 1.25.0
David Handermann created NIFI-12397: --- Summary: Upgrade Commons Compress to 1.25.0 Key: NIFI-12397 URL: https://issues.apache.org/jira/browse/NIFI-12397 Project: Apache NiFi Issue Type: Improvement Components: Core Framework, Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest Apache Commons Compress [1.25.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.25.0] includes a number of minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11481: Initial migration to Angular 16 [nifi]
rfellows commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1399638818
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-listing.component.ts:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { ParameterContextEntity, ParameterContextListingState } from
'../../state/parameter-context-listing';
+import {
+selectContext,
+selectParameterContextIdFromRoute,
+selectParameterContextListingState,
+selectSingleEditedParameterContext
+} from
'../../state/parameter-context-listing/parameter-context-listing.selectors';
+import {
+getEffectiveParameterContextAndOpenDialog,
+loadParameterContexts,
+navigateToEditParameterContext,
+openNewParameterContextDialog,
+promptParameterContextDeletion,
+selectParameterContext
+} from
'../../state/parameter-context-listing/parameter-context-listing.actions';
+import { initialState } from
'../../state/parameter-context-listing/parameter-context-listing.reducer';
+import { filter, switchMap, take } from 'rxjs';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+
+@Component({
+selector: 'parameter-context-listing',
+templateUrl: './parameter-context-listing.component.html',
+styleUrls: ['./parameter-context-listing.component.scss']
+})
+export class ParameterContextListing {
Review Comment:
while not required, we should declare this class to `implement OnInit` as it
defines an `ngOnInit` method.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/loading.service.ts:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { BehaviorSubject, delay, Observable } from 'rxjs';
+
+@Injectable({
+providedIn: 'root'
+})
+export class LoadingService {
+status$: Observable;
+
+loading: BehaviorSubject = new BehaviorSubject(false);
+requests: Map = new Map();
Review Comment:
These should probably be marked as `private`.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/storage.service.ts:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+
+@Injectable({
+providedIn: 'root'
+})
+export class Storage {
+private static readonly
[jira] [Updated] (NIFI-12396) Add python3-venv to Docker Hub Build
[
https://issues.apache.org/jira/browse/NIFI-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12396:
Status: Patch Available (was: Open)
> Add python3-venv to Docker Hub Build
>
>
> Key: NIFI-12396
> URL: https://issues.apache.org/jira/browse/NIFI-12396
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Dockerfile for the {{nifi-docker/dockerhub}} module is missing the
> {{python3-venv}} module, resulting in startup failures using the default
> configuration, which enables Python extensions. Adding the library mirrors
> the configuration in the dockermaven module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12396 Add python3-venv to Dockerfile for dockerhub [nifi]
exceptionfactory opened a new pull request, #8056: URL: https://github.com/apache/nifi/pull/8056 # Summary [NIFI-12396](https://issues.apache.org/jira/browse/NIFI-12396) Adds the `python3-env` package to the `Dockerfile` in the `dockerhub` module for NiFi, following the same settings in the `dockermaven` configuration. This package is necessary to run Python extensions in the Docker Hub container. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12396) Add python3-venv to Docker Hub Build
David Handermann created NIFI-12396:
---
Summary: Add python3-venv to Docker Hub Build
Key: NIFI-12396
URL: https://issues.apache.org/jira/browse/NIFI-12396
Project: Apache NiFi
Issue Type: Bug
Reporter: David Handermann
Assignee: David Handermann
Fix For: 2.latest
The Dockerfile for the {{nifi-docker/dockerhub}} module is missing the
{{python3-venv}} module, resulting in startup failures using the default
configuration, which enables Python extensions. Adding the library mirrors the
configuration in the dockermaven module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12395 Update Jackson.bom.version to 2.16.0 [nifi]
mr1716 opened a new pull request, #8055: URL: https://github.com/apache/nifi/pull/8055 # Summary [NIFI-12395](https://issues.apache.org/jira/browse/NIFI-12395) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12395) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12395) Update Jackson.bom.version to 2.16.0
[ https://issues.apache.org/jira/browse/NIFI-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12395: - Assignee: Mike R > Update Jackson.bom.version to 2.16.0 > > > Key: NIFI-12395 > URL: https://issues.apache.org/jira/browse/NIFI-12395 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.24.0, 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update Jackson.bom.version to 2.16.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12395) Update Jackson.bom.version to 2.16.0
Mike R created NIFI-12395: - Summary: Update Jackson.bom.version to 2.16.0 Key: NIFI-12395 URL: https://issues.apache.org/jira/browse/NIFI-12395 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.23.2, 1.24.0 Reporter: Mike R Update Jackson.bom.version to 2.16.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12393) Upgrade OWASP Dependency Check to 8.4.3 and Address Findings
[ https://issues.apache.org/jira/browse/NIFI-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12393: -- Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade OWASP Dependency Check to 8.4.3 and Address Findings > > > Key: NIFI-12393 > URL: https://issues.apache.org/jira/browse/NIFI-12393 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The OWASP Dependency Check Plugin should be upgraded to 8.4.3 and recent > findings in the report should be resolved. > Several findings are false positives due to misidentified dependencies, and > other findings are related to version settings that are not carried through > to the nifi-code-coverage module, which is specific to JaCoCo coverage > aggregation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12393) Upgrade OWASP Dependency Check to 8.4.3 and Address Findings
[ https://issues.apache.org/jira/browse/NIFI-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788369#comment-17788369 ] ASF subversion and git services commented on NIFI-12393: Commit e5e76d0161988d633ff554a3cb12e149b79576b6 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e5e76d0161 ] NIFI-12393 Upgraded OWASP Check from 8.4.2 to 8.4.3 - Upgraded Azure SDK BOM from 1.2.17 to 1.2.18 - Upgraded Reactor Netty HTTP from 1.0.34 to 1.0.39 for Azure Identity - Upgraded MSAL4J from 1.13.10 to 1.14.0 - Upgraded Box Java SDK from 4.4.0 to 4.6.1 - Relocated Apache Ant managed versions to bundle parent modules - Added okio-fakefilesystem to managed dependencies - Suppressed vulnerability for Picocli misidentified as LINE library - Added managed dependencies to nifi-code-coverage to avoid false positives due to different parent modules Signed-off-by: Pierre Villard This closes #8054. > Upgrade OWASP Dependency Check to 8.4.3 and Address Findings > > > Key: NIFI-12393 > URL: https://issues.apache.org/jira/browse/NIFI-12393 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > The OWASP Dependency Check Plugin should be upgraded to 8.4.3 and recent > findings in the report should be resolved. > Several findings are false positives due to misidentified dependencies, and > other findings are related to version settings that are not carried through > to the nifi-code-coverage module, which is specific to JaCoCo coverage > aggregation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12393 Upgrade OWASP Check from 8.4.2 to 8.4.3 and Address Findings [nifi]
asfgit closed pull request #8054: NIFI-12393 Upgrade OWASP Check from 8.4.2 to 8.4.3 and Address Findings URL: https://github.com/apache/nifi/pull/8054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12372 MiNiFi C2 Encrypt Flow Configuration Properties when Transferring [nifi]
briansolo1985 commented on PR #8028: URL: https://github.com/apache/nifi/pull/8028#issuecomment-1820697471 I addressed the second round of comments. Decided to make a bigger refactor: moved services to minifi-commons, created interfaces for those services to become consistent. Also removed the flow serialization and deserialization from those particular services. Performance was not an issue there as that code was not on a critical path, eg flow updates are expected maximum a few times a day, but most frequently we talk about weeks or months here. However having the serde in the services hurt SRP at some level, so moved the logic to an upper layer. Also now the flow serde logic is encapsulated in one class. Rebased onto the latest main. Tested a flow with C2, unecrypted properties were encrypted correctly. Please review the latest changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12372 MiNiFi C2 Encrypt Flow Configuration Properties when Transferring [nifi]
briansolo1985 commented on code in PR #8028:
URL: https://github.com/apache/nifi/pull/8028#discussion_r1400399693
##
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-framework-core/src/test/java/org/apache/nifi/minifi/c2/command/FlowPropertyEncryptorTest.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.c2.command;
+
+import static java.util.Map.entry;
+import static java.util.UUID.randomUUID;
+import static java.util.stream.Collectors.toMap;
+import static org.apache.commons.lang3.RandomStringUtils.randomAlphabetic;
+import static
org.apache.nifi.controller.serialization.FlowSerializer.ENC_PREFIX;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.stream.Stream;
+import org.apache.nifi.c2.protocol.component.api.Bundle;
+import org.apache.nifi.c2.protocol.component.api.ComponentManifest;
+import org.apache.nifi.c2.protocol.component.api.ControllerServiceDefinition;
+import org.apache.nifi.c2.protocol.component.api.ProcessorDefinition;
+import org.apache.nifi.c2.protocol.component.api.PropertyDescriptor;
+import org.apache.nifi.c2.protocol.component.api.RuntimeManifest;
+import org.apache.nifi.controller.flow.VersionedDataflow;
+import org.apache.nifi.encrypt.PropertyEncryptor;
+import org.apache.nifi.flow.VersionedConfigurableExtension;
+import org.apache.nifi.flow.VersionedControllerService;
+import org.apache.nifi.flow.VersionedParameter;
+import org.apache.nifi.flow.VersionedParameterContext;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.flow.VersionedProcessor;
+import org.apache.nifi.flow.VersionedPropertyDescriptor;
+import org.apache.nifi.minifi.commons.service.FlowSerDeService;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+public class FlowPropertyEncryptorTest {
Review Comment:
Thanks for the catch, renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2244) C2: Change JSON flow definition mimetype to application/json
[ https://issues.apache.org/jira/browse/MINIFICPP-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2244: - Description: After NiFi version 2.0 json config will be the only supported format of the minifi c2 server, and the previously used application/vnd.minifi-c2+json;version=1 mime type will not be accepted anymore. This should be changed to application/json in the C2 agent and we should also update our minifi c2 tests to use json configurations. > C2: Change JSON flow definition mimetype to application/json > > > Key: MINIFICPP-2244 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2244 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > > After NiFi version 2.0 json config will be the only supported format of the > minifi c2 server, and the previously used > application/vnd.minifi-c2+json;version=1 mime type will not be accepted > anymore. This should be changed to application/json in the C2 agent and we > should also update our minifi c2 tests to use json configurations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2244) C2: Change JSON flow definition mimetype to application/json
[ https://issues.apache.org/jira/browse/MINIFICPP-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2244: Assignee: Gábor Gyimesi > C2: Change JSON flow definition mimetype to application/json > > > Key: MINIFICPP-2244 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2244 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11288) When using AssumeRoleWithWebIdentity method, the STS dependencies is missing.
[
https://issues.apache.org/jira/browse/NIFI-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julien G. updated NIFI-11288:
-
Status: Patch Available (was: Open)
> When using AssumeRoleWithWebIdentity method, the STS dependencies is missing.
> -
>
> Key: NIFI-11288
> URL: https://issues.apache.org/jira/browse/NIFI-11288
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions, NiFi Registry
>Reporter: Julian Zhang
>Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When NiFi Processors or NiFi Registry accesses AWS services using the
> AssumeRoleWithWebIdentity method in the AWSCredentialsProviderChain class,
> the correct credentials are not available due to the lack of STS dependencies.
> {code:java}
> 2023-03-14 15:56:44,700 DEBUG [Timer-Driven Process Thread-2]
> c.a.auth.AWSCredentialsProviderChain Unable to load credentials from
> WebIdentityTokenCredentialsProvider: To use assume role profiles the
> aws-java-sdk-sts module must be on the class path. {code}
> ADDITIONAL INFORMATION: STS lib needs to be on class path for the
> WebidentityTokenCredentialsProvider to work properly, otherwise it will be
> skipped in DefaultAWSCredentialsProviderChain.
> https://github.com/aws/aws-sdk-java/issues/2136
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
