[jira] [Updated] (NIFI-12680) DefaultedDynamicClassPathModificationIT Fails due to Missing JAR
[ https://issues.apache.org/jira/browse/NIFI-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12680: Status: Patch Available (was: Open) > DefaultedDynamicClassPathModificationIT Fails due to Missing JAR > > > Key: NIFI-12680 > URL: https://issues.apache.org/jira/browse/NIFI-12680 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.25.0 >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The system test DefaultedDynamicClassPathModificationIT fails while waiting > for a valid Processor due to a reference to commons-lang3 version 3.13.0, > which is no longer current as of recent upgrades to version 3.14.0. This test > succeeds on the current main branch, but fails on the support branch due to > the version change in the library used for testing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12680 Fix JAR for DefaultedDynamicClassPathModificationIT on Support Branch [nifi]
exceptionfactory opened a new pull request, #8307: URL: https://github.com/apache/nifi/pull/8307 # Summary [NIFI-12680](https://issues.apache.org/jira/browse/NIFI-12680) Corrects the `DefaultedDynamicClassPathModificationIT` system test on the support branch following the same strategy as implemented on the current main branch. The test fails due to a hard-coded default property value referencing commons-lang3 3.13.0. The changes check the `lib/bootstrap` directory for the current available version. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12680) DefaultedDynamicClassPathModificationIT Fails due to Missing JAR
David Handermann created NIFI-12680: --- Summary: DefaultedDynamicClassPathModificationIT Fails due to Missing JAR Key: NIFI-12680 URL: https://issues.apache.org/jira/browse/NIFI-12680 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.25.0 Reporter: David Handermann Assignee: David Handermann The system test DefaultedDynamicClassPathModificationIT fails while waiting for a valid Processor due to a reference to commons-lang3 version 3.13.0, which is no longer current as of recent upgrades to version 3.14.0. This test succeeds on the current main branch, but fails on the support branch due to the version change in the library used for testing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-9677) LookUpRecord record path evaluation is "breaking" the next evaluation in case data is missing
[
https://issues.apache.org/jira/browse/NIFI-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811456#comment-17811456
]
ASF subversion and git services commented on NIFI-9677:
---
Commit 59ff1b6561863c500283d665e9675979b065e78b in nifi's branch
refs/heads/main from jsteinebrey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=59ff1b6561 ]
NIFI-9677 Fixed issue that an empty JSON array causes flow file to be
considered unmatched even though it should be considered as a match.
Refactored to avoid streaming over the list twice.
Tweaked unit test, so it works in NiFi 1.x also.
Signed-off-by: Matt Burgess
This closes #8266
> LookUpRecord record path evaluation is "breaking" the next evaluation in case
> data is missing
> -
>
> Key: NIFI-9677
> URL: https://issues.apache.org/jira/browse/NIFI-9677
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Environment: Apache NiFi custom built from Github repo.
>Reporter: Peter Molnar
>Assignee: Jim Steinebrey
>Priority: Major
> Attachments: LookUpRecord_empty_array_data_issue.xml,
> image-2022-02-11-12-30-53-134.png, image-2022-02-11-12-32-01-833.png,
> image-2022-02-11-12-33-23-283.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Input JSON generated by GenerateFlowFile processor looks like this (actually
> I just added a currencies array under each record in addition to the "Record
> Update Strategy - Replace Existing Values" example here
> [https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.15.0/org.apache.nifi.processors.standard.LookupRecord/additionalDetails.html).]
> *Note:* for the first record currencies array is empty.
>
> {code:java}
> [
> {
> "locales": [
> {
> "region": "FR",
> "language": "fr"
> }, {
> "region": "US",
> "language": "en"
> }
> ],
> "currencies": []
> }, {
> "locales": [
> {
> "region": "CA",
> "language": "fr"
> },
> {
> "region": "JP",
> "language": "ja"
> }
> ],
> "currencies": [
> {
> "currency": "CAD"
> }, {
> "currency": "JPY"
> }
> ]
> }
> ]{code}
>
> SimpleKeyValueLookUp service contains the following values:
> !image-2022-02-11-12-33-23-283.png!
>
> LookUpRecord processor is configured as follows:
> !image-2022-02-11-12-30-53-134.png!
> Once I execute the LookUpRecord processor for the flow file, language look up
> works fine, but the look up for currencies and regions do not work.
>
> !image-2022-02-11-12-32-01-833.png!
> *Note:* in case the 1st currencies array is not empty but contains \{
> "currency": "EUR" }, \{ "currency": "USD" }, all look up works fine. But a
> missing data seems to break the next evaluation of the record path.
> Please find the template for reproducing the issue enclosed as
> "LookUpRecord_empty_array_data_issue.xml".
> Thank you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-9677) LookUpRecord record path evaluation is "breaking" the next evaluation in case data is missing
[
https://issues.apache.org/jira/browse/NIFI-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-9677:
---
Fix Version/s: 2.0.0
1.26.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> LookUpRecord record path evaluation is "breaking" the next evaluation in case
> data is missing
> -
>
> Key: NIFI-9677
> URL: https://issues.apache.org/jira/browse/NIFI-9677
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Environment: Apache NiFi custom built from Github repo.
>Reporter: Peter Molnar
>Assignee: Jim Steinebrey
>Priority: Major
> Fix For: 2.0.0, 1.26.0
>
> Attachments: LookUpRecord_empty_array_data_issue.xml,
> image-2022-02-11-12-30-53-134.png, image-2022-02-11-12-32-01-833.png,
> image-2022-02-11-12-33-23-283.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Input JSON generated by GenerateFlowFile processor looks like this (actually
> I just added a currencies array under each record in addition to the "Record
> Update Strategy - Replace Existing Values" example here
> [https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.15.0/org.apache.nifi.processors.standard.LookupRecord/additionalDetails.html).]
> *Note:* for the first record currencies array is empty.
>
> {code:java}
> [
> {
> "locales": [
> {
> "region": "FR",
> "language": "fr"
> }, {
> "region": "US",
> "language": "en"
> }
> ],
> "currencies": []
> }, {
> "locales": [
> {
> "region": "CA",
> "language": "fr"
> },
> {
> "region": "JP",
> "language": "ja"
> }
> ],
> "currencies": [
> {
> "currency": "CAD"
> }, {
> "currency": "JPY"
> }
> ]
> }
> ]{code}
>
> SimpleKeyValueLookUp service contains the following values:
> !image-2022-02-11-12-33-23-283.png!
>
> LookUpRecord processor is configured as follows:
> !image-2022-02-11-12-30-53-134.png!
> Once I execute the LookUpRecord processor for the flow file, language look up
> works fine, but the look up for currencies and regions do not work.
>
> !image-2022-02-11-12-32-01-833.png!
> *Note:* in case the 1st currencies array is not empty but contains \{
> "currency": "EUR" }, \{ "currency": "USD" }, all look up works fine. But a
> missing data seems to break the next evaluation of the record path.
> Please find the template for reproducing the issue enclosed as
> "LookUpRecord_empty_array_data_issue.xml".
> Thank you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-9677 Fixed LookupRecord issue that an empty JSON array caused mismatch [nifi]
mattyb149 closed pull request #8266: NIFI-9677 Fixed LookupRecord issue that an empty JSON array caused mismatch URL: https://github.com/apache/nifi/pull/8266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-9677 Fixed LookupRecord issue that an empty JSON array caused mismatch [nifi]
mattyb149 commented on PR #8266: URL: https://github.com/apache/nifi/pull/8266#issuecomment-1912930704 +1 LGTM, thanks for the fix! Merging to support/nifi-1.x and main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9677) LookUpRecord record path evaluation is "breaking" the next evaluation in case data is missing
[
https://issues.apache.org/jira/browse/NIFI-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811455#comment-17811455
]
ASF subversion and git services commented on NIFI-9677:
---
Commit 4c1edbefa36cda8ad19d4d1956a678558d50eca8 in nifi's branch
refs/heads/support/nifi-1.x from jsteinebrey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4c1edbefa3 ]
NIFI-9677 Fixed issue that an empty JSON array causes flow file to be
considered unmatched even though it should be considered as a match.
Refactored to avoid streaming over the list twice.
Tweaked unit test, so it works in NiFi 1.x also.
Signed-off-by: Matt Burgess
> LookUpRecord record path evaluation is "breaking" the next evaluation in case
> data is missing
> -
>
> Key: NIFI-9677
> URL: https://issues.apache.org/jira/browse/NIFI-9677
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Environment: Apache NiFi custom built from Github repo.
>Reporter: Peter Molnar
>Assignee: Jim Steinebrey
>Priority: Major
> Attachments: LookUpRecord_empty_array_data_issue.xml,
> image-2022-02-11-12-30-53-134.png, image-2022-02-11-12-32-01-833.png,
> image-2022-02-11-12-33-23-283.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Input JSON generated by GenerateFlowFile processor looks like this (actually
> I just added a currencies array under each record in addition to the "Record
> Update Strategy - Replace Existing Values" example here
> [https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.15.0/org.apache.nifi.processors.standard.LookupRecord/additionalDetails.html).]
> *Note:* for the first record currencies array is empty.
>
> {code:java}
> [
> {
> "locales": [
> {
> "region": "FR",
> "language": "fr"
> }, {
> "region": "US",
> "language": "en"
> }
> ],
> "currencies": []
> }, {
> "locales": [
> {
> "region": "CA",
> "language": "fr"
> },
> {
> "region": "JP",
> "language": "ja"
> }
> ],
> "currencies": [
> {
> "currency": "CAD"
> }, {
> "currency": "JPY"
> }
> ]
> }
> ]{code}
>
> SimpleKeyValueLookUp service contains the following values:
> !image-2022-02-11-12-33-23-283.png!
>
> LookUpRecord processor is configured as follows:
> !image-2022-02-11-12-30-53-134.png!
> Once I execute the LookUpRecord processor for the flow file, language look up
> works fine, but the look up for currencies and regions do not work.
>
> !image-2022-02-11-12-32-01-833.png!
> *Note:* in case the 1st currencies array is not empty but contains \{
> "currency": "EUR" }, \{ "currency": "USD" }, all look up works fine. But a
> missing data seems to break the next evaluation of the record path.
> Please find the template for reproducing the issue enclosed as
> "LookUpRecord_empty_array_data_issue.xml".
> Thank you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Routing error handling * General API response error handling ** Management CS (NIFI-12663) * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) **
Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]
mcgilman commented on code in PR #8273:
URL: https://github.com/apache/nifi/pull/8273#discussion_r1468196770
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js:
##
@@ -400,6 +406,554 @@
}
}
+/**
+ * The flow analysis controller.
+ */
+
+this.flowAnalysis = {
+
+/**
+ * Create the list of rule violations
+ */
+buildRuleViolationsList: function(rules, violationsAndRecs) {
+var ruleViolationCountEl = $('#rule-violation-count');
+var ruleViolationListEl = $('#rule-violations-list');
+var ruleWarningCountEl = $('#rule-warning-count');
+var ruleWarningListEl = $('#rule-warnings-list');
+var violations = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'ENFORCE'
+});
+var warnings = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'WARN'
+});
+ruleViolationCountEl.empty().text('(' + violations.length
+ ')');
+ruleWarningCountEl.empty().text('(' + warnings.length +
')');
+ruleViolationListEl.empty();
+violations.forEach(function(violation) {
+var rule = rules.find(function(rule) {
+return rule.id === violation.ruleId;
+});
+// create DOM elements
+var violationListItemEl = $('');
+var violationEl = $('');
+var violationListItemWrapperEl = $('');
+var violationRuleEl = $('');
+var violationListItemNameEl = $('');
+var violationListItemIdEl = $('');
+var violationInfoButtonEl = $('');
+
+// add text content and button data
+$(violationRuleEl).text(rule.name);
+
$(violationListItemNameEl).text(violation.subjectDisplayName);
+$(violationListItemIdEl).text(violation.subjectId);
+
$(violationListItemEl).append(violationRuleEl).append(violationListItemWrapperEl);
+$(violationInfoButtonEl).data('violationInfo',
violation);
+
+// build list DOM structure
+
violationListItemWrapperEl.append(violationListItemNameEl).append(violationListItemIdEl);
+
violationEl.append(violationListItemWrapperEl).append(violationInfoButtonEl);
+
violationListItemEl.append(violationRuleEl).append(violationEl)
+ruleViolationListEl.append(violationListItemEl);
+});
+
+warnings.forEach(function(warning) {
+var rule = rules.find(function(rule) {
+return rule.id === warning.ruleId;
+});
+// create DOM elements
+var warningListItemEl = $('');
+var warningEl = $('');
+var warningListItemWrapperEl = $('');
+var warningRuleEl = $('');
+var warningListItemNameEl = $('');
+var warningListItemIdEl = $('');
+var warningInfoButtonEl = $('');
+
+// add text content and button data
+$(warningRuleEl).text(rule.name);
+
$(warningListItemNameEl).text(warning.subjectDisplayName);
+$(warningListItemIdEl).text(warning.subjectId);
+
$(warningListItemEl).append(warningRuleEl).append(warningListItemWrapperEl);
+$(warningInfoButtonEl).data('violationInfo', warning);
+
+// build list DOM structure
+
warningListItemWrapperEl.append(warningListItemNameEl).append(warningListItemIdEl);
+
warningEl.append(warningListItemWrapperEl).append(warningInfoButtonEl);
+
warningListItemEl.append(warningRuleEl).append(warningEl)
+ruleWarningListEl.append(warningListItemEl);
+});
+},
+
+/**
+ *
+ * Render a new list when it differs from the previous
violations response
+ */
+buildRuleViolations: function(rules, violations) {
+if
Re: [PR] NIFI-12663: Error Handling in CS Listing [nifi]
mcgilman commented on PR #8305: URL: https://github.com/apache/nifi/pull/8305#issuecomment-1912757719 Thanks for the review @rfellows! I hadn't targeted the property descriptor and new inline service error handling but it makes sense to address it now since it's exposed through the edit service dialog. I've already addressed a few of the items above but still need to consider the descriptor and inline service concerns. Will comment again once it's all ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12663: Error Handling in CS Listing [nifi]
rfellows commented on code in PR #8305:
URL: https://github.com/apache/nifi/pull/8305#discussion_r1468061938
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/message/message.component.ts:
##
@@ -16,15 +16,19 @@
*/
import { Component, Input } from '@angular/core';
-import { AuthStorage } from '../../../../service/auth-storage.service';
-import { AuthService } from '../../../../service/auth.service';
+import { AuthStorage } from '../../../service/auth-storage.service';
+import { AuthService } from '../../../service/auth.service';
+import { RouterLink } from '@angular/router';
+import { NgIf } from '@angular/common';
@Component({
-selector: 'login-message',
-templateUrl: './login-message.component.html',
-styleUrls: ['./login-message.component.scss']
+selector: 'message',
+standalone: true,
+templateUrl: './message.component.html',
+imports: [RouterLink, NgIf],
+styleUrls: ['./message.component.scss']
})
-export class LoginMessage {
+export class Message {
Review Comment:
We should probably rename this one too, Its not really a generic message
component.
Also...
I think we should allow the "message" to be `ng-content` instead of a basic
`@Input()`.
That way we could provide whatever we want in the message
```
{{someMessageHere}}
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/banner/banner.component.ts:
##
@@ -17,28 +17,25 @@
import { Component } from '@angular/core';
import { Store } from '@ngrx/store';
-import { CanvasState } from '../../../state';
-import { selectApiError } from '../../../state/flow/flow.selectors';
-import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
-import { NgClass, NgIf } from '@angular/common';
+import { AsyncPipe, NgForOf, NgIf } from '@angular/common';
+import { MatButtonModule } from '@angular/material/button';
+import { NiFiState } from '../../../state';
+import { selectBannerErrors } from '../../../state/error/error.selectors';
+import { clearBannerErrors } from '../../../state/error/error.actions';
@Component({
selector: 'banner',
standalone: true,
-imports: [NgClass, NgIf],
+imports: [NgIf, NgForOf, MatButtonModule, AsyncPipe],
templateUrl: './banner.component.html',
styleUrls: ['./banner.component.scss']
})
export class Banner {
Review Comment:
Banner is a generic term that implies broader re-use capabilities than this
provides. Maybe we should rename it to be more specific to what it does, like
`ErrorBanner` or something.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/error/error.effects.ts:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { Actions, createEffect, ofType } from '@ngrx/effects';
+import * as ErrorActions from './error.actions';
+import { map, tap } from 'rxjs';
+import { Router } from '@angular/router';
+import { MatSnackBar } from '@angular/material/snack-bar';
+
+@Injectable()
+export class ErrorEffects {
+constructor(
+private actions$: Actions,
+private router: Router,
+private snackBar: MatSnackBar
+) {}
+
+fullScreenError$ = createEffect(
+() =>
+this.actions$.pipe(
+ofType(ErrorActions.fullScreenError),
+tap(() => {
+this.router.navigate(['/error']);
+})
+),
+{ dispatch: false }
+);
+
+snackBarError$ = createEffect(
+() =>
+this.actions$.pipe(
+ofType(ErrorActions.snackBarError),
+map((action) => action.error),
+tap((error) => {
+this.snackBar.open(error, 'Dismiss');
Review Comment:
We might want to consider putting an auto-close duration on these. The
snackbar remains until dismissed... even if the user navigates away from the
page/route where the error originated.
Maybe this is
[jira] [Updated] (NIFI-12679) Prompt to copy during Policy override
[ https://issues.apache.org/jira/browse/NIFI-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12679: --- Status: Patch Available (was: In Progress) > Prompt to copy during Policy override > - > > Key: NIFI-12679 > URL: https://issues.apache.org/jira/browse/NIFI-12679 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When overriding a component, the UI should prompt whether the new policy > should be empty or a copy of the parent policy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12679) Prompt to copy during Policy override
Matt Gilman created NIFI-12679: -- Summary: Prompt to copy during Policy override Key: NIFI-12679 URL: https://issues.apache.org/jira/browse/NIFI-12679 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman When overriding a component, the UI should prompt whether the new policy should be empty or a copy of the parent policy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12663: Error Handling in CS Listing [nifi]
rfellows commented on PR #8305: URL: https://github.com/apache/nifi/pull/8305#issuecomment-1912511527 will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12622) Parameter Providers
[ https://issues.apache.org/jira/browse/NIFI-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12622: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Parameter Providers > --- > > Key: NIFI-12622 > URL: https://issues.apache.org/jira/browse/NIFI-12622 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12622) Parameter Providers
[ https://issues.apache.org/jira/browse/NIFI-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811361#comment-17811361 ] ASF subversion and git services commented on NIFI-12622: Commit 0e87032ef3e2b74c1451f5859e277e6d9787b4d8 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e87032ef3 ] [NIFI-12622] - Parameter Providers - listing table (#8298) * [NIFI-12622] - Parameter Providers - listing table * Add a new Parameter Provider * Delete parameter provider * refactor to reduce duplicate code when creating new properties * support editing parameter providers * refactored inline service creation into PropertyTableHelperService * added parameter provider linking to access policies. * fix bugs in flow reducer not setting state properly when starting/stopping components and run once. * address review feedback * refactored nifiCommon to provide stripProtocol method that was implemented in loads of places. replaced all occurrences to the nifiCommon implementation. This closes #8298 > Parameter Providers > --- > > Key: NIFI-12622 > URL: https://issues.apache.org/jira/browse/NIFI-12622 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12622] - Parameter Providers - listing table [nifi]
mcgilman merged PR #8298: URL: https://github.com/apache/nifi/pull/8298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12663) Management Controller Services - General API error response handling
[ https://issues.apache.org/jira/browse/NIFI-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12663: --- Status: Patch Available (was: In Progress) > Management Controller Services - General API error response handling > > > Key: NIFI-12663 > URL: https://issues.apache.org/jira/browse/NIFI-12663 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Update the Management Controller Services page to show API error responses. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12663: Error Handling in CS Listing [nifi]
mcgilman opened a new pull request, #8305: URL: https://github.com/apache/nifi/pull/8305 NIFI-12663: - Handling API error responses in the Management Controller Services page. The following items are covered in this PR 1) Snackbar errors for management service creation or deletion failure. 2) Banner errors in edit management service dialog. (enable/disable not covered in this PR) 3) Full screen error when initially loading management service listing. 4) Full screen error with missing or expired token. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12678) Link from Reporting Task to referenced Controller Service not fully working
Nissim Shiman created NIFI-12678: Summary: Link from Reporting Task to referenced Controller Service not fully working Key: NIFI-12678 URL: https://issues.apache.org/jira/browse/NIFI-12678 Project: Apache NiFi Issue Type: Bug Reporter: Nissim Shiman If a reporting task is referencing a controller service, clicking on the arrow leading to the controller service will bring user to the Management Controller Services tab, but will point to the top controller service on the list. So, for example, if SiteToSiteProvenanceReportingTask has SSL Context Service set, clicking on the arrow to the right of the value will take us to the Management Controller Services tab, but will point to the top controller service on the list. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12677) ExcelReader documentation gives an example of a non existent strategy
[
https://issues.apache.org/jira/browse/NIFI-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12677:
Summary: ExcelReader documentation gives an example of a non existent
strategy (was: ExcelReader give an example of a non existent strategy)
> ExcelReader documentation gives an example of a non existent strategy
> -
>
> Key: NIFI-12677
> URL: https://issues.apache.org/jira/browse/NIFI-12677
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Labels: backport-needed
>
> In the Addtional Details of Excel Reader it gives an example for a strategy
> "Use Fields From Header" which does not exist. This ticket addresses the need
> to remove the whole paragraph with the title
> {quote}
> Example 2 - Schema with Excel Header Line
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12677) ExcelReader give an example of a non existent strategy
[
https://issues.apache.org/jira/browse/NIFI-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12677:
Labels: backport-needed (was: )
> ExcelReader give an example of a non existent strategy
> --
>
> Key: NIFI-12677
> URL: https://issues.apache.org/jira/browse/NIFI-12677
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Labels: backport-needed
>
> In the Addtional Details of Excel Reader it gives an example for a strategy
> "Use Fields From Header" which does not exist. This ticket addresses the need
> to remove the whole
> {quote}
> Example 2 - Schema with Excel Header Line
> {quote}
> paragraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12677) ExcelReader give an example of a non existent strategy
[
https://issues.apache.org/jira/browse/NIFI-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12677:
Description:
In the Addtional Details of Excel Reader it gives an example for a strategy
"Use Fields From Header" which does not exist. This ticket addresses the need
to remove the whole paragraph with the title
{quote}
Example 2 - Schema with Excel Header Line
{quote}
was:
In the Addtional Details of Excel Reader it gives an example for a strategy
"Use Fields From Header" which does not exist. This ticket addresses the need
to remove the whole
{quote}
Example 2 - Schema with Excel Header Line
{quote}
paragraph.
> ExcelReader give an example of a non existent strategy
> --
>
> Key: NIFI-12677
> URL: https://issues.apache.org/jira/browse/NIFI-12677
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Labels: backport-needed
>
> In the Addtional Details of Excel Reader it gives an example for a strategy
> "Use Fields From Header" which does not exist. This ticket addresses the need
> to remove the whole paragraph with the title
> {quote}
> Example 2 - Schema with Excel Header Line
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12677) ExcelReader give an example of a non existent strategy
Daniel Stieglitz created NIFI-12677:
---
Summary: ExcelReader give an example of a non existent strategy
Key: NIFI-12677
URL: https://issues.apache.org/jira/browse/NIFI-12677
Project: Apache NiFi
Issue Type: Bug
Reporter: Daniel Stieglitz
Assignee: Daniel Stieglitz
In the Addtional Details of Excel Reader it gives an example for a strategy
"Use Fields From Header" which does not exist. This ticket addresses the need
to remove the whole
{quote}
Example 2 - Schema with Excel Header Line
{quote}
paragraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2270) AWS extension does not compile on Visual Studio 17.8 or above
[ https://issues.apache.org/jira/browse/MINIFICPP-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2270: Assignee: Marton Szasz > AWS extension does not compile on Visual Studio 17.8 or above > - > > Key: MINIFICPP-2270 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2270 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Martin Zink >Assignee: Marton Szasz >Priority: Major > > Due to [https://github.com/aws/aws-sdk-cpp/pull/2726] > > We should upgrade the sdk -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2270) AWS extension does not compile on Visual Studio 17.8 or above
[ https://issues.apache.org/jira/browse/MINIFICPP-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-2270. -- Resolution: Fixed > AWS extension does not compile on Visual Studio 17.8 or above > - > > Key: MINIFICPP-2270 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2270 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Martin Zink >Assignee: Marton Szasz >Priority: Major > > Due to [https://github.com/aws/aws-sdk-cpp/pull/2726] > > We should upgrade the sdk -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12643) Add local file upload option in PutGCS processor
[ https://issues.apache.org/jira/browse/NIFI-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12643: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add local file upload option in PutGCS processor > > > Key: NIFI-12643 > URL: https://issues.apache.org/jira/browse/NIFI-12643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutGCSObject* > processor, add option to upload file from the local filesystem directly to > GCS storage by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12642 Added support for FileResourceService in PutS3Object [nifi]
balazsgerner commented on code in PR #8295:
URL: https://github.com/apache/nifi/pull/8295#discussion_r1467694135
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java:
##
@@ -88,6 +100,74 @@ public static void setupClass() {
kmsKeyId = getKMSKey();
}
+@AfterEach
+public void tearDown() {
+// clear bucket content
+AmazonS3 client = getClient();
+List objectSummaries =
client.listObjects(BUCKET_NAME).getObjectSummaries();
+if (!objectSummaries.isEmpty()) {
+client.deleteObjects(new DeleteObjectsRequest(BUCKET_NAME)
+.withKeys(objectSummaries.stream()
+.map(S3ObjectSummary::getKey)
+.toArray(String[]::new)));
+}
Review Comment:
Fixed in
[7b26f3b](https://github.com/apache/nifi/pull/8295/commits/7b26f3b4fd6641388eebf4ac0d59f17aa92a6a0e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling ** Management CS (NIFI-12663) * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy
Re: [PR] [NIFI-12622] - Parameter Providers - listing table [nifi]
mcgilman commented on code in PR #8298:
URL: https://github.com/apache/nifi/pull/8298#discussion_r1467676005
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/parameter-providers/parameter-providers.component.ts:
##
@@ -15,11 +15,109 @@
* limitations under the License.
*/
-import { Component } from '@angular/core';
+import { Component, OnDestroy, OnInit } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { NiFiState } from '../../../../state';
+import { ParameterProviderEntity, ParameterProvidersState } from
'../../state/parameter-providers';
+import { selectCurrentUser } from
'../../../../state/current-user/current-user.selectors';
+import {
+selectParameterProvider,
+selectParameterProviderIdFromRoute,
+selectParameterProvidersState,
+selectSingleEditedParameterProvider
+} from '../../state/parameter-providers/parameter-providers.selectors';
+import { selectFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.selectors';
+import { loadFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.actions';
+import * as ParameterProviderActions from
'../../state/parameter-providers/parameter-providers.actions';
+import { initialParameterProvidersState } from
'../../state/parameter-providers/parameter-providers.reducer';
+import { filter, switchMap, take } from 'rxjs';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
@Component({
selector: 'parameter-providers',
templateUrl: './parameter-providers.component.html',
styleUrls: ['./parameter-providers.component.scss']
})
-export class ParameterProviders {}
+export class ParameterProviders implements OnInit, OnDestroy {
+currentUser$ = this.store.select(selectCurrentUser);
+parameterProvidersState$ =
this.store.select(selectParameterProvidersState);
+selectedParameterProviderId$ =
this.store.select(selectParameterProviderIdFromRoute);
+flowConfiguration$ = this.store.select(selectFlowConfiguration);
+
+constructor(private store: Store) {
+this.store
+.select(selectSingleEditedParameterProvider)
+.pipe(
+filter((id: string) => !!id),
Review Comment:
Should be able to use `isDefinedAndNotNull` here.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/parameter-providers/parameter-providers.component.ts:
##
@@ -15,11 +15,109 @@
* limitations under the License.
*/
-import { Component } from '@angular/core';
+import { Component, OnDestroy, OnInit } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { NiFiState } from '../../../../state';
+import { ParameterProviderEntity, ParameterProvidersState } from
'../../state/parameter-providers';
+import { selectCurrentUser } from
'../../../../state/current-user/current-user.selectors';
+import {
+selectParameterProvider,
+selectParameterProviderIdFromRoute,
+selectParameterProvidersState,
+selectSingleEditedParameterProvider
+} from '../../state/parameter-providers/parameter-providers.selectors';
+import { selectFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.selectors';
+import { loadFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.actions';
+import * as ParameterProviderActions from
'../../state/parameter-providers/parameter-providers.actions';
+import { initialParameterProvidersState } from
'../../state/parameter-providers/parameter-providers.reducer';
+import { filter, switchMap, take } from 'rxjs';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
@Component({
selector: 'parameter-providers',
templateUrl: './parameter-providers.component.html',
styleUrls: ['./parameter-providers.component.scss']
})
-export class ParameterProviders {}
+export class ParameterProviders implements OnInit, OnDestroy {
+currentUser$ = this.store.select(selectCurrentUser);
+parameterProvidersState$ =
this.store.select(selectParameterProvidersState);
+selectedParameterProviderId$ =
this.store.select(selectParameterProviderIdFromRoute);
+flowConfiguration$ = this.store.select(selectFlowConfiguration);
+
+constructor(private store: Store) {
+this.store
+.select(selectSingleEditedParameterProvider)
+.pipe(
+filter((id: string) => !!id),
+switchMap((id: string) =>
+this.store.select(selectParameterProvider(id)).pipe(
+filter((entity) => !!entity),
Review Comment:
Should be able to use `isDefinedAndNotNull` here.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/property-table-helper.service.ts:
##
@@ -0,0
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue
Re: [PR] NIFI-12673 - ExtractKeywords processor [nifi]
exceptionfactory commented on code in PR #8302: URL: https://github.com/apache/nifi/pull/8302#discussion_r1467668838 ## nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ExtractKeywords.py: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import yake + +from nifiapi.flowfiletransform import FlowFileTransform, FlowFileTransformResult +from nifiapi.properties import PropertyDescriptor, StandardValidators, ExpressionLanguageScope + +class ExtractKeywords(FlowFileTransform): +class Java: +implements = ["org.apache.nifi.python.processor.FlowFileTransform"] + +class ProcessorDetails: +version = "2.0.0-SNAPSHOT" +description = """Parses the content of the incoming FlowFile to extract the keywords and add those as attributes +using the convention 'keyword.i' where i is a number depending on how many keywords are extracted. The attribute +'keywords.length' will be set with the number of extracted keywords. The attribute 'keyword.0' will contain the +list of all extracted keywords with the associated score.""" +tags = ["text", "keyword", "vector", "extract"] +dependencies = ['yake'] Review Comment: For reference, I think this highlights a reason for moving Python-based components to a separate repository, where there would be a clearer distinction between what is standard, and what is optional for project operation. https://lists.apache.org/thread/nok561sg1dzw3zrott06gkl34hdjxbb3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12643 Added support for FileResourceService in PutGCSObject [nifi]
asfgit closed pull request #8281: NIFI-12643 Added support for FileResourceService in PutGCSObject URL: https://github.com/apache/nifi/pull/8281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12643) Add local file upload option in PutGCS processor
[ https://issues.apache.org/jira/browse/NIFI-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811278#comment-17811278 ] ASF subversion and git services commented on NIFI-12643: Commit bce14f573b57685637d776333029641e62730d26 in nifi's branch refs/heads/main from Balázs Gerner [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=bce14f573b ] NIFI-12643 Added support for FileResourceService in PutGCSObject This closes #8281. Signed-off-by: Peter Turcsanyi > Add local file upload option in PutGCS processor > > > Key: NIFI-12643 > URL: https://issues.apache.org/jira/browse/NIFI-12643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutGCSObject* > processor, add option to upload file from the local filesystem directly to > GCS storage by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12673 - ExtractKeywords processor [nifi]
exceptionfactory commented on code in PR #8302: URL: https://github.com/apache/nifi/pull/8302#discussion_r1467655082 ## nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ExtractKeywords.py: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import yake + +from nifiapi.flowfiletransform import FlowFileTransform, FlowFileTransformResult +from nifiapi.properties import PropertyDescriptor, StandardValidators, ExpressionLanguageScope + +class ExtractKeywords(FlowFileTransform): +class Java: +implements = ["org.apache.nifi.python.processor.FlowFileTransform"] + +class ProcessorDetails: +version = "2.0.0-SNAPSHOT" +description = """Parses the content of the incoming FlowFile to extract the keywords and add those as attributes +using the convention 'keyword.i' where i is a number depending on how many keywords are extracted. The attribute +'keywords.length' will be set with the number of extracted keywords. The attribute 'keyword.0' will contain the +list of all extracted keywords with the associated score.""" +tags = ["text", "keyword", "vector", "extract"] +dependencies = ['yake'] Review Comment: Thanks for the reply @pvillard31. Although we are not including the `yake` library as part of the release distribution, it is required to use this component. That puts it in a different category than something like JDBC drivers, which can have any type of license that the user can accept. The Apache Licensing guidance as a section on [relying on dependencies with prohibited licenses when they support an optional feature](https://www.apache.org/legal/resolved.html#optional): > Optional means that the component is not required for standard use of the product or for the product to achieve a desirable level of quality. > The question to ask yourself in this situation is: "Will the majority of users want to use my product without adding the optional components?" From a general reading, it sounds like that could be construed to allow this type of inclusion, but it still seems questionable. Particularly in light of the summary question, if a user were to install this component, it would not be clear that they were also installing a component licensed under GPLv3 unless they analyzed the dependencies after installation. Furthermore, while this might be acceptable for components with marginal use, the summary question also seems to discourage such inclusion based on the level of use. In other words, we would not want to use this as justification for something we expect to be widely used. This sounds like a question that may need further input from Apache, but based on this initial reading, I think we should draw a clear line here and avoid Category X dependencies, as they are required at runtime, even though we are not distributing them directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12642 Added support for FileResourceService in PutS3Object [nifi]
turcsanyip commented on code in PR #8295:
URL: https://github.com/apache/nifi/pull/8295#discussion_r1467623687
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java:
##
@@ -88,6 +100,74 @@ public static void setupClass() {
kmsKeyId = getKMSKey();
}
+@AfterEach
+public void tearDown() {
+// clear bucket content
+AmazonS3 client = getClient();
+List objectSummaries =
client.listObjects(BUCKET_NAME).getObjectSummaries();
+if (!objectSummaries.isEmpty()) {
+client.deleteObjects(new DeleteObjectsRequest(BUCKET_NAME)
+.withKeys(objectSummaries.stream()
+.map(S3ObjectSummary::getKey)
+.toArray(String[]::new)));
+}
Review Comment:
[AbstractS3IT](https://github.com/apache/nifi/blob/49702f1f510cc33c9cb52bb5b9580009a1d8afe8/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/AbstractS3IT.java#L133-L149)
contains similar functionality. To avoid duplication, that logic could be
extracted to `emptyBucket()` method which could be called here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12642 Added support for FileResourceService in PutS3Object [nifi]
balazsgerner commented on PR #8295: URL: https://github.com/apache/nifi/pull/8295#issuecomment-1911903310 > @balazsgerner It looks the processor does not upload the file's content in File Resource Service mode (an empty file is created only). Could you please double check it? Thanks for spotting that, the reason for this issue was that we always considered the flowfile content's size, and in the case the source is `FILE_RESOURCE_SERVICE`, the incoming flowfile content was empty. Fixed in [73f49bb](https://github.com/apache/nifi/pull/8295/commits/73f49bbc665ebfd946bfdd41b8c7f5d1419e2370) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12642 Added support for FileResourceService in PutS3Object [nifi]
balazsgerner commented on code in PR #8295:
URL: https://github.com/apache/nifi/pull/8295#discussion_r1467525114
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java:
##
@@ -517,331 +526,328 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
/*
* Then
*/
-try {
-final FlowFile flowFileCopy = flowFile;
-session.read(flowFile, new InputStreamCallback() {
-@Override
-public void process(final InputStream in) throws IOException {
-final ObjectMetadata objectMetadata = new ObjectMetadata();
-objectMetadata.setContentLength(ff.getSize());
-
-final String contentType =
context.getProperty(CONTENT_TYPE)
-.evaluateAttributeExpressions(ff).getValue();
-if (contentType != null) {
-objectMetadata.setContentType(contentType);
-attributes.put(S3_CONTENT_TYPE, contentType);
-}
+final FlowFile flowFileCopy = session.clone(flowFile);
Review Comment:
Cloning the flowfile was only used as a workaround for an issue which
occurred during unit test execution.
If the inputstream of the flowfile was open, the
`session.putAllAttributes(flowFile, attributes)` call threw exception, because
the inputstream was already in use. I agree that the cloning is not needed,
after some examination, I managed to eliminate the need for that.
See 73f49bbc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez opened a new pull request, #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721 https://issues.apache.org/jira/browse/MINIFICPP-2277 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2276 Support FlowFileTransform NiFi Python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1467516253
##
extensions/python/ExecutePythonProcessor.h:
##
@@ -118,7 +126,30 @@ class ExecutePythonProcessor : public core::Processor {
return description_;
}
+ void setPythonClassName(const std::string& python_class_name) {
+python_class_name_ = python_class_name;
+ }
+
+ void setPythonPaths(const std::vector& python_paths) {
+python_paths_ = python_paths;
+ }
+
+ protected:
+ core::Property* findProperty(const std::string& name) const override;
+
private:
+ enum class PropertyTypeCode : int64_t {
+INTEGER_TYPE = 0,
+LONG_TYPE = 1,
+BOOLEAN_TYPE = 2,
+DATA_SIZE_TYPE = 3,
+TIME_PERIOD_TYPE = 4,
+NON_BLANK_TYPE = 5,
+PORT_TYPE = 6
+ };
Review Comment:
Updated in ee23065b91cd8ba88fb7db2dfeaa5c1cb31dae55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-2292) Support notifystop in python processors
Gábor Gyimesi created MINIFICPP-2292: Summary: Support notifystop in python processors Key: MINIFICPP-2292 URL: https://issues.apache.org/jira/browse/MINIFICPP-2292 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi When calling the onTrigger function in a python processor it is done through python C API binding. This is basically a C function call which cannot be interrupted at the moment. We should find a way to implement the notifystop function in the ExecutePythonProcessor processor to be able to interrupt the running onTrigger call of the python processor if we want to. -- This message was sent by Atlassian Jira (v8.20.10#820010)
