[GitHub] [nifi] mattyb149 opened a new pull request, #6818: NIFI-10996: Write out CSV header even if there are no records

2023-01-03 Thread GitBox
mattyb149 opened a new pull request, #6818: URL: https://github.com/apache/nifi/pull/6818 # Summary [NIFI-10996](https://issues.apache.org/jira/browse/NIFI-10996) Adds code to write out the CSV header when configured to do so, even if there are no records written # Tracking

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-02 Thread GitBox
exceptionfactory commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1060158226 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/AbstractIoTDB.java: ## @@ -0,0 +1,365 @@ +/* + * Licensed to

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-02 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1369138557 @lizhizhou It looks like the latest updates included many historical commits, please rebase and force-push to correct the branch history. -- This is an automated message from the

[GitHub] [nifi] exceptionfactory closed pull request #6814: [NIFI-11018] Upgraded from Junit4 to Junit5

2023-01-02 Thread GitBox
exceptionfactory closed pull request #6814: [NIFI-11018] Upgraded from Junit4 to Junit5 URL: https://github.com/apache/nifi/pull/6814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1458: MINIFICPP-1991 - Remove unused ControllerServiceProvider methods

2023-01-02 Thread GitBox
fgerlits commented on code in PR #1458: URL: https://github.com/apache/nifi-minifi-cpp/pull/1458#discussion_r1060126151 ## libminifi/include/core/controller/StandardControllerServiceProvider.h: ## @@ -97,22 +73,15 @@ class StandardControllerServiceProvider : public

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1484: MINIFICPP-2023 Fix MacOS and Docker test github environment issues

2023-01-02 Thread GitBox
lordgamez opened a new pull request, #1484: URL: https://github.com/apache/nifi-minifi-cpp/pull/1484 - Fixing python version conflict issue of MacOS github actions VM image as suggested by https://github.com/orgs/Homebrew/discussions/3895 - Upgrading pyopenssl version in python

[GitHub] [nifi] ChrisSamo632 opened a new pull request, #6817: NIFI-2161 add option to skip attribute output for unmatched JSON path expressions in EvaluateJsonPath

2023-01-02 Thread GitBox
ChrisSamo632 opened a new pull request, #6817: URL: https://github.com/apache/nifi/pull/6817 # Summary [NIFI-2161](https://issues.apache.org/jira/browse/NIFI-2161) add option to skip attribute output for unmatched JSON path expressions in EvaluateJsonPath # Tracking

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1460: MINIFICPP-1995 Add configuring path for flowfile_checkpoint directory

2023-01-02 Thread GitBox
lordgamez commented on code in PR #1460: URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1059904518 ## extensions/rocksdb-repos/FlowFileRepository.h: ## @@ -100,11 +100,17 @@ class FlowFileRepository : public ThreadedRepository, public SwapManager {

[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-01 Thread GitBox
lizhizhou commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059840281 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/AbstractIoTDB.java: ## @@ -0,0 +1,365 @@ +/* + * Licensed to the

[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-01 Thread GitBox
lizhizhou commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059840281 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/AbstractIoTDB.java: ## @@ -0,0 +1,365 @@ +/* + * Licensed to the

[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-01 Thread GitBox
lizhizhou commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059840281 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/AbstractIoTDB.java: ## @@ -0,0 +1,365 @@ +/* + * Licensed to the

[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-01 Thread GitBox
lizhizhou commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059837395 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/AbstractIoTDB.java: ## @@ -0,0 +1,365 @@ +/* + * Licensed to the

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6814: [NIFI-11018] Upgraded from Junit4 to Junit5

2023-01-01 Thread GitBox
ChrisSamo632 commented on code in PR #6814: URL: https://github.com/apache/nifi/pull/6814#discussion_r1059721500 ##

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6813: [NIFI-11006] Upgraded from Junit4 to Junit5

2023-01-01 Thread GitBox
ChrisSamo632 commented on code in PR #6813: URL: https://github.com/apache/nifi/pull/6813#discussion_r1059721468 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/SearchableMatcherTest.java:

[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6814: [NIFI-11018] Upgraded from Junit4 to Junit5

2022-12-31 Thread GitBox
MikeThomsen commented on code in PR #6814: URL: https://github.com/apache/nifi/pull/6814#discussion_r1059677189 ##

[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6813: [NIFI-11006] Upgraded from Junit4 to Junit5

2022-12-31 Thread GitBox
MikeThomsen commented on code in PR #6813: URL: https://github.com/apache/nifi/pull/6813#discussion_r1059677168 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/SearchableMatcherTest.java:

[GitHub] [nifi] ChrisSamo632 opened a new pull request, #6816: NIFI-9206: Add RemoveRecordField processor and implement the ability to remove fields from records

2022-12-31 Thread GitBox
ChrisSamo632 opened a new pull request, #6816: URL: https://github.com/apache/nifi/pull/6816 # Summary [NIFI-9206](https://issues.apache.org/jira/browse/NIFI-9206) add the `RemoveRecordField` processor to allow for remove of Record Field(s) from FlowFile content using RecordPath

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6814: [NIFI-11018] Upgraded from Junit4 to Junit5

2022-12-31 Thread GitBox
ChrisSamo632 commented on code in PR #6814: URL: https://github.com/apache/nifi/pull/6814#discussion_r1059620434 ##

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6813: [NIFI-11006] Upgraded from Junit4 to Junit5

2022-12-31 Thread GitBox
ChrisSamo632 commented on code in PR #6813: URL: https://github.com/apache/nifi/pull/6813#discussion_r1059619260 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/SearchableMatcherTest.java:

[GitHub] [nifi] asfgit closed pull request #6815: NIFI-11015 Correct Registry Trust Store Type handling

2022-12-31 Thread GitBox
asfgit closed pull request #6815: NIFI-11015 Correct Registry Trust Store Type handling URL: https://github.com/apache/nifi/pull/6815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059539872 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/PutIoTDBRecord.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1059537189 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/PutIoTDBRecord.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1368107974 It looks like the current build is failing due to differing parent POM versions. Recommend rebasing against the current main branch, which would be a good time to squash commits

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1368106343 @lizhizhou I pushed a minor update to correct build errors related to removed CompressionType values, and also adjusted the unit test class name to match standard conventions. I

[GitHub] [nifi] exceptionfactory opened a new pull request, #6815: NIFI-11015 Correct Registry Trust Store Type handling

2022-12-30 Thread GitBox
exceptionfactory opened a new pull request, #6815: URL: https://github.com/apache/nifi/pull/6815 # Summary [NIFI-11015](https://issues.apache.org/jira/browse/NIFI-11015) Corrects NiFi Registry configuration processing of the Trust Store Type property for the internal Jetty Server.

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-30 Thread GitBox
exceptionfactory commented on code in PR #6689: URL: https://github.com/apache/nifi/pull/6689#discussion_r1059523853 ## nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java: ## @@ -0,0 +1,63

[GitHub] [nifi] exceptionfactory closed pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-30 Thread GitBox
exceptionfactory closed pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5. URL: https://github.com/apache/nifi/pull/6806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory closed pull request #6782: NIFI-10456: Add client authentication strategy option to OAuth2 provider

2022-12-30 Thread GitBox
exceptionfactory closed pull request #6782: NIFI-10456: Add client authentication strategy option to OAuth2 provider URL: https://github.com/apache/nifi/pull/6782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi] dan-s1 opened a new pull request, #6814: [NIFI-11018] Upgraded from Junit4 to Junit5

2022-12-30 Thread GitBox
dan-s1 opened a new pull request, #6814: URL: https://github.com/apache/nifi/pull/6814 # Summary [NIFI-11018](https://issues.apache.org/jira/browse/NIFI-11018) # Tracking Please complete the following tracking steps

[GitHub] [nifi] davyam commented on pull request #6053: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) from PostgreSQL tables via Logical Replicati

2022-12-30 Thread GitBox
davyam commented on PR #6053: URL: https://github.com/apache/nifi/pull/6053#issuecomment-1368052164 Hey guys, we are a little late, I know, other personal activities get in the way, but I'm still working on the improvements. ASAP we will have the CapctureChangePostgreSQL

[GitHub] [nifi] janis-ax commented on pull request #6053: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) from PostgreSQL tables via Logical Replica

2022-12-30 Thread GitBox
janis-ax commented on PR #6053: URL: https://github.com/apache/nifi/pull/6053#issuecomment-1368036088 Hey @MaheshKungaria if it's urgent for you: I build the processor, so you can try it out by putting the nar file into your lib folder.

[GitHub] [nifi] NissimShiman commented on a diff in pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory

2022-12-30 Thread GitBox
NissimShiman commented on code in PR #6783: URL: https://github.com/apache/nifi/pull/6783#discussion_r1059474644 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java: ## @@ -218,7 +218,11 @@ public

[GitHub] [nifi] NissimShiman commented on a diff in pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory

2022-12-30 Thread GitBox
NissimShiman commented on code in PR #6783: URL: https://github.com/apache/nifi/pull/6783#discussion_r1059474487 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java: ## @@ -218,7 +218,11 @@ public

[GitHub] [nifi] dan-s1 opened a new pull request, #6813: [NIFI-11006] Upgraded from Junit4 to Junit5

2022-12-30 Thread GitBox
dan-s1 opened a new pull request, #6813: URL: https://github.com/apache/nifi/pull/6813 # Summary [NIFI-11006](https://issues.apache.org/jira/browse/NIFI-11006) # Tracking Please complete the following tracking steps

[GitHub] [nifi] NissimShiman commented on pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory

2022-12-30 Thread GitBox
NissimShiman commented on PR #6783: URL: https://github.com/apache/nifi/pull/6783#issuecomment-1367926251 reviewing.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] exceptionfactory closed pull request #6812: NIFI-11017 Bump hazelcast from 4.2.5 to 4.2.6 in /nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services

2022-12-29 Thread GitBox
exceptionfactory closed pull request #6812: NIFI-11017 Bump hazelcast from 4.2.5 to 4.2.6 in /nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services URL: https://github.com/apache/nifi/pull/6812 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] dependabot[bot] commented on pull request #6812: NIFI-11017 Bump hazelcast from 4.2.5 to 4.2.6 in /nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services

2022-12-29 Thread GitBox
dependabot[bot] commented on PR #6812: URL: https://github.com/apache/nifi/pull/6812#issuecomment-1367708341 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [nifi] exceptionfactory closed pull request #6811: NIFI-11012 - Update Twitter SDK to v2

2022-12-29 Thread GitBox
exceptionfactory closed pull request #6811: NIFI-11012 - Update Twitter SDK to v2 URL: https://github.com/apache/nifi/pull/6811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] exceptionfactory closed pull request #6808: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7

2022-12-29 Thread GitBox
exceptionfactory closed pull request #6808: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7 URL: https://github.com/apache/nifi/pull/6808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6782: NIFI-10456: Add client authentication strategy option to OAuth2 provider

2022-12-29 Thread GitBox
exceptionfactory commented on code in PR #6782: URL: https://github.com/apache/nifi/pull/6782#discussion_r1059226097 ##

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6797: NIFI-10992 - Option to build all include-x profiles

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6797: URL: https://github.com/apache/nifi/pull/6797#discussion_r1059090649 ## nifi-assembly/pom.xml: ## @@ -983,6 +983,9 @@ language governing permissions and limitations under the License. --> include-graph

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
dan-s1 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059066766 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -109,6 +98,6

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059062965 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -109,6

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6750: NIFI-10934 Adding uniqueness check for Registry Client creation

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6750: URL: https://github.com/apache/nifi/pull/6750#discussion_r1059061359 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java: ## @@ -494,22 +495,26

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059057282 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -24,51

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
dan-s1 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059053833 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -24,51 +24,38

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
dan-s1 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059053833 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -24,51 +24,38

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
dan-s1 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1059053833 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -24,51 +24,38

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6778: NIFI-10970: Added a count RecordPath function

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6778: URL: https://github.com/apache/nifi/pull/6778#discussion_r1058952730 ## nifi-docs/src/main/asciidoc/record-path-guide.adoc: ## @@ -1071,6 +1071,37 @@ take the value of the supplied record path and use it as the namespace. Please

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6778: NIFI-10970: Added a count RecordPath function

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6778: URL: https://github.com/apache/nifi/pull/6778#discussion_r1058951771 ## nifi-docs/src/main/asciidoc/record-path-guide.adoc: ## @@ -1071,6 +1071,37 @@ take the value of the supplied record path and use it as the namespace. Please

[GitHub] [nifi] asfgit closed pull request #6810: NIFI-11011 - Update AWS SDK versions to 1.12.371 and 2.17.295

2022-12-29 Thread GitBox
asfgit closed pull request #6810: NIFI-11011 - Update AWS SDK versions to 1.12.371 and 2.17.295 URL: https://github.com/apache/nifi/pull/6810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1058905623 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/groovy/org/apache/nifi/remote/StandardPublicPortGroovyTest.groovy: ## @@ -24,51

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-29 Thread GitBox
ChrisSamo632 commented on code in PR #6806: URL: https://github.com/apache/nifi/pull/6806#discussion_r1058903579 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils/src/test/java/org/apache/nifi/nar/NarThreadContextClassLoaderTest.java: ## @@

[GitHub] [nifi] asfgit closed pull request #6809: NIFI-11010 - Update Kinesis client to 1.14.9

2022-12-29 Thread GitBox
asfgit closed pull request #6809: NIFI-11010 - Update Kinesis client to 1.14.9 URL: https://github.com/apache/nifi/pull/6809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] ChrisSamo632 commented on pull request #6628: NIFI-10067 enable use of script for Elasticsearch updates

2022-12-29 Thread GitBox
ChrisSamo632 commented on PR #6628: URL: https://github.com/apache/nifi/pull/6628#issuecomment-1367243167 > My vision for that processor... @MikeThomsen FYI I raised [NIFI-11016](https://issues.apache.org/jira/browse/NIFI-11016) to cover your future update to the

[GitHub] [nifi] jynolen commented on pull request #5745: NIFI-9492: Fix for Chinese VPCE - Tests included

2022-12-29 Thread GitBox
jynolen commented on PR #5745: URL: https://github.com/apache/nifi/pull/5745#issuecomment-1367174310 Not closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] github-actions[bot] closed pull request #5745: NIFI-9492: Fix for Chinese VPCE - Tests included

2022-12-28 Thread GitBox
github-actions[bot] closed pull request #5745: NIFI-9492: Fix for Chinese VPCE - Tests included URL: https://github.com/apache/nifi/pull/5745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-28 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1366789116 @exceptionfactory I added the null literal as you requested and modified the documentation to reflect this. Please let me know if my changes are what you were intending. Thanks! -- This

[GitHub] [nifi] dependabot[bot] opened a new pull request, #6812: Bump hazelcast from 4.2.5 to 4.2.6 in /nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services

2022-12-27 Thread GitBox
dependabot[bot] opened a new pull request, #6812: URL: https://github.com/apache/nifi/pull/6812 Bumps [hazelcast](https://github.com/hazelcast/hazelcast) from 4.2.5 to 4.2.6. Release notes Sourced from https://github.com/hazelcast/hazelcast/releases;>hazelcast's releases.

[GitHub] [nifi] asfgit closed pull request #6563: NIFI-10677: Add Choice data type handling to Iceberg record converter

2022-12-25 Thread GitBox
asfgit closed pull request #6563: NIFI-10677: Add Choice data type handling to Iceberg record converter URL: https://github.com/apache/nifi/pull/6563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] asfgit closed pull request #6780: NIFI-10971: improved edge case handling while fetching objects using …

2022-12-25 Thread GitBox
asfgit closed pull request #6780: NIFI-10971: improved edge case handling while fetching objects using … URL: https://github.com/apache/nifi/pull/6780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] Lehel44 commented on pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property

2022-12-24 Thread GitBox
Lehel44 commented on PR #6802: URL: https://github.com/apache/nifi/pull/6802#issuecomment-1364593106 Thank you. LGTM+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] pvillard31 opened a new pull request, #6811: NIFI-11012 - Update Twitter SDK to v2

2022-12-24 Thread GitBox
pvillard31 opened a new pull request, #6811: URL: https://github.com/apache/nifi/pull/6811 # Summary [NIFI-11012](https://issues.apache.org/jira/browse/NIFI-11012) # Tracking Please complete the following tracking steps

[GitHub] [nifi] pvillard31 opened a new pull request, #6810: NIFI-11011 - Update AWS SDK versions to 1.12.371 and 2.17.295

2022-12-24 Thread GitBox
pvillard31 opened a new pull request, #6810: URL: https://github.com/apache/nifi/pull/6810 # Summary [NIFI-11011](https://issues.apache.org/jira/browse/NIFI-11011) # Tracking Please complete the following tracking steps

[GitHub] [nifi] pvillard31 opened a new pull request, #6809: NIFI-11010 - Update Kinesis client to 1.14.9

2022-12-24 Thread GitBox
pvillard31 opened a new pull request, #6809: URL: https://github.com/apache/nifi/pull/6809 # Summary [NIFI-11010](https://issues.apache.org/jira/browse/NIFI-11010) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue

[GitHub] [nifi] pvillard31 opened a new pull request, #6808: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7

2022-12-24 Thread GitBox
pvillard31 opened a new pull request, #6808: URL: https://github.com/apache/nifi/pull/6808 # Summary [NIFI-11009](https://issues.apache.org/jira/browse/NIFI-11009) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue

[GitHub] [nifi] pvillard31 closed pull request #6807: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7

2022-12-24 Thread GitBox
pvillard31 closed pull request #6807: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7 URL: https://github.com/apache/nifi/pull/6807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] pvillard31 opened a new pull request, #6807: NIFI-11009 Update Snowflake SDK to 1.0.2-beta.7

2022-12-24 Thread GitBox
pvillard31 opened a new pull request, #6807: URL: https://github.com/apache/nifi/pull/6807 # Summary [NIFI-11009](https://issues.apache.org/jira/browse/NIFI-11009) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue

[GitHub] [nifi] asfgit closed pull request #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-24 Thread GitBox
asfgit closed pull request #6805: NIFI-10855 Add Documentation on CSRF Protection URL: https://github.com/apache/nifi/pull/6805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364408883 > What did you have in mind for implementing a literal null as a function argument? I only question if it is more clearer than specifying to users to use an empty string which we

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364270877 @exceptionfactory I am fine with only implementing the the seven argument constructor. What did you have in mind for implementing a literal null as a function argument? I only question if it

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364267630 Thanks for the reply @dan-s1. As you observed, the Expression Language parser does not support a literal `null` as a function argument. It would take a bit more work, but it

[GitHub] [nifi] dan-s1 opened a new pull request, #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-23 Thread GitBox
dan-s1 opened a new pull request, #6806: URL: https://github.com/apache/nifi/pull/6806 # Summary [NIFI-10979](https://issues.apache.org/jira/browse/NIFI-10979) # Tracking Please complete the following tracking steps

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364180293 > Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. > > With that background, do you need all of the possible constructor

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364167903 Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. With that background, do you need all of the possible constructor

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056535336 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/ResultOutputStrategy.java:

[GitHub] [nifi] asfgit closed pull request #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration

2022-12-23 Thread GitBox
asfgit closed pull request #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration URL: https://github.com/apache/nifi/pull/6804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] asfgit closed pull request #6788: NIFI-10988 - Fix `ConsumeGCPubSubLite` processors delivering incorrect messages

2022-12-23 Thread GitBox
asfgit closed pull request #6788: NIFI-10988 - Fix `ConsumeGCPubSubLite` processors delivering incorrect messages URL: https://github.com/apache/nifi/pull/6788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi] exceptionfactory commented on pull request #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6805: URL: https://github.com/apache/nifi/pull/6805#issuecomment-1364127208 Thanks for the feedback and suggestions @Lehel44, I updated the wording in several places and included links to OWASP and Spring Security reference pages. -- This is an automated

[GitHub] [nifi] exceptionfactory commented on pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6802: URL: https://github.com/apache/nifi/pull/6802#issuecomment-1364109162 > Why do we need to update nifi-resources.pom? Thanks for the feedback @Lehel44. The updates to `pom.xml` in `nifi-resources` sets the default value for the `nifi.properties`

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1460: MINIFICPP-1995 Add configuring path for flowfile_checkpoint directory

2022-12-23 Thread GitBox
fgerlits commented on code in PR #1460: URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1056437169 ## extensions/rocksdb-repos/FlowFileRepository.h: ## @@ -100,11 +100,17 @@ class FlowFileRepository : public ThreadedRepository, public SwapManager {

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6802: URL: https://github.com/apache/nifi/pull/6802#discussion_r1056363577 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -503,6 +503,9 @@ JSON Web Key (JWK) provided through the jwks_uri in the metadata found at the di

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6803: URL: https://github.com/apache/nifi/pull/6803#discussion_r1056360444 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitJson.java: ## @@ -112,6 +112,43 @@ public

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6805: URL: https://github.com/apache/nifi/pull/6805#discussion_r1056337558 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -582,6 +582,36 @@ The following settings can be configured in _nifi.properties_ to control JSON We

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363956081 > Thanks for working on this new feature @dan-s1. Although most of the implementation makes sense, it raises some questions about treating blanks strings as nulls. Although the

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1483: MINIFICPP-2019 Fix auto-generation of PROCESSORS.md

2022-12-23 Thread GitBox
fgerlits opened a new pull request, #1483: URL: https://github.com/apache/nifi-minifi-cpp/pull/1483 https://issues.apache.org/jira/browse/MINIFICPP-2019 The `PROCESSORS.md` file included in this PR is almost auto-generated (by merging the output of `minifi docs ...` on Linux and on

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056252416 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/PaginationType.java:

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056252276 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/ResultOutputStrategy.java:

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

2022-12-23 Thread GitBox
fgerlits commented on code in PR #1481: URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1055622646 ## libminifi/include/core/logging/LoggerConfiguration.h: ## @@ -133,16 +132,21 @@ class LoggerConfiguration { class LoggerImpl : public Logger {

[GitHub] [nifi] exceptionfactory opened a new pull request, #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-22 Thread GitBox
exceptionfactory opened a new pull request, #6805: URL: https://github.com/apache/nifi/pull/6805 # Summary [NIFI-10855](https://issues.apache.org/jira/browse/NIFI-10855) Updates the Administrator's Guide with a new section describing Cross-Site Request Forgery Protection under the

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-22 Thread GitBox
exceptionfactory commented on code in PR #6689: URL: https://github.com/apache/nifi/pull/6689#discussion_r1056009178 ## nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java: ## @@ -0,0 +1,77

[GitHub] [nifi] exceptionfactory opened a new pull request, #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration

2022-12-22 Thread GitBox
exceptionfactory opened a new pull request, #6804: URL: https://github.com/apache/nifi/pull/6804 # Summary [NIFI-11005](https://issues.apache.org/jira/browse/NIFI-11005) Adds `IllegalImport` and `RedundantImport` modules to the Checkstyle configuration to flag usage of classes from

[GitHub] [nifi] exceptionfactory closed pull request #6480: NIFI-10585: Add GenerateFakeRecord processor

2022-12-22 Thread GitBox
exceptionfactory closed pull request #6480: NIFI-10585: Add GenerateFakeRecord processor URL: https://github.com/apache/nifi/pull/6480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6791: NIFI-6501: Refactor CaptureChangeMySQL to not use an unbounded event queue

2022-12-22 Thread GitBox
exceptionfactory commented on code in PR #6791: URL: https://github.com/apache/nifi/pull/6791#discussion_r1055922009 ## nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java: ## @@

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes

2022-12-22 Thread GitBox
exceptionfactory commented on code in PR #6803: URL: https://github.com/apache/nifi/pull/6803#discussion_r1055920409 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitJson.java: ## @@ -112,6 +112,43 @@

[GitHub] [nifi] mattyb149 commented on a diff in pull request #6791: NIFI-6501: Refactor CaptureChangeMySQL to not use an unbounded event queue

2022-12-22 Thread GitBox
mattyb149 commented on code in PR #6791: URL: https://github.com/apache/nifi/pull/6791#discussion_r1055910980 ## nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java: ## @@ -433,7

[GitHub] [nifi] mattyb149 commented on pull request #6480: NIFI-10585: Add GenerateFakeRecord processor

2022-12-22 Thread GitBox
mattyb149 commented on PR #6480: URL: https://github.com/apache/nifi/pull/6480#issuecomment-1363411973 Ah looks like I missed the property name update and your other changes look good too. thanks much! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] ChrisSamo632 commented on pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-22 Thread GitBox
ChrisSamo632 commented on PR #6687: URL: https://github.com/apache/nifi/pull/6687#issuecomment-1363395679 @exceptionfactory refactored to use `DescribedValue` enums for the new and other existing properties in these processors - led to me uncovering the fact that I'd mistakenly not added

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-22 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1055894635 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java:

[GitHub] [nifi] mattyb149 opened a new pull request, #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes

2022-12-22 Thread GitBox
mattyb149 opened a new pull request, #6803: URL: https://github.com/apache/nifi/pull/6803 # Summary [NIFI-10998](https://issues.apache.org/jira/browse/NIFI-10998) This PR removes the check for `oldValue == null` before compiling and caching the new JsonPath value # Tracking

<    1   2   3   4   5   6   7   8   9   10   >