[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041280626 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041268666 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041264186 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041258769 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-06 Thread GitBox
exceptionfactory commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1041235006 ## nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/PutIoTDBRecord.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1467: MINIFICPP-1986 Upgrade github action versions

2022-12-06 Thread GitBox
szaszm closed pull request #1467: MINIFICPP-1986 Upgrade github action versions URL: https://github.com/apache/nifi-minifi-cpp/pull/1467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1468: MINIFICPP-2005 - Use gsl::span instead of std::span

2022-12-06 Thread GitBox
szaszm closed pull request #1468: MINIFICPP-2005 - Use gsl::span instead of std::span URL: https://github.com/apache/nifi-minifi-cpp/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory commented on pull request #6761: NIFI-10952 - Fix TestScriptedPartitionRecord.testWhenMultiplePartitions

2022-12-06 Thread GitBox
exceptionfactory commented on PR #6761: URL: https://github.com/apache/nifi/pull/6761#issuecomment-1339639014 Running a full build with `mvn clean install` should run the tests and show the problems. For this particular module, running `mvn clean install -am -pl

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041159887 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1041157615 ## libminifi/src/controllers/keyvalue/KeyValueStateManager.cpp: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi] mr1716 commented on pull request #6760: NIFI-10921 Update poi.version to 5.2.3

2022-12-06 Thread GitBox
mr1716 commented on PR #6760: URL: https://github.com/apache/nifi/pull/6760#issuecomment-1339586829 When I ran this locally, every check passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041148586 ## libminifi/include/utils/Enum.h: ## @@ -127,7 +128,7 @@ namespace utils { #define SMART_ENUM(Clazz, ...) \ struct Clazz { \ using Base =

[GitHub] [nifi] TheGreatRandall commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-06 Thread GitBox
TheGreatRandall commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1339568171 Hi there, after more tests locally, the code can not been simplify because the order of the value inside hashmap is non deterministic which you can not guarentee. And accoring to

[GitHub] [nifi] KalmanJantner commented on pull request #6589: NIFI-10710 implement processor for AWS Polly, Textract, Translate, Tr…

2022-12-06 Thread GitBox
KalmanJantner commented on PR #6589: URL: https://github.com/apache/nifi/pull/6589#issuecomment-1339536388 > @KalmanJantner, I will take a closer look at the latest changes soon. Please avoid introducing merge commits, instead, please rebase and force-push changes to align with the main

[GitHub] [nifi] TheGreatRandall commented on pull request #6761: NIFI-10952 - Fix TestScriptedPartitionRecord.testWhenMultiplePartitions

2022-12-06 Thread GitBox
TheGreatRandall commented on PR #6761: URL: https://github.com/apache/nifi/pull/6761#issuecomment-1339504069 > @TheGreatRandall Please run a local build and test to verify changes prior to submitting a pull request. As shown in the automated checks, this change breaks the unit test on all

[GitHub] [nifi] exceptionfactory commented on pull request #6589: NIFI-10710 implement processor for AWS Polly, Textract, Translate, Tr…

2022-12-06 Thread GitBox
exceptionfactory commented on PR #6589: URL: https://github.com/apache/nifi/pull/6589#issuecomment-1339483465 @KalmanJantner, I will take a closer look at the latest changes soon. Please avoid introducing merge commits, instead, please rebase and force-push changes to align with the main

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-06 Thread GitBox
exceptionfactory commented on code in PR #6757: URL: https://github.com/apache/nifi/pull/6757#discussion_r1041048312 ## nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/test/java/org/apache/nifi/processors/parquet/TestConvertAvroToParquet.java: ## @@ -228,8

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-12-06 Thread GitBox
lordgamez commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1041021124 ## libminifi/src/controllers/keyvalue/KeyValueStateManager.cpp: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040931415 ## extensions/mqtt/processors/AbstractMQTTProcessor.h: ## @@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor { freeResources();

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040930018 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040926309 ## libminifi/include/utils/Enum.h: ## @@ -127,7 +128,7 @@ namespace utils { #define SMART_ENUM(Clazz, ...) \ struct Clazz { \ using Base =

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040921622 ## libminifi/include/utils/Enum.h: ## @@ -39,6 +39,7 @@ namespace utils { constexpr Clazz(Type value = static_cast(-1)) : value_{value} {} \

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040850939 ## extensions/mqtt/processors/AbstractMQTTProcessor.h: ## @@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040845912 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039819121 ## libminifi/include/utils/Enum.h: ## @@ -39,6 +39,7 @@ namespace utils { constexpr Clazz(Type value = static_cast(-1)) : value_{value} {} \

[GitHub] [nifi] TheGreatRandall opened a new pull request, #6761: Fix TestScriptedPartitionRecord.testWhenMultiplePartitions

2022-12-05 Thread GitBox
TheGreatRandall opened a new pull request, #6761: URL: https://github.com/apache/nifi/pull/6761 # Summary [NIFI-10952](https://issues.apache.org/jira/browse/NIFI-10952) Following the problem in the issue NIFI-10952. The issue

[GitHub] [nifi] TheGreatRandall commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
TheGreatRandall commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1338150679 hi there, all test been passed. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6740: NIFI-10868 Add PutDropbox processor

2022-12-05 Thread GitBox
turcsanyip commented on code in PR #6740: URL: https://github.com/apache/nifi/pull/6740#discussion_r1039997166 ## nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-processors/src/main/java/org/apache/nifi/processors/dropbox/PutDropbox.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-05 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1039600994 ## extensions/standard-processors/tests/unit/TailFileTests.cpp: ## @@ -99,18 +89,16 @@ TEST_CASE("TailFile reads the file until the first delimiter",

[GitHub] [nifi] thenatog closed pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies

2022-12-05 Thread GitBox
thenatog closed pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies URL: https://github.com/apache/nifi/pull/6735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] thenatog commented on pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies

2022-12-05 Thread GitBox
thenatog commented on PR #6735: URL: https://github.com/apache/nifi/pull/6735#issuecomment-1337993707 Confirmed that the OIDC cookie names were updated with the SameSite=none attribute applied. +1 will merge. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] mr1716 opened a new pull request, #6760: NIFI-10921 Update poi.version to 5.2.3

2022-12-05 Thread GitBox
mr1716 opened a new pull request, #6760: URL: https://github.com/apache/nifi/pull/6760 # Summary [NIFI-10921](https://issues.apache.org/jira/browse/NIFI-10921) # Tracking Please complete the following tracking steps

[GitHub] [nifi] exceptionfactory commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
exceptionfactory commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1337853282 Please review the output in the [Checks](https://github.com/apache/nifi/pull/6757/checks) section for a list of compilation failures. -- This is an automated message from the

[GitHub] [nifi] TheGreatRandall commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
TheGreatRandall commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1337838836 > Thanks for the updates @TheGreatRandall, it looks like the latest changes did not update all variable references, resulting in compilation failures. is that because we need

[GitHub] [nifi] exceptionfactory commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
exceptionfactory commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1337738479 Thanks for the updates @TheGreatRandall, it looks like the latest changes did not update all variable references, resulting in compilation failures. -- This is an automated

[GitHub] [nifi] exceptionfactory opened a new pull request, #6759: NIFI-10949 Update MongoDB components using current driver

2022-12-05 Thread GitBox
exceptionfactory opened a new pull request, #6759: URL: https://github.com/apache/nifi/pull/6759 # Summary [NIFI-10949](https://issues.apache.org/jira/browse/NIFI-10949) Updates MongoDB Processors and Controller Services to use the current version of `mongodb-driver-sync` in place

[GitHub] [nifi] thenatog closed pull request #6739: NIFI-10916 - Controller Service allowable values dropdown list should…

2022-12-05 Thread GitBox
thenatog closed pull request #6739: NIFI-10916 - Controller Service allowable values dropdown list should… URL: https://github.com/apache/nifi/pull/6739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] thenatog commented on pull request #6739: NIFI-10916 - Controller Service allowable values dropdown list should…

2022-12-05 Thread GitBox
thenatog commented on PR #6739: URL: https://github.com/apache/nifi/pull/6739#issuecomment-1337700808 Confirmed that the controller service list for processors is now sorted. Also tried changing the names of the controller services and confirmed still sorted correctly. +1 will merge. --

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-05 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039826380 ## PROCESSORS.md: ## @@ -2364,6 +2380,8 @@ In the list below, the names of required properties appear in bold. Any other pr ### Description Routes

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-05 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039825741 ## PROCESSORS.md: ## @@ -337,28 +337,34 @@ This Processor gets the contents of a FlowFile from a MQTT broker for a specifie In the list below, the

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-05 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039823934 ## libminifi/include/utils/Enum.h: ## @@ -127,7 +128,7 @@ namespace utils { #define SMART_ENUM(Clazz, ...) \ struct Clazz { \ using Base =

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2022-12-05 Thread GitBox
adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039819121 ## libminifi/include/utils/Enum.h: ## @@ -39,6 +39,7 @@ namespace utils { constexpr Clazz(Type value = static_cast(-1)) : value_{value} {} \

[GitHub] [nifi] thenatog commented on pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies

2022-12-05 Thread GitBox
thenatog commented on PR #6735: URL: https://github.com/apache/nifi/pull/6735#issuecomment-1337669138 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] asfgit closed pull request #6758: NIFI-10947 Upgrade Apache Commons Net to 3.9.0

2022-12-05 Thread GitBox
asfgit closed pull request #6758: NIFI-10947 Upgrade Apache Commons Net to 3.9.0 URL: https://github.com/apache/nifi/pull/6758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6504: NIFI-10618: Add Asana connector

2022-12-05 Thread GitBox
turcsanyip commented on code in PR #6504: URL: https://github.com/apache/nifi/pull/6504#discussion_r1039539797 ## nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/utils/PollableAsanaObjectFetcher.java: ## @@ -0,0 +1,40 @@

[GitHub] [nifi] thenatog commented on pull request #6739: NIFI-10916 - Controller Service allowable values dropdown list should…

2022-12-05 Thread GitBox
thenatog commented on PR #6739: URL: https://github.com/apache/nifi/pull/6739#issuecomment-1337621679 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] thenatog commented on pull request #6758: NIFI-10947 Upgrade Apache Commons Net to 3.9.0

2022-12-05 Thread GitBox
thenatog commented on PR #6758: URL: https://github.com/apache/nifi/pull/6758#issuecomment-1337612003 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] exceptionfactory opened a new pull request, #6758: NIFI-10947 Upgrade Apache Commons Net to 3.9.0

2022-12-05 Thread GitBox
exceptionfactory opened a new pull request, #6758: URL: https://github.com/apache/nifi/pull/6758 # Summary [NIFI-10947](https://issues.apache.org/jira/browse/NIFI-10947) Upgrades Apache Commons Net to 3.9.0 from 3.3 and 3.6 in several different modules. The upgrade centralizes

[GitHub] [nifi] exceptionfactory closed pull request #6749: NIFI-10931 Allow docker user to override LDAP Referral Strategy

2022-12-05 Thread GitBox
exceptionfactory closed pull request #6749: NIFI-10931 Allow docker user to override LDAP Referral Strategy URL: https://github.com/apache/nifi/pull/6749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] exceptionfactory closed pull request #6747: NIFI-10920 Upgrade Jettison to 1.5.2

2022-12-05 Thread GitBox
exceptionfactory closed pull request #6747: NIFI-10920 Upgrade Jettison to 1.5.2 URL: https://github.com/apache/nifi/pull/6747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] bbende commented on a diff in pull request #6756: NIFI-10945: Create a PostgreSQL Controller Service

2022-12-05 Thread GitBox
bbende commented on code in PR #6756: URL: https://github.com/apache/nifi/pull/6756#discussion_r1039710860 ## nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/pom.xml: ## @@ -0,0 +1,64 @@ +http://maven.apache.org/POM/4.0.0;

[GitHub] [nifi] TheGreatRandall commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
TheGreatRandall commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1337527633 > Thanks for the contribution @TheGreatRandall, the changes make the test a bit more verbose, but with a few adjustments, this seems acceptable. Thank you so much! I commited.

[GitHub] [nifi] TheGreatRandall commented on a diff in pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
TheGreatRandall commented on code in PR #6757: URL: https://github.com/apache/nifi/pull/6757#discussion_r1039707009 ## nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/test/java/org/apache/nifi/processors/parquet/TestConvertAvroToParquet.java: ## @@ -228,8

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-05 Thread GitBox
exceptionfactory commented on code in PR #6757: URL: https://github.com/apache/nifi/pull/6757#discussion_r1039703169 ## nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/test/java/org/apache/nifi/processors/parquet/TestConvertAvroToParquet.java: ## @@ -228,8

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6756: NIFI-10945: Create a PostgreSQL Controller Service

2022-12-05 Thread GitBox
Lehel44 commented on code in PR #6756: URL: https://github.com/apache/nifi/pull/6756#discussion_r1039656518 ## nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java: ## @@ -0,0 +1,255 @@ +/* + *

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6756: NIFI-10945: Create a PostgreSQL Controller Service

2022-12-05 Thread GitBox
exceptionfactory commented on code in PR #6756: URL: https://github.com/apache/nifi/pull/6756#discussion_r1039628605 ## nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java: ## @@ -0,0 +1,255

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1463: MINIFICPP-1993 Fix empty return value of PyInputStream

2022-12-05 Thread GitBox
adamdebreceni closed pull request #1463: MINIFICPP-1993 Fix empty return value of PyInputStream URL: https://github.com/apache/nifi-minifi-cpp/pull/1463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1462: MINIFICPP-1990 Add ProcessSession::remove to Python API

2022-12-05 Thread GitBox
adamdebreceni closed pull request #1462: MINIFICPP-1990 Add ProcessSession::remove to Python API URL: https://github.com/apache/nifi-minifi-cpp/pull/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1464: MINIFICPP-2003 Fix PutTCPTests platform dependent message check

2022-12-05 Thread GitBox
adamdebreceni closed pull request #1464: MINIFICPP-2003 Fix PutTCPTests platform dependent message check URL: https://github.com/apache/nifi-minifi-cpp/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi] asfgit closed pull request #6753: NIFI-10941 Remove TestNG references

2022-12-05 Thread GitBox
asfgit closed pull request #6753: NIFI-10941 Remove TestNG references URL: https://github.com/apache/nifi/pull/6753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] turcsanyip commented on pull request #6756: NIFI-10945: Create a PostgreSQL Controller Service

2022-12-05 Thread GitBox
turcsanyip commented on PR #6756: URL: https://github.com/apache/nifi/pull/6756#issuecomment-1337196493 @Lehel44 Thanks of adding this database-specific connection pool controller service for PostgreSQL! Can you please eliminate the RAT and Checkstyle issues first? Please also use the

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1467: MINIFICPP-1986 Upgrade github action versions

2022-12-05 Thread GitBox
lordgamez commented on PR #1467: URL: https://github.com/apache/nifi-minifi-cpp/pull/1467#issuecomment-1337130596 > Looks good, but do you know why the CI jobs didn't run? It would be good to trigger them, if possible. I'm not sure why it did not trigger, maybe because the only

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1465: MINIFICPP-1975 Volatile and persistent combination of repositories should be avoided

2022-12-05 Thread GitBox
lordgamez commented on code in PR #1465: URL: https://github.com/apache/nifi-minifi-cpp/pull/1465#discussion_r1039435285 ## controller/Controller.h: ## @@ -259,13 +261,16 @@ std::shared_ptr if (!flow_repo) { throw

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1465: MINIFICPP-1975 Volatile and persistent combination of repositories should be avoided

2022-12-05 Thread GitBox
adamdebreceni commented on code in PR #1465: URL: https://github.com/apache/nifi-minifi-cpp/pull/1465#discussion_r1039430812 ## controller/Controller.h: ## @@ -259,13 +261,16 @@ std::shared_ptr if (!flow_repo) { throw

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1468: MINIFICPP-2005 - Use gsl::span instead of std::span

2022-12-05 Thread GitBox
adamdebreceni opened a new pull request, #1468: URL: https://github.com/apache/nifi-minifi-cpp/pull/1468 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1467: MINIFICPP-1986 Upgrade github action versions

2022-12-05 Thread GitBox
lordgamez opened a new pull request, #1467: URL: https://github.com/apache/nifi-minifi-cpp/pull/1467 Upgrade actions to avoid Node.js 12 deprecation warnings https://issues.apache.org/jira/browse/MINIFICPP-1986 --- Thank you for submitting

[GitHub] [nifi] asfgit closed pull request #6729: NIFI-10898 Remove unused test HTTP Servlets

2022-12-04 Thread GitBox
asfgit closed pull request #6729: NIFI-10898 Remove unused test HTTP Servlets URL: https://github.com/apache/nifi/pull/6729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] TheGreatRandall closed pull request #6755: NIFI-10944 FixTestConvertAvroToParquet

2022-12-04 Thread GitBox
TheGreatRandall closed pull request #6755: NIFI-10944 FixTestConvertAvroToParquet URL: https://github.com/apache/nifi/pull/6755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] TheGreatRandall opened a new pull request, #6757: NIFI-10944 FixTestConvertAvroToParquet

2022-12-04 Thread GitBox
TheGreatRandall opened a new pull request, #6757: URL: https://github.com/apache/nifi/pull/6757 # Summary [NIFI-10944](https://issues.apache.org/jira/browse/NIFI-10944) Following the problem in the issue NIFI-10944. I set several

[GitHub] [nifi] Lehel44 opened a new pull request, #6756: NIFI-10945: Create a PostgreSQL Controller Service

2022-12-04 Thread GitBox
Lehel44 opened a new pull request, #6756: URL: https://github.com/apache/nifi/pull/6756 # Summary [NIFI-10945](https://issues.apache.org/jira/browse/NIFI-10945) # Tracking Please complete the following tracking steps

[GitHub] [nifi] TheGreatRandall opened a new pull request, #6755: Fix TestConvertAvroToParquet

2022-12-04 Thread GitBox
TheGreatRandall opened a new pull request, #6755: URL: https://github.com/apache/nifi/pull/6755 # Summary [NIFI-10944](https://issues.apache.org/jira/browse/NIFI-10944) Following the problem in the issue NIFI-10944. I set several

[GitHub] [nifi] TheGreatRandall opened a new pull request, #6754: NIFI-10637 Fixing Flaky Test In TestGenerateTableFetch

2022-12-04 Thread GitBox
TheGreatRandall opened a new pull request, #6754: URL: https://github.com/apache/nifi/pull/6754 # Summary [NIFI-10942](https://issues.apache.org/jira/browse/NIFI-10942) Following the problem in the issue NIFI-10942. I set several

[GitHub] [nifi] exceptionfactory opened a new pull request, #6753: NIFI-10941 Remove TestNG references

2022-12-03 Thread GitBox
exceptionfactory opened a new pull request, #6753: URL: https://github.com/apache/nifi/pull/6753 # Summary [NIFI-10941](https://issues.apache.org/jira/browse/NIFI-10941) Removes all references to TestNG assertions and dependencies. Several test classes had inadvertent references to

[GitHub] [nifi-fds] dependabot[bot] opened a new pull request, #71: Bump decode-uri-component from 0.2.0 to 0.2.2

2022-12-03 Thread GitBox
dependabot[bot] opened a new pull request, #71: URL: https://github.com/apache/nifi-fds/pull/71 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from

[GitHub] [nifi] thenatog closed pull request #6752: NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, pro…

2022-12-02 Thread GitBox
thenatog closed pull request #6752: NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, pro… URL: https://github.com/apache/nifi/pull/6752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] thenatog commented on pull request #6752: NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, pro…

2022-12-02 Thread GitBox
thenatog commented on PR #6752: URL: https://github.com/apache/nifi/pull/6752#issuecomment-1335960953 Was able to confirm the issue on a secure cluster using an insecure external NiFi, and that it was resolved with this fix. +1 will merge. -- This is an automated message from the Apache

[GitHub] [nifi] thenatog commented on pull request #6752: NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, pro…

2022-12-02 Thread GitBox
thenatog commented on PR #6752: URL: https://github.com/apache/nifi/pull/6752#issuecomment-1335918370 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] markap14 opened a new pull request, #6752: NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, pro…

2022-12-02 Thread GitBox
markap14 opened a new pull request, #6752: URL: https://github.com/apache/nifi/pull/6752 …perly parse XML for registry clients, looking for 'id' tag instead of 'identifier' tag. Fixed typo in error message about Reporting Task for Registry Clients. Updated StandardFlowComparator so that we

[GitHub] [nifi] asfgit closed pull request #6751: NIFI-10933 Upgrade OWASP Dependency Check from 7.1.2 to 7.3.2

2022-12-02 Thread GitBox
asfgit closed pull request #6751: NIFI-10933 Upgrade OWASP Dependency Check from 7.1.2 to 7.3.2 URL: https://github.com/apache/nifi/pull/6751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6740: NIFI-10868 Add PutDropbox processor

2022-12-02 Thread GitBox
krisztina-zsihovszki commented on code in PR #6740: URL: https://github.com/apache/nifi/pull/6740#discussion_r1038395625 ## nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-processors/src/main/java/org/apache/nifi/processors/dropbox/PutDropbox.java: ## @@ -0,0 +1,238 @@ +/* +

[GitHub] [nifi] exceptionfactory opened a new pull request, #6751: NIFI-10933 Upgrade OWASP Dependency Check from 7.1.2 to 7.3.2

2022-12-02 Thread GitBox
exceptionfactory opened a new pull request, #6751: URL: https://github.com/apache/nifi/pull/6751 # Summary [NIFI-10933](https://issues.apache.org/jira/browse/NIFI-10933) Upgrades the OWASP Dependency Check Plugin from 7.1.2 to 7.3.2. The upgrade includes a number of improvements,

[GitHub] [nifi] simonbence opened a new pull request, #6750: NIFI-10934 Adding uniqueness check for Regisrty Client creation

2022-12-02 Thread GitBox
simonbence opened a new pull request, #6750: URL: https://github.com/apache/nifi/pull/6750 # Summary [NIFI-10934](https://issues.apache.org/jira/browse/NIFI-10934) # Tracking Please complete the following tracking steps prior to pull request creation. ###

[GitHub] [nifi] asfgit closed pull request #6736: NIFI-10918: When fetching a flow from a Flow Registry, if it referenc…

2022-12-02 Thread GitBox
asfgit closed pull request #6736: NIFI-10918: When fetching a flow from a Flow Registry, if it referenc… URL: https://github.com/apache/nifi/pull/6736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] simonbence commented on pull request #6736: NIFI-10918: When fetching a flow from a Flow Registry, if it referenc…

2022-12-02 Thread GitBox
simonbence commented on PR #6736: URL: https://github.com/apache/nifi/pull/6736#issuecomment-1335181613 The code passed the test case successfully and also the debug shows that it tries to load the flow from the incorrect repository, then it falls back and loads it correctly. I will merge

[GitHub] [nifi] simonbence commented on pull request #6736: NIFI-10918: When fetching a flow from a Flow Registry, if it referenc…

2022-12-02 Thread GitBox
simonbence commented on PR #6736: URL: https://github.com/apache/nifi/pull/6736#issuecomment-1335149789 I execute the test case I added to the ticket. If it is successfull, I merge this into the main. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6740: NIFI-10868 Add PutDropbox processor

2022-12-02 Thread GitBox
turcsanyip commented on code in PR #6740: URL: https://github.com/apache/nifi/pull/6740#discussion_r1038030168 ## nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-processors/src/test/java/org/apache/nifi/processors/dropbox/PutDropboxTest.java: ## @@ -0,0 +1,255 @@ +/* + *

[GitHub] [nifi] djeanprost opened a new pull request, #6749: NIFI-10931 Allow docker user to override LDAP Referral Strategy

2022-12-02 Thread GitBox
djeanprost opened a new pull request, #6749: URL: https://github.com/apache/nifi/pull/6749 # Summary As a docker user, I cannot override ldap Referral Strategy with environment variables.

[GitHub] [nifi] asfgit closed pull request #6746: NIFI-10925 Refactor TestPutSFTP with discrete test methods

2022-12-02 Thread GitBox
asfgit closed pull request #6746: NIFI-10925 Refactor TestPutSFTP with discrete test methods URL: https://github.com/apache/nifi/pull/6746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] urbandan commented on pull request #6744: NIFI-10867 Refactor Stateless NiFi Connectors to support subclassing …

2022-12-02 Thread GitBox
urbandan commented on PR #6744: URL: https://github.com/apache/nifi/pull/6744#issuecomment-1334930744 @egyedt @exceptionfactory Thanks for the reviews - I had some problems with building some modules, but finally managed to do the checks locally. I've also tried running the tests in the

[GitHub] [nifi] kevdoran commented on pull request #6651: NIFI-10799 Add OIDC to Docker images for NiFi and NiFi Registry

2022-12-01 Thread GitBox
kevdoran commented on PR #6651: URL: https://github.com/apache/nifi/pull/6651#issuecomment-1334746225 Apologies for the delay. I should hopefully be able to look into this soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nifi] priyanka-28 opened a new pull request, #6748: NIFI-10928 Fixed Flaky Test failing with NonDex

2022-12-01 Thread GitBox
priyanka-28 opened a new pull request, #6748: URL: https://github.com/apache/nifi/pull/6748 # Summary Tests in the testSchemaWithCoreAttribuesToAttribute(), testSchemaToContent(), testSchemaWithCoreAttribuesToContent() and

[GitHub] [nifi] mr1716 opened a new pull request, #6747: NIFI-10920 Upgrade Jettison to 1.5.2

2022-12-01 Thread GitBox
mr1716 opened a new pull request, #6747: URL: https://github.com/apache/nifi/pull/6747 # Summary [NIFI-10920](https://issues.apache.org/jira/browse/NIFI-10920) # Tracking Please complete the following tracking steps

[GitHub] [nifi-maven] bbende opened a new pull request, #27: NIFI-10927 Remove service files from parent class loader before disco…

2022-12-01 Thread GitBox
bbende opened a new pull request, #27: URL: https://github.com/apache/nifi-maven/pull/27 …vering class names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] exceptionfactory opened a new pull request, #6746: NIFI-10925 Refactor TestPutSFTP with discrete test methods

2022-12-01 Thread GitBox
exceptionfactory opened a new pull request, #6746: URL: https://github.com/apache/nifi/pull/6746 # Summary [NIFI-10925](https://issues.apache.org/jira/browse/NIFI-10925) Refactors `TestPutSFTP` with discrete test methods to improve reliability and provide better tracking of

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6740: NIFI-10868 Add PutDropbox processor

2022-12-01 Thread GitBox
turcsanyip commented on code in PR #6740: URL: https://github.com/apache/nifi/pull/6740#discussion_r1037447129 ## nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-processors/src/main/java/org/apache/nifi/processors/dropbox/PutDropbox.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-01 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1035973706 ## Windows.md: ## @@ -93,7 +93,7 @@ A basic working CMake configuration can be inferred from the `win_build_vs.bat`. ``` mkdir build cd build -cmake -G

[GitHub] [nifi] asfgit closed pull request #6742: NIFI-10912 Upgrade JSLT To 0.1.14

2022-12-01 Thread GitBox
asfgit closed pull request #6742: NIFI-10912 Upgrade JSLT To 0.1.14 URL: https://github.com/apache/nifi/pull/6742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] asfgit closed pull request #6745: NIFI-10923 Upgrade Apache SSHD to 2.9.2

2022-12-01 Thread GitBox
asfgit closed pull request #6745: NIFI-10923 Upgrade Apache SSHD to 2.9.2 URL: https://github.com/apache/nifi/pull/6745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] exceptionfactory opened a new pull request, #6745: NIFI-10923 Upgrade Apache SSHD to 2.9.2

2022-12-01 Thread GitBox
exceptionfactory opened a new pull request, #6745: URL: https://github.com/apache/nifi/pull/6745 # Summary [NIFI-10923](https://issues.apache.org/jira/browse/NIFI-10923) Upgrades Apache SSHD to 2.9.2 in NiFi Standard Processor tests and NiFi Registry for the JGit library. The

[GitHub] [nifi] takraj commented on a diff in pull request #6504: NIFI-10618: Add Asana connector

2022-12-01 Thread GitBox
takraj commented on code in PR #6504: URL: https://github.com/apache/nifi/pull/6504#discussion_r1037448185 ## nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to

<    5   6   7   8   9   10   11   12   13   14   >