[GitHub] nifi-minifi-cpp pull request #121: MINIFI-357 fixing PutFile bug that caused...

2017-07-30 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/121 MINIFI-357 fixing PutFile bug that caused all writes to fail Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp pull request #:

2017-07-30 Thread dtrodrigues
Github user dtrodrigues commented on the pull request: https://github.com/apache/nifi-minifi-cpp/commit/fe63485342fc0e84250887871826b9f17b1f9a94#commitcomment-23376815 In libminifi/src/processors/PutFile.cpp: In libminifi/src/processors/PutFile.cpp on line 167: Returning here

[GitHub] nifi-minifi-cpp issue #211: MINIFICPP-321: Support Maximum File Count in Put...

2017-11-29 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/211 Fixed the `max_dest_files_` name. Also resolved file descriptor leak. The opendir pattern now matches what's currently in the GetFile and TailFile processors. ---

[GitHub] nifi-minifi-cpp pull request #211: MINIFICPP-321: Support Maximum File Count...

2017-11-29 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/211 MINIFICPP-321: Support Maximum File Count in PutFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi pull request #2316: NIFI-4657 update update dir-only in travis

2017-12-04 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2316 NIFI-4657 update update dir-only in travis Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi-minifi-cpp pull request #221: MINIFICPP-350: fix PutFile and Expression...

2017-12-16 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/221 MINIFICPP-350: fix PutFile and Expression compilation warnings Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp pull request #196: MINIFICPP-315 - allow plain b suffix on p...

2017-11-18 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/196 MINIFICPP-315 - allow plain b suffix on properties Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we

[GitHub] nifi-minifi-cpp pull request #195: MINIFICPP-307: Support text mode in Gener...

2017-11-18 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/195 MINIFICPP-307: Support text mode in GenerateFlowFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...

2017-11-18 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/195 Linter issues should be fixed now ---

[GitHub] nifi-minifi-cpp pull request #160: Minificpp 272

2017-10-29 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/160 Minificpp 272 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #2787: NIFI-5252 - support arbitrary headers in PutEmail p...

2018-06-11 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2787 NIFI-5252 - support arbitrary headers in PutEmail processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...

2018-06-16 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/360 MINIFICPP-427 - add PublishKafka headers support Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 I updated the test X-Mailer header to be more explicit that it's non-ASCII ---

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-16 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2800 NIFI-5317 - support non-ASCII X-Mailer header Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 Header setting is now refactored into a function and there are tests for non-ascii headers ---

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195935356 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java

[GitHub] nifi issue #2787: NIFI-5252 - support arbitrary headers in PutEmail processo...

2018-06-14 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2787 moved regex compilation to when processor is scheduled and ensured header values are encoded appropriately ---

[GitHub] nifi-minifi-cpp pull request #345: MINIFICPP-512 - upgrade to librdkafka 0.1...

2018-05-26 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/345 MINIFICPP-512 - upgrade to librdkafka 0.11.4 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask

[GitHub] nifi-minifi-cpp issue #345: MINIFICPP-512 - upgrade to librdkafka 0.11.4

2018-06-05 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/345 @phrocker I've removed tests and windows directories and updated CMakeLists.txt in librdkafka to not build the examples or tests. ---

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

2018-06-24 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/364 MINIFICPP-538 - only print error on actual error during shutdown, upd… …ate semaphore name Thank you for submitting a contribution to Apache NiFi - MiNiFi C

[GitHub] nifi-minifi-cpp pull request #362: MINIFICPP-540 - add issue tracker link to...

2018-06-20 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/362 MINIFICPP-540 - add issue tracker link to README.md Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-minifi-cpp pull request #361: MINIFICPP-522 - more robust minifi.sh sto...

2018-06-19 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/361 MINIFICPP-522 - more robust minifi.sh stop command Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we

[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...

2018-06-26 Thread dtrodrigues
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198361089 --- Diff: extensions/librdkafka/PublishKafka.h --- @@ -28,6 +28,7 @@ #include "core/Property.h" #include &qu

[GitHub] nifi-minifi-cpp pull request #366: MINIFICPP-546 - exit code of 0 for minifi...

2018-06-26 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/366 MINIFICPP-546 - exit code of 0 for minifi.sh status when process isn'… …t running Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order

[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...

2018-06-26 Thread dtrodrigues
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198359374 --- Diff: extensions/librdkafka/PublishKafka.cpp --- @@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const std::shared_ptr

[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...

2018-06-26 Thread dtrodrigues
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198360594 --- Diff: extensions/librdkafka/PublishKafka.h --- @@ -115,14 +121,35 @@ class PublishKafka: public core::Processor { buffer.reserve

[GitHub] nifi-minifi-cpp pull request #159: remove unncessary Boost header dependency...

2017-10-28 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/159 remove unncessary Boost header dependency from core Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-minifi-cpp pull request #239: MINIFICPP-371: document Maximum File Coun...

2018-01-12 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/239 MINIFICPP-371: document Maximum File Count in PutFile processor Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp pull request #240: MINIFICPP-313: correctly implement unique...

2018-01-12 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/240 MINIFICPP-313: correctly implement unique flowfiles param for GenerateFlowFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline

[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-29 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/360 I've pushed a commit which updates the README regarding the GCC version required and refactored the extension code slightly. I'm not sure of the best way to incorporate the GCC version

[GitHub] nifi-minifi-cpp pull request #386: MINIFICPP-587 - fix typo in bstrp_functio...

2018-07-31 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/386 MINIFICPP-587 - fix typo in bstrp_functions.sh Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask

[GitHub] nifi-minifi-cpp pull request #385: MINIFICPP-584 - update pybind to prevent ...

2018-07-31 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/385 MINIFICPP-584 - update pybind to prevent hang for Python3.7 on OSX Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi pull request #135: MINIFI-469 - support OSX in travis automated ...

2018-08-01 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi/pull/135 MINIFI-469 - support OSX in travis automated builds Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi-minifi-cpp pull request #363: MINIFICPP-541 - fix openssl endif cmake w...

2018-06-24 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/363 MINIFICPP-541 - fix openssl endif cmake warning Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we

[GitHub] nifi-minifi-cpp issue #425: MINIFICPP-650 - Fix MiNiFi typos

2018-10-22 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/425 closing due to GitHub degradation, will re-open when webhooks are functional ---

[GitHub] nifi-minifi-cpp pull request #425: MINIFICPP-650 - Fix MiNiFi typos

2018-10-22 Thread dtrodrigues
Github user dtrodrigues closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/425 ---

[GitHub] nifi-minifi-cpp pull request #425: MINIFICPP-650 - Fix MiNiFi typos

2018-10-22 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/425 MINIFICPP-650 - Fix MiNiFi typos Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you

[GitHub] nifi-minifi-cpp pull request #426: MINIFICPP-650 - Fix MiNiFi typos

2018-10-22 Thread dtrodrigues
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/426 MINIFICPP-650 - Fix MiNiFi typos Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you