[GitHub] nifi issue #2037: NIFI-4227 - add a ForkRecord processor

2018-05-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2037 @pvillard31 sorry it's taken me so long to get back to this - it seems to have slipped between the cracks. I did another review and all looks good (except it seems that the description of &qu

[GitHub] nifi issue #2739: NIFI-5066: Fixing enable/disable verification

2018-05-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2739 @mcgilman I tried testing this. Created a Process Group with 2 processors. One was STOPPED, the other DISABLED. Clicked on canvas to clear the selection. Then clicked "Disable" in t

[GitHub] nifi issue #2739: NIFI-5066: Fixing enable/disable verification

2018-05-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2739 @mcgilman all looks good now, thanks! Have merged to master. ---

[GitHub] nifi issue #2509: NIFI-543 Added annotation to indicate processor should run...

2018-05-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2509 @zenfenan sorry for the delay and all the back-and-forth on this one, but I've merged to master now! Many thanks for the PR and sticking with it through the end. Definitely nice to have

[GitHub] nifi pull request #2752: NIFI-5241: Updated EventSumValue to use synchronize...

2018-06-01 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2752 NIFI-5241: Updated EventSumValue to use synchronized methods instead … …of many atomic values. This is more efficient and uses less heap. Also noticed that the Logger instance in ProcessorNode

[GitHub] nifi pull request #2753: NIFI-5200: Fixed issue with InputStream being close...

2018-06-01 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2753 NIFI-5200: Fixed issue with InputStream being closed when calling Pro… …cessSession.read() twice against sequential Content Claims Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192493332 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192494134 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192494945 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192496937 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192492813 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192492212 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192494587 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192496067 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192495631 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192492300 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192493834 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192493590 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192495332 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java

[GitHub] nifi issue #2752: NIFI-5241: Updated EventSumValue to use synchronized metho...

2018-06-06 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2752 @mcgilman that's a good call. I pushed a new commit that addresses that. I also rebased against master, since quite a bit has changed, and all still seems to work well. ---

[GitHub] nifi pull request #2770: NIFI-5279: Allow components up to 50 milliseconds t...

2018-06-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2770 NIFI-5279: Allow components up to 50 milliseconds to complete validat… …ion before returning from update request Thank you for submitting a contribution to Apache NiFi. In

[GitHub] nifi issue #2770: NIFI-5279: Allow components up to 50 milliseconds to compl...

2018-06-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2770 For those reviewing, the simplest way to verify the fix is to create a DebugFlow processor. Set the "CustomValidate Pause Time" property to "70 millis" and when you apply the up

[GitHub] nifi issue #2771: NIFI-5280: Preventing duplicate bulletins

2018-06-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2771 @mcgilman thanks, was able to verify that the logic makes sense, all looks good. +1 merged to master. ---

[GitHub] nifi pull request #2772: NIFI-5281: If value is not valid according to the s...

2018-06-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2772 NIFI-5281: If value is not valid according to the schema's CHOICE fi… …eld, JSON Writer should write null value instead of throwing NullPointerException Thank you for submitt

[GitHub] nifi pull request #2774: [WIP] NIFI-4508: Update ConsumeAMQP to use basicCon...

2018-06-08 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2774 [WIP] NIFI-4508: Update ConsumeAMQP to use basicConsume API instead of basicGet in order to provide better performance This PR is not ready to be merged. However, I wanted to go ahead and

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1652 NIFI-1280: Renamed FilterCSVColumns to QueryFlowFile; introduced readers and writers as controller services Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi pull request #1654: NIFI-3678: Ensure that we catch EOFException when r...

2017-04-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1654 NIFI-3678: Ensure that we catch EOFException when reading header info… …rmation from WAL Partition files; previously, we caught EOFExceptions when reading a 'record' from the WAL bu

[GitHub] nifi pull request #1654: NIFI-3678: Ensure that we catch EOFException when r...

2017-04-06 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/1654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #1655: NIFI-3679: Added Avro Content Viewer

2017-04-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1655 NIFI-3679: Added Avro Content Viewer Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #1656: NIFI-3678

2017-04-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1656 NIFI-3678 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] nifi issue #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFile; intr...

2017-04-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1652 @olegz thanks for reviewing! Just a heads up - I pushed a new commit to address some RAT exclusions and checkstyle violations -- i had forgotten to run the -Pcontrib-check before creating the PR

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110645816 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/.gitignore --- @@ -0,0 +1

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110645869 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110646007 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110646390 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110646586 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110647404 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryFlowFile.java --- @@ -0,0

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110647534 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFil...

2017-04-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1652#discussion_r110647631 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi issue #1652: NIFI-1280: Renamed FilterCSVColumns to QueryFlowFile; intr...

2017-04-10 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1652 ok @olegz @mattyb149 I have submitted a new commit that addresses all of the feedback above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1668: NIFI-3658: Created processor for converting records...

2017-04-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1668 NIFI-3658: Created processor for converting records between data form… …ats with like schemas Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi pull request #1681: NIFI-3682: Add "Schema Access Strategy" and "Schema...

2017-04-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1681 NIFI-3682: Add "Schema Access Strategy" and "Schema Write Strategy" Record Readers and Writers; bug fixes. Thank you for submitting a contribution to Apache NiFi. In

[GitHub] nifi pull request #1681: NIFI-3682: Add "Schema Access Strategy" and "Schema...

2017-04-19 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/1681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1682 NIFI-3682: Add Schema Access Strategy and Schema Write Strategy Recor… …d Readers and Writers; bug fixes. Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi pull request #1668: NIFI-3658: Created processor for converting records...

2017-04-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1668#discussion_r112283576 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertRecord.java --- @@ -0,0

[GitHub] nifi pull request #1668: NIFI-3658: Created processor for converting records...

2017-04-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1668#discussion_r112284424 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertRecord.java --- @@ -0,0

[GitHub] nifi issue #1668: NIFI-3658: Created processor for converting records betwee...

2017-04-19 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1668 @mattyb149 I've pushed another commit that should address the property names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #1672: NIFI-3705: Using consistent logic when verifying connectio...

2017-04-19 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1672 @mcgilman looks good. I agree with the logic change and code looks clean. Everything appears to still work well. Merged to master. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1682#discussion_r112444804 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1682#discussion_r112449062 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1682#discussion_r112450884 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1682#discussion_r112450731 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #1682: NIFI-3682: Add Schema Access Strategy and Schema Wr...

2017-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1682#discussion_r112517204 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi issue #1682: NIFI-3682: Add Schema Access Strategy and Schema Write Str...

2017-04-20 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1682 I think I've got the things wrapped up that we've discussed here. However, I did realize that avro schemas define a default value and a set of aliases, which we don't take into

[GitHub] nifi issue #1682: NIFI-3682: Add Schema Access Strategy and Schema Write Str...

2017-04-21 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1682 OK @joewitt I think the latest push here addresses all of the issues raised. Please let me know if you find any other concerns. Thanks! --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #1682: NIFI-3682: Add Schema Access Strategy and Schema Write Str...

2017-04-21 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1682 @joewitt you're right - the schema text should be marked as optional. I think we can also tighten up the validation a bit for the writers to ensure that the Schema Access Strategy and Schema

[GitHub] nifi issue #1642: NIFI-1336 - Ensure that flowfiles are penalized upon excep...

2017-04-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1642 @trixpan sorry - the email that github sent me got lost in my inbox. Just saw it. I think the logic here is still not quite right, though. And I think I may have actually misunderstood what was

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112956387 --- Diff: nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/AESProvenanceEventEncryptor.java --- @@ -0,0 +1,237

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112957440 --- Diff: nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/CryptoUtils.java --- @@ -0,0 +1,228 @@ +/* + * Licensed

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112958054 --- Diff: nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/CryptoUtils.java --- @@ -0,0 +1,228 @@ +/* + * Licensed

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112963050 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112965910 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/groovy/org/apache/nifi/provenance

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r112966396 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/groovy/org/apache/nifi/provenance

[GitHub] nifi issue #1686: NIFI-3594 Encrypted provenance repository implementation

2017-04-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1686 @alopresto one thought regarding the StaticKeyProvider... rather than having a .key= perhaps it would make sense to instead use a .key.= property scheme. This would allow multiple Key ID's

[GitHub] nifi pull request #1686: NIFI-3594 Encrypted provenance repository implement...

2017-04-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1686#discussion_r113019393 --- Diff: nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/CryptoUtils.java --- @@ -0,0 +1,228 @@ +/* + * Licensed

[GitHub] nifi issue #1682: NIFI-3682: Add Schema Access Strategy and Schema Write Str...

2017-04-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1682 @joewitt I've pushed another commit that I think addresses your concerns above. Re: the GrokReader, if you are using a "SELECT * FROM FLOWFILE..." type of query then I agree it is a b

[GitHub] nifi issue #1682: NIFI-3682: Add Schema Access Strategy and Schema Write Str...

2017-04-24 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1682 Good catch, @joewitt. Pushed another commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1664: NIFI-2323: Fixed Oracle timestamp handling in DB fetch pro...

2017-04-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1664 This looks good to me. Code is clean and makes sense. Contrib-check passes with all unit tests. +1 merged to master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request #1695: NIFI-3739: Added ConsumeKafkaRecord_0_10 and Publis...

2017-04-25 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1695 NIFI-3739: Added ConsumeKafkaRecord_0_10 and PublishKafkaRecord_0_10 … …processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of

[GitHub] nifi pull request #1706: NIFI-3717: Added HortonworksSchemaRegistry

2017-04-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1706 NIFI-3717: Added HortonworksSchemaRegistry Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi pull request #1707: NIFI-3659: Added Processor to Split a FlowFile cons...

2017-04-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1707 NIFI-3659: Added Processor to Split a FlowFile consisting of Record-o… …riented data into multiple FlowFiles, each containing a subset of the original FlowFile's records Thank yo

[GitHub] nifi pull request #1706: NIFI-3717: Added HortonworksSchemaRegistry

2017-04-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1706#discussion_r113759624 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-nar/pom.xml --- @@ -0,0 +1,39 @@ + +

[GitHub] nifi pull request #1706: NIFI-3717: Added HortonworksSchemaRegistry

2017-04-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1706#discussion_r113762440 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/src/main/java/org/apache/nifi/schemaregistry

[GitHub] nifi issue #1706: NIFI-3717: Added HortonworksSchemaRegistry

2017-04-27 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1706 @joewitt I think I've addressed all of the comments above, except for the naming. Let me know if you think we need to change the class name. --- If your project is set up for it, you can rep

[GitHub] nifi pull request #1706: NIFI-3717: Added HortonworksSchemaRegistry

2017-04-27 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/1706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #1686: NIFI-3594 Encrypted provenance repository implementation

2017-04-28 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1686 @alopresto @YolandaMDavis just a quick update on my review... I think the code looks good and am a +1 on that front. I had no problem getting this up & running and things seem to work well. I

[GitHub] nifi pull request #1717: NIFI-3760: Fixed issue that caused session to conti...

2017-04-28 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1717 NIFI-3760: Fixed issue that caused session to continually poll from t… …he same connection when using ProcessSession.get(FlowFileFilter, Set) Thank you for submitting a contribution to

[GitHub] nifi issue #1695: NIFI-3739: Added ConsumeKafkaRecord_0_10 and PublishKafkaR...

2017-05-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1695 @joewitt agreed on all fronts. Will push a new commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1695: NIFI-3739: Added ConsumeKafkaRecord_0_10 and PublishKafkaR...

2017-05-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1695 @joewitt agreed. Pushed a new commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1695: NIFI-3739: Added ConsumeKafkaRecord_0_10 and PublishKafkaR...

2017-05-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1695 @joewitt excellent! Thanks for such a diligent review & testing - you're certainly keeping me on my toes! ;-) --- If your project is set up for it, you can reply to this email and have y

[GitHub] nifi issue #1725: NIFI-3762: Fixing JS errors when referencing services are ...

2017-05-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1725 @mcgilman @scottyaslan server-side code looks fine. Rebuilt and deployed to same flow that was having problems before. All looks good! +1 from me. --- If your project is set up for it, you can

[GitHub] nifi pull request #1727: NIFI-3768: Avoid wrapping FlowFile Attributes Map i...

2017-05-01 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1727 NIFI-3768: Avoid wrapping FlowFile Attributes Map in an UnmodifiableM… …ap in the StandardFlowFileBuilder Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi pull request #1728: NIFI-3739: Pass the proper InputStream to RecordSet...

2017-05-01 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1728 NIFI-3739: Pass the proper InputStream to RecordSetWriterFactory in o… …rder to obtain RecordSetWriter; also fix error handling so that we don't kill kafka client if unable to create w

[GitHub] nifi issue #1729: NIFI-3769 - Document detail value of 'nifi.provenance.repo...

2017-05-02 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1729 Looks good to me. Thanks for updating the doc! +1 merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #1735: NIFI-3775: Ensure that a '0' byte is written out to...

2017-05-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1735 NIFI-3775: Ensure that a '0' byte is written out to Hortonworks Encod… …ed Schema Reference header to indicate that GenericRecord is being used Thank you for submitting a co

[GitHub] nifi pull request #1742: NIFI-3787: Addressed NPE and ensure that if validat...

2017-05-03 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1742 NIFI-3787: Addressed NPE and ensure that if validation fails due to R… …untimeException, that it gets logged. Also clarified documentation for Json Reader services Thank you for

[GitHub] nifi pull request #1762: NIFI-2268: Instead of allowing HandleHttpRequest to...

2017-05-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1762 NIFI-2268: Instead of allowing HandleHttpRequest to run constantly ca… …lling BlockingQueue.poll() as fast as possible, call BlockingQueue.poll(2, TimeUnit.MILLISECONDS) to avoid

[GitHub] nifi pull request #1772: NIFI-3838: Initial implementation of RecordPath and...

2017-05-09 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1772 NIFI-3838: Initial implementation of RecordPath and UpdateRecord proc… …essor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi issue #1772: NIFI-3838: Initial implementation of RecordPath and Update...

2017-05-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1772 @joewitt good catch. Addressed the versioning info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1768: NIFI-3832: Fixed AvroRecordSetWriter validation NPE.

2017-05-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1768 @ijokarumawak thanks for the PR, and for catching the bug. Verified that NiFi was exhibiting the behavior that you described before and that after the PR the behavior was as-expected. +1 merged to

[GitHub] nifi pull request #1778: NIFI-3860: Relax the constraint that the ProcessSes...

2017-05-10 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1778 NIFI-3860: Relax the constraint that the ProcessSession must always b… …e given the most up-to-date version of a FlowFile Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1779: NIFI-3861: Fixed AvroReader nullable logical types issue

2017-05-10 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1779 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1779: NIFI-3861: Fixed AvroReader nullable logical types issue

2017-05-10 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1779 All looks good. Thanks for catching this one too, @ijokarumawak! +1 merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1772: NIFI-3838: Initial implementation of RecordPath and Update...

2017-05-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1772 @mattyb149 I just pushed a new commit that should address the issue that you noticed here with the differing schemas. I added unit tests to verify as well. I just noticed your comment about the

[GitHub] nifi issue #1772: NIFI-3838: Initial implementation of RecordPath and Update...

2017-05-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1772 @mattyb149 updated docs. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1772: NIFI-3838: Initial implementation of RecordPath and Update...

2017-05-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1772 @mattyb149 I also ran into an issue when comparing Integer values to Long values so I pushed one more commit to handle that case. --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1778: NIFI-3860: Relax the constraint that the ProcessSession mu...

2017-05-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1778 @joewitt good catches. I have pushed another commit that I think will address all of the concerns above. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1792: NIFI-3879: Allow null Avro default values

2017-05-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1792 @champagst - was able to verify the issue with your template. Then applied the PR and verified that it addressed the problem. Many thanks again! Merged this to master. Excited to see this getting

[GitHub] nifi pull request #1804: NIFI-3900: Ensure that when we serialize a flow to ...

2017-05-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1804 NIFI-3900: Ensure that when we serialize a flow to send to Cluster Co… …ordinator that we include the Scheduled State for processors as they are intended to be, not as they are currently

[GitHub] nifi pull request #1805: NIFI-3905: When a Provenance Query is submitted to ...

2017-05-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1805 NIFI-3905: When a Provenance Query is submitted to WriteAheadProvenan… …ceRepository, purge any obsolete queries from the internal state before rejecting the query due to 'too many outsta

<    1   2   3   4   5   6   7   8   9   10   >