Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051588
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051737
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051853
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051917
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114294
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114562
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114893
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Your second commit is labelled NIFI-2584, but I believe it's for NIFI-2583.
Would you mind re-submitting with the new commit label? Just want to make sure
when the merge happens that the Jira
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75120131
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Everything looks good and works well, thanks! @patricker what do you think
about adding fragment.count? Could be a later improvement but I think it'd be a
good thing to add if not too troubl
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Awesome, thanks! Looking forward to these improvements, will make QDT much
more flexible and powerful
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
+1 LGTM, thanks again for the great contribution! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/889
NIFI-2598: Fixed issue with static init of properties in HiveConnectionPool
Should be tested/merged after #887 is merged, that is the PR that brings
the issue to light.
You can merge this pull
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/891
NIFI-2593: Fixed handling of nested records/structs in ConvertAvroToORC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/898
NIFI-2602: Fixed NPE in SelectHiveQL when CSV output and null column value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/883#discussion_r75413240
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -787,6 +792,12
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/883
A complex problem for sure. Certainly you are right with the Jira that
Binary types are currently not supported, and if the use case you describe
(coming from Avro) is the most common, then this is
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/883
That sounds good. We should move the discussion into an email thread on the
users or dev list?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75594156
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java
---
@@ -0,0 +1,198
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75594158
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java
---
@@ -0,0 +1,198
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/850
+1 LGTM, built and ran the tests, and tried on a live system with and
without incoming flow files, using different glob patterns, files and
directories, etc. Great job, thanks! Merging to master
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/896
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/907
NIFI-2619: Added logic to ClassLoaderUtils to trim module paths and accept
URLs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/896
+1 LGTM to me, tested with and without fixes, verified problem is resolved.
Merging to master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/907#discussion_r75730484
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java
---
@@ -21,45 +21,59 @@
import
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/912
NIFI-2604: Added validators & logic for multiple URLs/files/folders for DB
driver location
You can merge this pull request into a Git repository by running:
$ git pull https://github
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/911#discussion_r75755360
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/scheduling
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/911#discussion_r75755578
--- Diff:
nifi-api/src/main/java/org/apache/nifi/testutil/IntegrationTest.java ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/709#discussion_r75773057
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestCSVToAvroProcessor.java
---
@@ -191,57
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/709#discussion_r75773261
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestCSVToAvroProcessor.java
---
@@ -191,57
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/919
NIFI-2632: Added fragment attributes to SplitJson and SplitXml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2632
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/920
NIFI-2623: Fixed support for binary types in SelectHiveQL
This code was originally copied from JdbcCommon, where arrays are treated
as binary (byte array, e.g.) and getBytes() is called on the
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/922
NIFI-2622: Added support for complex types in SelectHiveQL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2622
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/918
+1 LGTM, ran all unit tests without failures (and Travis passed). Merging
to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/919#discussion_r75937909
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitJson.java
---
@@ -61,6
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/928
NIFI-2641: Add max values as attributes to QueryDatabaseTable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2641
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/883#discussion_r76068439
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -787,6 +802,29
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/883
That part makes sense, but what about when I put three emoticons in the
UpdateAttribute processor to set the value, then I get three bytes in the
table, all value 63. I would've expected 6
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/883
Sounds good. Yeah I used the hex and base64 stuff with no issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/883
+1 LGTM, tested all the logic. Thanks for the great contribution! Merging
to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/942
NIFI-2665: Fixed intermittent validation errors in InvokeScriptedProcessor
Also, due to #930 the parent classloaders have been fixed so there is no
need for the createScriptEngineModuleClassLoader
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/948
NIFI-2668: Replaced JSR-107 JCache API JAR w Geronimo version, updated
notices
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/948
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/912#discussion_r76333907
--- Diff:
nifi-commons/nifi-processor-utilities/src/test/java/org/apache/nifi/processor/util/TestStandardValidators.java
---
@@ -100,4 +100,105 @@ public
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/912#discussion_r76333878
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
---
@@ -379,6 +381,68 @@ public
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/953
+1 LGTM thanks for the fix! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r76610727
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,172
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r76611496
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,172
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r76612149
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,172
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r76624189
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,172
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/976
NIFI-2712: Fixed Fetch processors for multiple max-value columns
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2712
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/785
Will do. Although I'm sure you meant "thread concurrency", I always keep an
eye out for threat concurrency ;) I've just started a long holiday weekend so I
may not be able to t
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/988
NIFI-2735: Add AggregateValues processor for aggregate operations on flow
file groups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/988#discussion_r77727912
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AggregateValues.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/988#discussion_r77811419
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AggregateValues.java
---
@@ -0,0
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/994
NIFI-2262: Added Avro-normalization of table/column names in SQL processors
Affected processors are QueryDatabaseTable and ExecuteSQL, since they
generate Avro output. GenerateTableFetch is not
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1012
NIFI-2765: Fixed Kerberos support for PutHiveStreaming
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2765
Alternatively
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1035
NIFI-1841: Fixed support for CLOB/BLOB types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-1841
Alternatively you can
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1037#discussion_r79657612
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1037#discussion_r79657850
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1037#discussion_r79656833
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79826524
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79832704
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79831856
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79831289
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79832571
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79827737
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r79826318
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/997
+1 LGTM, verified the problem exists, the unit tests show the problem, and
the fix corrects the problem. Merging to master.
---
If your project is set up for it, you can reply to this email and
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1004#discussion_r79869437
--- Diff:
nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1004#discussion_r79869645
--- Diff:
nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1004#discussion_r79869457
--- Diff:
nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1037
@pvillard31 nope I'm good if you are, I hadn't realized we had started
reviewing at the same time :)
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1045
NIFI-1458: Added ScriptedReportingTask
I refactored AbstractScriptProcessor into ScriptUtils, so the functionality
could be shared between scripting processors and scripting reporting tasks. I
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1046
NIFI-2805: Add fragment attributes to SplitAvro
Same idea as #919 but for SplitAvro
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r80096977
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r80098194
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r80101565
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/733#discussion_r80112353
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/733
+1 LGTM, Thanks for the great contribution! Lots of folks have asked about
this capability, glad to have it in NiFi :) Merging to master
---
If your project is set up for it, you can reply to this
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/733
Oops, forgot to rebase and add the comment that auto-closes this PR. Do you
mind closing it? I'll Resolve the Jira. Thanks!
---
If your project is set up for it, you can reply to this emai
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1055
NIFI-2815: Fixed InvokeScriptedProcessor to allow changes to script engine
type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1052
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1052
This commit breaks some unit tests that check the SQL statement(s) being
generated, I will fix the tests before merging. Otherwise +1 LGTM, merging to
master, thanks much for your contribution
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r80535718
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -819,7 +819,7
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r80535990
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r80535518
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,323
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1053
+1 Looks good to me, thank you for the fix! It's been very frustrating
trying to find out how each database handles various types, some return a
different JDBC type than the corresponding Java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1053
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r80703541
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r80709952
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -254,6 +254,17 @@ language governing permissions and limitations
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1075
NIFI-2828: Fix Hive NAR dependencies
The approach is to remove the parent dependency and put all Hadoop/Hive
dependencies in the Hive NAR instead of expecting them in a parent classloader.
You
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/785
Sounds good thanks, will take a look soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r82634033
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r82633365
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,323
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/785#discussion_r82633006
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
---
@@ -0,0 +1,323
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1123
+1 LGTM, ran the unit tests and on a full NiFi, verified the NFE is not
presented and the flow file is parsed successfully. Merging to master, thanks!
---
If your project is set up for it, you can
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1123
+1 LGTM, ran the unit tests and with a full NiFi, verified the NFE is not
presented and messages are parsed successfully. Merging to master, thanks!
---
If your project is set up for it, you can
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1101
Can you add a unit test for this? One option is to update the
testInitialMaxValue() test to change the name of the "created_on" column to
uppercase, as well as the max-value column na
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1129
NIFI-2894: Fixed typo in PutSQL documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2894
Alternatively
701 - 800 of 1416 matches
Mail list logo
