[GitHub] nifi issue #719: NIFI-2389 Refactoring identity mapping and applying it to F...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/719 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #719: NIFI-2389 Refactoring identity mapping and applying it to F...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/719 Thanks @bbende... looks good. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/724 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/724 @bbende This is a great start. I've verified that we can no longer add new users or groups with the same name as existing users or groups. However, I think we need to additionally ensure uniqueness

[GitHub] nifi issue #627: [NIFI-2205] [NIFI-2217] [NIFI-2219] [NIFI-2180] [NIFI-2140]...

2016-07-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/627 @scottyaslan Looks good... Ran into a couple minor issues... 1) Progress bar flickers and seems to default to 100%. 2) Label color preview does not update automatically. --- If your

[GitHub] nifi issue #563: NIFI-2078: External state management.

2016-07-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/563 @ijokarumawak Awesome, thank you. There was just some confusion about whether we could resolve the PR for NIFI-2078 and just wanted to verify with you first. --- If your project is set up

[GitHub] nifi pull request #651: UI - Cluster Awareness

2016-07-14 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/651 UI - Cluster Awareness NIFI-1947 NIFI-2082: - Making it more obviously when a nodes cluster state changes. - Showing which node is the cluster coordinator. You can merge this pull request

[GitHub] nifi pull request #654: Addressing issue with enabling/disabling Controller ...

2016-07-14 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/654 Addressing issue with enabling/disabling Controller Services NIFI-2261: - Addressed issue enabling/disabling controller services where the wrong URI was referenced. - Addressed

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

2016-07-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 Good catch. Will update PR shortly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIFI-2134]...

2016-07-25 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/703 Thanks @scottyaslan! Looks good.. this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #730: Ensuring component specific policies are retained wh...

2016-07-27 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/730 Ensuring component specific policies are retained when copying/pasting NIFI-2347: - Ensuring component specific policies are retained when using copy/paste. - This includes the policies

[GitHub] nifi issue #732: [NIFI-2396] Update Bulletin Board shell header and filter c...

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/732 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #724: NIFI-2403 Ensuring uniqueness on user identities and group ...

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/724 Thanks @bbende! While testing I found a condition where the UI wasn't displaying the error returned from the server. I included that minor addition into your commit. This has been merged to master

[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

2016-07-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/725 Good catch and great suggestion. I've updated the PR accordingly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #736: Cleanup endpoints/UI when not running with a configu...

2016-07-28 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/736 Cleanup endpoints/UI when not running with a configurable authorizer NIFI-2122: - Merging responses for the current user and the flow configuration. - Returning whether NiFi is configured

[GitHub] nifi issue #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIFI-2027]...

2016-07-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/715 Looks great @scottyaslan! This has been merged to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #698: Updating the UI to reflect the access policies being...

2016-07-21 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/698#discussion_r71818711 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi issue #735: NIFI-2390 Separating of users and groups from authorization...

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/735 Looks good @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #740: Message on history page when clustered

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/740 Each node processed each action regardless if your browser was pointed to it. That's how the flows are kept in sync. The potential confusion here is with actions that happened to a node when

[GitHub] nifi issue #740: Message on history page when clustered

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/740 Do you have another suggestion for the message? What if we create another JIRA for further explanation in the user guide? Tough to explain the scenario in a short sentence or two. --- If your

[GitHub] nifi issue #740: Message on history page when clustered

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/740 The message is only shown when the node is part of a cluster. I think we shouldn't overcomplicate things. Inform the user that they are viewing the history of the current node and suggest they can

[GitHub] nifi issue #740: Message on history page when clustered

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/740 Your first impression of that message is accurate. We are only showing actions from the node the browser is pointing to. Meaning, if that node has other history before it was clustered it would

[GitHub] nifi pull request #745: Enabling Play/Stop buttons in palette more liberally

2016-07-29 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/745 Enabling Play/Stop buttons in palette more liberally NIFI-2401: - Returning the enabled state of play and stop buttons in the palette. Allowing the user to always press if they have permissions

[GitHub] nifi issue #726: NIFI-2339 Removed some outputs which could cause errors to ...

2016-07-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/726 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #750: Removing client side check for component move eligib...

2016-07-29 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/750 Removing client side check for component move eligibility NIFI-2402: - Removing client side check component move eligibility and instead relaying on verification server side. Cannot check client

[GitHub] nifi pull request #756: Fixing issue when searching for a component in a dif...

2016-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/756 Fixing issue when searching for a component in a different Group NIFI-2443: - Addressing issue where reload group deferred was being resolved prematurely. You can merge this pull request

[GitHub] nifi pull request #755: Update REST endpoint documentation

2016-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/755 Update REST endpoint documentation NIFI-2237: - Updating Rest Endpoint documentation specifically regarding access policies. - Ensuring the resource listing is accurate. - Removing

[GitHub] nifi pull request #757: Ensuring all component specific policies are removed...

2016-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/757 Ensuring all component specific policies are removed when the component is deleted NIFI-2301: - Ensure all component specific policies are removed when the component is removed. You can merge

[GitHub] nifi issue #759: [NIFI-2426] Update visibility of New service/task button in...

2016-08-01 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/759 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #760: Reporting appropriate error message when not authori...

2016-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/760 Reporting appropriate error message when not authorized to empty queue in a cluster NIFI-2438: - If a node reports forbidden, using an appropriate response failure exception. You can merge

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/720 @markap14 Good catch. We also need to do this for site to site data transfers. Will update the seeding. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #720: Introduce data resource for authorizing Provenance a...

2016-07-25 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/720 Introduce data resource for authorizing Provenance and Queue interactions NIFI-2346: - Introducing data resource for authorizing provenance events and queue listing. - Authorizing entire

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

2016-07-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/720 @markap14 PR has been updated to address the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #725: Addressing issues surrounding Template uploading

2016-07-26 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/725 Addressing issues surrounding Template uploading NIFI-2224: - Ensuring the template form is reset when the upload template dialog is closed. NIFI-2175: - Not submitting the template

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/770 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/770 @olegz I just ran through some of these scenario's and everything looks good so far. However, with the new UUID generation strategy I think there is some dead code in SnippetUtils that should

[GitHub] nifi issue #759: [NIFI-2426] Update visibility of New service/task button in...

2016-08-01 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/759 All merged. Thanks @scottyaslan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #764: NIFI-2339 made exception statements more vague and limited ...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/764 Thanks @joewitt! Looks good, this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #835: Ensuring users can access the Controller Service and...

2016-08-11 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/835 Ensuring users can access the Controller Service and Reporting Tasks lists NIFI-2501: - Ensuring users can access the controller service list regardless of permissions on the corresponding

[GitHub] nifi pull request #837: Controller Services - Addressing issues with transit...

2016-08-11 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/837 Controller Services - Addressing issues with transitive referencing components NIFI-2542: - Ensuring transitive referencing components are able to be returned. NIFI-2543: - Ensuring we

[GitHub] nifi pull request #839: Allowing selection of User/Cluster node when searchi...

2016-08-11 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/839 Allowing selection of User/Cluster node when searching and encountering an exact match NIFI-2548: - Allowing selection of User/Cluster node when searching and encountering an exact match. You

[GitHub] nifi pull request #822: Ensuring bulletins bubble up to ancestor Process Gro...

2016-08-09 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/822 Ensuring bulletins bubble up to ancestor Process Groups NIFI-2511: - Ensuring Process Group bulletins are bubbling up as expected. You can merge this pull request into a Git repository

[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/757 Another good catch. I've updated the PR accordingly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #750: Removing client side check for component move eligibility

2016-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/750 Good catch. I've update the PR accordingly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #755: Update REST endpoint documentation

2016-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/755#discussion_r73401024 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessPolicyResource.java

[GitHub] nifi pull request #755: Update REST endpoint documentation

2016-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/755#discussion_r73401076 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java --- @@ -111,7

[GitHub] nifi pull request #755: Update REST endpoint documentation

2016-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/755#discussion_r73401344 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #755: Update REST endpoint documentation

2016-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/755#discussion_r73408766 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProvenanceResource.java

[GitHub] nifi issue #775: [NIFI-2053] update open/close palettes

2016-08-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/775 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #784: Fixing issue with auto complete after closing/openin...

2016-08-04 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/784 Fixing issue with auto complete after closing/opening the containing dialog NIFI-2467: - Resetting cached search term when closing the dialog to ensure the same search time works upon re-opening

[GitHub] nifi pull request #788: Updating the REST docs to account for the refactored...

2016-08-04 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/788 Updating the REST docs to account for the refactored endpoints NIFI-2237: - Reorganizing the refactored REST endpoints. - Tweaking message text. You can merge this pull request into a Git

[GitHub] nifi issue #781: [NIFI-2468] addressing some inconsistencies

2016-08-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/781 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #842: [NIFI-2557] Enhance Modal Plugin

2016-08-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/842 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #846: Addressing potential NullPointerException in AccessD...

2016-08-12 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/846 Addressing potential NullPointerException in AccessDeniedExceptionMapper NIFI-2555: - Addressing potential NullPointerException when an AccessDeniedException is thrown from an endpoint

[GitHub] nifi issue #842: [NIFI-2557] Enhance Modal Plugin

2016-08-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/842 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #841: [NIFI-2558] adjust content viewer combo alignment

2016-08-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/841 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #694: NIFI-1876 Implements merging of responses to successful req...

2016-08-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/694 @jtstorck I think we also need a CounterEndpointMerger. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #641: NIFI-2252: Fixed issue where POST to Controller Resource cr...

2016-07-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/641 Looks good @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #627: [NIFI-2205] [NIFI-2217] [NIFI-2219] [NIFI-2180] [NIFI-2140]...

2016-07-12 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/627 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #634: [NIFI-2182] [NIFI-2019] [NIFI-2183]

2016-07-12 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/634 [NIFI-2182] [NIFI-2019] [NIFI-2183] NIFI-2182: - Ensuring the active thread count is shown. NIFI-2019: - Ensuring correct color of the run status in the From connection label

[GitHub] nifi pull request #644: NIFI-2254: Fixing URI when reloading/updating compon...

2016-07-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/644 NIFI-2254: Fixing URI when reloading/updating component - Addressing accessing URI on the wrong object. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #628: NIFI-2003 Creating abstract authentication provider ...

2016-07-12 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/628#discussion_r70423287 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-authorization/src/main/java/org/apache/nifi/authorization/user

[GitHub] nifi pull request #635: NIFI-2232: Dynamically updating the global menu acco...

2016-07-12 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/635 NIFI-2232: Dynamically updating the global menu according to the current users permissions - Dynamically updating the global menu according to the current users permissions. You can merge

[GitHub] nifi pull request #636: NIFI-2249: Move URI out of component so it is access...

2016-07-12 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/636 NIFI-2249: Move URI out of component so it is accessible without read permissions - Making the URI accessible outside of the component. You can merge this pull request into a Git repository

[GitHub] nifi pull request #698: Updating the UI to reflect the access policies being...

2016-07-20 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/698 Updating the UI to reflect the access policies being enforced NIFI-2244: - Separating the access control check and the supports modification check for the selected component. - Using

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

2016-07-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 NIFI-2242 was when there are multiple components selected with mixed permissions so I think this may be a slightly different case but I'd be happy to address as part of this PR. --- If your project

[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...

2016-07-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 Yeah, I'm unable to replicate. The first message you mentioned sounds like the request was attempted like it was prior to the fix. Maybe your browser had some old JS cached. The "Must be autho

[GitHub] nifi pull request #666: Fixing issues loading the Policy Management UI

2016-07-18 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/666 Fixing issues loading the Policy Management UI NIFI-2272: - Ensuring the appropriate visibility of the action in the policy management page. NIFI-2273: - Ensuring we load the policy

[GitHub] nifi issue #673: [NIFI-2105] [NIFI-2106] fix status history dialog issues

2016-07-19 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/673 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #684: [NIFI-2107] [NIFI-2143] Update content-viewer, error, and l...

2016-07-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/684 @scottyaslan After merging #646 this PR doesn't rebase cleanly. Can you update for the current state of master? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #666: Fixing issues loading the Policy Management UI

2016-07-20 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #646: [NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refresh upd...

2016-07-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/646 Looks great @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #646: [NIFI-2257] refresh updateattribute processor advanced shel...

2016-07-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/646 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #660: Addressing issue prevent access to login page

2016-07-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/660 Addressing issue prevent access to login page NIFI-2271: - Fixing issue that was preventing an anonymous user from accessing the log in page. You can merge this pull request into a Git

[GitHub] nifi pull request #658: Addressing issue searching Provenance while clustere...

2016-07-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/658 Addressing issue searching Provenance while clustered and Replaying Events NIFI-2260: - Addressing issue searching provenance on a specific node. - Fixing issues viewing content

[GitHub] nifi pull request #646: [NIFI-2257] refresh updateattribute processor advanc...

2016-07-15 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/646#discussion_r71017973 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js --- @@ -1598,9 +1635,9 @@ var ua

[GitHub] nifi pull request #660: Addressing issue prevent access to login page

2016-07-15 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #530: NIFI-1992: Updated site-to-site client and server to suppor...

2016-07-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/530 Looks good @markap14! I've merged this into master. Also found and addressed in your PR a minor issue that was already reported in NIFI-2274 [1] [1] https://issues.apache.org/jira/browse/NIFI

[GitHub] nifi pull request #617: NIFI-826 Added deterministic template support

2016-07-15 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/617#discussion_r71035162 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/TemplateResource.java

[GitHub] nifi pull request #636: NIFI-2249: Move URI out of component so it is access...

2016-07-13 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #620: [NIFI-2147] Fix Warning/Invalid roll-over text

2016-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/620 Looks good @scottyaslan! Thanks, this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]

2016-07-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/604 Looks good @scottyaslan! This has been merged to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #621: NIFI-2185: Proxy requests through the cluster coordinator r...

2016-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/621 Looks good @markap14. This has been merged to master. I ran into a couple of unrelated issues while testing and will open additional JIRAs as necessary. Thanks! --- If your project is set up

[GitHub] nifi pull request #620: [NIFI-2147] Fix Warning/Invalid roll-over text

2016-07-11 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/620#discussion_r70240401 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js

[GitHub] nifi issue #619: [NIFI-2198] [NIFI-1879] [NIFI-2197]

2016-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/619 Looks good @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #794: UI inconsistencies

2016-08-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/794 Thanks @moranr. Will update shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line

2016-08-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/793 @jskora Thanks for the PR. I just tried it out and was able to replicate the issue. However, with your proposed change, the heading text on the Controller Settings dialog is missing. This is accessed

[GitHub] nifi pull request #800: Addressing issue preventing the display of the user ...

2016-08-05 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/800 Addressing issue preventing the display of the user in the history table NIFI-2505: - Updating the user identity field in the ActionDTO. You can merge this pull request into a Git repository

[GitHub] nifi issue #781: [NIFI-2468] addressing some inconsistencies

2016-08-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/781 @scottyaslan There were a few items that we're not implemented from the original JIRA. I am going to take your commit from this PR and include it in a subsequent PR that I'll post later

[GitHub] nifi pull request #792: Authorizing each bulletin returned through the bulle...

2016-08-04 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/792 Authorizing each bulletin returned through the bulletin board NIFI-2486: - Authorizing individual bulletins being returned through the bulletin board. You can merge this pull request into a Git

[GitHub] nifi pull request #813: Updating UI to reflect administrator policies do not...

2016-08-08 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/813 Updating UI to reflect administrator policies do not override NIFI-2475: - Updating UI to better suggest that component specific administrators do not override higher level administrators. You

[GitHub] nifi issue #806: Extend REST API docs template to handle read only propertie...

2016-08-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/806 Looks good @jskora. This has been merged to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #806: Extend REST API docs template to handle read only propertie...

2016-08-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/806 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #770: NIFI-2425 fixed ControllerService referencing in DTOs/Templ...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/770 Thanks @olegz. This has been merged to master. All changes looked good. I verified using a template from a 0.x release and templates generated with current version of 1.0.0-SNAPSHOT. All looks good

[GitHub] nifi issue #767: NIFI-1869 Cloning controller services when referenced by re...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/767 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #767: NIFI-1869 Cloning controller services when referenced by re...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/767 Looks great @bbende! Thanks for knocking this out. I've merged it to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #765: NIFI-2455 Removing 'Queue Buffering Max Time' as a required...

2016-08-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/765 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #773: Addressing issue when initial Provenance query is ca...

2016-08-02 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/773 Addressing issue when initial Provenance query is cancelled NIFI-2458: - Fixing issue with timezone when the initial provenance result was cancelled. You can merge this pull request into a Git

[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally

2016-07-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/745 Invalid processors are only ignored when your starting a group (there is no selection). This is how it works in 0.x and 1.x. When there is something selected this is not the case. I believe

[GitHub] nifi issue #735: NIFI-2390 Separating of users and groups from authorization...

2016-07-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/735 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   3   4   5   6   7   8   9   10   >